tangled.org / core
Monorepo for Tangled tangled.org
fork atom

appview: add personal pronouns to profile #688

merged opened by serendipty01.dev targeting master from serendipty01.dev/tangled-core: pronouns
Labels

None yet.

assignee

None yet.

Participants 2
AT URI
at://did:plc:pzcr34e3e2emtcnyzrpmilht/sh.tangled.repo.pull/3m3pooe7qj322
+5 -4
Interdiff #0 → #1
unified split
api/tangled/actorprofile.go

This file has not been changed.

+1 -1
appview/db/db.go
··· 1108 1108 1109 1109 runMigration(conn, logger, "add-pronouns-profile", func(tx *sql.Tx) error { 1110 1110 _, err := tx.Exec(` 1111 - alter table profile add column pronouns text; 1111 + alter table profile add column pronouns text not null default ''; 1112 1112 `) 1113 1113 return err 1114 1114 })
+1
appview/db/profile.go
··· 308 308 profile.Did = did 309 309 310 310 includeBluesky := 0 311 + 311 312 err := e.QueryRow( 312 313 `select description, include_bluesky, location, pronouns from profile where did = ?`, 313 314 did,
appview/ingester.go

This file has not been changed.

appview/models/profile.go

This file has not been changed.

appview/pages/templates/user/fragments/editBio.html

This file has not been changed.

+1 -1
appview/pages/templates/user/fragments/profileCard.html
··· 14 14 </p> 15 15 {{ with .Profile }} 16 16 {{ if .Pronouns }} 17 - <span>{{ .Pronouns }}</span> 17 + <p class="text-gray-500 dark:text-gray-400">{{ .Pronouns }}</p> 18 18 {{ end }} 19 19 {{ end }} 20 20 <a href="/{{ $userIdent }}/feed.atom">{{ i "rss" "size-4" }}</a>
appview/state/profile.go

This file has not been changed.

lexicons/actor/profile.json

This file has not been changed.

+2 -2
flake.lock
··· 83 83 "lastModified": 1731402384, 84 84 "narHash": "sha256-OwUmrPfEehLDz0fl2ChYLK8FQM2p0G1+EMrGsYEq+6g=", 85 85 "type": "tarball", 86 - "url": "https://github.com/IBM/plex/releases/download/@ibm/plex-mono@1.1.0/ibm-plex-mono.zip" 86 + "url": "https://github.com/IBM/plex/releases/download/@ibm%2Fplex-mono@1.1.0/ibm-plex-mono.zip" 87 87 }, 88 88 "original": { 89 89 "type": "tarball", 90 - "url": "https://github.com/IBM/plex/releases/download/@ibm/plex-mono@1.1.0/ibm-plex-mono.zip" 90 + "url": "https://github.com/IBM/plex/releases/download/@ibm%2Fplex-mono@1.1.0/ibm-plex-mono.zip" 91 91 } 92 92 }, 93 93 "indigo": {

History

4 rounds 5 comments
sign up or login to add to the discussion
serendipty01.dev submitted #3
diff interdiff
1 commit
expand
e3f27a5b
appview: add personal pronouns to profile
expand 1 comment
oppi.li

lgtm thanks!

pull request successfully merged
serendipty01.dev submitted #2
diff interdiff
1 commit
expand
11044fd9
appview: add personal pronouns to profile
expand 1 comment
oppi.li

this is looking pretty neat! i'd like the pronouns column to still be nullable however. we can use pronouns sql.Null[String] in the scanner instead, and do a pronouns.Valid check before assigning to the profile.

serendipty01.dev submitted #1
diff
1 commit
expand
81169be6
appview: add personal pronouns to profile
expand 0 comments
serendipty01.dev submitted #0
diff
1 commit
expand
77301f1a
appview: add personal pronouns to profile
expand 3 comments
oppi.li

thanks for the PR! couple of things:

  • the timeline fails to load, GetProfiles does not handle null pronouns gracefully
  • can we use text-gray-500 dark:text-gray-400 on the rendered field?

otherwise, quite happy with this changeset!

serendipty01.dev

thanks, let me do those changes

serendipty01.dev

updated the PR