appview/labels: reduce the opset after validation #605

merged
opened by oppi.li targeting master from push-plpuqtyrprou

validation also performs a transformation upon labels: it resolves handles to DIDs, it is important that this transform be present when determining redundant ops.

Signed-off-by: oppiliappan me@oppi.li

Changed files
+3 -3
appview
labels
+3 -3
appview/labels/labels.go
··· 162 } 163 } 164 165 - // reduce the opset 166 - labelOps = models.ReduceLabelOps(labelOps) 167 - 168 for i := range labelOps { 169 def := actx.Defs[labelOps[i].OperandKey] 170 if err := l.validator.ValidateLabelOp(def, repo, &labelOps[i]); err != nil { ··· 173 } 174 } 175 176 // next, apply all ops introduced in this request and filter out ones that are no-ops 177 validLabelOps := labelOps[:0] 178 for _, op := range labelOps {
··· 162 } 163 } 164 165 for i := range labelOps { 166 def := actx.Defs[labelOps[i].OperandKey] 167 if err := l.validator.ValidateLabelOp(def, repo, &labelOps[i]); err != nil { ··· 170 } 171 } 172 173 + // reduce the opset 174 + labelOps = models.ReduceLabelOps(labelOps) 175 + 176 // next, apply all ops introduced in this request and filter out ones that are no-ops 177 validLabelOps := labelOps[:0] 178 for _, op := range labelOps {