appview/labels: reduce the opset after validation #605

merged
opened by oppi.li targeting master from push-plpuqtyrprou

validation also performs a transformation upon labels: it resolves handles to DIDs, it is important that this transform be present when determining redundant ops.

Signed-off-by: oppiliappan me@oppi.li

Changed files
+3 -3
appview
labels
+3 -3
appview/labels/labels.go
··· 152 } 153 } 154 155 - // reduce the opset 156 - labelOps = models.ReduceLabelOps(labelOps) 157 - 158 for i := range labelOps { 159 def := actx.Defs[labelOps[i].OperandKey] 160 if err := l.validator.ValidateLabelOp(def, &labelOps[i]); err != nil { ··· 163 } 164 } 165 166 // next, apply all ops introduced in this request and filter out ones that are no-ops 167 validLabelOps := labelOps[:0] 168 for _, op := range labelOps {
··· 152 } 153 } 154 155 for i := range labelOps { 156 def := actx.Defs[labelOps[i].OperandKey] 157 if err := l.validator.ValidateLabelOp(def, &labelOps[i]); err != nil { ··· 160 } 161 } 162 163 + // reduce the opset 164 + labelOps = models.ReduceLabelOps(labelOps) 165 + 166 // next, apply all ops introduced in this request and filter out ones that are no-ops 167 validLabelOps := labelOps[:0] 168 for _, op := range labelOps {