appview: do not require auth for upgrade banner #599

merged

opened by

oppi.li 3 months ago targeting master from push-rurrtsvmnvku

the upgrade banner is left empty if the user's session is expired. this prevents them from randomly being booted to the login page.

Signed-off-by: oppiliappan me@oppi.li

options

unified split

Changed files

+5 -1

appview

state

router.go

state.go

+1 -1

appview/state/router.go

··· 116 117 r.Get("/", s.HomeOrTimeline) 118 r.Get("/timeline", s.Timeline) 119 - r.With(middleware.AuthMiddleware(s.oauth)).Get("/upgradeBanner", s.UpgradeBanner) 120 121 // special-case handler for serving tangled.org/core 122 r.Get("/core", s.Core())

··· 116 117 r.Get("/", s.HomeOrTimeline) 118 r.Get("/timeline", s.Timeline) 119 + r.Get("/upgradeBanner", s.UpgradeBanner) 120 121 // special-case handler for serving tangled.org/core 122 r.Get("/core", s.Core())

appview/state/state.go

··· 249 250 func (s *State) UpgradeBanner(w http.ResponseWriter, r *http.Request) { 251 user := s.oauth.GetUser(r) 252 l := s.logger.With("handler", "UpgradeBanner") 253 l = l.With("did", user.Did) 254 l = l.With("handle", user.Handle)

··· 249 250 func (s *State) UpgradeBanner(w http.ResponseWriter, r *http.Request) { 251 user := s.oauth.GetUser(r) 252 + if user == nil { 253 + return 254 + } 255 + 256 l := s.logger.With("handler", "UpgradeBanner") 257 l = l.With("did", user.Did) 258 l = l.With("handle", user.Handle)