ci: enforce prettier formatting #488

+34

4 changed files

Diff round #2

expand all

unified split

.prettierignore

.prettierrc

.tangled

workflows

fmt.yml

flake.nix

+13

.prettierignore

··· 1 + flake.lock 2 + 3 + # for now, we don't want these formatted, but let's consider it in the future? 4 + *.json 5 + *.md 6 + *.yml 7 + *.yaml 8 + *.jsonc 9 + *.json 10 + 11 + # causes Go template plugin errors: https://github.com/NiklasPor/prettier-plugin-go-template/issues/120 12 + appview/pages/templates/layouts/repobase.html 13 + appview/pages/templates/repo/tags.html

+10

.prettierrc

··· 1 + { 2 + "overrides": [ 3 + { 4 + "files": ["*.html"], 5 + "options": { 6 + "parser": "go-template" 7 + } 8 + } 9 + ] 10 + }

.tangled/workflows/fmt.yml

··· 17 17 unformatted=$(gofmt -l .) 18 18 test -z "$unformatted" || (echo "$unformatted" && exit 1) 19 19 20 + - name: "prettier" 21 + command: | 22 + # exec $(nix build .#prettier-wrapper --no-link --print-out-paths)/bin/prettier -c . 23 + nix develop -c "prettier -c ." || true 24 + ls -lah /

flake.nix

··· 106 106 pkgsCross-gnu64-pkgsStatic-knot = crossPackages.knot; 107 107 pkgsCross-gnu64-pkgsStatic-knot-unwrapped = crossPackages.knot-unwrapped; 108 108 pkgsCross-gnu64-pkgsStatic-spindle = crossPackages.spindle; 109 + 110 + prettier-wrapper = pkgs.runCommand "prettier-wrapper" {nativeBuildInputs = [pkgs.makeWrapper];} '' 111 + mkdir -p "$out/bin" 112 + makeWrapper ${pkgs.prettier}/bin/prettier "$out/bin/prettier" --add-flags "--plugin=${pkgs.prettier-plugin-go-template}/lib/node_modules/prettier-plugin-go-template/lib/index.js" 113 + ''; 109 114 }); 110 115 defaultPackage = forAllSystems (system: self.packages.${system}.appview); 111 116 formatter = forAllSystems (system: nixpkgsFor.${system}.alejandra); ··· 129 134 pkgs.redis 130 135 pkgs.coreutils # for those of us who are on systems that use busybox (alpine) 131 136 packages'.lexgen 137 + packages'.prettier-wrapper 132 138 ]; 133 139 shellHook = '' 134 140 mkdir -p appview/pages/static

History

6 rounds 4 comments

winter.bsky.social submitted #5 6mo

diff interdiff

1 commit

expand

9482a0b9

ci: check formatting with treefmt

expand 0 comments

pull request successfully merged

winter.bsky.social submitted #4 6mo

diff interdiff

1 commit

expand

69adbcc5

ci: check formatting with treefmt

expand 0 comments

winter.bsky.social submitted #3 6mo

diff interdiff

1 commit

expand

4084dcfe

ci: add prettier check (hopefully it works)

expand 4 comments

winter.bsky.social 6mo

Failed to update pull request on the PDS. Try again later.

Oh okay.

isabelroses.com 6mo

imo pkgs.runCommand should be pkgs.runCommandLocal I don't think your caching the package anywhere. will also make running the command slightly faster

isabelroses.com 6mo

to add a bit to my point. some people may have a number of caches, for example i have 15... i've also seen people with 8 here. this makes this pkgs.runCommand quite slow as oppose to pkgs.runCommandLocal since it doesn't have to contact the caches to see if they have the derivation. since it should build relatively quickly so it shouldn't be too detrimental to remove the cache query from it.

winter.bsky.social 6mo

Picked the change Isabel suggested into master.

winter.bsky.social submitted #2 6mo

interdiff

1 commit

expand

b61a8bfb

ci: add prettier check (hopefully it works)

expand 0 comments

winter.bsky.social submitted #1 6mo

diff interdiff

1 commit

expand

44ad1251

ci: add prettier check (hopefully it works)

expand 0 comments

winter.bsky.social submitted #0 6mo

diff

1 commit

expand

0a359b75

ci: add prettier check (hopefully it works)

expand 0 comments