tangled.org / core
Monorepo for Tangled tangled.org
fork atom

appview: implement follower and following pages for users #484

merged opened by ptr.pet targeting master from [deleted fork]: followers-following-list
STACK 4
#505 appview: implement GetFollowersFollowingCounts to query follow stats for multiple dids in one go
1
#5
#504 appview: state: dedup profile pages
0
#5
#484 appview: implement follower and following pages for users
6
#13
#483 appview: db: follow: add GetFollowers and GetFollowing functions to fetch Follows
3
#2
ABANDONED PULLS 1
#482 appview: rename GetFollowerFollowing to GetFollowerFollowingCount
0
#0
Labels

None yet.

assignee

None yet.

Participants 2
AT URI
at://did:plc:dfl62fgb7wtjj3fcbb72naae/sh.tangled.repo.pull/3lwawsuk3de22
+8 -4
Interdiff #7 → #8
unified split
appview/db/profile.go

This file has not been changed.

appview/db/timeline.go

This file has not been changed.

appview/pages/funcmap.go

This file has not been changed.

appview/pages/pages.go

This file has not been changed.

+2 -2
appview/pages/templates/timeline.html
··· 152 {{ with $stat }} 153 <div class="text-sm flex items-center gap-2 my-2 overflow-hidden text-ellipsis whitespace-nowrap max-w-full"> 154 <span class="flex-shrink-0">{{ i "users" "size-4" }}</span> 155 - <span id="followers">{{ .Followers }} followers</span> 156 <span class="select-none after:content-['·']"></span> 157 - <span id="following">{{ .Following }} following</span> 158 </div> 159 {{ end }} 160 </div>
··· 152 {{ with $stat }} 153 <div class="text-sm flex items-center gap-2 my-2 overflow-hidden text-ellipsis whitespace-nowrap max-w-full"> 154 <span class="flex-shrink-0">{{ i "users" "size-4" }}</span> 155 + <span id="followers"><a href="/{{ $userHandle }}/followers">{{ .Followers }} followers</a></span> 156 <span class="select-none after:content-['·']"></span> 157 + <span id="following"><a href="/{{ $userHandle }}/following">{{ .Following }} following</a></span> 158 </div> 159 {{ end }} 160 </div>
appview/pages/templates/user/followers.html

This file has not been changed.

appview/pages/templates/user/following.html

This file has not been changed.

appview/pages/templates/user/fragments/follow.html

This file has not been changed.

+2 -2
appview/pages/templates/user/fragments/followCard.html
··· 13 <p class="text-sm pb-2 md:pb-2">{{.Profile.Description}}</p> 14 <div class="text-sm flex items-center gap-2 my-2 overflow-hidden text-ellipsis whitespace-nowrap max-w-full"> 15 <span class="flex-shrink-0">{{ i "users" "size-4" }}</span> 16 - <span id="followers">{{ .FollowersCount }} followers</span> 17 <span class="select-none after:content-['·']"></span> 18 - <span id="following">{{ .FollowingCount }} following</span> 19 </div> 20 </div> 21
··· 13 <p class="text-sm pb-2 md:pb-2">{{.Profile.Description}}</p> 14 <div class="text-sm flex items-center gap-2 my-2 overflow-hidden text-ellipsis whitespace-nowrap max-w-full"> 15 <span class="flex-shrink-0">{{ i "users" "size-4" }}</span> 16 + <span id="followers"><a href="/{{ $userIdent }}/followers">{{ .FollowersCount }} followers</a></span> 17 <span class="select-none after:content-['·']"></span> 18 + <span id="following"><a href="/{{ $userIdent }}/following">{{ .FollowingCount }} following</a></span> 19 </div> 20 </div> 21
appview/pages/templates/user/fragments/profileCard.html

This file has not been changed.

+4
appview/state/profile.go
··· 28 s.profilePage(w, r) 29 case "repos": 30 s.reposPage(w, r) 31 } 32 } 33
··· 28 s.profilePage(w, r) 29 case "repos": 30 s.reposPage(w, r) 31 + case "followers": 32 + s.followersPage(w, r) 33 + case "following": 34 + s.followingPage(w, r) 35 } 36 } 37
appview/state/router.go

This file has not been changed.

appview/strings/strings.go

This file has not been changed.

History

14 rounds 6 comments
sign up or login to add to the discussion
ptr.pet submitted #13
diff interdiff
1 commit
expand
cb75b373
appview: implement follower and following pages for users
expand 0 comments
pull request successfully merged
ptr.pet submitted #12
diff interdiff
1 commit
expand
98413d89
appview: implement follower and following pages for users
expand 0 comments
ptr.pet submitted #11
diff interdiff
1 commit
expand
118fb342
appview: implement follower and following pages for users
expand 0 comments
ptr.pet submitted #10
diff interdiff
1 commit
expand
7a5c931a
appview: implement follower and following pages for users
expand 0 comments
ptr.pet submitted #9
diff interdiff
1 commit
expand
773aa964
appview: implement follower and following pages for users
expand 1 comment
ptr.pet
  • fixed timeline linking to wrong user (forgot to use subjectHandle instead of userHandle)
  • use ?tab= for followers / following like repo page does
  • fix repos opengraph url from /repos to ?tab=repos
ptr.pet submitted #8
interdiff
1 commit
expand
ece60a35
appview: implement follower and following pages for users
expand 1 comment
ptr.pet
  • added following / follower page links to timeline and follow cards
  • also added followers and following to profile tab switch case
ptr.pet submitted #7
diff interdiff
1 commit
expand
a8bcde9d
appview: implement follower and following pages for users
expand 1 comment
ptr.pet

using resolve in html instead of resolving handles in go code, and dedupped followers/followingPage into followPage

ptr.pet submitted #6
diff interdiff
1 commit
expand
a285cd0f
appview: implement follower and following pages for users
expand 0 comments
ptr.pet submitted #5
diff interdiff
1 commit
expand
3c2d8223
appview: implement follower and following pages for users
expand 1 comment
ptr.pet

fixed some issues now that i got my dev setup working again

ptr.pet submitted #4
diff interdiff
1 commit
expand
90b0a392
appview: implement follower and following pages for users
expand 1 comment
ptr.pet

comments from #1 should be addressed now

on top of that changed GetProfiles to return a map instead of array, which seemed easier to do since it internally uses a map anyway and both places it's used in need it as a map

ptr.pet submitted #3
diff interdiff
1 commit
expand
0dfc15e9
appview: implement follower and following pages for users
expand 0 comments
ptr.pet submitted #2
diff interdiff
1 commit
expand
9643a898
appview: implement follower and following pages for users
expand 0 comments
ptr.pet submitted #1
diff interdiff
1 commit
expand
cf9a2ce8
appview: implement follower and following pages for users
expand 1 comment
oppi.li

the pages themselves look pretty good for a start!

  • i'd like to add follower-following count to each item (to make these identical to the profile cards in the timeline)
  • this GetProfile call results in an N+1 query. we have a helper called GetProfiles to help with this, you can get profiles of multiple DIDs in one DB call. db/timeline.go has an example of the same.

overall, i'm loving this stack!

ptr.pet submitted #0
diff
1 commit
expand
cbdbaf6d
appview: implement follower and following pages for users
expand 0 comments