tangled.org / core
Monorepo for Tangled tangled.org
fork atom

appview: repo: implement generating feed #476

merged opened by ptr.pet targeting master from [deleted fork]: repo-feed
STACK 4
#477 appview: pages: repobase: add link to atom feed
3
#1
#476 appview: repo: implement generating feed
4
#4
#475 appview: db: pulls: add method for getting any pulls on a repo
5
#2
#474 appview: db: issues: add method for getting any issues a repo might have
2
#1
Labels

None yet.

assignee

None yet.

Participants 2
AT URI
at://did:plc:dfl62fgb7wtjj3fcbb72naae/sh.tangled.repo.pull/3lw7rerhbqm22
+22 -4
Interdiff #2 → #3
unified split
+22 -4
appview/repo/repo.go
··· 314 314 if err != nil { 315 315 return nil, err 316 316 } 317 + 318 + for _, round := range pull.Submissions { 319 + item := &feeds.Item{ 320 + Title: fmt.Sprintf("[PR #%d] %s (round #%d)", pull.PullId, pull.Title, round.RoundNumber), 321 + Description: fmt.Sprintf("@%s submitted changes (at round #%d) on PR #%d in %s", owner.Handle, round.RoundNumber, pull.PullId, f.OwnerSlashRepo()), 322 + Link: &feeds.Link{Href: fmt.Sprintf("%s/%s/pulls/%d", rp.config.Core.AppviewHost, f.OwnerSlashRepo(), pull.PullId)}, 323 + Created: pull.Created, 324 + Author: &feeds.Author{ 325 + Name: fmt.Sprintf("@%s", owner.Handle), 326 + }, 327 + } 328 + feed.Items = append(feed.Items, item) 329 + } 330 + 317 331 var state string 318 332 if pull.State == db.PullOpen { 319 333 state = "opened" 320 334 } else { 321 335 state = pull.State.String() 322 336 } 337 + mergedAtRounds := "" 338 + if pull.State == db.PullMerged { 339 + mergedAtRounds = fmt.Sprintf(" (on round #%d)", pull.LastRoundNumber()) 340 + } 323 341 item := &feeds.Item{ 324 - Title: fmt.Sprintf("[PR] %s", pull.Title), 325 - Description: fmt.Sprintf("@%s %s pull request on %s", owner.Handle, state, f.OwnerSlashRepo()), 342 + Title: fmt.Sprintf("[PR #%d] %s", pull.PullId, pull.Title), 343 + Description: fmt.Sprintf("@%s %s pull request #%d%s in %s", owner.Handle, state, pull.PullId, mergedAtRounds, f.OwnerSlashRepo()), 326 344 Link: &feeds.Link{Href: fmt.Sprintf("%s/%s/pulls/%d", rp.config.Core.AppviewHost, f.OwnerSlashRepo(), pull.PullId)}, 327 345 Created: pull.Created, 328 346 Author: &feeds.Author{ ··· 344 362 state = "closed" 345 363 } 346 364 item := &feeds.Item{ 347 - Title: fmt.Sprintf("[Issue] %s", issue.Title), 348 - Description: fmt.Sprintf("@%s %s issue on %s", owner.Handle, state, f.OwnerSlashRepo()), 365 + Title: fmt.Sprintf("[Issue #%d] %s", issue.IssueId, issue.Title), 366 + Description: fmt.Sprintf("@%s %s issue #%d in %s", owner.Handle, state, issue.IssueId, f.OwnerSlashRepo()), 349 367 Link: &feeds.Link{Href: fmt.Sprintf("%s/%s/issues/%d", rp.config.Core.AppviewHost, f.OwnerSlashRepo(), issue.IssueId)}, 350 368 Created: issue.Created, 351 369 Author: &feeds.Author{
appview/repo/router.go

This file has not been changed.

History

5 rounds 4 comments
sign up or login to add to the discussion
ptr.pet submitted #4
diff interdiff
1 commit
expand
bd1694e2
appview: repo: implement generating feed
expand 1 comment
ptr.pet

including submissions in the feed now aswell

pull request successfully merged
ptr.pet submitted #3
diff
1 commit
expand
7e9f0eea
appview: repo: implement generating feed
expand 0 comments
ptr.pet submitted #2
diff interdiff
1 commit
expand
2851773b
appview: repo: implement generating feed
expand 0 comments
ptr.pet submitted #1
diff interdiff
1 commit
expand
381c1840
appview: repo: implement generating feed
expand 2 comments
oppi.li

for the feed title, can we change it to be of the format [Issue] <Issue Title> and [PR] <Pull title>?

ptr.pet

made the title that, moved the existing one as description

ptr.pet submitted #0
diff
1 commit
expand
aea5b04f
appview: repo: implement generating feed
expand 1 comment
ptr.pet

this is pretty simple for now (only puts pull and issue creation in), like the profile timeline since i assume this could use the same code as notifications code later for keeping track of pulls / issues being closed etc etc