back interdiff of round #1 and #0

appview/repo: make pipelines page actually reflect if no spindle is selected, allow removing a spindle from a repo #439

merged
opened by winter.bsky.social targeting master from winter.bsky.social/core: push-pxstrpokmqmn
files
appview
db
pages
templates
repo
settings
repo
REVERTED
appview/db/repos.go
··· 391 391 var description, spindle sql.NullString 392 392 393 393 row := e.QueryRow(` 394 + select did, name, knot, created, at_uri, description, spindle 394 - select did, name, knot, created, at_uri, description, spindle 395 395 from repos 396 396 where did = ? and name = ? 397 397 `, ··· 556 556 return err 557 557 } 558 558 559 + func UpdateSpindle(e Execer, repoAt, spindle string) error { 559 - func UpdateSpindle(e Execer, repoAt string, spindle *string) error { 560 560 _, err := e.Exec( 561 561 `update repos set spindle = ? where at_uri = ?`, spindle, repoAt) 562 562 return err
REVERTED
appview/pages/templates/repo/settings/pipelines.html
··· 38 38 name="spindle" 39 39 required 40 40 class="p-1 max-w-64 border border-gray-200 bg-white dark:bg-gray-800 dark:text-white dark:border-gray-700"> 41 + <option value="" disabled> 41 - {{/* For some reason, we can't use an empty string in a <select> in all scenarios unless it is preceded by a disabled select?? No idea, could just be a Firefox thing? */}} 42 - <option value="[[none]]" class="py-1" {{ if not $.CurrentSpindle }}selected{{ end }}> 43 - {{ if not $.CurrentSpindle }} 44 42 Choose a spindle 45 - {{ else }} 46 - Disable pipelines 47 - {{ end }} 48 43 </option> 49 44 {{ range $.Spindles }} 50 45 <option value="{{ . }}" class="py-1" {{ if eq . $.CurrentSpindle }}selected{{ end }}>
ERROR
appview/repo/repo.go

Failed to calculate interdiff for this file.