tangled.org / core
Monorepo for Tangled tangled.org
fork atom

appview: replace PullComment to Comment #1273

open opened by boltless.me targeting master from sl/comment

Including db migration to migrate issue_comments and pull_comments to unified comments table.

Signed-off-by: Seongmin Lee git@boltless.me

STACK 10
#1303 appview: add reactions to comments
0/3
0
#3
#1306 appview: fetch aturi->reactionMap from DB
0/3
0
#3
#1305 appview: add comment to strings
0/3
1
#3
#1304 appview: move CommentList out of Issue
0/3
0
#3
#1276 appview: unified comment fragments/handlers
0/3
4
#9
#1275 appview/notify: merge new comment events into one
0/3
0
#9
#1274 appview: replace IssueComment to Comment
0/3
0
#9
#1273 appview: replace PullComment to Comment
0/3
8
#9
#1271 lexicons: com.atproto.repo.strongRef and sh.tangled.markup#markdown
0/3
2
#9
#1270 lexicons: add general sh.tangled.comment lexicon
0/3
0
#9
ABANDONED PULLS 1
#1272 knotserver: invalidate directory cache on identity events
0/3
1
#0
Labels

None yet.

assignee

None yet.

Participants 2
AT URI
at://did:plc:xasnlahkri4ewmbuzly2rlc5/sh.tangled.repo.pull/3mimbhgiqc722
Interdiff #8 → #9
appview/db/comments.go

This file has not been changed.

appview/db/db.go

This file has not been changed.

appview/db/pulls.go

This file has not been changed.

appview/db/reference.go

This file has not been changed.

appview/ingester.go

This patch was likely rebased, as context lines do not match.

appview/models/comment.go

This file has not been changed.

appview/models/pull.go

This patch was likely rebased, as context lines do not match.

appview/notify/db/db.go

This file has not been changed.

appview/notify/logging/notifier.go

This file has not been changed.

appview/notify/merged_notifier.go

This file has not been changed.

appview/notify/notifier.go

This file has not been changed.

appview/notify/posthog/notifier.go

This file has not been changed.

appview/oauth/scopes.go

This file has not been changed.

appview/pages/templates/repo/pulls/pull.html

This file has not been changed.

appview/pulls/pulls.go

This patch was likely rebased, as context lines do not match.

appview/state/state.go

This file has not been changed.

History

10 rounds 8 comments
sign up or login to add to the discussion
boltless.me submitted #9
diff
1 commit
expand
28e2bfea
appview: replace PullComment to Comment
3/3 failed
expand
build.yml
fmt.yml
test.yml
no conflicts, ready to merge
expand 0 comments
boltless.me submitted #8
diff interdiff
1 commit
expand
dc838cf1
appview: replace PullComment to Comment
3/3 failed
expand
build.yml
fmt.yml
test.yml
expand 0 comments
boltless.me submitted #7
diff interdiff
1 commit
expand
7cbbbf81
appview: replace PullComment to Comment
3/3 failed
expand
build.yml
fmt.yml
test.yml
expand 0 comments
boltless.me submitted #6
diff interdiff
1 commit
expand
d18d899f
appview: replace PullComment to Comment
3/3 failed
expand
build.yml
fmt.yml
test.yml
expand 0 comments
boltless.me submitted #5
diff interdiff
1 commit
expand
e1fba919
appview: replace PullComment to Comment
3/3 failed
expand
build.yml
fmt.yml
test.yml
expand 0 comments
boltless.me submitted #4
diff interdiff
1 commit
expand
e1fba919
appview: replace PullComment to Comment
3/3 failed
expand
build.yml
fmt.yml
test.yml
expand 0 comments
boltless.me submitted #3
diff interdiff
1 commit
expand
b396d488
appview: replace PullComment to Comment
3/3 failed
expand
build.yml
fmt.yml
test.yml
expand 2 comments
oyster.cafe

appview/models/comment.go:144 won't this always be non-nil, which means issue comments might get a pull round in the record?

oyster.cafe

appview/ingester.go:1073 maybe this should resolve mentions from the original instead of processed

boltless.me submitted #2
diff interdiff
1 commit
expand
df8c1f82
appview: replace PullComment to Comment
3/3 failed
expand
build.yml
fmt.yml
test.yml
expand 6 comments
oyster.cafe

appview/db/reference.go:137 is this supposed to be subject_uri as per the db?

boltless.me

Good spot! I completely missed it. Thanks

oyster.cafe

there's that one instance and a couple others I think

oyster.cafe

appview/ingester.go:1036 we could make a notification in this function right? :p

oyster.cafe

appview/db/comments.go:243 I think this should be before the rows loop, maybe

boltless.me

we could make a notification in this function right? :p

yeah, I was going to introduce that after #1275 and forgot to do that.

I think this should be before the rows loop, maybe

good spot. will fix

boltless.me submitted #1
diff interdiff
1 commit
expand
7b4697b3
appview: replace PullComment to Comment
3/3 failed
expand
build.yml
fmt.yml
test.yml
expand 0 comments
boltless.me submitted #0
diff
1 commit
expand
21784c75
appview: replace PullComment to Comment
3/3 failed
expand
build.yml
fmt.yml
test.yml
expand 0 comments