tangled.org
Including db migration to migrate issue_comments and pull_comments
to unified comments table.
Signed-off-by: Seongmin Lee git@boltless.me
appview/db/comments.go
appview/db/comments.go
This file has not been changed.
appview/db/db.go
appview/db/db.go
This file has not been changed.
appview/db/pulls.go
appview/db/pulls.go
This file has not been changed.
appview/db/reference.go
appview/db/reference.go
This file has not been changed.
+2
-2
appview/ingester.go
+2
-2
appview/ingester.go
···
1069
1069
}
1070
1070
1071
1071
var references []syntax.ATURI
1072
-
if original := comment.Body.Original; original != nil {
1073
-
_, references = i.MentionsResolver.Resolve(ctx, comment.Body.Text)
1072
+
if comment.Body.Original != nil {
1073
+
_, references = i.MentionsResolver.Resolve(ctx, *comment.Body.Original)
1074
1074
}
1075
1075
1076
1076
tx, err := ddb.Begin()
+4
-3
appview/models/comment.go
+4
-3
appview/models/comment.go
···
126
126
}
127
127
}
128
128
129
-
var pullRoundIdx int
129
+
var pullRoundIdx *int
130
130
if record.PullRoundIdx != nil {
131
-
pullRoundIdx = int(*record.PullRoundIdx)
131
+
pullRoundIdx = new(int)
132
+
*pullRoundIdx = int(*record.PullRoundIdx)
132
133
}
133
134
134
135
return &Comment{
···
141
142
Body: *record.Body.MarkupMarkdown,
142
143
Created: created,
143
144
ReplyTo: record.ReplyTo,
144
-
PullRoundIdx: &pullRoundIdx,
145
+
PullRoundIdx: pullRoundIdx,
145
146
}, nil
146
147
}
appview/models/pull.go
appview/models/pull.go
This file has not been changed.
appview/notify/db/db.go
appview/notify/db/db.go
This file has not been changed.
appview/notify/logging/notifier.go
appview/notify/logging/notifier.go
This file has not been changed.
appview/notify/merged_notifier.go
appview/notify/merged_notifier.go
This file has not been changed.
appview/notify/notifier.go
appview/notify/notifier.go
This file has not been changed.
appview/notify/posthog/notifier.go
appview/notify/posthog/notifier.go
This file has not been changed.
appview/oauth/scopes.go
appview/oauth/scopes.go
This file has not been changed.
appview/pages/templates/repo/pulls/pull.html
appview/pages/templates/repo/pulls/pull.html
This file has not been changed.
appview/pulls/pulls.go
appview/pulls/pulls.go
This file has not been changed.
appview/state/state.go
appview/state/state.go
This file has not been changed.
History
10 rounds
8 comments
boltless.me
submitted
#9
1 commit
expand
collapse
appview: replace
PullComment to Comment
Including db migration to migrate `issue_comments` and `pull_comments`
to unified `comments` table.
Signed-off-by: Seongmin Lee <git@boltless.me>
3/3 failed
expand
collapse
no conflicts, ready to merge
expand 0 comments
boltless.me
submitted
#8
1 commit
expand
collapse
appview: replace
PullComment to Comment
Including db migration to migrate `issue_comments` and `pull_comments`
to unified `comments` table.
Signed-off-by: Seongmin Lee <git@boltless.me>
3/3 failed
expand
collapse
expand 0 comments
boltless.me
submitted
#7
1 commit
expand
collapse
appview: replace
PullComment to Comment
Including db migration to migrate `issue_comments` and `pull_comments`
to unified `comments` table.
Signed-off-by: Seongmin Lee <git@boltless.me>
3/3 failed
expand
collapse
expand 0 comments
boltless.me
submitted
#6
1 commit
expand
collapse
appview: replace
PullComment to Comment
Including db migration to migrate `issue_comments` and `pull_comments`
to unified `comments` table.
Signed-off-by: Seongmin Lee <git@boltless.me>
3/3 failed
expand
collapse
expand 0 comments
boltless.me
submitted
#5
1 commit
expand
collapse
appview: replace
PullComment to Comment
Including db migration to migrate `issue_comments` and `pull_comments`
to unified `comments` table.
Signed-off-by: Seongmin Lee <git@boltless.me>
3/3 failed
expand
collapse
expand 0 comments
boltless.me
submitted
#4
1 commit
expand
collapse
appview: replace
PullComment to Comment
Including db migration to migrate `issue_comments` and `pull_comments`
to unified `comments` table.
Signed-off-by: Seongmin Lee <git@boltless.me>
3/3 failed
expand
collapse
expand 0 comments
boltless.me
submitted
#3
1 commit
expand
collapse
appview: replace
PullComment to Comment
Including db migration to migrate `issue_comments` and `pull_comments`
to unified `comments` table.
Signed-off-by: Seongmin Lee <git@boltless.me>
3/3 failed
expand
collapse
expand 2 comments
appview/ingester.go:1073 maybe this should resolve mentions from the original instead of processed
boltless.me
submitted
#2
1 commit
expand
collapse
appview: replace
PullComment to Comment
Including db migration to migrate `issue_comments` and `pull_comments`
to unified `comments` table.
Signed-off-by: Seongmin Lee <git@boltless.me>
3/3 failed
expand
collapse
expand 6 comments
appview/db/reference.go:137 is this supposed to be subject_uri as per the db?
Good spot! I completely missed it. Thanks
there's that one instance and a couple others I think
appview/ingester.go:1036 we could make a notification in this function right? :p
appview/db/comments.go:243 I think this should be before the rows loop, maybe
we could make a notification in this function right? :p
yeah, I was going to introduce that after #1275 and forgot to do that.
I think this should be before the rows loop, maybe
good spot. will fix
boltless.me
submitted
#1
1 commit
expand
collapse
appview: replace
PullComment to Comment
Including db migration to migrate `issue_comments` and `pull_comments`
to unified `comments` table.
Signed-off-by: Seongmin Lee <git@boltless.me>
3/3 failed
expand
collapse
expand 0 comments
boltless.me
submitted
#0
1 commit
expand
collapse
appview: replace
PullComment to Comment
Including db migration to migrate `issue_comments` and `pull_comments`
to unified `comments` table.
Signed-off-by: Seongmin Lee <git@boltless.me>
appview/models/comment.go:144won't this always be non-nil, which means issue comments might get a pull round in the record?