tangled.org / core
Monorepo for Tangled tangled.org
fork atom

appview,knotmirror: use knotmirror to read the repository #1164

merged opened by boltless.me targeting master from sl/knotmirror

Underlying types except the interface hasn't changed much. Removed xrpcclient.HandleXrpcErr() call as appview always expect knotmirror with compatible API.

Signed-off-by: Seongmin Lee git@boltless.me

STACK 9
#1184 appview/repo: avoid extra xrpc call on empty repo
1/3
0
#2
#1168 knotmirror: add knotBackoff and reachability test
1/3
0
#4
#1167 nix: add knotmirror module
1/3
0
#4
#1164 appview,knotmirror: use knotmirror to read the repository
1/3
5
#4
#1163 lexicons: introduce repo.temp xrpc methods
1/3
3
#4
#1160 knotmirror: introduce knotmirror
1/3
4
#4
#1159 tapc: add tap client package
1/3
2
#4
#1158 nix: add more nix packages/modules related to atproto
1/3
3
#4
#1157 go.mod: bump indigo version to fork
1/3
1
#4
ABANDONED PULLS 4
#1166 knotmirror: add manual resync/cancel
3
#1
#1165 knotmirror: move git logic into GitMirrorManager
0
#1
#1162 knotmirror/db: add timestamps to track syncs
1
#1
#1161 knotmirror: switch to postgres for concurrent writes
3
#1
Labels

None yet.

assignee

None yet.

Participants 3
AT URI
at://did:plc:xasnlahkri4ewmbuzly2rlc5/sh.tangled.repo.pull/3mh3qbj6ygg22
Interdiff #3 → #4
appview/config/config.go

This file has not been changed.

appview/pulls/pulls.go

This file has not been changed.

appview/repo/archive.go

This file has not been changed.

appview/repo/artifact.go

This file has not been changed.

appview/repo/branches.go

This file has not been changed.

appview/repo/compare.go

This file has not been changed.

appview/repo/index.go

This file has not been changed.

appview/repo/log.go

This file has not been changed.

appview/repo/settings.go

This file has not been changed.

appview/repo/tags.go

This file has not been changed.

appview/repo/tree.go

This file has not been changed.

knotmirror/config/config.go

This file has not been changed.

knotmirror/knotmirror.go

This file has not been changed.

knotmirror/xrpc/git_getArchive.go

This file has not been changed.

knotmirror/xrpc/git_getBlob.go

This file has not been changed.

knotmirror/xrpc/git_getBranch.go

This file has not been changed.

knotmirror/xrpc/git_getTag.go

This file has not been changed.

knotmirror/xrpc/git_getTree.go

This file has not been changed.

knotmirror/xrpc/git_listBranches.go

This file has not been changed.

knotmirror/xrpc/git_listCommits.go

This file has not been changed.

knotmirror/xrpc/git_listLanguages.go

This file has not been changed.

knotmirror/xrpc/git_listTags.go

This file has not been changed.

knotmirror/xrpc/xrpc.go

This file has not been changed.

knotserver/git/git.go

This file has not been changed.

History

5 rounds 5 comments
sign up or login to add to the discussion
boltless.me submitted #4
diff
1 commit
expand
099858fc
appview,knotmirror: use knotmirror to read the repository
2/3 failed, 1/3 success
expand
build.yml
fmt.yml
test.yml
expand 0 comments
pull request successfully merged
boltless.me submitted #3
diff interdiff
1 commit
expand
1a5eb1e5
appview,knotmirror: use knotmirror to read the repository
expand 0 comments
boltless.me submitted #2
diff interdiff
1 commit
expand
8c6a4059
appview,knotmirror: use knotmirror to read the repository
expand 0 comments
boltless.me submitted #1
diff interdiff
1 commit
expand
dc655d5f
appview,knotmirror: use knotmirror to read the repository
expand 5 comments
oppi.li

appview/config/config.go:49: can the appview be run without the knotmirror at all?

boltless.me

Yes.

we can't run appview without db syncing atproto repos
we can't run appview without knotmirror syncing git repos

simple as that

oyster.cafe

knotmirror/xrpc/xrpc.go:34

Just to confirm that this doesn't double up on /xrpc/xrpc/something right?

boltless.me

@lewis.moe Thank you for pointing out. Seems like I changed too much since testing it. I'll resubmit everything after testing everything again.

oppi.li

lgtm!

boltless.me submitted #0
diff
1 commit
expand
0ba0ce7f
appview,knotmirror: use knotmirror to read the repository
expand 0 comments