Monorepo for Tangled tangled.org

tapc: add tap client package #1159

merged opened by boltless.me targeting master from sl/knotmirror
Labels

None yet.

assignee

None yet.

Participants 2
AT URI
at://did:plc:xasnlahkri4ewmbuzly2rlc5/sh.tangled.repo.pull/3mh3qbj6xp422
Interdiff #3 #4
tapc/readme.md

This file has not been changed.

tapc/simpleIndexer.go

This file has not been changed.

tapc/tap.go

This file has not been changed.

tapc/types.go

This file has not been changed.

History

5 rounds 2 comments
sign up or login to add to the discussion
1 commit
expand
tapc: add tap client package
2/3 timeout, 1/3 success
expand
expand 0 comments
pull request successfully merged
1 commit
expand
tapc: add tap client package
expand 0 comments
1 commit
expand
tapc: add tap client package
expand 0 comments
1 commit
expand
tapc: add tap client package
expand 2 comments

tapc/tap.go:19-23: can be removed

tapc/tap.go:104: do we need to do this still?

lgtm otherwise!

tapc/tap.go:19-23: can be removed

good point out, I'll clean it up.

tapc/tap.go:104: do we need to do this still?

As a published go package, yes. We can harden the connection by using tap admin password. Not strictly necessary for our infra I guess..?

1 commit
expand
tapc: add tap client package
expand 0 comments