tangled.org / core
Monorepo for Tangled tangled.org
fork atom

tapc: add tap client package #1159

merged opened by boltless.me targeting master from sl/knotmirror
STACK 9
#1184 appview/repo: avoid extra xrpc call on empty repo
1/3
0
#2
#1168 knotmirror: add knotBackoff and reachability test
1/3
0
#4
#1167 nix: add knotmirror module
1/3
0
#4
#1164 appview,knotmirror: use knotmirror to read the repository
1/3
5
#4
#1163 lexicons: introduce repo.temp xrpc methods
1/3
3
#4
#1160 knotmirror: introduce knotmirror
1/3
4
#4
#1159 tapc: add tap client package
1/3
2
#4
#1158 nix: add more nix packages/modules related to atproto
1/3
3
#4
#1157 go.mod: bump indigo version to fork
1/3
1
#4
ABANDONED PULLS 4
#1166 knotmirror: add manual resync/cancel
3
#1
#1165 knotmirror: move git logic into GitMirrorManager
0
#1
#1162 knotmirror/db: add timestamps to track syncs
1
#1
#1161 knotmirror: switch to postgres for concurrent writes
3
#1
Labels

None yet.

assignee

None yet.

Participants 2
AT URI
at://did:plc:xasnlahkri4ewmbuzly2rlc5/sh.tangled.repo.pull/3mh3qbj6xp422
-6
Interdiff #1 → #2
tapc/readme.md

This file has not been changed.

tapc/simpleIndexer.go

This file has not been changed.

-6
tapc/tap.go
··· 16 16 "tangled.org/core/log" 17 17 ) 18 18 19 - // type WebsocketOptions struct { 20 - // maxReconnectSeconds int 21 - // heartbeatIntervalMs int 22 - // // onReconnectError 23 - // } 24 - 25 19 type Handler interface { 26 20 OnEvent(ctx context.Context, evt Event) error 27 21 OnError(ctx context.Context, err error)
tapc/types.go

This file has not been changed.

History

5 rounds 2 comments
sign up or login to add to the discussion
boltless.me submitted #4
diff interdiff
1 commit
expand
873ca115
tapc: add tap client package
2/3 timeout, 1/3 success
expand
build.yml
fmt.yml
test.yml
expand 0 comments
pull request successfully merged
boltless.me submitted #3
diff interdiff
1 commit
expand
1fe2a927
tapc: add tap client package
expand 0 comments
boltless.me submitted #2
diff
1 commit
expand
1fe2a927
tapc: add tap client package
expand 0 comments
boltless.me submitted #1
diff interdiff
1 commit
expand
2adf7b9f
tapc: add tap client package
expand 2 comments
oppi.li

tapc/tap.go:19-23: can be removed

tapc/tap.go:104: do we need to do this still?

lgtm otherwise!

boltless.me

tapc/tap.go:19-23: can be removed

good point out, I'll clean it up.

tapc/tap.go:104: do we need to do this still?

As a published go package, yes. We can harden the connection by using tap admin password. Not strictly necessary for our infra I guess..?

boltless.me submitted #0
diff
1 commit
expand
2adf7b9f
tapc: add tap client package
expand 0 comments