tangled.org / core
Monorepo for Tangled tangled.org
fork atom

appview: update repo, pulls, issues, and pages handlers for repo DID #1141

deleted opened by oyster.cafe targeting master from oyster.cafe/tangled-core: master
STACK 9
#1144 knotserver: add repo DID migration on startup
1
#13
#1143 appview, knotserver: add didAssign event and PDS rewrite on login
1
#13
#1142 spindle: add repo DID support in ingester, secrets, and xrpc handlers
0
#13
#1140 appview: update state, ingester, middleware, and resolver for repo DID
2
#13
#1138 appview: add repo_did columns, migrations, and model struct fields
1
#13
#1137 knotserver: DID-based repo resolution in internal, ingester, git, and router
0
#13
#1136 knotserver/xrpc: use repo DID resolution in all handlers
0
#13
#1135 knotserver: add repodid package, db migrations, and go-didplc dep
1
#13
#1134 lexicons, api/tangled: add repoDid field to all repo-scoped lexicons
2
#13
ABANDONED PULLS 2
#1141 appview: update repo, pulls, issues, and pages handlers for repo DID
2
#8
#1139 appview/db: update query functions for repo_did across all tables
0
#8
Labels

None yet.

assignee

None yet.

Participants 2
AT URI
at://did:plc:3fwecdnvtcscjnrx2p4n7alz/sh.tangled.repo.pull/3mgprvt2eqy22
+5 -5
Interdiff #1 → #2
appview/issues/issues.go

This file has not been changed.

appview/pages/funcmap.go

This file has not been changed.

appview/pages/repoinfo/repoinfo.go

This file has not been changed.

appview/pages/templates/repo/fork.html

This file has not been changed.

appview/pages/templates/repo/new.html

This file has not been changed.

appview/pulls/pulls.go

This file has not been changed.

appview/repo/archive.go

This patch was likely rebased, as context lines do not match.

appview/repo/artifact.go

This file has not been changed.

appview/repo/blob.go

This file has not been changed.

appview/repo/branches.go

This file has not been changed.

appview/repo/compare.go

This file has not been changed.

appview/repo/index.go

This file has not been changed.

appview/repo/log.go

This file has not been changed.

appview/repo/repo.go

This patch was likely rebased, as context lines do not match.

+5 -5
appview/repo/settings.go
··· 188 188 Host: host, 189 189 } 190 190 191 - xrpcBytes, err := tangled.RepoBranches(r.Context(), xrpcc, "", 0, f.RepoIdentifier()) 191 + repo := fmt.Sprintf("%s/%s", f.Did, f.Name) 192 + xrpcBytes, err := tangled.RepoBranches(r.Context(), xrpcc, "", 0, repo) 192 193 var result types.RepoBranchesResponse 193 194 if xrpcerr := xrpcclient.HandleXrpcErr(err); xrpcerr != nil { 194 195 l.Error("failed to call XRPC repo.branches", "err", xrpcerr) ··· 259 260 user := rp.oauth.GetMultiAccountUser(r) 260 261 261 262 collaborators, err := func(repo *models.Repo) ([]pages.Collaborator, error) { 262 - repoCollaborators, err := rp.enforcer.E.GetImplicitUsersForResourceByDomain(repo.RepoIdentifier(), repo.Knot) 263 + repoCollaborators, err := rp.enforcer.E.GetImplicitUsersForResourceByDomain(repo.DidSlashRepo(), repo.Knot) 263 264 if err != nil { 264 265 return nil, err 265 266 } ··· 394 395 Host: host, 395 396 } 396 397 397 - repo := fmt.Sprintf("%s/%s", f.Did, f.Name) 398 - xrpcBytes, err := tangled.RepoBranches(r.Context(), xrpcc, "", 0, repo) 398 + xrpcBytes, err := tangled.RepoBranches(r.Context(), xrpcc, "", 0, f.RepoIdentifier()) 399 399 var result types.RepoBranchesResponse 400 400 if xrpcerr := xrpcclient.HandleXrpcErr(err); xrpcerr != nil { 401 401 l.Error("failed to call XRPC repo.branches", "err", xrpcerr) ··· 466 466 user := rp.oauth.GetMultiAccountUser(r) 467 467 468 468 collaborators, err := func(repo *models.Repo) ([]pages.Collaborator, error) { 469 - repoCollaborators, err := rp.enforcer.E.GetImplicitUsersForResourceByDomain(repo.DidSlashRepo(), repo.Knot) 469 + repoCollaborators, err := rp.enforcer.E.GetImplicitUsersForResourceByDomain(repo.RepoIdentifier(), repo.Knot) 470 470 if err != nil { 471 471 return nil, err 472 472 }
appview/repo/tags.go

This file has not been changed.

appview/repo/tree.go

This file has not been changed.

appview/repo/webhooks.go

This file has not been changed.

History

9 rounds 2 comments
sign up or login to add to the discussion
oyster.cafe submitted #8
diff interdiff
1 commit
expand
d5dee7aa
appview: update repo, pulls, issues, and pages handlers for repo DID
expand 2 comments
boltless.me

Uh, in general I want to abandon like half of the stacks. I should've be more clear on this at first place.

Appview doesn't need to know about repo-did situation in most of the cases yet. If repoDid is optional value, there is no reason to use it. Appview still has to support legacy at-uri based connection, so I'd suggest to not introduce extra behavior on referencing and only use repo-did when performing the repository migration. We don't need to touch any tables except the repos itself.

Appview will

  1. ingest repo-did information from sh.tangled.repo records,
  2. store that extra identifier in repos table,
  3. and use that unique identifier when doing redirection/backlinking after owner migration.

No need to change other data.

oyster.cafe

I'll do some cutting then let you know! :p

This pull has been deleted (possibly by jj abandon or jj squash)
oyster.cafe submitted #7
diff interdiff
1 commit
expand
d5dee7aa
appview: update repo, pulls, issues, and pages handlers for repo DID
expand 0 comments
oyster.cafe submitted #6
diff interdiff
1 commit
expand
d6349c7e
appview: update repo, pulls, issues, and pages handlers for repo DID
expand 0 comments
oyster.cafe submitted #5
diff interdiff
1 commit
expand
52f173c6
appview: update repo, pulls, issues, and pages handlers for repo DID
expand 0 comments
oyster.cafe submitted #4
diff interdiff
1 commit
expand
e8f69bf9
appview: update repo, pulls, issues, and pages handlers for repo DID
expand 0 comments
oyster.cafe submitted #3
diff interdiff
1 commit
expand
5a6108af
appview: update repo, pulls, issues, and pages handlers for repo DID
expand 0 comments
oyster.cafe submitted #2
diff
1 commit
expand
82a027f0
appview: update repo, pulls, issues, and pages handlers for repo DID
expand 0 comments
oyster.cafe submitted #1
diff interdiff
1 commit
expand
11874a66
appview: update repo, pulls, issues, and pages handlers for repo DID
expand 0 comments
oyster.cafe submitted #0
diff
1 commit
expand
26aa6f0a
appview: update repo, pulls, issues, and pages handlers for repo DID
expand 0 comments