Monorepo for Tangled tangled.org

appview: update repo, pulls, issues, and pages handlers for repo DID #1141

deleted opened by oyster.cafe targeting master from oyster.cafe/tangled-core: master
Labels

None yet.

assignee

None yet.

Participants 2
AT URI
at://did:plc:3fwecdnvtcscjnrx2p4n7alz/sh.tangled.repo.pull/3mgprvt2eqy22
-6
Interdiff #0 #1
appview/issues/issues.go

This file has not been changed.

appview/pages/funcmap.go

This file has not been changed.

-6
appview/pages/repoinfo/repoinfo.go
··· 20 20 } 21 21 22 22 func (r RepoInfo) FullName() string { 23 - if r.RepoDid != "" { 24 - return r.RepoDid 25 - } 26 23 return path.Join(r.owner(), r.Name) 27 24 } 28 25 ··· 35 32 } 36 33 37 34 func (r RepoInfo) FullNameWithoutAt() string { 38 - if r.RepoDid != "" { 39 - return userutil.FlattenDid(r.RepoDid) 40 - } 41 35 return path.Join(r.ownerWithoutAt(), r.Name) 42 36 } 43 37
appview/pages/templates/repo/fork.html

This file has not been changed.

appview/pages/templates/repo/new.html

This file has not been changed.

appview/pulls/pulls.go

This file has not been changed.

appview/repo/archive.go

This file has not been changed.

appview/repo/artifact.go

This file has not been changed.

appview/repo/blob.go

This file has not been changed.

appview/repo/branches.go

This file has not been changed.

appview/repo/compare.go

This file has not been changed.

appview/repo/index.go

This file has not been changed.

appview/repo/log.go

This file has not been changed.

appview/repo/repo.go

This file has not been changed.

appview/repo/settings.go

This file has not been changed.

appview/repo/tags.go

This file has not been changed.

appview/repo/tree.go

This file has not been changed.

appview/repo/webhooks.go

This file has not been changed.

History

9 rounds 2 comments
sign up or login to add to the discussion
1 commit
expand
appview: update repo, pulls, issues, and pages handlers for repo DID
expand 2 comments

Uh, in general I want to abandon like half of the stacks. I should've be more clear on this at first place.

Appview doesn't need to know about repo-did situation in most of the cases yet. If repoDid is optional value, there is no reason to use it. Appview still has to support legacy at-uri based connection, so I'd suggest to not introduce extra behavior on referencing and only use repo-did when performing the repository migration. We don't need to touch any tables except the repos itself.

Appview will

  1. ingest repo-did information from sh.tangled.repo records,
  2. store that extra identifier in repos table,
  3. and use that unique identifier when doing redirection/backlinking after owner migration.

No need to change other data.

I'll do some cutting then let you know! :p

This pull has been deleted (possibly by jj abandon or jj squash)
1 commit
expand
appview: update repo, pulls, issues, and pages handlers for repo DID
expand 0 comments
1 commit
expand
appview: update repo, pulls, issues, and pages handlers for repo DID
expand 0 comments
1 commit
expand
appview: update repo, pulls, issues, and pages handlers for repo DID
expand 0 comments
1 commit
expand
appview: update repo, pulls, issues, and pages handlers for repo DID
expand 0 comments
1 commit
expand
appview: update repo, pulls, issues, and pages handlers for repo DID
expand 0 comments
1 commit
expand
appview: update repo, pulls, issues, and pages handlers for repo DID
expand 0 comments
1 commit
expand
appview: update repo, pulls, issues, and pages handlers for repo DID
expand 0 comments
1 commit
expand
appview: update repo, pulls, issues, and pages handlers for repo DID
expand 0 comments