tangled.org / core
Monorepo for Tangled tangled.org
fork atom

appview:{db,models}: webhook tables and crud ops #1066

merged opened by anirudh.fi targeting master from icy/qlyxxp
STACK 6
#1074 docs: document webhooks
3/3
1
#4
#1070 appview/pages: add webhook settings ui
3/3
1
#5
#1069 appview/repo: add webhook management endpoints
1/3
1
#5
#1068 appview/state: integrate webhooks with gitRefUpdate events
3/3
1
#5
#1067 appview/notify: add Push event and webhook notifier
3/3
3
#5
#1066 appview:{db,models}: webhook tables and crud ops
3/3
5
#5
Labels

None yet.

assignee

None yet.

Participants 2
AT URI
at://did:plc:hwevmowznbiukdf6uk5dwrrq/sh.tangled.repo.pull/3menyebs7l722
+1 -1
Interdiff #2 → #3
unified split
+1 -1
appview/db/db.go
··· 572 id integer primary key autoincrement, 573 repo_at text not null, 574 url text not null, 575 - secret text not null, 576 active integer not null default 1, 577 events text not null, -- comma-separated list of events 578 created_at text not null default (strftime('%Y-%m-%dT%H:%M:%SZ', 'now')),
··· 572 id integer primary key autoincrement, 573 repo_at text not null, 574 url text not null, 575 + secret text, 576 active integer not null default 1, 577 events text not null, -- comma-separated list of events 578 created_at text not null default (strftime('%Y-%m-%dT%H:%M:%SZ', 'now')),
appview/db/webhooks.go

This file has not been changed.

appview/models/webhook.go

This file has not been changed.

History

6 rounds 5 comments
sign up or login to add to the discussion
anirudh.fi submitted #5
diff interdiff
1 commit
expand
1c4085b4
appview/{db,models}: webhook tables and crud ops
3/3 success
expand
build.yml
fmt.yml
test.yml
expand 0 comments
pull request successfully merged
anirudh.fi submitted #4
diff interdiff
1 commit
expand
d9d18448
appview/{db,models}: webhook tables and crud ops
3/3 success
expand
build.yml
fmt.yml
test.yml
expand 0 comments
anirudh.fi submitted #3
interdiff
1 commit
expand
9ae20e5b
appview/{db,models}: webhook tables and crud ops
3/3 success
expand
build.yml
fmt.yml
test.yml
expand 3 comments
anirudh.fi

@oppi.li, done.

oppi.li

the db code needs to be updated accordingly to handle null strings, by reading into a sql.Null[string] and checking for s.Valid.

anirudh.fi

Oh, right...

anirudh.fi submitted #2
diff interdiff
1 commit
expand
938c9b71
appview/{db,models}: webhook tables and crud ops
3/3 success
expand
build.yml
fmt.yml
test.yml
expand 1 comment
oppi.li
  • here: we should make the secret nullable in the db, since we no longer sign if secret is not supplied
anirudh.fi submitted #1
diff interdiff
1 commit
expand
8e116bc3
appview:{db,models}: webhook tables and crud ops
3/3 success
expand
build.yml
fmt.yml
test.yml
expand 1 comment
oppi.li
  • we dont need this index
  • would be nice to make [this] more strongly typed, we could have an enum for this, like type WebhookEvent string with more concrete variants
anirudh.fi submitted #0
diff
1 commit
expand
8e116bc3
appview:{db,models}: webhook tables and crud ops
3/3 success
expand
build.yml
fmt.yml
test.yml
expand 0 comments