boltless.me boltless.me It's hard to notice which is commit-id and which is change-id at a glance. Position won't work for new users and it's bit confusing for jj users too because it's inverted from jj's behavior. jj shows change-id on left, commit-id on right. Make UI more clear, or at least give users an option to adjust the bahavior.
| current | proposed |
|---|---|
that's too subtle imo... Isn't it fine to be use a bit strong accent here? revision IDs are most important data in that page, and we want users to actually notice the difference, not unconsciously focus on certain part.
also, I don't think absent of the prefix highlight is helping much to distinguish commit-id and change-id. Because we often intentionally omit the highlight in other pages, it's not that clear.
If colors bother some users too much, can we make the highlight opt-out for people who don't care? or just make it part of a theme so they can just customize it.
OR, how about having super subtle colors for both full 8-chars with same visual weight to uncolored ones? I think subtle bold for prefix is actually good idea.
how about this?
before:
after:
the 'after' option is slightly more readable because the weight of the highlighted text was increased
i like the subtle color for the non-highlighted part and stronger color for highlighted part idea though! will try it
Is this highlight usable anywhere? In the CLI, you can at least use the shorthand to refer to revisions, but what can you do with it on the web?
Maybe we add shortcuts to quickly select that commit by hitting the highlighted char.
Right now, their purpose is only to differentiate git commit-id and jj change-id. We are just doing unique prefix sequence highlight like jj because highlighting them all is bit too much unless we make them super subtle.
I wonder if we can extend this further for actual use-cases though...
color-based highlighting is too noisy. subtle highlighting has been added. will push to master soon!