appview/pipelines: fix incorrect totals

the default query limits to 30 items, we need a separate query for
total pipeline counts.

Signed-off-by: oppiliappan <[e-mail]>

appview/db/pipeline.go

···
 
 // this is a mega query, but the most useful one:
 // get N pipelines, for each one get the latest status of its N workflows
+//
+// the pipelines table is aliased to `p`
+// the triggers table is aliased to `t`
 func GetPipelineStatuses(e Execer, limit int, filters ...orm.Filter) ([]models.Pipeline, error) {
 	var conditions []string
 	var args []any
 	for _, filter := range filters {
-		filter.Key = "p." + filter.Key // the table is aliased in the query to `p`
 		conditions = append(conditions, filter.Condition())
 		args = append(args, filter.Arg()...)
 	}
···
 
 	return all, nil
 }
+
+// the pipelines table is aliased to `p`
+// the triggers table is aliased to `t`
+func GetTotalPipelineStatuses(e Execer, filters ...orm.Filter) (int64, error) {
+	var conditions []string
+	var args []any
+	for _, filter := range filters {
+		conditions = append(conditions, filter.Condition())
+		args = append(args, filter.Arg()...)
+	}
+
+	whereClause := ""
+	if conditions != nil {
+		whereClause = " where " + strings.Join(conditions, " and ")
+	}
+
+	query := fmt.Sprintf(`
+		select
+			count(1)
+		from
+			pipelines p
+		join
+			triggers t ON p.trigger_id = t.id
+		%s
+	`, whereClause)
+
+	rows, err := e.Query(query, args...)
+	if err != nil {
+		return 0, err
+	}
+	defer rows.Close()
+
+	for rows.Next() {
+		var count int64
+		err := rows.Scan(&count)
+		if err != nil {
+			return 0, err
+		}
+
+		return count, nil
+	}
+
+	// unreachable
+	return 0, nil
+}

appview/pages/pages.go

···
 }
 
 type PipelinesParams struct {
-	LoggedInUser    *oauth.MultiAccountUser
-	RepoInfo        repoinfo.RepoInfo
-	Pipelines       []models.Pipeline
-	Active          string
-	FilteringByPush bool
-	FilteringByPR   bool
+	LoggedInUser *oauth.MultiAccountUser
+	RepoInfo     repoinfo.RepoInfo
+	Pipelines    []models.Pipeline
+	Active       string
+	FilterKind   string
+	Total        int64
 }
 
 func (p *Pages) Pipelines(w io.Writer, params PipelinesParams) error {

appview/pages/templates/repo/pipelines/pipelines.html

···
 {{ end }}
 
 {{ define "repoContent" }}
-  {{ $active := "all" }}
-  {{ if .FilteringByPush }}
-    {{ $active = "push" }}
-  {{ else if .FilteringByPR }}
-    {{ $active = "pr" }}
-  {{ end }}
+  {{ $active := .FilterKind }}
 
   {{ $all :=
      (dict
···
        "Meta" "") }}
   {{ $pr :=
      (dict
-       "Key" "pr"
+       "Key" "pull_request"
        "Value" "pull request"
        "Icon" "git-pull-request"
        "Meta" "") }}
···
 
   <div class="flex justify-between items-center gap-4">
     <div>
-      {{ template "fragments/tabSelector" (dict "Name" "trigger" "Values" $values "Active" $active) }}
+      {{ template "fragments/tabSelector" (dict "Name" "trigger" "Values" $values "Active" .FilterKind) }}
     </div>
     <div class="text-sm text-gray-600 dark:text-gray-400">
-      {{ len .Pipelines }} pipeline run{{ if ne (len .Pipelines) 1 }}s{{ end }}
+      {{ .Total }} pipeline run{{ if ne .Total 1 }}s{{ end }}
     </div>
   </div>
 {{ end }}
···
     {{ end }}
   </div>
 {{ else }}
-  <div class="mt-2 py-12 flex flex-col items-center justify-center gap-6 text-center border border-gray-200 dark:border-gray-700 rounded bg-gray-50 dark:bg-gray-900">
+  <div class="mt-2 py-12 flex flex-col items-center justify-center gap-6 text-center border border-gray-200 dark:border-gray-700 rounded bg-white dark:bg-gray-800">
     <div class="flex justify-center">
       {{ i "package" "size-16 text-gray-300 dark:text-gray-700" }}
     </div>

appview/pipelines/pipelines.go

···
 		return
 	}
 
+	filterKind := r.URL.Query().Get("trigger")
+	filters := []orm.Filter{
+		orm.FilterEq("p.repo_owner", f.Did),
+		orm.FilterEq("p.repo_name", f.Name),
+		orm.FilterEq("p.knot", f.Knot),
+	}
+	switch filterKind {
+	case "push":
+		filters = append(filters, orm.FilterEq("t.kind", "push"))
+	case "pull_request":
+		filters = append(filters, orm.FilterEq("t.kind", "pull_request"))
+	default:
+		// no filters otherwise, default to "all"
+		filterKind = "all"
+	}
+
 	ps, err := db.GetPipelineStatuses(
 		p.db,
 		30,
-		orm.FilterEq("repo_owner", f.Did),
-		orm.FilterEq("repo_name", f.Name),
-		orm.FilterEq("knot", f.Knot),
+		filters...,
 	)
 	if err != nil {
 		l.Error("failed to query db", "err", err)
 		return
 	}
 
-	// Filter by trigger
-	filterTrigger := r.URL.Query().Get("trigger")
-	var filtered []models.Pipeline
-	for _, pipeline := range ps {
-		if filterTrigger == "push" && pipeline.Trigger != nil && pipeline.Trigger.IsPush() {
-			filtered = append(filtered, pipeline)
-		} else if filterTrigger == "pr" && pipeline.Trigger != nil && pipeline.Trigger.IsPullRequest() {
-			filtered = append(filtered, pipeline)
-		} else if filterTrigger == "" || filterTrigger == "all" {
-			filtered = append(filtered, pipeline)
-		}
+	total, err := db.GetTotalPipelineStatuses(p.db, filters...)
+	if err != nil {
+		l.Error("failed to query db", "err", err)
+		return
 	}
 
-	filteringByPush := filterTrigger == "push"
-	filteringByPR := filterTrigger == "pr"
-
 	p.pages.Pipelines(w, pages.PipelinesParams{
-		LoggedInUser:    user,
-		RepoInfo:        p.repoResolver.GetRepoInfo(r, user),
-		Pipelines:       filtered,
-		FilteringByPush: filteringByPush,
-		FilteringByPR:   filteringByPR,
+		LoggedInUser: user,
+		RepoInfo:     p.repoResolver.GetRepoInfo(r, user),
+		Pipelines:    ps,
+		FilterKind:   filterKind,
+		Total:        total,
 	})
 }
 
···
 	ps, err := db.GetPipelineStatuses(
 		p.db,
 		1,
-		orm.FilterEq("repo_owner", f.Did),
-		orm.FilterEq("repo_name", f.Name),
-		orm.FilterEq("knot", f.Knot),
-		orm.FilterEq("id", pipelineId),
+		orm.FilterEq("p.repo_owner", f.Did),
+		orm.FilterEq("p.repo_name", f.Name),
+		orm.FilterEq("p.knot", f.Knot),
+		orm.FilterEq("p.id", pipelineId),
 	)
 	if err != nil {
 		l.Error("failed to query db", "err", err)
···
 	ps, err := db.GetPipelineStatuses(
 		p.db,
 		1,
-		orm.FilterEq("repo_owner", f.Did),
-		orm.FilterEq("repo_name", f.Name),
-		orm.FilterEq("knot", f.Knot),
-		orm.FilterEq("id", pipelineId),
+		orm.FilterEq("p.repo_owner", f.Did),
+		orm.FilterEq("p.repo_name", f.Name),
+		orm.FilterEq("p.knot", f.Knot),
+		orm.FilterEq("p.id", pipelineId),
 	)
 	if err != nil || len(ps) != 1 {
 		l.Error("pipeline query failed", "err", err, "count", len(ps))
···
 		ps, err := db.GetPipelineStatuses(
 			p.db,
 			1,
-			orm.FilterEq("repo_owner", f.Did),
-			orm.FilterEq("repo_name", f.Name),
-			orm.FilterEq("knot", f.Knot),
-			orm.FilterEq("id", pipelineId),
+			orm.FilterEq("p.repo_owner", f.Did),
+			orm.FilterEq("p.repo_name", f.Name),
+			orm.FilterEq("p.knot", f.Knot),
+			orm.FilterEq("p.id", pipelineId),
 		)
 		if err != nil {
 			return models.Pipeline{}, err

appview/pulls/pulls.go

···
 	ps, err := db.GetPipelineStatuses(
 		s.db,
 		len(shas),
-		orm.FilterEq("repo_owner", f.Did),
-		orm.FilterEq("repo_name", f.Name),
-		orm.FilterEq("knot", f.Knot),
-		orm.FilterIn("sha", shas),
+		orm.FilterEq("p.repo_owner", f.Did),
+		orm.FilterEq("p.repo_name", f.Name),
+		orm.FilterEq("p.knot", f.Knot),
+		orm.FilterIn("p.sha", shas),
 	)
 	if err != nil {
 		log.Printf("failed to fetch pipeline statuses: %s", err)
···
 	ps, err := db.GetPipelineStatuses(
 		s.db,
 		len(shas),
-		orm.FilterEq("repo_owner", f.Did),
-		orm.FilterEq("repo_name", f.Name),
-		orm.FilterEq("knot", f.Knot),
-		orm.FilterIn("sha", shas),
+		orm.FilterEq("p.repo_owner", f.Did),
+		orm.FilterEq("p.repo_name", f.Name),
+		orm.FilterEq("p.knot", f.Knot),
+		orm.FilterIn("p.sha", shas),
 	)
 	if err != nil {
 		log.Printf("failed to fetch pipeline statuses: %s", err)

appview/repo/repo_util.go

···
 	ps, err := db.GetPipelineStatuses(
 		d,
 		len(shas),
-		orm.FilterEq("repo_owner", repo.Did),
-		orm.FilterEq("repo_name", repo.Name),
-		orm.FilterEq("knot", repo.Knot),
-		orm.FilterIn("sha", shas),
+		orm.FilterEq("p.repo_owner", repo.Did),
+		orm.FilterEq("p.repo_name", repo.Name),
+		orm.FilterEq("p.knot", repo.Knot),
+		orm.FilterIn("p.sha", shas),
 	)
 	if err != nil {
 		return nil, err