appview: apply gopls lints

- remove returns at end of function
- replace loop with copy

Signed-off-by: oppiliappan <[e-mail]>

appview/knots/knots.go

···
 	}
 
 	w.Write([]byte(strings.Join(memberDids, "\n")))
-	return
 }
 
 // add member to domain, requires auth and requires invite access

appview/pulls/pulls.go

···
 		FilteringBy:  state,
 		Stacks:       stacks,
 	})
-	return
 }
 
 func (s *Pulls) PullComment(w http.ResponseWriter, r *http.Request) {
···
 	}
 
 	s.pages.HxLocation(w, fmt.Sprintf("/%s/pulls/%d", f.OwnerSlashRepo(), pull.PullId))
-	return
 }
 
 func (s *Pulls) resubmitStackedPullHelper(
···
 	}
 
 	s.pages.HxLocation(w, fmt.Sprintf("/%s/pulls/%d", f.OwnerSlashRepo(), pull.PullId))
-	return
 }
 
 func (s *Pulls) MergePull(w http.ResponseWriter, r *http.Request) {
···
 	}
 
 	s.pages.HxLocation(w, fmt.Sprintf("/%s/pulls/%d", f.OwnerSlashRepo(), pull.PullId))
-	return
 }
 
 func (s *Pulls) ReopenPull(w http.ResponseWriter, r *http.Request) {
···
 	}
 
 	s.pages.HxLocation(w, fmt.Sprintf("/%s/pulls/%d", f.OwnerSlashRepo(), pull.PullId))
-	return
 }
 
 func newStack(f *reporesolver.ResolvedRepo, user *oauth.User, targetBranch, patch string, pullSource *db.PullSource, stackId string) (db.Stack, error) {

appview/repo/repo.go

···
 	rp.pages.EditRepoDescriptionFragment(w, pages.RepoDescriptionParams{
 		RepoInfo: f.RepoInfo(user),
 	})
-	return
 }
 
 func (rp *Repo) RepoDescription(w http.ResponseWriter, r *http.Request) {
···
 		ArtifactMap:       artifactMap,
 		DanglingArtifacts: danglingArtifacts,
 	})
-	return
 }
 
 func (rp *Repo) RepoBranches(w http.ResponseWriter, r *http.Request) {
···
 		ShowRendered:     showRendered,
 		RenderToggle:     renderToggle,
 	})
-	return
 }
 
 func (rp *Repo) RepoBlobRaw(w http.ResponseWriter, r *http.Request) {
···
 
 	w.Header().Set("Content-Type", "text/plain; charset=utf-8")
 	w.Write([]byte(result.Contents))
-	return
 }
 
 // modify the spindle configured for this repo

appview/spindles/spindles.go

···
 	}
 
 	identsToResolve := make([]string, len(members))
-	for i, member := range members {
-		identsToResolve[i] = member
-	}
+	copy(identsToResolve, members)
 	resolvedIds := s.IdResolver.ResolveIdents(r.Context(), identsToResolve)
 	didHandleMap := make(map[string]string)
 	for _, identity := range resolvedIds {
···
 
 	// ok
 	s.Pages.HxRefresh(w)
-	return
 }
 
 func (s *Spindles) delete(w http.ResponseWriter, r *http.Request) {
···
 
 	// ok
 	s.Pages.HxRefresh(w)
-	return
 }

appview/state/profile.go

···
 	}
 
 	s.updateProfile(profile, w, r)
-	return
 }
 
 func (s *State) UpdateProfilePins(w http.ResponseWriter, r *http.Request) {
···
 	profile.PinnedRepos = pinnedRepos
 
 	s.updateProfile(profile, w, r)
-	return
 }
 
 func (s *State) updateProfile(profile *db.Profile, w http.ResponseWriter, r *http.Request) {
···
 	s.notifier.UpdateProfile(r.Context(), profile)
 
 	s.pages.HxRedirect(w, "/"+user.Did)
-	return
 }
 
 func (s *State) EditBioFragment(w http.ResponseWriter, r *http.Request) {