types: rework NiceTree to use go-git filemodes

we can now differentiate between regular directories and submodules in
filetree walkers. this fixes things like broken commit info and language
detection in submodules.

Signed-off-by: oppiliappan <[e-mail]>

appview/repo/index.go

···
 	if treeResp != nil && treeResp.Files != nil {
 		for _, file := range treeResp.Files {
 			niceFile := types.NiceTree{
-				IsFile:    file.Is_file,
-				IsSubtree: file.Is_subtree,
-				Name:      file.Name,
-				Mode:      file.Mode,
-				Size:      file.Size,
+				Name: file.Name,
+				Mode: file.Mode,
+				Size: file.Size,
 			}
+
 			if file.Last_commit != nil {
 				when, _ := time.Parse(time.RFC3339, file.Last_commit.When)
 				niceFile.LastCommit = &types.LastCommitInfo{

appview/repo/repo_util.go

···
 
 func sortFiles(files []types.NiceTree) {
 	sort.Slice(files, func(i, j int) bool {
-		iIsFile := files[i].IsFile
-		jIsFile := files[j].IsFile
+		iIsFile := files[i].IsFile()
+		jIsFile := files[j].IsFile()
 		if iIsFile != jIsFile {
 			return !iIsFile
 		}

appview/repo/tree.go

···
 	files := make([]types.NiceTree, len(xrpcResp.Files))
 	for i, xrpcFile := range xrpcResp.Files {
 		file := types.NiceTree{
-			Name:      xrpcFile.Name,
-			Mode:      xrpcFile.Mode,
-			Size:      int64(xrpcFile.Size),
-			IsFile:    xrpcFile.Is_file,
-			IsSubtree: xrpcFile.Is_subtree,
+			Name: xrpcFile.Name,
+			Mode: xrpcFile.Mode,
+			Size: int64(xrpcFile.Size),
 		}
 		// Convert last commit info if present
 		if xrpcFile.Last_commit != nil {
···
 		}
 	}
 	sortFiles(result.Files)
+
 	rp.pages.RepoTree(w, pages.RepoTreeParams{
 		LoggedInUser:     user,
 		BreadCrumbs:      breadcrumbs,

knotserver/git/tree.go

···
 	"path"
 	"time"
 
+	"github.com/go-git/go-git/v5/plumbing/filemode"
 	"github.com/go-git/go-git/v5/plumbing/object"
 	"tangled.org/core/types"
 )
···
 	}
 
 	for _, e := range subtree.Entries {
-		mode, _ := e.Mode.ToOSFileMode()
 		sz, _ := subtree.Size(e.Name)
-
 		fpath := path.Join(parent, e.Name)
 
 		var lastCommit *types.LastCommitInfo
···
 
 		nts = append(nts, types.NiceTree{
 			Name:       e.Name,
-			Mode:       mode.String(),
-			IsFile:     e.Mode.IsFile(),
+			Mode:       e.Mode.String(),
 			Size:       sz,
 			LastCommit: lastCommit,
 		})
···
 		default:
 		}
 
-		mode, err := e.Mode.ToOSFileMode()
-		if err != nil {
-			// TODO: log this
-			continue
-		}
-
 		if e.Mode.IsFile() {
-			err = cb(e, currentTree, root)
-			if errors.Is(err, TerminateWalk) {
+			if err := cb(e, currentTree, root); errors.Is(err, TerminateWalk) {
 				return err
 			}
 		}
 
 		// e is a directory
-		if mode.IsDir() {
+		if e.Mode == filemode.Dir {
 			subtree, err := currentTree.Tree(e.Name)
 			if err != nil {
 				return fmt.Errorf("sub tree %s: %w", e.Name, err)

knotserver/ingester.go

···
 
 	var pipeline workflow.RawPipeline
 	for _, e := range workflowDir {
-		if !e.IsFile {
+		if !e.IsFile() {
 			continue
 		}
 

knotserver/internal.go

···
 
 	var pipeline workflow.RawPipeline
 	for _, e := range workflowDir {
-		if !e.IsFile {
+		if !e.IsFile() {
 			continue
 		}
 

knotserver/xrpc/repo_tree.go

···
 	treeEntries := make([]*tangled.RepoTree_TreeEntry, len(files))
 	for i, file := range files {
 		entry := &tangled.RepoTree_TreeEntry{
-			Name:       file.Name,
-			Mode:       file.Mode,
-			Size:       file.Size,
-			Is_file:    file.IsFile,
-			Is_subtree: file.IsSubtree,
+			Name: file.Name,
+			Mode: file.Mode,
+			Size: file.Size,
 		}
 
 		if file.LastCommit != nil {

types/tree.go

···
 	"time"
 
 	"github.com/go-git/go-git/v5/plumbing"
+	"github.com/go-git/go-git/v5/plumbing/filemode"
 )
 
 // A nicer git tree representation.
 type NiceTree struct {
 	// Relative path
-	Name      string `json:"name"`
-	Mode      string `json:"mode"`
-	Size      int64  `json:"size"`
-	IsFile    bool   `json:"is_file"`
-	IsSubtree bool   `json:"is_subtree"`
+	Name string `json:"name"`
+	Mode string `json:"mode"`
+	Size int64  `json:"size"`
 
 	LastCommit *LastCommitInfo `json:"last_commit,omitempty"`
+}
+
+func (t *NiceTree) FileMode() (filemode.FileMode, error) {
+	return filemode.New(t.Mode)
+}
+
+func (t *NiceTree) IsFile() bool {
+	m, err := t.FileMode()
+
+	if err != nil {
+		return false
+	}
+
+	return m.IsFile()
+}
+
+func (t *NiceTree) IsSubmodule() bool {
+	m, err := t.FileMode()
+
+	if err != nil {
+		return false
+	}
+
+	return m == filemode.Submodule
 }
 
 type LastCommitInfo struct {