playback: cleanup from code review

pkg/e2etest/e2etest.go

···
-package e2etest

pkg/media/webrtc_playback.go

···
 	ctx, cancel := context.WithCancel(ctx) //nolint:all
 
 	pipelineSlice := []string{
-		"h264parse name=videoparse ! video/x-h264,stream-format=byte-stream ! appsink sync=false name=videoappsink",
-		"opusparse name=audioparse ! appsink sync=false name=audioappsink",
+		"h264parse name=videoparse ! video/x-h264,stream-format=byte-stream ! appsink name=videoappsink",
+		"opusparse name=audioparse ! appsink name=audioappsink",
 	}
 
 	pipeline, err := gst.NewPipelineFromString(strings.Join(pipelineSlice, "\n"))
···
 		}
 	}()
 
-	started := time.Now()
-	elapsed := time.Duration(0)
-
-	go func() {
-		for {
-			select {
-			case <-ctx.Done():
-				return
-			case <-time.After(time.Second * 5):
-				log.Log(ctx, "check elapsed", "elapsed", elapsed, "duration", time.Since(started))
-			}
-		}
-	}()
-
 	var lastVideoDuration = &DefaultDuration
 
 	go func() {
···
 				if dur != nil {
 					mediaSample.Duration = *dur
 					lastVideoDuration = dur
-					elapsed += *dur
 				} else if lastVideoDuration != nil {
 					// log.Log(ctx, "no video duration, using last duration", "lastVideoDuration", lastVideoDuration)
 					mediaSample.Duration = *lastVideoDuration

pkg/media/webrtc_playback2.go

···
 	"stream.place/streamplace/pkg/spmetrics"
 )
 
-// we have a bug that prevents us from correctly probing video durations
-// a lot of the time. so when we don't have them we use the last duration
-// that we had, and when we don't have that we use a default duration
-var DefaultDuration2 = time.Duration(32 * time.Millisecond)
-
 // This function remains in scope for the duration of a single users' playback
 func (mm *MediaManager) WebRTCPlayback2(ctx context.Context, user string, rendition string, offer *webrtc.SessionDescription) (*webrtc.SessionDescription, error) {
 	uu, err := uuid.NewV7()