fix: updating dagcbor validation function

crates/atproto-attestation/src/cid.rs

···
     create_dagbor_cid(&record_obj)
 }
 
-/// Validates that a CID string conforms to AT Protocol attestation requirements.
+/// Validates that a CID string is a valid DAG-CBOR CID for AT Protocol attestations.
 ///
 /// This function performs strict validation to ensure the CID meets the exact
 /// specifications required for AT Protocol attestations:
···
 ///
 /// # Returns
 ///
-/// * `true` if the CID meets all AT Protocol requirements
+/// * `true` if the CID is a valid DAG-CBOR CID with SHA-256 hash
 /// * `false` if the CID is invalid or doesn't meet any requirement
 ///
 /// # Examples
 ///
 /// ```rust
-/// use atproto_attestation::cid::validate_cid_format;
+/// use atproto_attestation::cid::validate_dagcbor_cid;
 ///
 /// // Valid AT Protocol CID (CIDv1, DAG-CBOR, SHA-256)
 /// let valid_cid = "bafyreigw5bqvbz6m3c3zjpqhxwl4njlnbbnw5xvptbx6dzfxjqcde6lt3y";
-/// assert!(validate_cid_format(valid_cid));
+/// assert!(validate_dagcbor_cid(valid_cid));
 ///
 /// // Invalid: Empty string
-/// assert!(!validate_cid_format(""));
+/// assert!(!validate_dagcbor_cid(""));
 ///
 /// // Invalid: Not a CID
-/// assert!(!validate_cid_format("not-a-cid"));
+/// assert!(!validate_dagcbor_cid("not-a-cid"));
 ///
 /// // Invalid: CIDv0 (starts with Qm)
 /// let cid_v0 = "QmYwAPJzv5CZsnA625ub3XtLxT3Tz5Lno5Wqv9eKewWKjE";
-/// assert!(!validate_cid_format(cid_v0));
+/// assert!(!validate_dagcbor_cid(cid_v0));
 /// ```
-///
-/// # Use Cases
-///
-/// This function is typically used to:
-/// - Validate CIDs in attestation signatures before verification
-/// - Ensure CIDs in remote attestations match expected format
-/// - Validate user-provided CIDs in API requests
-/// - Verify CIDs generated by external systems conform to AT Protocol standards
-pub fn validate_cid_format(cid: &str) -> bool {
+pub fn validate_dagcbor_cid(cid: &str) -> bool {
     if cid.is_empty() {
         return false
     }
···
     }
 
     #[test]
-    fn test_validate_cid_format() {
+    fn test_validate_dagcbor_cid() {
         // Test valid CID (generated from our own create_dagbor_cid function)
         let valid_data = serde_json::json!({"test": "data"});
         let valid_cid = create_dagbor_cid(&valid_data).unwrap();
         let valid_cid_str = valid_cid.to_string();
-        assert!(validate_cid_format(&valid_cid_str), "Valid CID should pass validation");
+        assert!(validate_dagcbor_cid(&valid_cid_str), "Valid CID should pass validation");
 
         // Test empty string
-        assert!(!validate_cid_format(""), "Empty string should fail validation");
+        assert!(!validate_dagcbor_cid(""), "Empty string should fail validation");
 
         // Test invalid CID string
-        assert!(!validate_cid_format("not-a-cid"), "Invalid string should fail validation");
-        assert!(!validate_cid_format("abc123"), "Invalid string should fail validation");
+        assert!(!validate_dagcbor_cid("not-a-cid"), "Invalid string should fail validation");
+        assert!(!validate_dagcbor_cid("abc123"), "Invalid string should fail validation");
 
         // Test CIDv0 (starts with Qm, uses different format)
         let cid_v0 = "QmYwAPJzv5CZsnA625ub3XtLxT3Tz5Lno5Wqv9eKewWKjE";
-        assert!(!validate_cid_format(cid_v0), "CIDv0 should fail validation");
+        assert!(!validate_dagcbor_cid(cid_v0), "CIDv0 should fail validation");
 
         // Test valid CID base32 format but wrong codec (not DAG-CBOR)
         // This is a valid CID but uses raw codec (0x55) instead of DAG-CBOR (0x71)
         let wrong_codec = "bafkreigw5bqvbz6m3c3zjpqhxwl4njlnbbnw5xvptbx6dzfxjqcde6lt3y";
-        assert!(!validate_cid_format(wrong_codec), "CID with wrong codec should fail");
+        assert!(!validate_dagcbor_cid(wrong_codec), "CID with wrong codec should fail");
 
         // Test that our constants match what we're checking
         assert_eq!(DAG_CBOR_CODEC, 0x71, "DAG-CBOR codec constant should be 0x71");