Change "Primary Domain" to "Primary Namespace" #1

open opened by

tynanpurdy.com 3 months ago targeting main from tynanpurdy.com/slices: main

Settings field for the primary namespace of a slice's lexicon was confusing, referred to both as Domain and Namespace. This made it unclear whether the namespace should be in a forward URL or reversed Namespace format. The example is in reversed namespace so I have updated the label of the field for consistency.

Labels

None yet.

assignee

None yet.

Participants 1

AT URI

at://did:plc:6ayddqghxhciedbaofoxkcbs/sh.tangled.repo.pull/3m23n36itjm22

+2 -2

2 changed files

Diff round #0

expand all

unified split

frontend

src

features

dashboard

templates

fragments

CreateSliceDialog.tsx

slices

settings

templates

SliceSettings.tsx

+1 -1

frontend/src/features/dashboard/templates/fragments/CreateSliceDialog.tsx

··· 48 type="text" 49 id="domain" 50 name="domain" 51 - label="Primary Domain" 52 required 53 defaultValue={domain} 54 placeholder="e.g. social.grain"

··· 48 type="text" 49 id="domain" 50 name="domain" 51 + label="Primary Namespace" 52 required 53 defaultValue={domain} 54 placeholder="e.g. social.grain"

+1 -1

frontend/src/features/slices/settings/templates/SliceSettings.tsx

··· 101 102 <div> 103 <Input 104 - label="Primary Domain" 105 type="text" 106 id="slice-domain" 107 name="domain"

··· 101 102 <div> 103 <Input 104 + label="Primary Namespace" 105 type="text" 106 id="slice-domain" 107 name="domain"

Submissions

tynanpurdy.com submitted #0 3mo

1 commit

expand

71f3a257

change "Primary Domain" to "Primary Namespace"

no conflicts, ready to merge