forked from tangled.org/core
Monorepo for Tangled

address review: avoid loop index

Changed files
+4 -8
appview
+4 -8
appview/db/pulls.go
··· 400 submission_id 401 `, inClause) 402 403 - args = make([]any, len(pulls)) 404 - idx = 0 405 for _, p := range pulls { 406 - args[idx] = p.Submissions[p.LastRoundNumber()].ID 407 - idx += 1 408 } 409 commentsRows, err := e.Query(commentsQuery, args...) 410 if err != nil { ··· 429 return nil, err 430 } 431 432 - orderedByDate := make([]*Pull, len(pulls)) 433 - idx = 0 434 for _, p := range pulls { 435 - orderedByDate[idx] = p 436 - idx += 1 437 } 438 sort.Slice(orderedByDate, func(i, j int) bool { 439 return orderedByDate[i].Created.After(orderedByDate[j].Created)
··· 400 submission_id 401 `, inClause) 402 403 + args = make([]any, 0, len(pulls)) 404 for _, p := range pulls { 405 + args = append(args, p.Submissions[p.LastRoundNumber()].ID) 406 } 407 commentsRows, err := e.Query(commentsQuery, args...) 408 if err != nil { ··· 427 return nil, err 428 } 429 430 + orderedByDate := make([]*Pull, 0, len(pulls)) 431 for _, p := range pulls { 432 + orderedByDate = append(orderedByDate, p) 433 } 434 sort.Slice(orderedByDate, func(i, j int) bool { 435 return orderedByDate[i].Created.After(orderedByDate[j].Created)