@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator

PHP 8.5: DifferentialChangesetTwoUpRenderer: Do not pass null array key

Summary:
See twenty lines below how to do it right.

```
ERROR 8192: Using null as an array offset is deprecated, use an empty string instead at [/var/www/html/phorge/phorge/src/applications/differential/render/DifferentialChangesetTwoUpRenderer.php:261]
```

Closes T16362

Test Plan: Go to a Differential revision like http://phorge.localhost/D1

Reviewers: O1 Blessed Committers, mainframe98

Reviewed By: O1 Blessed Committers, mainframe98

Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T16362

Differential Revision: https://we.phorge.it/D26531

+1 -1
+1 -1
src/applications/differential/render/DifferentialChangesetTwoUpRenderer.php
··· 258 258 } 259 259 } 260 260 261 - if (isset($hunk_starts[$o_num])) { 261 + if ($o_num && isset($hunk_starts[$o_num])) { 262 262 $html[] = $context_not_available; 263 263 } 264 264