@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator

Display Query Errors below the Search form area (instead of above)

Summary:
Move the phui-info-view box about Query Errors below the phui-form-view Search form. That's below the `#R` anchor that the view automatically scrolls to. People do not scroll up again to expect an error message up there so show the error message down here.

Closes T16089

Test Plan: Go to http://phorge.localhost/maniphest/query/advanced/ and enter something in the Query field that will trigger a Query Error, such as `help:now` or a very long string. Press the Search button.

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T16089

Differential Revision: https://we.phorge.it/D26672

+1 -1
+1 -1
src/view/phui/PHUIObjectBoxView.php
··· 309 309 ($this->showHideOpen == false ? $this->anchor : null), 310 310 $header, 311 311 $this->infoView, 312 - $this->formErrors, 313 312 $exception_errors, 314 313 $this->form, 315 314 $this->tabGroups, ··· 318 317 $lists, 319 318 $this->table, 320 319 $pager, 320 + $this->formErrors, 321 321 $this->renderChildren(), 322 322 ); 323 323