@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator

Fix PHP 8.5 null array key in PhutilRemarkupQuotedBlockRule

Summary: Setting null as an array key is deprecated since PHP 8.5 per https://www.php.net/releases/8.5/en.php: "Using null as an array offset or when calling array_key_exists() is now deprecated. Use an empty string instead."

Test Plan: Unknown. Read the code and check where and how $c is used.

Reviewers: O1 Blessed Committers, mainframe98

Reviewed By: O1 Blessed Committers, mainframe98

Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Differential Revision: https://we.phorge.it/D26670

+1 -1
+1 -1
src/infrastructure/markup/blockrule/PhutilRemarkupQuotedBlockRule.php
··· 109 109 if (isset($line[0])) { 110 110 $c = $line[0]; 111 111 } else { 112 - $c = null; 112 + $c = ''; 113 113 } 114 114 115 115 if (isset($no_whitespace[$c])) {