Convert Drydock lease and resource constants to strings

Summary:
Ref T9252. Drydock currently uses integer statuses, but there's no reason for this (they don't need to be ordered) and it makes debugging them, working with them, future APIs, etc., more cumbersome.

Switch to string instead.

Also rename `STATUS_OPEN` to `STATUS_ACTIVE` and `STATUS_CLOSED` to `STATUS_RELEASED` for consistency. This makes resources and leases have more similar states, and gives resource states more accurate names.

Test Plan: Browsed web UI, grepped for changed constants, applied patch, inspected database.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T9252

Differential Revision: https://secure.phabricator.com/D14153

resources/sql/autopatches/20150924.drydock.status.1.sql

···
+ALTER TABLE {$NAMESPACE}_drydock.drydock_lease
+  CHANGE status status VARCHAR(32) NOT NULL COLLATE {$COLLATE_TEXT};
+
+UPDATE {$NAMESPACE}_drydock.drydock_lease
+  SET status = 'pending' WHERE status = '0';
+
+UPDATE {$NAMESPACE}_drydock.drydock_lease
+  SET status = 'acquired' WHERE status = '5';
+
+UPDATE {$NAMESPACE}_drydock.drydock_lease
+  SET status = 'active' WHERE status = '1';
+
+UPDATE {$NAMESPACE}_drydock.drydock_lease
+  SET status = 'released' WHERE status = '2';
+
+UPDATE {$NAMESPACE}_drydock.drydock_lease
+  SET status = 'broken' WHERE status = '3';
+
+UPDATE {$NAMESPACE}_drydock.drydock_lease
+  SET status = 'destroyed' WHERE status = '4';
+
+
+ALTER TABLE {$NAMESPACE}_drydock.drydock_resource
+  CHANGE status status VARCHAR(32) NOT NULL COLLATE {$COLLATE_TEXT};
+
+UPDATE {$NAMESPACE}_drydock.drydock_resource
+  SET status = 'pending' WHERE status = '0';
+
+UPDATE {$NAMESPACE}_drydock.drydock_resource
+  SET status = 'active' WHERE status = '1';
+
+UPDATE {$NAMESPACE}_drydock.drydock_resource
+  SET status = 'released' WHERE status = '2';
+
+UPDATE {$NAMESPACE}_drydock.drydock_resource
+  SET status = 'broken' WHERE status = '3';
+
+UPDATE {$NAMESPACE}_drydock.drydock_resource
+  SET status = 'destroyed' WHERE status = '4';

src/applications/drydock/blueprint/DrydockAlmanacServiceHostBlueprintImplementation.php

···
         ->withStatuses(
           array(
             DrydockResourceStatus::STATUS_PENDING,
-            DrydockResourceStatus::STATUS_OPEN,
-            DrydockResourceStatus::STATUS_CLOSED,
+            DrydockResourceStatus::STATUS_ACTIVE,
+            DrydockResourceStatus::STATUS_RELEASED,
           ))
         ->execute();
 

src/applications/drydock/constants/DrydockLeaseStatus.php

···
 
 final class DrydockLeaseStatus extends DrydockConstants {
 
-  const STATUS_PENDING = 0;
-  const STATUS_ACQUIRED = 5;
-  const STATUS_ACTIVE = 1;
-  const STATUS_RELEASED = 2;
-  const STATUS_BROKEN = 3;
-  const STATUS_DESTROYED = 4;
+  const STATUS_PENDING = 'pending';
+  const STATUS_ACQUIRED = 'acquired';
+  const STATUS_ACTIVE = 'active';
+  const STATUS_RELEASED = 'released';
+  const STATUS_BROKEN = 'broken';
+  const STATUS_DESTROYED = 'destroyed';
 
   public static function getNameForStatus($status) {
     $map = array(

src/applications/drydock/constants/DrydockResourceStatus.php

···
 
 final class DrydockResourceStatus extends DrydockConstants {
 
-  const STATUS_PENDING      = 0;
-  const STATUS_OPEN         = 1;
-  const STATUS_CLOSED       = 2;
-  const STATUS_BROKEN       = 3;
-  const STATUS_DESTROYED    = 4;
+  const STATUS_PENDING = 'pending';
+  const STATUS_ACTIVE = 'active';
+  const STATUS_RELEASED = 'released';
+  const STATUS_BROKEN = 'broken';
+  const STATUS_DESTROYED = 'destroyed';
 
   public static function getNameForStatus($status) {
     $map = array(
-      self::STATUS_PENDING      => pht('Pending'),
-      self::STATUS_OPEN         => pht('Open'),
-      self::STATUS_CLOSED       => pht('Closed'),
-      self::STATUS_BROKEN       => pht('Broken'),
-      self::STATUS_DESTROYED    => pht('Destroyed'),
+      self::STATUS_PENDING => pht('Pending'),
+      self::STATUS_ACTIVE => pht('Active'),
+      self::STATUS_RELEASED => pht('Released'),
+      self::STATUS_BROKEN => pht('Broken'),
+      self::STATUS_DESTROYED => pht('Destroyed'),
     );
 
     return idx($map, $status, pht('Unknown'));
···
   public static function getAllStatuses() {
     return array(
      self::STATUS_PENDING,
-     self::STATUS_OPEN,
-     self::STATUS_CLOSED,
+     self::STATUS_ACTIVE,
+     self::STATUS_RELEASED,
      self::STATUS_BROKEN,
      self::STATUS_DESTROYED,
     );

src/applications/drydock/query/DrydockLeaseQuery.php

···
     if ($this->statuses !== null) {
       $where[] = qsprintf(
         $conn,
-        'status IN (%Ld)',
+        'status IN (%Ls)',
         $this->statuses);
     }
 

src/applications/drydock/query/DrydockResourceSearchEngine.php

···
           'statuses',
           array(
             DrydockResourceStatus::STATUS_PENDING,
-            DrydockResourceStatus::STATUS_OPEN,
+            DrydockResourceStatus::STATUS_ACTIVE,
           ));
       case 'all':
         return $query;

src/applications/drydock/storage/DrydockLease.php

···
         'attributes'    => self::SERIALIZATION_JSON,
       ),
       self::CONFIG_COLUMN_SCHEMA => array(
-        'status' => 'uint32',
+        'status' => 'text32',
         'until' => 'epoch?',
         'resourceType' => 'text128',
         'ownerPHID' => 'phid?',

src/applications/drydock/storage/DrydockResource.php

···
       self::CONFIG_COLUMN_SCHEMA => array(
         'name' => 'text255',
         'ownerPHID' => 'phid?',
-        'status' => 'uint32',
+        'status' => 'text32',
         'type' => 'text64',
       ),
       self::CONFIG_KEY_SCHEMA => array(
-        'key_phid' => null,
-        'phid' => array(
-          'columns' => array('phid'),
-          'unique' => true,
+        'key_type' => array(
+          'columns' => array('type', 'status'),
+        ),
+        'key_blueprint' => array(
+          'columns' => array('blueprintPHID', 'status'),
         ),
       ),
     ) + parent::getConfiguration();
···
     }
 
     if ($this->activateWhenAllocated) {
-      $new_status = DrydockResourceStatus::STATUS_OPEN;
+      $new_status = DrydockResourceStatus::STATUS_ACTIVE;
     } else {
       $new_status = DrydockResourceStatus::STATUS_PENDING;
     }
···
     $this->openTransaction();
 
       $this
-        ->setStatus(DrydockResourceStatus::STATUS_OPEN)
+        ->setStatus(DrydockResourceStatus::STATUS_ACTIVE)
         ->save();
 
       DrydockSlotLock::acquireLocks($this->getPHID(), $this->slotLocks);
···
 
   public function canRelease() {
     switch ($this->getStatus()) {
-      case DrydockResourceStatus::STATUS_CLOSED:
+      case DrydockResourceStatus::STATUS_RELEASED:
       case DrydockResourceStatus::STATUS_DESTROYED:
         return false;
       default:

src/applications/drydock/view/DrydockResourceListView.php

···
         case DrydockResourceStatus::STATUS_PENDING:
           $item->setStatusIcon('fa-dot-circle-o yellow');
           break;
-        case DrydockResourceStatus::STATUS_OPEN:
+        case DrydockResourceStatus::STATUS_ACTIVE:
           $item->setStatusIcon('fa-dot-circle-o green');
           break;
         case DrydockResourceStatus::STATUS_DESTROYED:

src/applications/drydock/worker/DrydockAllocatorWorker.php

···
       ->withStatuses(
         array(
           DrydockResourceStatus::STATUS_PENDING,
-          DrydockResourceStatus::STATUS_OPEN,
+          DrydockResourceStatus::STATUS_ACTIVE,
         ))
       ->execute();
 

src/applications/drydock/worker/DrydockLeaseWorker.php

···
       throw new Exception(pht('Resource still activating.'));
     }
 
-    if ($resource_status != DrydockResourceStatus::STATUS_OPEN) {
+    if ($resource_status != DrydockResourceStatus::STATUS_ACTIVE) {
       throw new PhabricatorWorkerPermanentFailureException(
         pht(
           'Trying to activate lease on a dead resource (in status "%s").',

src/applications/drydock/worker/DrydockResourceDestroyWorker.php

···
     $status = $resource->getStatus();
 
     switch ($status) {
-      case DrydockResourceStatus::STATUS_CLOSED:
+      case DrydockResourceStatus::STATUS_RELEASED:
       case DrydockResourceStatus::STATUS_BROKEN:
         break;
       default:

src/applications/drydock/worker/DrydockResourceUpdateWorker.php

···
   private function updateResource(DrydockResource $resource) {
     $commands = $this->loadCommands($resource->getPHID());
     foreach ($commands as $command) {
-      if ($resource->getStatus() != DrydockResourceStatus::STATUS_OPEN) {
+      if ($resource->getStatus() != DrydockResourceStatus::STATUS_ACTIVE) {
         // Resources can't receive commands before they activate or after they
         // release.
         break;
···
   }
 
   private function releaseResource(DrydockResource $resource) {
-    if ($resource->getStatus() != DrydockResourceStatus::STATUS_OPEN) {
+    if ($resource->getStatus() != DrydockResourceStatus::STATUS_ACTIVE) {
       // If we had multiple release commands
       // This command is only meaningful to resources in the "Open" state.
       return;
···
 
     $resource->openTransaction();
       $resource
-        ->setStatus(DrydockResourceStatus::STATUS_CLOSED)
+        ->setStatus(DrydockResourceStatus::STATUS_RELEASED)
         ->save();
 
       // TODO: Hold slot locks until destruction?