DarkConsole: Fix "strlen(null)" but for the "tab" query parameter

@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge

phorge phabricator

fork atom

Summary:
See rPf4d2811

Bug: T15344

Test Plan: Opened DarkConsole with /~/, saw no errors in DarkConsole

Reviewers: O1 Blessed Committers, aklapper

Reviewed By: O1 Blessed Committers, aklapper

Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Differential Revision: https://we.phorge.it/D25834

mainframe98 1 year ago ddf26e89 74bf6c0e

+1 -1

1 changed file

expand all

src

applications

console

controller

DarkConsoleController.php

+1 -1

src/applications/console/controller/DarkConsoleController.php

··· 35 35 } 36 36 37 37 $tab = $request->getStr('tab'); 38 - if (strlen($tab)) { 38 + if (phutil_nonempty_string($tab)) { 39 39 $this->writeDarkConsoleSetting( 40 40 PhabricatorDarkConsoleTabSetting::SETTINGKEY, 41 41 $tab);