@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator

Config: Fix inconsistent Database panel name

Summary:
Do not use two different names for the same panel: "Database Schemata" versus "Database Status".

Navigation still works because `PhabricatorConfigDatabaseStatusController::buildResponse()` sets `$nav = $this->newNavigation('schemata')` and `PhabricatorConfigServicesController::newNavigation()` also sets `$nav->newLink('schemata')`.

Test Plan:
1. Go to http://phorge.localhost/config/database/
2. See that the selected item in the sidebar says "Database Schemata" while the panel title is "Database Status"
3. Apply the patch
4. Repeat step 2
5. After applying D26266, read the Diviner docs in http://phorge.localhost/book/phorge/article/storage_adjust/ which make more sense now

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Differential Revision: https://we.phorge.it/D26268

+1 -1
+1 -1
src/applications/config/controller/services/PhabricatorConfigServicesController.php
··· 17 17 ->setHref(urisprintf('%s%s/', $services_uri, 'cluster/databases')); 18 18 19 19 $nav->newLink('schemata') 20 - ->setName(pht('Database Schemata')) 20 + ->setName(pht('Database Status')) 21 21 ->setIcon('fa-table') 22 22 ->setHref(urisprintf('%s%s/', $services_uri, 'database')); 23 23