Remove some conditions which are always true/false

Summary:
Remove code around some conditions which are always true/false anyway.

Same game as rP1b9fafc7af72.

Test Plan: Read earlier code in each file; run static code analysis.

Reviewers: O1 Blessed Committers, mainframe98

Reviewed By: O1 Blessed Committers, mainframe98

Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Differential Revision: https://we.phorge.it/D26760

src/applications/auth/provider/PhabricatorLDAPAuthProvider.php

···
 
     if ($request->isFormPost()) {
       try {
-        if (phutil_nonempty_string($username) && $has_password) {
-          $adapter = $this->getAdapter();
-          $adapter->setLoginUsername($username);
-          $adapter->setLoginPassword($password);
+        $adapter = $this->getAdapter();
+        $adapter->setLoginUsername($username);
+        $adapter->setLoginPassword($password);
 
-          // TODO: This calls ldap_bind() eventually, which dumps cleartext
-          // passwords to the error log. See note in PhutilLDAPAuthAdapter.
-          // See T3351.
+        // TODO: This calls ldap_bind() eventually, which dumps cleartext
+        // passwords to the error log. See note in PhutilLDAPAuthAdapter.
+        // See T3351.
 
-          DarkConsoleErrorLogPluginAPI::enableDiscardMode();
-            $identifiers = $adapter->getAccountIdentifiers();
-          DarkConsoleErrorLogPluginAPI::disableDiscardMode();
-        } else {
-          throw new Exception(pht('Username and password are required!'));
-        }
+        DarkConsoleErrorLogPluginAPI::enableDiscardMode();
+          $identifiers = $adapter->getAccountIdentifiers();
+        DarkConsoleErrorLogPluginAPI::disableDiscardMode();
       } catch (PhutilAuthCredentialException $ex) {
         $response = $controller->buildProviderPageResponse(
           $this,

src/applications/fact/controller/PhabricatorFactObjectController.php

···
           continue;
         }
 
-        if (!$has_any) {
-          $rows[] = array(
-            $icon_nodata,
-            $fact->getName(),
-            null,
-            null,
-            null,
-          );
-        }
+        $rows[] = array(
+          $icon_nodata,
+          $fact->getName(),
+          null,
+          null,
+          null,
+        );
       }
 
       $table = id(new AphrontTableView($rows))

src/applications/maniphest/conduit/ManiphestConduitAPIMethod.php

···
     } else {
 
       $comments = $request->getValue('comments');
-      if (!$is_new && $comments !== null) {
+      if ($comments !== null) {
         $changes[PhabricatorTransactions::TYPE_COMMENT] = null;
       }
 

src/applications/repository/management/PhabricatorRepositoryManagementReparseWorkflow.php

···
       // OK.
     } else if ($importing) {
       // OK.
-    } else if (!$any_step && !$importing) {
+    } else {
       throw new PhutilArgumentUsageException(
         pht(
           'Specify which steps to reparse with "--message", "--change", '.

src/view/control/AphrontTableView.php

···
           if ($sort_value == $this->sortSelected) {
             if ($this->sortReverse) {
               $sort_glyph_class = 'aphront-table-up-sort';
-            } else if (!$this->sortReverse) {
+            } else {
               $sort_value = '-'.$sort_value;
             }
             $classes[] = 'aphront-table-view-sortable-selected';

src/view/phui/PHUITimelineEventView.php

···
           ));
 
       if (!$is_admin && !$can_interact) {
-        $remove_item->setDisabled(!$is_admin && !$can_interact);
+        $remove_item->setDisabled(true);
       } else {
         $remove_item->setColor(PhabricatorActionView::RED);
       }

support/startup/PhabricatorStartup.php

···
     }
 
     $msg = ">>> UNRECOVERABLE FATAL ERROR <<<\n\n";
-    if ($event) {
-      // Even though we should be emitting this as text-plain, escape things
-      // just to be sure since we can't really be sure what the program state
-      // is when we get here.
-      $msg .= htmlspecialchars(
-        $event['message']."\n\n".$event['file'].':'.$event['line'],
-        ENT_QUOTES,
-        'UTF-8');
-    }
+    // Even though we should be emitting this as text-plain, escape things
+    // just to be sure since we can't really be sure what the program state
+    // is when we get here.
+    $msg .= htmlspecialchars(
+      $event['message']."\n\n".$event['file'].':'.$event['line'],
+      ENT_QUOTES,
+      'UTF-8');
 
     // flip dem tables
     $msg .= "\n\n\n";