PHP 8.5: Remove deprecated non-canonical scalar type casts

Summary:
PHP 8.5 deprecates non-canonical scalar type casts.
See https://wiki.php.net/rfc/deprecations_php_8_5#deprecate_non-standard_cast_names and https://wiki.php.net/rfc/deprecations_php_8_5

Closes T16317

Test Plan: In theory, run `./bin/arc unit --everything` (which fails with at least three known issues for me, sigh)

Reviewers: O1 Blessed Committers, mainframe98

Reviewed By: O1 Blessed Committers, mainframe98

Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T16317

Differential Revision: https://we.phorge.it/D26444

src/applications/conduit/parametertype/ConduitPointsParameterType.php

···
     }
 
     if ($value !== null) {
-      $value = (double)$value;
+      $value = (float)$value;
       if ($value < 0) {
         $this->raiseValidationException(
           $request,

src/applications/differential/controller/DifferentialController.php

···
     // Cast duration to a float since it used to be a string in some
     // cases.
     if (isset($map['duration'])) {
-      $map['duration'] = (double)$map['duration'];
+      $map['duration'] = (float)$map['duration'];
     }
 
     return $map;

src/applications/fact/chart/PhabricatorChartFunction.php

···
 
     $is_reversed = ($src > $dst);
     if ($is_reversed) {
-      $min = (double)$dst;
-      $max = (double)$src;
+      $min = (float)$dst;
+      $max = (float)$src;
     } else {
-      $min = (double)$src;
-      $max = (double)$dst;
+      $min = (float)$src;
+      $max = (float)$dst;
     }
 
-    $step = (double)($max - $min) / (double)($count - 1);
+    $step = (float)($max - $min) / (float)($count - 1);
 
     $steps = array();
     for ($cursor = $min; $cursor <= $max; $cursor += $step) {

src/applications/maniphest/xaction/ManiphestTaskPointsTransaction.php

···
         continue;
       }
 
-      if ((double)$new < 0) {
+      if ((float)$new < 0) {
         $errors[] = $this->newInvalidError(
           pht('Points value must be nonnegative.'));
         continue;
···
       $value = null;
     }
     if ($value !== null) {
-      $value = (double)$value;
+      $value = (float)$value;
     }
     return $value;
   }

src/applications/project/engine/PhabricatorBoardResponseEngine.php

···
 
   public static function newTaskProperties($task) {
     return array(
-      'points' => (double)$task->getPoints(),
+      'points' => (float)$task->getPoints(),
       'status' => $task->getStatus(),
       'priority' => (int)$task->getPriority(),
       'owner' => $task->getOwnerPHID(),

src/applications/project/order/PhabricatorProjectColumnPointsOrder.php

···
 
     return array(
       $overall_order,
-      -1.0 * (double)$points,
+      -1.0 * (float)$points,
       -1 * (int)$object->getID(),
     );
   }

src/applications/search/management/PhabricatorSearchManagementNgramsWorkflow.php

···
           pht('Specify a numeric threshold between 0 and 1.'));
       }
 
-      $threshold = (double)$threshold;
+      $threshold = (float)$threshold;
       if ($threshold <= 0 || $threshold >= 1) {
         throw new PhutilArgumentUsageException(
           pht('Threshold must be greater than 0.0 and less than 1.0.'));

src/infrastructure/export/field/PhabricatorDoubleExportField.php

···
       return $value;
     }
 
-    return (double)$value;
+    return (float)$value;
   }
 
   /**

src/infrastructure/markup/markuprule/PhutilRemarkupHexColorCodeRule.php

···
     list($r, $g, $b) = array_map('hexdec', $colors_hex);
     // Calculation adapted from Myndex, CC BY-SA 4.0
     // https://stackoverflow.com/a/69869976
-    $y = pow((double)$r / 255.0, 2.2) * 0.2126 +
-      pow((double)$g / 255.0, 2.2) * 0.7152 +
-      pow((double)$b / 255.0, 2.2) * 0.0722;
+    $y = pow((float)$r / 255.0, 2.2) * 0.2126 +
+      pow((float)$g / 255.0, 2.2) * 0.7152 +
+      pow((float)$b / 255.0, 2.2) * 0.0722;
 
     return ($y < 0.34) ? 'white' : 'black';
   }