Remove "metamta.*.subject-prefix" options

Summary:
In ~2012, the first of these options was added because someone who hates dogs and works at Asana also hated `[Differential]` in the subject line. The use case there was actually //removing// the text, not changing it, but I made the prefix editable since it seemed like slightly less of a one-off.

These options are among the dumbest and most useless config options we have and very rarely used, see T11760. A very small number of instances have configured one of these options.

Newer applications stopped providing these options and no one has complained.

You can get the same effect with `translation.override`. Although I'm not sure we'll keep that around forever, it's a reasonable replacement today. I'll call out an example in the changelog to help installs that want to preserve this option.

If we did want to provide this, it should just be in {nav Applications > Settings} for each application, but I think it's wildly-low-value and "hack via translations" or "local patch" are entirely reasonable if you really want to change these strings.

Test Plan: Grepped for `subject-prefix`.

Reviewers: amckinley

Reviewed By: amckinley

Differential Revision: https://secure.phabricator.com/D19993

src/__phutil_library_map__.php

···
     'ConduitWildParameterType' => 'applications/conduit/parametertype/ConduitWildParameterType.php',
     'ConpherenceColumnViewController' => 'applications/conpherence/controller/ConpherenceColumnViewController.php',
     'ConpherenceConduitAPIMethod' => 'applications/conpherence/conduit/ConpherenceConduitAPIMethod.php',
-    'ConpherenceConfigOptions' => 'applications/conpherence/config/ConpherenceConfigOptions.php',
     'ConpherenceConstants' => 'applications/conpherence/constants/ConpherenceConstants.php',
     'ConpherenceController' => 'applications/conpherence/controller/ConpherenceController.php',
     'ConpherenceCreateThreadConduitAPIMethod' => 'applications/conpherence/conduit/ConpherenceCreateThreadConduitAPIMethod.php',
···
     'PhabricatorLDAPAuthProvider' => 'applications/auth/provider/PhabricatorLDAPAuthProvider.php',
     'PhabricatorLabelProfileMenuItem' => 'applications/search/menuitem/PhabricatorLabelProfileMenuItem.php',
     'PhabricatorLegalpadApplication' => 'applications/legalpad/application/PhabricatorLegalpadApplication.php',
-    'PhabricatorLegalpadConfigOptions' => 'applications/legalpad/config/PhabricatorLegalpadConfigOptions.php',
     'PhabricatorLegalpadDocumentPHIDType' => 'applications/legalpad/phid/PhabricatorLegalpadDocumentPHIDType.php',
     'PhabricatorLegalpadSignaturePolicyRule' => 'applications/legalpad/policyrule/PhabricatorLegalpadSignaturePolicyRule.php',
     'PhabricatorLibraryTestCase' => '__tests__/PhabricatorLibraryTestCase.php',
···
     'PhabricatorMacroAudioBehaviorTransaction' => 'applications/macro/xaction/PhabricatorMacroAudioBehaviorTransaction.php',
     'PhabricatorMacroAudioController' => 'applications/macro/controller/PhabricatorMacroAudioController.php',
     'PhabricatorMacroAudioTransaction' => 'applications/macro/xaction/PhabricatorMacroAudioTransaction.php',
-    'PhabricatorMacroConfigOptions' => 'applications/macro/config/PhabricatorMacroConfigOptions.php',
     'PhabricatorMacroController' => 'applications/macro/controller/PhabricatorMacroController.php',
     'PhabricatorMacroDatasource' => 'applications/macro/typeahead/PhabricatorMacroDatasource.php',
     'PhabricatorMacroDisableController' => 'applications/macro/controller/PhabricatorMacroDisableController.php',
···
     'PhabricatorPaste' => 'applications/paste/storage/PhabricatorPaste.php',
     'PhabricatorPasteApplication' => 'applications/paste/application/PhabricatorPasteApplication.php',
     'PhabricatorPasteArchiveController' => 'applications/paste/controller/PhabricatorPasteArchiveController.php',
-    'PhabricatorPasteConfigOptions' => 'applications/paste/config/PhabricatorPasteConfigOptions.php',
     'PhabricatorPasteContentSearchEngineAttachment' => 'applications/paste/engineextension/PhabricatorPasteContentSearchEngineAttachment.php',
     'PhabricatorPasteContentTransaction' => 'applications/paste/xaction/PhabricatorPasteContentTransaction.php',
     'PhabricatorPasteController' => 'applications/paste/controller/PhabricatorPasteController.php',
···
     'PhabricatorPhamePostPHIDType' => 'applications/phame/phid/PhabricatorPhamePostPHIDType.php',
     'PhabricatorPhluxApplication' => 'applications/phlux/application/PhabricatorPhluxApplication.php',
     'PhabricatorPholioApplication' => 'applications/pholio/application/PhabricatorPholioApplication.php',
-    'PhabricatorPholioConfigOptions' => 'applications/pholio/config/PhabricatorPholioConfigOptions.php',
     'PhabricatorPholioMockTestDataGenerator' => 'applications/pholio/lipsum/PhabricatorPholioMockTestDataGenerator.php',
     'PhabricatorPhoneNumber' => 'applications/metamta/message/PhabricatorPhoneNumber.php',
     'PhabricatorPhortuneApplication' => 'applications/phortune/application/PhabricatorPhortuneApplication.php',
···
     'PhabricatorPhragmentApplication' => 'applications/phragment/application/PhabricatorPhragmentApplication.php',
     'PhabricatorPhrequentApplication' => 'applications/phrequent/application/PhabricatorPhrequentApplication.php',
     'PhabricatorPhrictionApplication' => 'applications/phriction/application/PhabricatorPhrictionApplication.php',
-    'PhabricatorPhrictionConfigOptions' => 'applications/phriction/config/PhabricatorPhrictionConfigOptions.php',
     'PhabricatorPhurlApplication' => 'applications/phurl/application/PhabricatorPhurlApplication.php',
     'PhabricatorPhurlConfigOptions' => 'applications/config/option/PhabricatorPhurlConfigOptions.php',
     'PhabricatorPhurlController' => 'applications/phurl/controller/PhabricatorPhurlController.php',
···
     'ConduitWildParameterType' => 'ConduitParameterType',
     'ConpherenceColumnViewController' => 'ConpherenceController',
     'ConpherenceConduitAPIMethod' => 'ConduitAPIMethod',
-    'ConpherenceConfigOptions' => 'PhabricatorApplicationConfigOptions',
     'ConpherenceConstants' => 'Phobject',
     'ConpherenceController' => 'PhabricatorController',
     'ConpherenceCreateThreadConduitAPIMethod' => 'ConpherenceConduitAPIMethod',
···
     'PhabricatorLDAPAuthProvider' => 'PhabricatorAuthProvider',
     'PhabricatorLabelProfileMenuItem' => 'PhabricatorProfileMenuItem',
     'PhabricatorLegalpadApplication' => 'PhabricatorApplication',
-    'PhabricatorLegalpadConfigOptions' => 'PhabricatorApplicationConfigOptions',
     'PhabricatorLegalpadDocumentPHIDType' => 'PhabricatorPHIDType',
     'PhabricatorLegalpadSignaturePolicyRule' => 'PhabricatorPolicyRule',
     'PhabricatorLibraryTestCase' => 'PhutilLibraryTestCase',
···
     'PhabricatorMacroAudioBehaviorTransaction' => 'PhabricatorMacroTransactionType',
     'PhabricatorMacroAudioController' => 'PhabricatorMacroController',
     'PhabricatorMacroAudioTransaction' => 'PhabricatorMacroTransactionType',
-    'PhabricatorMacroConfigOptions' => 'PhabricatorApplicationConfigOptions',
     'PhabricatorMacroController' => 'PhabricatorController',
     'PhabricatorMacroDatasource' => 'PhabricatorTypeaheadDatasource',
     'PhabricatorMacroDisableController' => 'PhabricatorMacroController',
···
     ),
     'PhabricatorPasteApplication' => 'PhabricatorApplication',
     'PhabricatorPasteArchiveController' => 'PhabricatorPasteController',
-    'PhabricatorPasteConfigOptions' => 'PhabricatorApplicationConfigOptions',
     'PhabricatorPasteContentSearchEngineAttachment' => 'PhabricatorSearchEngineAttachment',
     'PhabricatorPasteContentTransaction' => 'PhabricatorPasteTransactionType',
     'PhabricatorPasteController' => 'PhabricatorController',
···
     'PhabricatorPhamePostPHIDType' => 'PhabricatorPHIDType',
     'PhabricatorPhluxApplication' => 'PhabricatorApplication',
     'PhabricatorPholioApplication' => 'PhabricatorApplication',
-    'PhabricatorPholioConfigOptions' => 'PhabricatorApplicationConfigOptions',
     'PhabricatorPholioMockTestDataGenerator' => 'PhabricatorTestDataGenerator',
     'PhabricatorPhoneNumber' => 'Phobject',
     'PhabricatorPhortuneApplication' => 'PhabricatorApplication',
···
     'PhabricatorPhragmentApplication' => 'PhabricatorApplication',
     'PhabricatorPhrequentApplication' => 'PhabricatorApplication',
     'PhabricatorPhrictionApplication' => 'PhabricatorApplication',
-    'PhabricatorPhrictionConfigOptions' => 'PhabricatorApplicationConfigOptions',
     'PhabricatorPhurlApplication' => 'PhabricatorApplication',
     'PhabricatorPhurlConfigOptions' => 'PhabricatorApplicationConfigOptions',
     'PhabricatorPhurlController' => 'PhabricatorController',

src/applications/audit/editor/PhabricatorAuditEditor.php

···
   }
 
   protected function getMailSubjectPrefix() {
-    return PhabricatorEnv::getEnvConfig('metamta.diffusion.subject-prefix');
+    return pht('[Diffusion]');
   }
 
   protected function getMailThreadID(PhabricatorLiskDAO $object) {

src/applications/config/check/PhabricatorExtraConfigSetupCheck.php

···
     $mailers_reason = pht(
       'Inbound and outbound mail is now configured with "cluster.mailers".');
 
+    $prefix_reason = pht(
+      'Per-application mail subject prefix customization is no longer '.
+      'directly supported. Prefixes and other strings may be customized with '.
+      '"translation.override".');
+
     $ancient_config += array(
       'phid.external-loaders' =>
         pht(
···
       'phabricator.allow-email-users' => pht(
         'Public email is now accepted if the associated address has a '.
         'default author, and rejected otherwise.'),
+
+      'metamta.conpherence.subject-prefix' => $prefix_reason,
+      'metamta.differential.subject-prefix' => $prefix_reason,
+      'metamta.diffusion.subject-prefix' => $prefix_reason,
+      'metamta.files.subject-prefix' => $prefix_reason,
+      'metamta.legalpad.subject-prefix' => $prefix_reason,
+      'metamta.macro.subject-prefix' => $prefix_reason,
+      'metamta.maniphest.subject-prefix' => $prefix_reason,
+      'metamta.package.subject-prefix' => $prefix_reason,
+      'metamta.paste.subject-prefix' => $prefix_reason,
+      'metamta.pholio.subject-prefix' => $prefix_reason,
+      'metamta.phriction.subject-prefix' => $prefix_reason,
+
     );
 
     return $ancient_config;

src/applications/conpherence/config/ConpherenceConfigOptions.php

···
-<?php
-
-final class ConpherenceConfigOptions
-  extends PhabricatorApplicationConfigOptions {
-
-  public function getName() {
-    return pht('Conpherence');
-  }
-
-  public function getDescription() {
-    return pht('Configure Conpherence messaging.');
-  }
-
-  public function getIcon() {
-    return 'fa-comments';
-  }
-
-  public function getGroup() {
-    return 'apps';
-  }
-
-  public function getOptions() {
-    return array(
-      $this->newOption(
-        'metamta.conpherence.subject-prefix',
-        'string',
-        '[Conpherence]')
-        ->setDescription(pht('Subject prefix for Conpherence mail.')),
-    );
-  }
-
-}

src/applications/conpherence/editor/ConpherenceEditor.php

···
   }
 
   protected function getMailSubjectPrefix() {
-    return PhabricatorEnv::getEnvConfig('metamta.conpherence.subject-prefix');
+    return pht('[Conpherence]');
   }
 
   protected function supportsSearch() {

src/applications/differential/config/PhabricatorDifferentialConfigOptions.php

···
             'This sort of workflow is very unusual. Very few installs should '.
             'need to change this option.')),
       $this->newOption(
-        'metamta.differential.subject-prefix',
-        'string',
-        '[Differential]')
-        ->setDescription(pht('Subject prefix for Differential mail.')),
-      $this->newOption(
         'metamta.differential.attach-patches',
         'bool',
         false)

src/applications/differential/doorkeeper/DifferentialDoorkeeperRevisionFeedStoryPublisher.php

···
   }
 
   private function getTitlePrefix(DifferentialRevision $revision) {
-    $prefix_key = 'metamta.differential.subject-prefix';
-    return PhabricatorEnv::getEnvConfig($prefix_key);
+    return pht('[Differential]');
   }
 
 }

src/applications/differential/editor/DifferentialTransactionEditor.php

···
   }
 
   protected function getMailSubjectPrefix() {
-    return PhabricatorEnv::getEnvConfig('metamta.differential.subject-prefix');
+    return pht('[Differential]');
   }
 
   protected function getMailThreadID(PhabricatorLiskDAO $object) {

src/applications/differential/mail/DifferentialCreateMailReceiver.php

···
       }
     }
 
-    $subject_prefix =
-      PhabricatorEnv::getEnvConfig('metamta.differential.subject-prefix');
+    $subject_prefix = pht('[Differential]');
     if (count($diffs)) {
       $subject = pht(
         'You successfully created %d diff(s).',

src/applications/diffusion/config/PhabricatorDiffusionConfigOptions.php

···
 
     return array(
       $this->newOption(
-        'metamta.diffusion.subject-prefix',
-        'string',
-        '[Diffusion]')
-        ->setDescription(pht('Subject prefix for Diffusion mail.')),
-      $this->newOption(
         'metamta.diffusion.attach-patches',
         'bool',
         false)

src/applications/diffusion/doorkeeper/DiffusionDoorkeeperCommitFeedStoryPublisher.php

···
   }
 
   private function getTitlePrefix(PhabricatorRepositoryCommit $commit) {
-    $prefix_key = 'metamta.diffusion.subject-prefix';
-    return PhabricatorEnv::getEnvConfig($prefix_key);
+    return pht('[Diffusion]');
   }
 
 }

src/applications/files/config/PhabricatorFilesConfigOptions.php

···
             "Set this to a valid Amazon S3 bucket to store files there. You ".
             "must also configure S3 access keys in the 'Amazon Web Services' ".
             "group.")),
-     $this->newOption(
-        'metamta.files.subject-prefix',
-        'string',
-        '[File]')
-        ->setDescription(pht('Subject prefix for Files email.')),
      $this->newOption('files.enable-imagemagick', 'bool', false)
        ->setBoolOptions(
          array(

src/applications/files/editor/PhabricatorFileEditor.php

···
   }
 
   protected function getMailSubjectPrefix() {
-    return PhabricatorEnv::getEnvConfig('metamta.files.subject-prefix');
+    return pht('[File]');
   }
 
   protected function getMailTo(PhabricatorLiskDAO $object) {

src/applications/files/mail/FileCreateMailReceiver.php

···
     } else {
       $subject = pht('You successfully uploaded a file.');
     }
-    $subject_prefix =
-      PhabricatorEnv::getEnvConfig('metamta.files.subject-prefix');
+    $subject_prefix = pht('[File]');
 
     $file_uris = array();
     foreach ($attachment_phids as $phid) {

src/applications/legalpad/config/PhabricatorLegalpadConfigOptions.php

···
-<?php
-
-final class PhabricatorLegalpadConfigOptions
-  extends PhabricatorApplicationConfigOptions {
-
-  public function getName() {
-    return pht('Legalpad');
-  }
-
-  public function getDescription() {
-    return pht('Configure Legalpad.');
-  }
-
-  public function getIcon() {
-    return 'fa-gavel';
-  }
-
-  public function getGroup() {
-    return 'apps';
-  }
-
-  public function getOptions() {
-    return array(
-      $this->newOption(
-        'metamta.legalpad.subject-prefix',
-        'string',
-        '[Legalpad]')
-        ->setDescription(pht('Subject prefix for Legalpad email.')),
-    );
-  }
-
-}

src/applications/legalpad/editor/LegalpadDocumentEditor.php

···
   }
 
   protected function getMailSubjectPrefix() {
-    return PhabricatorEnv::getEnvConfig('metamta.legalpad.subject-prefix');
+    return pht('[Legalpad]');
   }
 
 

src/applications/macro/config/PhabricatorMacroConfigOptions.php

···
-<?php
-
-final class PhabricatorMacroConfigOptions
-  extends PhabricatorApplicationConfigOptions {
-
-  public function getName() {
-    return pht('Macro');
-  }
-
-  public function getDescription() {
-    return pht('Configure Macro.');
-  }
-
-  public function getIcon() {
-    return 'fa-file-image-o';
-  }
-
-  public function getGroup() {
-    return 'apps';
-  }
-
-  public function getOptions() {
-    return array(
-      $this->newOption('metamta.macro.subject-prefix', 'string', '[Macro]')
-        ->setDescription(pht('Subject prefix for Macro email.')),
-    );
-  }
-
-}

src/applications/macro/editor/PhabricatorMacroEditor.php

···
   }
 
   protected function getMailSubjectPrefix() {
-    return PhabricatorEnv::getEnvConfig('metamta.macro.subject-prefix');
+    return pht('[Macro]');
   }
 
   protected function shouldPublishFeedStory(

src/applications/maniphest/config/PhabricatorManiphestConfigOptions.php

···
             '%s configuration option. The default value (`90`) '.
             'corresponds to the default "Needs Triage" priority.',
             'maniphest.priorities')),
-      $this->newOption(
-        'metamta.maniphest.subject-prefix',
-        'string',
-        '[Maniphest]')
-        ->setDescription(pht('Subject prefix for Maniphest mail.')),
       $this->newOption('maniphest.points', $points_type, array())
         ->setSummary(pht('Configure point values for tasks.'))
         ->setDescription($points_description)

src/applications/maniphest/editor/ManiphestTransactionEditor.php

···
   }
 
   protected function getMailSubjectPrefix() {
-    return PhabricatorEnv::getEnvConfig('metamta.maniphest.subject-prefix');
+    return pht('[Maniphest]');
   }
 
   protected function getMailThreadID(PhabricatorLiskDAO $object) {

src/applications/owners/config/PhabricatorOwnersConfigOptions.php

···
     $fields_example = id(new PhutilJSON())->encodeFormatted($fields_example);
 
     return array(
-      $this->newOption('metamta.package.subject-prefix', 'string', '[Package]')
-        ->setDescription(pht('Subject prefix for Owners email.')),
       $this->newOption('owners.fields', $custom_field_type, $default_fields)
         ->setCustomData($field_base_class)
         ->setDescription(pht('Select and reorder package fields.')),

src/applications/owners/editor/PhabricatorOwnersPackageTransactionEditor.php

···
   }
 
   protected function getMailSubjectPrefix() {
-    return PhabricatorEnv::getEnvConfig('metamta.package.subject-prefix');
+    return pht('[Package]');
   }
 
   protected function getMailTo(PhabricatorLiskDAO $object) {

src/applications/paste/config/PhabricatorPasteConfigOptions.php

···
-<?php
-
-final class PhabricatorPasteConfigOptions
-  extends PhabricatorApplicationConfigOptions {
-
-  public function getName() {
-    return pht('Paste');
-  }
-
-  public function getDescription() {
-    return pht('Configure Paste.');
-  }
-
-  public function getIcon() {
-    return 'fa-paste';
-  }
-
-  public function getGroup() {
-    return 'apps';
-  }
-
-  public function getOptions() {
-    return array(
-      $this->newOption(
-        'metamta.paste.subject-prefix',
-        'string',
-        '[Paste]')
-        ->setDescription(pht('Subject prefix for Paste email.')),
-    );
-  }
-
-}

src/applications/paste/editor/PhabricatorPasteEditor.php

···
   }
 
   protected function getMailSubjectPrefix() {
-    return PhabricatorEnv::getEnvConfig('metamta.paste.subject-prefix');
+    return pht('[Paste]');
   }
 
   protected function getMailTo(PhabricatorLiskDAO $object) {

src/applications/paste/mail/PasteCreateMailReceiver.php

···
       return;
     }
 
-    $subject_prefix =
-      PhabricatorEnv::getEnvConfig('metamta.paste.subject-prefix');
+    $subject_prefix = pht('[Paste]');
     $subject = pht('You successfully created a paste.');
     $paste_uri = PhabricatorEnv::getProductionURI($paste->getURI());
     $body = new PhabricatorMetaMTAMailBody();

src/applications/pholio/config/PhabricatorPholioConfigOptions.php

···
-<?php
-
-final class PhabricatorPholioConfigOptions
-  extends PhabricatorApplicationConfigOptions {
-
-  public function getName() {
-    return pht('Pholio');
-  }
-
-  public function getDescription() {
-    return pht('Configure Pholio.');
-  }
-
-  public function getIcon() {
-    return 'fa-camera-retro';
-  }
-
-  public function getGroup() {
-    return 'apps';
-  }
-
-  public function getOptions() {
-    return array(
-      $this->newOption('metamta.pholio.subject-prefix', 'string', '[Pholio]')
-        ->setDescription(pht('Subject prefix for Pholio email.')),
-    );
-  }
-
-}

src/applications/pholio/editor/PholioMockEditor.php

···
   }
 
   protected function getMailSubjectPrefix() {
-    return PhabricatorEnv::getEnvConfig('metamta.pholio.subject-prefix');
+    return pht('[Pholio]');
   }
 
   public function getMailTagsMap() {

src/applications/phriction/config/PhabricatorPhrictionConfigOptions.php

···
-<?php
-
-final class PhabricatorPhrictionConfigOptions
-  extends PhabricatorApplicationConfigOptions {
-
-  public function getName() {
-    return pht('Phriction');
-  }
-
-  public function getDescription() {
-    return pht('Options related to Phriction (wiki).');
-  }
-
-  public function getIcon() {
-    return 'fa-book';
-  }
-
-  public function getGroup() {
-    return 'apps';
-  }
-
-  public function getOptions() {
-    return array(
-      $this->newOption(
-        'metamta.phriction.subject-prefix', 'string', '[Phriction]')
-        ->setDescription(pht('Subject prefix for Phriction email.')),
-    );
-  }
-
-}

src/applications/repository/worker/PhabricatorRepositoryPushMailWorker.php

···
       $body->addTextSection(pht('REFERENCES'), implode("\n", $ref_lines));
     }
 
-    $prefix = PhabricatorEnv::getEnvConfig('metamta.diffusion.subject-prefix');
+    $prefix = pht('[Diffusion]');
 
     $parts = array();
     if ($commit_count) {