@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator

Update Forms on People.

Summary: Makes all forms on People app consistent with rest of site.

Test Plan: Click each page

Reviewers: epriestley, btrahan

Reviewed By: btrahan

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D5865

+17 -32
+17 -32
src/applications/people/controller/PhabricatorPeopleEditController.php
··· 115 115 array( 116 116 'title' => pht('Edit User'), 117 117 'device' => true, 118 + 'dust' => true, 118 119 )); 119 120 } 120 121 ··· 343 344 id(new AphrontFormSubmitControl()) 344 345 ->setValue(pht('Save'))); 345 346 346 - $panel = new AphrontPanelView(); 347 + $header = new PhabricatorHeaderView(); 347 348 if ($user->getID()) { 348 - $panel->setHeader(pht('Edit User')); 349 + $header->setHeader(pht('Edit User')); 349 350 } else { 350 - $panel->setHeader(pht('Create New User')); 351 + $header->setHeader(pht('Create New User')); 351 352 } 352 353 353 - $panel->appendChild($form); 354 - $panel->setNoBackground(); 355 - $panel->setWidth(AphrontPanelView::WIDTH_FORM); 356 - 357 - return array($error_view, $panel); 354 + return array($error_view, $form); 358 355 } 359 356 360 357 private function processRoleRequest(PhabricatorUser $user) { ··· 452 449 ->setValue(pht('Edit Role'))); 453 450 } 454 451 455 - $panel = new AphrontPanelView(); 456 - $panel->setHeader(pht('Edit Role')); 457 - $panel->setWidth(AphrontPanelView::WIDTH_FORM); 458 - $panel->setNoBackground(); 459 - $panel->appendChild($form); 452 + $header = new PhabricatorHeaderView(); 453 + $header->setHeader(pht('Edit Role')); 460 454 461 - return array($error_view, $panel); 455 + return array($error_view, $header, $form); 462 456 } 463 457 464 458 private function processCertificateRequest($user) { ··· 493 487 pht('You may only view the certificates of System Agents.'))); 494 488 } 495 489 496 - $panel = new AphrontPanelView(); 497 - $panel->setHeader(pht('Conduit Certificate')); 498 - $panel->setWidth(AphrontPanelView::WIDTH_FORM); 499 - $panel->setNoBackground(); 500 - $panel->appendChild($form); 490 + $header = new PhabricatorHeaderView(); 491 + $header->setHeader(pht('Conduit Certificate')); 501 492 502 - return array($panel); 493 + return array($header, $form); 503 494 } 504 495 505 496 private function processRenameRequest(PhabricatorUser $user) { ··· 591 582 id(new AphrontFormSubmitControl()) 592 583 ->setValue(pht('Change Username'))); 593 584 594 - $panel = new AphrontPanelView(); 595 - $panel->setHeader(pht('Change Username')); 596 - $panel->setWidth(AphrontPanelView::WIDTH_FORM); 597 - $panel->setNoBackground(); 598 - $panel->appendChild($form); 585 + $header = new PhabricatorHeaderView(); 586 + $header->setHeader(pht('Change Username')); 599 587 600 - return array($errors, $panel); 588 + return array($errors, $header, $form); 601 589 } 602 590 603 591 private function processDeleteRequest(PhabricatorUser $user) { ··· 685 673 id(new AphrontFormSubmitControl()) 686 674 ->setValue(pht('Delete User'))); 687 675 688 - $panel = new AphrontPanelView(); 689 - $panel->setHeader(pht('Delete User')); 690 - $panel->setWidth(AphrontPanelView::WIDTH_FORM); 691 - $panel->setNoBackground(); 692 - $panel->appendChild($form); 676 + $header = new PhabricatorHeaderView(); 677 + $header->setHeader(pht('Delete User')); 693 678 694 - return array($errors, $panel); 679 + return array($errors, $header, $form); 695 680 } 696 681 697 682 private function getRoleInstructions() {