@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator

Fix some copy and bugs in Ponder

Summary: Fixes T12939. Fixes some feed stories, mailtags, and headers.

Test Plan: Review changes locally by asking how babby is formed.

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin

Maniphest Tasks: T12939

Differential Revision: https://secure.phabricator.com/D18285

+27 -3
+1 -1
src/applications/ponder/controller/PonderQuestionViewController.php
··· 94 94 $wiki = new PHUIRemarkupView($viewer, $question->getAnswerWiki()); 95 95 $answer_wiki = id(new PHUIObjectBoxView()) 96 96 ->setBackground(PHUIObjectBoxView::BLUE_PROPERTY) 97 - ->setHeaderText(pht('ANSWER SUMMARY')) 97 + ->setHeaderText(pht('Answer Summary')) 98 98 ->appendChild($wiki) 99 99 ->addClass('ponder-answer-wiki'); 100 100 }
+2 -2
src/applications/ponder/editor/PonderQuestionEditor.php
··· 10 10 } 11 11 12 12 public function getCreateObjectTitle($author, $object) { 13 - return pht('%s created this question.', $author); 13 + return pht('%s asked this question.', $author); 14 14 } 15 15 16 16 public function getCreateObjectTitleForFeed($author, $object) { 17 - return pht('%s created %s.', $author, $object); 17 + return pht('%s asked %s.', $author, $object); 18 18 } 19 19 20 20 /**
+7
src/applications/ponder/storage/PonderAnswerTransaction.php
··· 23 23 return 'PonderAnswerTransactionType'; 24 24 } 25 25 26 + public function getMailTags() { 27 + $tags = parent::getMailTags(); 28 + $tags[] = PonderQuestionTransaction::MAILTAG_OTHER; 29 + 30 + return $tags; 31 + } 32 + 26 33 }
+17
src/applications/ponder/xaction/PonderAnswerContentTransaction.php
··· 14 14 } 15 15 16 16 public function getTitle() { 17 + $old = $this->getOldValue(); 18 + 19 + if (!strlen($old)) { 20 + return pht( 21 + '%s added an answer.', 22 + $this->renderAuthor()); 23 + } 24 + 17 25 return pht( 18 26 '%s updated the answer details.', 19 27 $this->renderAuthor()); 20 28 } 21 29 22 30 public function getTitleForFeed() { 31 + $old = $this->getOldValue(); 32 + 33 + if (!strlen($old)) { 34 + return pht( 35 + '%s added %s.', 36 + $this->renderAuthor(), 37 + $this->renderObject()); 38 + } 39 + 23 40 return pht( 24 41 '%s updated the answer details for %s.', 25 42 $this->renderAuthor(),