Conduit: Add some missing parameter descriptions

Summary: Add missing descriptions to parameters of (mostly) search related API endpoints.

Test Plan:
* Go to http://phorge.localhost/conduit/method/diffusion.uri.edit/, scroll to the "mfa" table, see a description for "value"
* Go to http://phorge.localhost/conduit/method/phurls.search/, scroll to the Constraints table, see missing parameter descriptions
* Go to http://phorge.localhost/conduit/method/maniphest.search/, scroll to the Constraints table, see missing parameters descriptions
* Repeat for the rest of the touched files

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Differential Revision: https://we.phorge.it/D26449

src/applications/auth/engineextension/PhabricatorAuthMFAEditEngineExtension.php

···
       ->setActionDescription(
         pht('You will be prompted to provide MFA when you submit.'))
       ->setDescription(pht('Sign this transaction group with MFA.'))
+      ->setConduitTypeDescription(
+        pht('True to sign this transaction group with MFA.'))
       ->setTransactionType($mfa_type);
 
     return array(

src/applications/badges/query/PhabricatorBadgesSearchEngine.php

···
       id(new PhabricatorSearchCheckboxesField())
         ->setKey('statuses')
         ->setLabel(pht('Status'))
+        ->setDescription(
+          pht('Search for active or archived badges.'))
         ->setOptions(
           id(new PhabricatorBadgesBadge())
             ->getStatusNameMap()),

src/applications/calendar/query/PhabricatorCalendarEventSearchEngine.php

···
         ->setLabel(pht('Hosts'))
         ->setKey('hostPHIDs')
         ->setAliases(array('host', 'hostPHID', 'hosts'))
+        ->setDescription(
+          pht('Search for events created by specific hosts.'))
         ->setDatasource(new PhabricatorPeopleUserFunctionDatasource()),
       id(new PhabricatorSearchDatasourceField())
         ->setLabel(pht('Invited'))
         ->setKey('invitedPHIDs')
+        ->setDescription(
+          pht('Search for events with specific invited users.'))
         ->setDatasource(new PhabricatorCalendarInviteeDatasource()),
       id(new PhabricatorSearchDateControlField())
         ->setLabel(pht('Occurs After'))
···
       id(new PhabricatorSearchSelectField())
         ->setLabel(pht('Cancelled Events'))
         ->setKey('isCancelled')
+        ->setDescription(pht('Search for active or cancelled events.'))
         ->setOptions($this->getCancelledOptions())
         ->setDefault('active'),
       id(new PhabricatorPHIDsSearchField())
         ->setLabel(pht('Import Sources'))
         ->setKey('importSourcePHIDs')
+        ->setDescription(
+          pht('Search for events with specific import sources.'))
         ->setAliases(array('importSourcePHID')),
       id(new PhabricatorSearchSelectField())
         ->setLabel(pht('Display Options'))
         ->setKey('display')
+        ->setDescription(
+          pht('Display events in a certain display format.'))
         ->setOptions($this->getViewOptions())
         ->setDefault('month'),
     );

src/applications/countdown/query/PhabricatorCountdownSearchEngine.php

···
       id(new PhabricatorUsersSearchField())
         ->setLabel(pht('Authors'))
         ->setKey('authorPHIDs')
+        ->setDescription(
+          pht('Search for objects created by specific authors.'))
         ->setAliases(array('author', 'authors')),
       id(new PhabricatorSearchCheckboxesField())
         ->setKey('upcoming')

src/applications/drydock/query/DrydockBlueprintSearchEngine.php

···
       id(new PhabricatorSearchThreeStateField())
         ->setLabel(pht('Disabled'))
         ->setKey('isDisabled')
+        ->setDescription(pht('Search for disabled or enabled blueprints.'))
         ->setOptions(
           pht('(Show All)'),
           pht('Show Only Disabled Blueprints'),

src/applications/drydock/query/DrydockLeaseSearchEngine.php

···
       id(new PhabricatorSearchCheckboxesField())
         ->setLabel(pht('Statuses'))
         ->setKey('statuses')
+        ->setDescription(pht('Search for objects with given statuses.'))
         ->setOptions(DrydockLeaseStatus::getStatusMap()),
       id(new PhabricatorPHIDsSearchField())
         ->setLabel(pht('Owners'))

src/applications/drydock/query/DrydockResourceSearchEngine.php

···
       id(new PhabricatorSearchCheckboxesField())
         ->setLabel(pht('Statuses'))
         ->setKey('statuses')
+        ->setDescription(pht('Search for objects with given statuses.'))
         ->setOptions(DrydockResourceStatus::getStatusMap()),
       id(new PhabricatorPHIDsSearchField())
         ->setLabel(pht('Blueprints'))

src/applications/files/query/PhabricatorFileSearchEngine.php

···
       id(new PhabricatorUsersSearchField())
         ->setKey('authorPHIDs')
         ->setAliases(array('author', 'authors'))
-        ->setLabel(pht('Authors')),
+        ->setLabel(pht('Authors'))
+        ->setDescription(
+          pht('Search for objects created by specific authors.')),
       id(new PhabricatorSearchThreeStateField())
         ->setKey('explicit')
         ->setLabel(pht('Upload Source'))
+        ->setDescription(
+          pht('Search for files which were explicitly uploaded.'))
         ->setOptions(
           pht('(Show All)'),
           pht('Show Only Manually Uploaded Files'),
           pht('Hide Manually Uploaded Files')),
       id(new PhabricatorSearchDateField())
         ->setKey('createdStart')
-        ->setLabel(pht('Created After')),
+        ->setLabel(pht('Created After'))
+        ->setDescription(
+          pht('Search for files created after a certain date.')),
       id(new PhabricatorSearchDateField())
         ->setKey('createdEnd')
-        ->setLabel(pht('Created Before')),
+        ->setLabel(pht('Created Before'))
+        ->setDescription(
+          pht('Search for files created before a certain date.')),
       id(new PhabricatorSearchTextField())
         ->setLabel(pht('Name Contains'))
         ->setKey('name')

src/applications/legalpad/query/LegalpadDocumentSearchEngine.php

···
           pht('Search for documents with given contributors.')),
       id(new PhabricatorSearchDateField())
         ->setLabel(pht('Created After'))
-        ->setKey('createdStart'),
+        ->setKey('createdStart')
+        ->setDescription(
+          pht('Search for documents created after a certain date.')),
       id(new PhabricatorSearchDateField())
         ->setLabel(pht('Created Before'))
-        ->setKey('createdEnd'),
+        ->setKey('createdEnd')
+        ->setDescription(
+          pht('Search for documents created before a certain date.')),
     );
   }
 

src/applications/legalpad/query/LegalpadDocumentSignatureSearchEngine.php

···
               'given string.')),
       id(new PhabricatorSearchDateField())
         ->setLabel(pht('Created After'))
-        ->setKey('createdStart'),
+        ->setKey('createdStart')
+        ->setDescription(
+          pht('Search for signatures created after a certain date.')),
       id(new PhabricatorSearchDateField())
         ->setLabel(pht('Created Before'))
-        ->setKey('createdEnd'),
+        ->setKey('createdEnd')
+        ->setDescription(
+          pht('Search for signatures created before a certain date.')),
     );
   }
 

src/applications/maniphest/query/ManiphestTaskSearchEngine.php

···
       id(new PhabricatorPHIDsSearchField())
         ->setLabel(pht('Columns'))
         ->setKey('columnPHIDs')
-        ->setAliases(array('column', 'columnPHID', 'columns')),
+        ->setAliases(array('column', 'columnPHID', 'columns'))
+        ->setDescription(
+          pht('Search for tasks in specific workboard columns.')),
       id(new PhabricatorSearchThreeStateField())
         ->setLabel(pht('Open Parents'))
         ->setKey('hasParents')
         ->setAliases(array('blocking'))
+        ->setDescription(
+          pht('Search for tasks which block open parent tasks.'))
         ->setOptions(
           pht('(Show All)'),
           pht('Show Only Tasks With Open Parents'),
···
         ->setLabel(pht('Open Subtasks'))
         ->setKey('hasSubtasks')
         ->setAliases(array('blocked'))
+        ->setDescription(
+          pht('Search for tasks blocked by open subtasks.'))
         ->setOptions(
           pht('(Show All)'),
           pht('Show Only Tasks With Open Subtasks'),
···
       id(new PhabricatorIDsSearchField())
         ->setLabel(pht('Parent IDs'))
         ->setKey('parentIDs')
-        ->setAliases(array('parentID')),
+        ->setAliases(array('parentID'))
+        ->setDescription(
+          pht('Search for tasks which have specific parent tasks.')),
       id(new PhabricatorIDsSearchField())
         ->setLabel(pht('Subtask IDs'))
         ->setKey('subtaskIDs')
-        ->setAliases(array('subtaskID')),
+        ->setAliases(array('subtaskID'))
+        ->setDescription(
+          pht('Search for tasks which have specific subtasks.')),
       id(new PhabricatorSearchSelectField())
         ->setLabel(pht('Group By'))
         ->setKey('group')
+        ->setDescription(pht('Group results by a certain parameter.'))
         ->setOptions($this->getGroupOptions()),
       id(new PhabricatorSearchDateField())
         ->setLabel(pht('Created After'))
-        ->setKey('createdStart'),
+        ->setKey('createdStart')
+        ->setDescription(
+          pht('Search for tasks created after a certain date.')),
       id(new PhabricatorSearchDateField())
         ->setLabel(pht('Created Before'))
-        ->setKey('createdEnd'),
+        ->setKey('createdEnd')
+        ->setDescription(
+          pht('Search for tasks created before a certain date.')),
       id(new PhabricatorSearchDateField())
         ->setLabel(pht('Updated After'))
-        ->setKey('modifiedStart'),
+        ->setKey('modifiedStart')
+        ->setDescription(
+          pht('Search for tasks updated after a certain date.')),
       id(new PhabricatorSearchDateField())
         ->setLabel(pht('Updated Before'))
-        ->setKey('modifiedEnd'),
+        ->setKey('modifiedEnd')
+        ->setDescription(
+          pht('Search for tasks updated before a certain date.')),
       id(new PhabricatorSearchDateField())
         ->setLabel(pht('Closed After'))
-        ->setKey('closedStart'),
+        ->setKey('closedStart')
+        ->setDescription(
+          pht('Search for tasks closed after a certain date.')),
       id(new PhabricatorSearchDateField())
         ->setLabel(pht('Closed Before'))
-        ->setKey('closedEnd'),
+        ->setKey('closedEnd')
+        ->setDescription(
+          pht('Search for tasks closed before a certain date.')),
       id(new PhabricatorUsersSearchField())
         ->setLabel(pht('Closed By'))
         ->setKey('closerPHIDs')

src/applications/phame/query/PhameBlogSearchEngine.php

···
       id(new PhabricatorSearchSelectField())
         ->setKey('statuses')
         ->setLabel(pht('Status'))
+        ->setDescription(pht('Search for blogs with given statuses.'))
         ->setOptions(array(
           '' => pht('All'),
           PhameBlog::STATUS_ACTIVE => pht('Active'),

src/applications/phame/query/PhamePostSearchEngine.php

···
       id(new PhabricatorSearchCheckboxesField())
         ->setKey('visibility')
         ->setLabel(pht('Visibility'))
+        ->setDescription(pht('Search for posts with specific visibility.'))
         ->setOptions(
           array(
             PhameConstants::VISIBILITY_PUBLISHED => pht('Published'),

src/applications/phriction/query/PhrictionDocumentSearchEngine.php

···
       id(new PhabricatorSearchCheckboxesField())
         ->setKey('statuses')
         ->setLabel(pht('Status'))
+        ->setDescription(pht('Search for objects with given statuses.'))
         ->setOptions(PhrictionDocumentStatus::getStatusMap()),
       id(new PhabricatorSearchStringListField())
         ->setKey('paths')
         ->setIsHidden(true)
+        ->setDescription(
+        pht('Find documents with specified paths (slugs).'))
         ->setLabel(pht('Paths')),
       id(new PhabricatorSearchStringListField())
         ->setKey('parentPaths')
         ->setIsHidden(true)
+        ->setDescription(
+        pht('Find documents beneath specified parent paths.'))
         ->setLabel(pht('Parent Paths')),
       id(new PhabricatorSearchStringListField())
         ->setKey('ancestorPaths')
         ->setIsHidden(true)
+        ->setDescription(
+        pht('Find documents beneath specified ancestor paths.'))
         ->setLabel(pht('Ancestor Paths')),
     );
   }

src/applications/phurl/query/PhabricatorPhurlURLSearchEngine.php

···
       id(new PhabricatorSearchDatasourceField())
         ->setLabel(pht('Created By'))
         ->setKey('authorPHIDs')
+        ->setDescription(
+          pht('Search for Phurl URLs created by specific authors.'))
         ->setDatasource(new PhabricatorPeopleUserFunctionDatasource()),
       id(new PhabricatorSearchTextField())
         ->setLabel(pht('Name Contains'))

src/applications/project/query/PhabricatorProjectColumnSearchEngine.php

···
         ->setLabel(pht('Projects'))
         ->setKey('projectPHIDs')
         ->setConduitKey('projects')
+        ->setDescription(
+          pht('Search for objects with specific project PHIDs.'))
         ->setAliases(array('project', 'projects', 'projectPHID')),
     );
   }

src/applications/project/query/PhabricatorProjectSearchEngine.php

···
         ->setLabel(pht('Members'))
         ->setKey('memberPHIDs')
         ->setConduitKey('members')
+        ->setDescription(pht('Search for projects with particular members.'))
         ->setAliases(array('member', 'members')),
       id(new PhabricatorUsersSearchField())
         ->setLabel(pht('Watchers'))
         ->setKey('watcherPHIDs')
         ->setConduitKey('watchers')
+        ->setDescription(pht('Search for projects with particular watchers.'))
         ->setAliases(array('watcher', 'watchers')),
       id(new PhabricatorSearchSelectField())
         ->setLabel(pht('Status'))
···
       id(new PhabricatorSearchCheckboxesField())
         ->setLabel(pht('Icons'))
         ->setKey('icons')
+        ->setDescription(pht('Search for projects with particular icons.'))
         ->setOptions($this->getIconOptions()),
       id(new PhabricatorSearchCheckboxesField())
         ->setLabel(pht('Colors'))
         ->setKey('colors')
+        ->setDescription(pht('Search for projects with particular colors.'))
         ->setOptions($this->getColorOptions()),
       id(new PhabricatorPHIDsSearchField())
         ->setLabel(pht('Parent Projects'))

src/applications/repository/query/PhabricatorRepositorySearchEngine.php

···
     return array(
       id(new PhabricatorSearchStringListField())
         ->setLabel(pht('Callsigns'))
-        ->setKey('callsigns'),
+        ->setKey('callsigns')
+        ->setDescription(
+          pht('Search for repositories with specific callsigns.')),
       id(new PhabricatorSearchStringListField())
         ->setLabel(pht('Short Names'))
-        ->setKey('shortNames'),
+        ->setKey('shortNames')
+        ->setDescription(
+          pht('Search for repositories with specific short names.')),
       id(new PhabricatorSearchSelectField())
         ->setLabel(pht('Status'))
         ->setKey('status')
+        ->setDescription(
+          pht('Search for repositories with a specific status.'))
         ->setOptions($this->getStatusOptions()),
       id(new PhabricatorSearchSelectField())
         ->setLabel(pht('Hosted'))
         ->setKey('hosted')
+        ->setDescription(
+          pht('Search for repositories which are hosted or remote.'))
         ->setOptions($this->getHostedOptions()),
       id(new PhabricatorSearchCheckboxesField())
         ->setLabel(pht('Types'))
         ->setKey('types')
+        ->setDescription(
+          pht('Search for repositories of a specific VCS type.'))
         ->setOptions(PhabricatorRepositoryType::getAllRepositoryTypes()),
       id(new PhabricatorSearchStringListField())
         ->setLabel(pht('URIs'))
···
       id(new PhabricatorPHIDsSearchField())
         ->setLabel(pht('Services'))
         ->setKey('almanacServicePHIDs')
+        ->setDescription(
+          pht('Search for repositories with a specific Almanac Service.'))
         ->setAliases(
           array(
             'almanacServicePHID',

src/applications/slowvote/query/PhabricatorSlowvoteSearchEngine.php

···
       id(new PhabricatorUsersSearchField())
         ->setKey('authorPHIDs')
         ->setAliases(array('authors'))
+        ->setDescription(
+          pht('Search for objects created by specific authors.'))
         ->setLabel(pht('Authors')),
       id(new PhabricatorSearchCheckboxesField())
         ->setKey('voted')