@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator

Put the HeraldActionRecord table back on the shelf

Summary:
Fixes T8958. I renamed this class and table (in D13644), but the migration `20150606.mlist.1.php` needs to load records from the table before the table rename applies.

Put the table back and accept a tiny bit of cruft here to fix this problem. We can no-op the migration after a while.

I'll cherry-pick this to `stable`.

Test Plan: Applied migration. Created Herald rules. Reviewed existing Herald rules.

Reviewers: btrahan

Subscribers: epriestley

Maniphest Tasks: T8958

Differential Revision: https://secure.phabricator.com/D13736

+10
+2
resources/sql/autopatches/20150727.heraldaction.1.sql
··· 1 + RENAME TABLE {$NAMESPACE}_herald.herald_actionrecord 2 + TO {$NAMESPACE}_herald.herald_action;
+8
src/applications/herald/storage/HeraldActionRecord.php
··· 7 7 protected $action; 8 8 protected $target; 9 9 10 + public function getTableName() { 11 + // TODO: This class was renamed, but we have a migration which affects the 12 + // table prior to to the rename. For now, having cruft here is cleaner than 13 + // having it in the migration. We could rename this table again and no-op 14 + // the migration after some time. See T8958. 15 + return 'herald_action'; 16 + } 17 + 10 18 protected function getConfiguration() { 11 19 return array( 12 20 self::CONFIG_SERIALIZATION => array(