@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator

Fix PHP 8.1 "strlen(null)" exception for empty default branch in PhabricatorRepository

Summary:
`strlen()` was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts `phutil_nonempty_string()` as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

```
ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/applications/repository/storage/PhabricatorRepository.php:2785]
```

Closes T16524

Test Plan:
1. PHP 8.1 or higher
2. Go to http://phorge.localhost/conduit/method/diffusion.repository.search/
3. In the "Attachments" field, enter `{"metrics": true}`
4. Click "Call Method"

Reviewers: O1 Blessed Committers, mainframe98

Reviewed By: O1 Blessed Committers, mainframe98

Subscribers: mainframe98, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T16524

Differential Revision: https://we.phorge.it/D26795

+1 -1
+1 -1
src/applications/repository/storage/PhabricatorRepository.php
··· 2782 2782 $permanent_rules = $this->getStringListForConduit($permanent_rules); 2783 2783 2784 2784 $default_branch = $this->getDefaultBranch(); 2785 - if (!strlen($default_branch)) { 2785 + if (!phutil_nonempty_string($default_branch)) { 2786 2786 $default_branch = null; 2787 2787 } 2788 2788