@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator

lipsum task generator: fix missing 'created this task'

Summary:
The lipsum generator for tasks was bugged, always causing a 'renamed this task' as first feed.

This happened since a manual setTitle() was called, and then the related "title transaction"
was also created, effectively causing a rename.

Just relying on the "title transaction" in the ex line 24 is sufficient.

Closes T16230

Test Plan:
Test the lipsum A/B for tasks:

./bin/lipsum generate task

The first feed is not anymore 'renamed' but 'created'.

Reviewers: O1 Blessed Committers, aklapper

Reviewed By: O1 Blessed Committers, aklapper

Subscribers: aklapper, tobiaswiese, Matthew, Cigaryno

Maniphest Tasks: T16228

Differential Revision: https://we.phorge.it/D26280

+1 -2
+1 -2
src/applications/maniphest/lipsum/PhabricatorManiphestTaskTestDataGenerator.php
··· 13 13 $author_phid = $this->loadPhabricatorUserPHID(); 14 14 $author = id(new PhabricatorUser()) 15 15 ->loadOneWhere('phid = %s', $author_phid); 16 - $task = ManiphestTask::initializeNewTask($author) 17 - ->setTitle($this->generateTitle()); 16 + $task = ManiphestTask::initializeNewTask($author); 18 17 19 18 $content_source = $this->getLipsumContentSource(); 20 19