@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator

Fix specifications of some "Visual Only" elements

Summary: See PHI823. These got "visual-only" but should acutally get "aural => false" to pick up "aria-hidden".

Test Plan: Viewed page source, saw both "visual-only" and "aria-hidden".

Reviewers: amckinley

Reviewed By: amckinley

Differential Revision: https://secure.phabricator.com/D20157

+9 -6
+3 -2
src/applications/transactions/view/PhabricatorApplicationTransactionCommentView.php
··· 254 254 255 255 require_celerity_resource('phui-comment-form-css'); 256 256 $image_uri = $viewer->getProfileImageURI(); 257 - $image = phutil_tag( 257 + $image = javelin_tag( 258 258 'div', 259 259 array( 260 260 'style' => 'background-image: url('.$image_uri.')', 261 - 'class' => 'phui-comment-image visual-only', 261 + 'class' => 'phui-comment-image', 262 + 'aural' => false, 262 263 )); 263 264 $wedge = phutil_tag( 264 265 'div',
+3 -2
src/view/phui/PHUIHeadThingView.php
··· 52 52 53 53 protected function getTagContent() { 54 54 55 - $image = phutil_tag( 55 + $image = javelin_tag( 56 56 'a', 57 57 array( 58 - 'class' => 'phui-head-thing-image visual-only', 58 + 'class' => 'phui-head-thing-image', 59 59 'style' => 'background-image: url('.$this->image.');', 60 60 'href' => $this->imageHref, 61 + 'aural' => false, 61 62 )); 62 63 63 64 if ($this->image) {
+3 -2
src/view/phui/PHUITimelineEventView.php
··· 420 420 $image = null; 421 421 $badges = null; 422 422 if ($image_uri) { 423 - $image = phutil_tag( 423 + $image = javelin_tag( 424 424 ($this->userHandle->getURI()) ? 'a' : 'div', 425 425 array( 426 426 'style' => 'background-image: url('.$image_uri.')', 427 - 'class' => 'phui-timeline-image visual-only', 427 + 'class' => 'phui-timeline-image', 428 428 'href' => $this->userHandle->getURI(), 429 + 'aural' => false, 429 430 ), 430 431 ''); 431 432 if ($this->badges && $show_badges) {