@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator

Remove `@group` annotations

Summary: I'm pretty sure that `@group` annotations are useless now... see D9855. Also fixed various other minor issues.

Test Plan: Eye-ball it.

Reviewers: #blessed_reviewers, epriestley, chad

Reviewed By: #blessed_reviewers, epriestley

Subscribers: epriestley, Korvin, hach-que

Differential Revision: https://secure.phabricator.com/D9859

+478 -1699
+2 -2
conf/default.conf.php
··· 798 798 // '#/autobuilt/#', 799 799 ), 800 800 801 - // If you set this to true, users can accept their own revisions. This action 801 + // If you set this to true, users can accept their own revisions. This action 802 802 // is disabled by default because it's most likely not a behavior you want, 803 803 // but it proves useful if you are working alone on a project and want to make 804 804 // use of all of differential's features. ··· 817 817 818 818 // If you set this to true, any user can reopen a revision so long as it has 819 819 // been closed. This can be useful if a revision is accidentally closed or 820 - // if a developer changes his or her mind after closing a revision. If it is 820 + // if a developer changes his or her mind after closing a revision. If it is 821 821 // false, reopening is not allowed. 822 822 'differential.allow-reopen' => false, 823 823
+8 -10
externals/balanced-php/tests/Balanced/SuiteTest.php
··· 27 27 * <li>$BALANCED_URL_ROOT If set applies to \Balanced\Settings::$url_root. 28 28 * <li>$BALANCED_API_KEY If set applies to \Balanced\Settings::$api_key. 29 29 * </ul> 30 - * 31 - * @group suite 32 30 */ 33 31 class SuiteTest extends \PHPUnit_Framework_TestCase 34 32 { ··· 784 782 } 785 783 786 784 function testEvents() { 787 - $prev_num_events = Marketplace::mine()->events->total(); 788 - $account = self::_createBuyer(); 789 - $account->debit(123); 790 - $cur_num_events = Marketplace::mine()->events->total(); 791 - $count = 0; 785 + $prev_num_events = Marketplace::mine()->events->total(); 786 + $account = self::_createBuyer(); 787 + $account->debit(123); 788 + $cur_num_events = Marketplace::mine()->events->total(); 789 + $count = 0; 792 790 while ($cur_num_events == $prev_num_events && $count < 10) { 793 791 printf("waiting for events - %d, %d == %d\n", $count + 1, $cur_num_events, $prev_num_events); 794 792 sleep(2); // 2 seconds 795 - $cur_num_events = Marketplace::mine()->events->total(); 796 - $count += 1; 797 - } 793 + $cur_num_events = Marketplace::mine()->events->total(); 794 + $count += 1; 795 + } 798 796 $this->assertTrue($cur_num_events > $prev_num_events); 799 797 } 800 798 }
-3
src/aphront/AphrontController.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group aphront 5 - */ 6 3 abstract class AphrontController extends Phobject { 7 4 8 5 private $request;
+1 -3
src/aphront/AphrontURIMapper.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group aphront 5 - */ 6 3 final class AphrontURIMapper { 7 4 8 5 private $map; ··· 49 46 50 47 return array(null, null); 51 48 } 49 + 52 50 }
+1 -1
src/aphront/configuration/AphrontApplicationConfiguration.php
··· 2 2 3 3 /** 4 4 * @task routing URI Routing 5 - * @group aphront 6 5 */ 7 6 abstract class AphrontApplicationConfiguration { 8 7 ··· 228 227 229 228 return array($controller, $uri_data); 230 229 } 230 + 231 231 }
-1
src/aphront/configuration/AphrontDefaultApplicationConfiguration.php
··· 4 4 * NOTE: Do not extend this! 5 5 * 6 6 * @concrete-extensible 7 - * @group aphront 8 7 */ 9 8 class AphrontDefaultApplicationConfiguration 10 9 extends AphrontApplicationConfiguration {
-3
src/aphront/console/DarkConsoleController.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group console 5 - */ 6 3 final class DarkConsoleController extends PhabricatorController { 7 4 8 5 protected $op;
-3
src/aphront/console/DarkConsoleCore.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group console 5 - */ 6 3 final class DarkConsoleCore { 7 4 8 5 private $plugins = array();
-3
src/aphront/console/DarkConsoleDataController.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group console 5 - */ 6 3 final class DarkConsoleDataController extends PhabricatorController { 7 4 8 5 private $key;
+1 -3
src/aphront/console/plugin/DarkConsoleErrorLogPlugin.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group console 5 - */ 6 3 final class DarkConsoleErrorLogPlugin extends DarkConsolePlugin { 7 4 8 5 public function getName() { ··· 98 95 phutil_tag('pre', array('class' => 'PhabricatorMonospaced'), $details), 99 96 )); 100 97 } 98 + 101 99 }
+1 -4
src/aphront/console/plugin/DarkConsoleEventPlugin.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group console 5 - */ 6 3 final class DarkConsoleEventPlugin extends DarkConsolePlugin { 7 4 8 5 public function getName() { ··· 14 11 } 15 12 16 13 public function generateData() { 17 - 18 14 $listeners = PhutilEventEngine::getInstance()->getAllListeners(); 19 15 foreach ($listeners as $key => $listener) { 20 16 $listeners[$key] = array( ··· 95 91 96 92 return phutil_implode_html("\n", $out); 97 93 } 94 + 98 95 }
+1 -6
src/aphront/console/plugin/DarkConsolePlugin.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group console 5 - */ 6 3 abstract class DarkConsolePlugin { 7 4 8 5 private $data; ··· 13 10 abstract public function getDescription(); 14 11 abstract public function renderPanel(); 15 12 16 - public function __construct() { 17 - 18 - } 13 + public function __construct() {} 19 14 20 15 public function getColor() { 21 16 return null;
-3
src/aphront/console/plugin/DarkConsoleRequestPlugin.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group console 5 - */ 6 3 final class DarkConsoleRequestPlugin extends DarkConsolePlugin { 7 4 8 5 public function getName() {
-4
src/aphront/console/plugin/DarkConsoleServicesPlugin.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group console 5 - */ 6 3 final class DarkConsoleServicesPlugin extends DarkConsolePlugin { 7 4 8 5 protected $observations; ··· 36 33 * @phutil-external-symbol class PhabricatorStartup 37 34 */ 38 35 public function generateData() { 39 - 40 36 $should_analyze = self::isQueryAnalyzerRequested(); 41 37 42 38 $log = PhutilServiceProfiler::getInstance()->getServiceCallLog();
-3
src/aphront/console/plugin/DarkConsoleXHProfPlugin.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group console 5 - */ 6 3 final class DarkConsoleXHProfPlugin extends DarkConsolePlugin { 7 4 8 5 protected $profileFilePHID;
-3
src/aphront/console/plugin/errorlog/DarkConsoleErrorLogPluginAPI.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group console 5 - */ 6 3 final class DarkConsoleErrorLogPluginAPI { 7 4 8 5 private static $errors = array();
-3
src/aphront/console/plugin/event/DarkConsoleEventPluginAPI.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group console 5 - */ 6 3 final class DarkConsoleEventPluginAPI extends PhabricatorEventListener { 7 4 8 5 private static $events = array();
-1
src/aphront/console/plugin/xhprof/DarkConsoleXHProfPluginAPI.php
··· 1 1 <?php 2 2 3 3 /** 4 - * @group console 5 4 * @phutil-external-symbol function xhprof_enable 6 5 * @phutil-external-symbol function xhprof_disable 7 6 */
-3
src/aphront/response/Aphront304Response.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group aphront 5 - */ 6 3 final class Aphront304Response extends AphrontResponse { 7 4 8 5 public function getHTTPResponseCode() {
-3
src/aphront/response/Aphront400Response.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group aphront 5 - */ 6 3 final class Aphront400Response extends AphrontResponse { 7 4 8 5 public function getHTTPResponseCode() {
-3
src/aphront/response/Aphront403Response.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group aphront 5 - */ 6 3 final class Aphront403Response extends AphrontHTMLResponse { 7 4 8 5 private $forbiddenText;
-3
src/aphront/response/Aphront404Response.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group aphront 5 - */ 6 3 final class Aphront404Response extends AphrontHTMLResponse { 7 4 8 5 public function getHTTPResponseCode() {
-3
src/aphront/response/AphrontAjaxResponse.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group aphront 5 - */ 6 3 final class AphrontAjaxResponse extends AphrontResponse { 7 4 8 5 private $content;
-3
src/aphront/response/AphrontDialogResponse.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group aphront 5 - */ 6 3 final class AphrontDialogResponse extends AphrontResponse { 7 4 8 5 private $dialog;
-3
src/aphront/response/AphrontFileResponse.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group aphront 5 - */ 6 3 final class AphrontFileResponse extends AphrontResponse { 7 4 8 5 private $content;
-3
src/aphront/response/AphrontHTMLResponse.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group aphront 5 - */ 6 3 abstract class AphrontHTMLResponse extends AphrontResponse { 7 4 8 5 public function getHeaders() {
+1 -3
src/aphront/response/AphrontJSONResponse.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group aphront 5 - */ 6 3 final class AphrontJSONResponse extends AphrontResponse { 7 4 8 5 private $content; ··· 40 37 $headers = array_merge(parent::getHeaders(), $headers); 41 38 return $headers; 42 39 } 40 + 43 41 }
-3
src/aphront/response/AphrontPlainTextResponse.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group aphront 5 - */ 6 3 final class AphrontPlainTextResponse extends AphrontResponse { 7 4 8 5 public function setContent($content) {
-3
src/aphront/response/AphrontProxyResponse.php
··· 7 7 * instantiating an @{class:AphrontAjaxResponse} in @{method:buildProxy}, and 8 8 * then constructing a real @{class:AphrontAjaxResponse} in 9 9 * @{method:reduceProxyResponse}. 10 - * 11 - * @group aphront 12 10 */ 13 11 abstract class AphrontProxyResponse extends AphrontResponse { 14 12 ··· 69 67 throw new Exception( 70 68 'AphrontProxyResponse must implement reduceProxyResponse().'); 71 69 } 72 - 73 70 74 71 }
-2
src/aphront/response/AphrontRedirectResponse.php
··· 2 2 3 3 /** 4 4 * TODO: Should be final but isn't because of AphrontReloadResponse. 5 - * 6 - * @group aphront 7 5 */ 8 6 class AphrontRedirectResponse extends AphrontResponse { 9 7
-2
src/aphront/response/AphrontReloadResponse.php
··· 5 5 * if the action is javascript-driven but redirect if it isn't. This preserves 6 6 * query parameters in the javascript case. A reload response behaves like 7 7 * a redirect response but causes a page reload when received via workflow. 8 - * 9 - * @group aphront 10 8 */ 11 9 final class AphrontReloadResponse extends AphrontRedirectResponse { 12 10
-4
src/aphront/response/AphrontResponse.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group aphront 5 - */ 6 3 abstract class AphrontResponse { 7 4 8 5 private $request; ··· 94 91 } 95 92 96 93 protected function addJSONShield($json_response) { 97 - 98 94 // Add a shield to prevent "JSON Hijacking" attacks where an attacker 99 95 // requests a JSON response using a normal <script /> tag and then uses 100 96 // Object.prototype.__defineSetter__() or similar to read response data.
-3
src/aphront/response/AphrontWebpageResponse.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group aphront 5 - */ 6 3 final class AphrontWebpageResponse extends AphrontHTMLResponse { 7 4 8 5 private $content;
+1 -2
src/aphront/sink/AphrontHTTPSink.php
··· 10 10 * 11 11 * @task write Writing Response Components 12 12 * @task emit Emitting the Response 13 - * 14 - * @group aphront 15 13 */ 16 14 abstract class AphrontHTTPSink { 17 15 ··· 117 115 abstract protected function emitHTTPStatus($code, $message = ''); 118 116 abstract protected function emitHeader($name, $value); 119 117 abstract protected function emitData($data); 118 + 120 119 }
-2
src/aphront/sink/AphrontIsolatedHTTPSink.php
··· 2 2 3 3 /** 4 4 * Isolated HTTP sink for testing. 5 - * 6 - * @group aphront 7 5 */ 8 6 final class AphrontIsolatedHTTPSink extends AphrontHTTPSink { 9 7
-2
src/aphront/sink/AphrontPHPHTTPSink.php
··· 2 2 3 3 /** 4 4 * Concrete HTTP sink which uses "echo" and "header()" to emit data. 5 - * 6 - * @group aphront 7 5 */ 8 6 final class AphrontPHPHTTPSink extends AphrontHTTPSink { 9 7
+1 -6
src/applications/arcanist/conduit/ConduitAPI_arcanist_Method.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group conduit 5 - */ 6 - abstract class ConduitAPI_arcanist_Method extends ConduitAPIMethod { 7 - 8 - } 3 + abstract class ConduitAPI_arcanist_Method extends ConduitAPIMethod {}
-3
src/applications/arcanist/conduit/ConduitAPI_arcanist_projectinfo_Method.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group conduit 5 - */ 6 3 final class ConduitAPI_arcanist_projectinfo_Method 7 4 extends ConduitAPI_arcanist_Method { 8 5
-3
src/applications/audit/conduit/ConduitAPI_audit_Method.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group conduit 5 - */ 6 3 abstract class ConduitAPI_audit_Method extends ConduitAPIMethod { 7 4 8 5 public function getApplication() {
-4
src/applications/audit/conduit/ConduitAPI_audit_query_Method.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group conduit 5 - */ 6 3 final class ConduitAPI_audit_query_Method extends ConduitAPI_audit_Method { 7 4 8 5 public function getMethodDescription() { ··· 75 72 76 73 return $results; 77 74 } 78 - 79 75 80 76 }
+1 -3
src/applications/base/PhabricatorApplication.php
··· 6 6 * @task uri URI Routing 7 7 * @task fact Fact Integration 8 8 * @task meta Application Management 9 - * @group apps 10 9 */ 11 - abstract class PhabricatorApplication 12 - implements PhabricatorPolicyInterface { 10 + abstract class PhabricatorApplication implements PhabricatorPolicyInterface { 13 11 14 12 const GROUP_CORE = 'core'; 15 13 const GROUP_UTILITIES = 'util';
-3
src/applications/calendar/constants/CalendarColors.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group calendar 5 - */ 6 3 final class CalendarColors extends CalendarConstants { 7 4 8 5 const COLOR_RED = 'red';
+1 -6
src/applications/calendar/constants/CalendarConstants.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group calendar 5 - */ 6 - abstract class CalendarConstants { 7 - 8 - } 3 + abstract class CalendarConstants {}
-3
src/applications/chatlog/conduit/ConduitAPI_chatlog_Method.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group conduit 5 - */ 6 3 abstract class ConduitAPI_chatlog_Method extends ConduitAPIMethod { 7 4 8 5 public function getApplication() {
+1 -6
src/applications/chatlog/conduit/ConduitAPI_chatlog_query_Method.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group conduit 5 - */ 6 - final class ConduitAPI_chatlog_query_Method 7 - extends ConduitAPI_chatlog_Method { 3 + final class ConduitAPI_chatlog_query_Method extends ConduitAPI_chatlog_Method { 8 4 9 5 public function getMethodStatus() { 10 6 return self::METHOD_STATUS_UNSTABLE; ··· 30 26 } 31 27 32 28 protected function execute(ConduitAPIRequest $request) { 33 - 34 29 $query = new PhabricatorChatLogQuery(); 35 30 36 31 $channel_ids = $request->getValue('channelIDs');
+2 -7
src/applications/chatlog/conduit/ConduitAPI_chatlog_record_Method.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group conduit 5 - */ 6 - final class ConduitAPI_chatlog_record_Method 7 - extends ConduitAPI_chatlog_Method { 3 + final class ConduitAPI_chatlog_record_Method extends ConduitAPI_chatlog_Method { 8 4 9 5 public function getMethodStatus() { 10 6 return self::METHOD_STATUS_UNSTABLE; ··· 25 21 } 26 22 27 23 public function defineErrorTypes() { 28 - return array( 29 - ); 24 + return array(); 30 25 } 31 26 32 27 protected function execute(ConduitAPIRequest $request) {
+1 -3
src/applications/conduit/controller/PhabricatorConduitAPIController.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group conduit 5 - */ 6 3 final class PhabricatorConduitAPIController 7 4 extends PhabricatorConduitController { 8 5 ··· 467 464 468 465 return $params; 469 466 } 467 + 470 468 }
-4
src/applications/conduit/controller/PhabricatorConduitController.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group conduit 5 - */ 6 3 abstract class PhabricatorConduitController extends PhabricatorController { 7 4 8 5 protected function buildSideNavView() { ··· 26 23 protected function buildApplicationMenu() { 27 24 return $this->buildSideNavView()->getMenu(); 28 25 } 29 - 30 26 31 27 }
-3
src/applications/conduit/controller/PhabricatorConduitLogController.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group conduit 5 - */ 6 3 final class PhabricatorConduitLogController 7 4 extends PhabricatorConduitController { 8 5
+1 -3
src/applications/conduit/controller/PhabricatorConduitTokenController.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group conduit 5 - */ 6 3 final class PhabricatorConduitTokenController 7 4 extends PhabricatorConduitController { 8 5 ··· 72 69 'title' => pht('Certificate Install Token'), 73 70 )); 74 71 } 72 + 75 73 }
+1 -7
src/applications/conduit/method/ConduitAPI_conduit_connect_Method.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group conduit 5 - */ 6 3 final class ConduitAPI_conduit_connect_Method extends ConduitAPIMethod { 7 4 8 5 public function shouldRequireAuthentication() { ··· 55 52 } 56 53 57 54 protected function execute(ConduitAPIRequest $request) { 58 - 59 55 $client = $request->getValue('client'); 60 56 $client_version = (int)$request->getValue('clientVersion'); 61 57 $client_description = (string)$request->getValue('clientDescription'); ··· 109 105 $token = $request->getValue('authToken'); 110 106 $signature = $request->getValue('authSignature'); 111 107 112 - $user = id(new PhabricatorUser())->loadOneWhere( 113 - 'username = %s', 114 - $username); 108 + $user = id(new PhabricatorUser())->loadOneWhere('username = %s', $username); 115 109 if (!$user) { 116 110 throw new ConduitException('ERR-INVALID-USER'); 117 111 }
+2 -5
src/applications/conduit/method/ConduitAPI_conduit_getcertificate_Method.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group conduit 5 - */ 6 3 final class ConduitAPI_conduit_getcertificate_Method extends ConduitAPIMethod { 7 4 8 5 public function shouldRequireAuthentication() { ··· 78 75 } 79 76 80 77 private function logFailure( 81 - ConduitAPIRequest $request, 82 - PhabricatorConduitCertificateToken $info = null) { 78 + ConduitAPIRequest $request, 79 + PhabricatorConduitCertificateToken $info = null) { 83 80 84 81 $log = PhabricatorUserLog::initializeNewLog( 85 82 $request->getUser(),
+1 -3
src/applications/conduit/method/ConduitAPI_conduit_ping_Method.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group conduit 5 - */ 6 3 final class ConduitAPI_conduit_ping_Method extends ConduitAPIMethod { 7 4 8 5 public function shouldRequireAuthentication() { ··· 28 25 protected function execute(ConduitAPIRequest $request) { 29 26 return php_uname('n'); 30 27 } 28 + 31 29 }
-3
src/applications/conduit/method/ConduitAPI_conduit_query_Method.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group conduit 5 - */ 6 3 final class ConduitAPI_conduit_query_Method extends ConduitAPIMethod { 7 4 8 5 public function getMethodDescription() {
-3
src/applications/conduit/protocol/ConduitAPIRequest.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group conduit 5 - */ 6 3 final class ConduitAPIRequest { 7 4 8 5 protected $params;
+3 -3
src/applications/conduit/protocol/ConduitAPIResponse.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group conduit 5 - */ 6 3 final class ConduitAPIResponse { 7 4 8 5 private $result; ··· 13 10 $this->result = $result; 14 11 return $this; 15 12 } 13 + 16 14 public function getResult() { 17 15 return $this->result; 18 16 } ··· 21 19 $this->errorCode = $error_code; 22 20 return $this; 23 21 } 22 + 24 23 public function getErrorCode() { 25 24 return $this->errorCode; 26 25 } ··· 40 39 'error_info' => $this->getErrorInfo(), 41 40 ); 42 41 } 42 + 43 43 }
-3
src/applications/conduit/protocol/ConduitException.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group conduit 5 - */ 6 3 final class ConduitException extends Exception { 7 4 8 5 private $errorDescription;
-3
src/applications/conduit/storage/PhabricatorConduitCertificateToken.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group conduit 5 - */ 6 3 final class PhabricatorConduitCertificateToken extends PhabricatorConduitDAO { 7 4 8 5 protected $userPHID;
-3
src/applications/conduit/storage/PhabricatorConduitConnectionLog.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group conduit 5 - */ 6 3 final class PhabricatorConduitConnectionLog extends PhabricatorConduitDAO { 7 4 8 5 protected $client;
-3
src/applications/conduit/storage/PhabricatorConduitDAO.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group conduit 5 - */ 6 3 abstract class PhabricatorConduitDAO extends PhabricatorLiskDAO { 7 4 8 5 public function getApplicationName() {
+2 -4
src/applications/conduit/storage/PhabricatorConduitMethodCallLog.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group conduit 5 - */ 6 - final class PhabricatorConduitMethodCallLog extends PhabricatorConduitDAO 3 + final class PhabricatorConduitMethodCallLog 4 + extends PhabricatorConduitDAO 7 5 implements PhabricatorPolicyInterface { 8 6 9 7 protected $callerPHID;
+1 -5
src/applications/conpherence/conduit/ConduitAPI_conpherence_Method.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group conduit 5 - */ 6 - abstract class ConduitAPI_conpherence_Method 7 - extends ConduitAPIMethod { 3 + abstract class ConduitAPI_conpherence_Method extends ConduitAPIMethod { 8 4 9 5 public function getApplication() { 10 6 return PhabricatorApplication::getByClass(
+3 -5
src/applications/conpherence/conduit/ConduitAPI_conpherence_createthread_Method.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group conduit 5 - */ 6 3 final class ConduitAPI_conpherence_createthread_Method 7 4 extends ConduitAPI_conpherence_Method { 8 5 ··· 32 29 } 33 30 34 31 protected function execute(ConduitAPIRequest $request) { 35 - 36 32 $participant_phids = $request->getValue('participantPHIDs', array()); 37 33 $message = $request->getValue('message'); 38 34 $title = $request->getValue('title'); ··· 60 56 return array( 61 57 'conpherenceID' => $conpherence->getID(), 62 58 'conpherencePHID' => $conpherence->getPHID(), 63 - 'conpherenceURI' => $this->getConpherenceURI($conpherence)); 59 + 'conpherenceURI' => $this->getConpherenceURI($conpherence), 60 + ); 64 61 } 62 + 65 63 }
+1 -4
src/applications/conpherence/conduit/ConduitAPI_conpherence_querythread_Method.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group conduit 5 - */ 6 3 final class ConduitAPI_conpherence_querythread_Method 7 4 extends ConduitAPI_conpherence_Method { 8 - 9 5 10 6 public function getMethodDescription() { 11 7 return pht( ··· 82 78 } 83 79 return $data; 84 80 } 81 + 85 82 }
+1 -4
src/applications/conpherence/conduit/ConduitAPI_conpherence_querytransaction_Method.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group conduit 5 - */ 6 3 final class ConduitAPI_conpherence_querytransaction_Method 7 4 extends ConduitAPI_conpherence_Method { 8 - 9 5 10 6 public function getMethodDescription() { 11 7 return pht( ··· 92 88 } 93 89 return $data; 94 90 } 91 + 95 92 }
+1 -3
src/applications/conpherence/conduit/ConduitAPI_conpherence_updatethread_Method.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group conduit 5 - */ 6 3 final class ConduitAPI_conpherence_updatethread_Method 7 4 extends ConduitAPI_conpherence_Method { 8 5 ··· 104 101 105 102 return true; 106 103 } 104 + 107 105 }
+1 -6
src/applications/conpherence/constants/ConpherenceConstants.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group conpherence 5 - */ 6 - abstract class ConpherenceConstants { 7 - 8 - } 3 + abstract class ConpherenceConstants {}
-3
src/applications/conpherence/constants/ConpherenceTransactionType.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group conpherence 5 - */ 6 3 final class ConpherenceTransactionType extends ConpherenceConstants { 7 4 8 5 const TYPE_FILES = 'files';
+3 -5
src/applications/conpherence/controller/ConpherenceController.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group conpherence 5 - */ 6 3 abstract class ConpherenceController extends PhabricatorController { 4 + 7 5 private $conpherences; 8 6 9 7 public function buildApplicationMenu() { ··· 149 147 return array( 150 148 'transactions' => $rendered_transactions, 151 149 'latest_transaction_id' => $latest_transaction_id, 152 - 'oldest_transaction_id' => $oldest_transaction_id 150 + 'oldest_transaction_id' => $oldest_transaction_id, 153 151 ); 154 - 155 152 } 153 + 156 154 }
+3 -6
src/applications/conpherence/controller/ConpherenceListController.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group conpherence 5 - */ 6 - final class ConpherenceListController 7 - extends ConpherenceController { 3 + final class ConpherenceListController extends ConpherenceController { 8 4 9 5 const SELECTED_MODE = 'selected'; 10 6 const UNSELECTED_MODE = 'unselected'; ··· 227 223 return array( 228 224 'scroll_up_participant' => $scroll_up_participant, 229 225 'scroll_down_participant' => $scroll_down_participant, 230 - 'participation' => $participation); 226 + 'participation' => $participation, 227 + ); 231 228 } 232 229 233 230 private function loadConpherenceThreadData($participation) {
+1 -3
src/applications/conpherence/controller/ConpherenceNewController.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group conpherence 5 - */ 6 3 final class ConpherenceNewController extends ConpherenceController { 7 4 8 5 public function processRequest() { ··· 99 96 100 97 return id(new AphrontDialogResponse())->setDialog($dialog); 101 98 } 99 + 102 100 }
+1 -4
src/applications/conpherence/controller/ConpherenceNotificationPanelController.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group conpherence 5 - */ 6 3 final class ConpherenceNotificationPanelController 7 4 extends ConpherenceController { 8 5 9 6 public function processRequest() { 10 - 11 7 $request = $this->getRequest(); 12 8 $user = $request->getUser(); 13 9 $conpherences = array(); ··· 108 104 109 105 return id(new AphrontAjaxResponse())->setContent($json); 110 106 } 107 + 111 108 }
+4 -5
src/applications/conpherence/controller/ConpherenceWidgetController.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group conpherence 5 - */ 6 - final class ConpherenceWidgetController extends 7 - ConpherenceController { 3 + final class ConpherenceWidgetController extends ConpherenceController { 8 4 9 5 private $conpherenceID; 10 6 private $conpherence; ··· 14 10 $this->userPreferences = $pref; 15 11 return $this; 16 12 } 13 + 17 14 public function getUserPreferences() { 18 15 return $this->userPreferences; 19 16 } ··· 22 19 $this->conpherence = $conpherence; 23 20 return $this; 24 21 } 22 + 25 23 public function getConpherence() { 26 24 return $this->conpherence; 27 25 } ··· 30 28 $this->conpherenceID = $conpherence_id; 31 29 return $this; 32 30 } 31 + 33 32 public function getConpherenceID() { 34 33 return $this->conpherenceID; 35 34 }
+1 -3
src/applications/conpherence/editor/ConpherenceEditor.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group conpherence 5 - */ 6 3 final class ConpherenceEditor extends PhabricatorApplicationTransactionEditor { 7 4 8 5 const ERROR_EMPTY_PARTICIPANTS = 'error-empty-participants'; ··· 421 418 protected function supportsSearch() { 422 419 return false; 423 420 } 421 + 424 422 }
-3
src/applications/conpherence/phid/PhabricatorConpherencePHIDTypeThread.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group conpherence 5 - */ 6 3 final class PhabricatorConpherencePHIDTypeThread extends PhabricatorPHIDType { 7 4 8 5 const TYPECONST = 'CONP';
-3
src/applications/conpherence/query/ConpherenceParticipantCountQuery.php
··· 9 9 * ->withParticipantPHIDs(array($my_phid)) 10 10 * ->withParticipationStatus(ConpherenceParticipationStatus::BEHIND) 11 11 * ->execute(); 12 - * 13 - * @group conpherence 14 12 */ 15 13 final class ConpherenceParticipantCountQuery 16 14 extends PhabricatorOffsetPagedQuery { ··· 65 63 } 66 64 67 65 private function buildGroupByClause(AphrontDatabaseConnection $conn_r) { 68 - 69 66 $group_by = qsprintf( 70 67 $conn_r, 71 68 'GROUP BY participantPHID');
+1 -5
src/applications/conpherence/query/ConpherenceParticipantQuery.php
··· 30 30 * 31 31 * For counts of read, un-read, or all conpherences by participant, see 32 32 * @{class:ConpherenceParticipantCountQuery}. 33 - * 34 - * @group conpherence 35 33 */ 36 - final class ConpherenceParticipantQuery 37 - extends PhabricatorOffsetPagedQuery { 34 + final class ConpherenceParticipantQuery extends PhabricatorOffsetPagedQuery { 38 35 39 36 const LIMIT = 100; 40 37 const ORDER_NEWER = 'newer'; ··· 116 113 } 117 114 118 115 private function buildOrderClause(AphrontDatabaseConnection $conn_r) { 119 - 120 116 $order_word = ($this->order == self::ORDER_OLDER) ? 'DESC' : 'ASC'; 121 117 // if these are different direction we won't get as efficient a query 122 118 // see http://dev.mysql.com/doc/refman/5.5/en/order-by-optimization.html
-3
src/applications/conpherence/query/ConpherenceThreadQuery.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group conpherence 5 - */ 6 3 final class ConpherenceThreadQuery 7 4 extends PhabricatorCursorPagedPolicyAwareQuery { 8 5
-4
src/applications/conpherence/query/ConpherenceTransactionQuery.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group conpherence 5 - */ 6 3 final class ConpherenceTransactionQuery 7 4 extends PhabricatorApplicationTransactionQuery { 8 5 ··· 13 10 protected function getReversePaging() { 14 11 return false; 15 12 } 16 - 17 13 18 14 }
-3
src/applications/conpherence/storage/ConpherenceDAO.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group conpherence 5 - */ 6 3 abstract class ConpherenceDAO extends PhabricatorLiskDAO { 7 4 8 5 public function getApplicationName() {
-3
src/applications/conpherence/storage/ConpherenceParticipant.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group conpherence 5 - */ 6 3 final class ConpherenceParticipant extends ConpherenceDAO { 7 4 8 5 protected $participantPHID;
-3
src/applications/conpherence/storage/ConpherenceThread.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group conpherence 5 - */ 6 3 final class ConpherenceThread extends ConpherenceDAO 7 4 implements PhabricatorPolicyInterface { 8 5
-3
src/applications/conpherence/storage/ConpherenceTransaction.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group conpherence 5 - */ 6 3 final class ConpherenceTransaction extends PhabricatorApplicationTransaction { 7 4 8 5 public function getApplicationName() {
-3
src/applications/conpherence/storage/ConpherenceTransactionComment.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group conpherence 5 - */ 6 3 final class ConpherenceTransactionComment 7 4 extends PhabricatorApplicationTransactionComment { 8 5
-3
src/applications/conpherence/view/ConpherenceFileWidgetView.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group conpherence 5 - */ 6 3 final class ConpherenceFileWidgetView extends ConpherenceWidgetView { 7 4 8 5 public function render() {
+1 -3
src/applications/conpherence/view/ConpherenceMenuItemView.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group conpherence 5 - */ 6 3 final class ConpherenceMenuItemView extends AphrontTagView { 7 4 8 5 private $title; ··· 119 116 $unread_count, 120 117 ); 121 118 } 119 + 122 120 }
+2 -3
src/applications/conpherence/view/ConpherencePeopleWidgetView.php
··· 1 1 <?php 2 - /** 3 - * @group conpherence 4 - */ 2 + 5 3 final class ConpherencePeopleWidgetView extends ConpherenceWidgetView { 6 4 7 5 public function render() { ··· 54 52 55 53 return $body; 56 54 } 55 + 57 56 }
+3 -3
src/applications/conpherence/view/ConpherenceTransactionView.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group conpherence 5 - */ 6 3 final class ConpherenceTransactionView extends AphrontView { 7 4 8 5 private $conpherenceTransaction; ··· 19 16 $this->handles = $handles; 20 17 return $this; 21 18 } 19 + 22 20 public function getHandles() { 23 21 return $this->handles; 24 22 } ··· 27 25 $this->conpherenceTransaction = $tx; 28 26 return $this; 29 27 } 28 + 30 29 private function getConpherenceTransaction() { 31 30 return $this->conpherenceTransaction; 32 31 } ··· 99 98 100 99 return $transaction_view->render(); 101 100 } 101 + 102 102 }
+1 -3
src/applications/conpherence/view/ConpherenceWidgetView.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group conpherence 5 - */ 6 3 abstract class ConpherenceWidgetView extends AphrontView { 7 4 8 5 private $conpherence; ··· 23 20 public function getConpherence() { 24 21 return $this->conpherence; 25 22 } 23 + 26 24 }
+1 -3
src/applications/countdown/controller/PhabricatorCountdownController.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group countdown 5 - */ 6 3 abstract class PhabricatorCountdownController extends PhabricatorController { 7 4 8 5 public function buildSideNavView($for_app = false) { ··· 39 36 40 37 return $crumbs; 41 38 } 39 + 42 40 }
-4
src/applications/countdown/controller/PhabricatorCountdownDeleteController.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group countdown 5 - */ 6 3 final class PhabricatorCountdownDeleteController 7 4 extends PhabricatorCountdownController { 8 5 ··· 13 10 } 14 11 15 12 public function processRequest() { 16 - 17 13 $request = $this->getRequest(); 18 14 $user = $request->getUser(); 19 15
+1 -3
src/applications/countdown/controller/PhabricatorCountdownEditController.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group countdown 5 - */ 6 3 final class PhabricatorCountdownEditController 7 4 extends PhabricatorCountdownController { 8 5 ··· 127 124 'title' => $page_title, 128 125 )); 129 126 } 127 + 130 128 }
-4
src/applications/countdown/query/PhabricatorCountdownQuery.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group countdown 5 - */ 6 3 final class PhabricatorCountdownQuery 7 4 extends PhabricatorCursorPagedPolicyAwareQuery { 8 5 ··· 44 41 $this->buildLimitClause($conn_r)); 45 42 46 43 $countdowns = $table->loadAllFromArray($data); 47 - 48 44 49 45 return $countdowns; 50 46 }
-3
src/applications/countdown/remarkup/PhabricatorCountdownRemarkupRule.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group countdown 5 - */ 6 3 final class PhabricatorCountdownRemarkupRule 7 4 extends PhabricatorRemarkupRuleObject { 8 5
-3
src/applications/countdown/storage/PhabricatorCountdownDAO.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group countdown 5 - */ 6 3 abstract class PhabricatorCountdownDAO extends PhabricatorLiskDAO { 7 4 8 5 public function getApplicationName() {
+1 -1
src/applications/differential/conduit/ConduitAPI_differential_finishpostponedlinters_Method.php
··· 71 71 } 72 72 } 73 73 74 - // Load the lint messages currenty attached to the diff. If this 74 + // Load the lint messages currenty attached to the diff. If this 75 75 // diff property doesn't exist, create it. 76 76 $messages_property = id(new DifferentialDiffProperty())->loadOneWhere( 77 77 'diffID = %d AND name = %s',
+3 -3
src/applications/differential/config/PhabricatorDifferentialConfigOptions.php
··· 146 146 ->setSummary(pht('Allows users to accept their own revisions.')) 147 147 ->setDescription( 148 148 pht( 149 - "If you set this to true, users can accept their own revisions. ". 149 + "If you set this to true, users can accept their own revisions. ". 150 150 "This action is disabled by default because it's most likely not ". 151 151 "a behavior you want, but it proves useful if you are working ". 152 152 "alone on a project and want to make use of all of ". ··· 186 186 ->setSummary(pht('Allows any user to reopen a closed revision.')) 187 187 ->setDescription( 188 188 pht('If you set this to true, any user can reopen a revision so '. 189 - 'long as it has been closed. This can be useful if a revision '. 189 + 'long as it has been closed. This can be useful if a revision '. 190 190 'is accidentally closed or if a developer changes his or her '. 191 - 'mind after closing a revision. If it is false, reopening '. 191 + 'mind after closing a revision. If it is false, reopening '. 192 192 'is not allowed.')), 193 193 $this->newOption('differential.close-on-accept', 'bool', false) 194 194 ->setBoolOptions(
+1 -1
src/applications/differential/parser/DifferentialChangesetParser.php
··· 598 598 if ($changetype == DifferentialChangeType::TYPE_MOVE_AWAY) { 599 599 // sometimes we show moved files as unchanged, sometimes deleted, 600 600 // and sometimes inconsistent with what actually happened at the 601 - // destination of the move. Rather than make a false claim, 601 + // destination of the move. Rather than make a false claim, 602 602 // omit the 'not changed' notice if this is the source of a move 603 603 $unchanged = false; 604 604 }
+1 -5
src/applications/differential/remarkup/DifferentialRemarkupRule.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group differential 5 - */ 6 - final class DifferentialRemarkupRule 7 - extends PhabricatorRemarkupRuleObject { 3 + final class DifferentialRemarkupRule extends PhabricatorRemarkupRuleObject { 8 4 9 5 protected function getObjectNamePrefix() { 10 6 return 'D';
+1 -2
src/applications/differential/storage/DifferentialAffectedPath.php
··· 3 3 /** 4 4 * Denormalized index table which stores relationships between revisions in 5 5 * Differential and paths in Diffusion. 6 - * 7 - * @group differential 8 6 */ 9 7 final class DifferentialAffectedPath extends DifferentialDAO { 10 8 ··· 18 16 self::CONFIG_TIMESTAMPS => false, 19 17 ) + parent::getConfiguration(); 20 18 } 19 + 21 20 }
+1 -5
src/applications/diffusion/conduit/ConduitAPI_diffusion_Method.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group conduit 5 - */ 6 - abstract class ConduitAPI_diffusion_Method 7 - extends ConduitAPIMethod { 3 + abstract class ConduitAPI_diffusion_Method extends ConduitAPIMethod { 8 4 9 5 public function getApplication() { 10 6 return PhabricatorApplication::getByClass(
+3 -3
src/applications/diffusion/conduit/ConduitAPI_diffusion_abstractquery_Method.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group conduit 5 - */ 6 3 abstract class ConduitAPI_diffusion_abstractquery_Method 7 4 extends ConduitAPI_diffusion_Method { 8 5 ··· 47 44 'ERR-UNSUPPORTED-VCS' => 48 45 pht('VCS is not supported for this method.')); 49 46 } 47 + 50 48 /** 51 49 * Subclasses should override this to specify custom error types. 52 50 */ ··· 61 59 'branch' => 'optional string', 62 60 ); 63 61 } 62 + 64 63 /** 65 64 * Subclasses should override this to specify custom param types. 66 65 */ ··· 129 128 } 130 129 return $result; 131 130 } 131 + 132 132 }
-3
src/applications/diffusion/conduit/ConduitAPI_diffusion_browsequery_Method.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group conduit 5 - */ 6 3 final class ConduitAPI_diffusion_browsequery_Method 7 4 extends ConduitAPI_diffusion_abstractquery_Method { 8 5
-3
src/applications/diffusion/conduit/ConduitAPI_diffusion_commitparentsquery_Method.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group conduit 5 - */ 6 3 final class ConduitAPI_diffusion_commitparentsquery_Method 7 4 extends ConduitAPI_diffusion_abstractquery_Method { 8 5
-3
src/applications/diffusion/conduit/ConduitAPI_diffusion_createcomment_Method.php
··· 1 1 <?php 2 2 3 - /** 4 - *@group conduit 5 - */ 6 3 final class ConduitAPI_diffusion_createcomment_Method 7 4 extends ConduitAPI_diffusion_Method { 8 5
-3
src/applications/diffusion/conduit/ConduitAPI_diffusion_diffquery_Method.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group conduit 5 - */ 6 3 final class ConduitAPI_diffusion_diffquery_Method 7 4 extends ConduitAPI_diffusion_abstractquery_Method { 8 5
+1 -3
src/applications/diffusion/conduit/ConduitAPI_diffusion_existsquery_Method.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group conduit 5 - */ 6 3 final class ConduitAPI_diffusion_existsquery_Method 7 4 extends ConduitAPI_diffusion_abstractquery_Method { 8 5 ··· 52 49 $commit); 53 50 return !$err; 54 51 } 52 + 55 53 }
+1 -3
src/applications/diffusion/conduit/ConduitAPI_diffusion_filecontentquery_Method.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group conduit 5 - */ 6 3 final class ConduitAPI_diffusion_filecontentquery_Method 7 4 extends ConduitAPI_diffusion_abstractquery_Method { 8 5 ··· 42 39 ->setTextList($text_list); 43 40 return $file_content->toDictionary(); 44 41 } 42 + 45 43 }
-3
src/applications/diffusion/conduit/ConduitAPI_diffusion_findsymbols_Method.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group conduit 5 - */ 6 3 final class ConduitAPI_diffusion_findsymbols_Method 7 4 extends ConduitAPI_diffusion_Method { 8 5
+1 -6
src/applications/diffusion/conduit/ConduitAPI_diffusion_getcommits_Method.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group conduit 5 - */ 6 3 final class ConduitAPI_diffusion_getcommits_Method 7 4 extends ConduitAPI_diffusion_Method { 8 5 ··· 29 26 } 30 27 31 28 public function defineErrorTypes() { 32 - return array( 33 - ); 29 + return array(); 34 30 } 35 31 36 32 protected function execute(ConduitAPIRequest $request) { 37 - 38 33 $results = array(); 39 34 40 35 $commits = $request->getValue('commits');
+1 -5
src/applications/diffusion/conduit/ConduitAPI_diffusion_getlintmessages_Method.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group conduit 5 - */ 6 3 final class ConduitAPI_diffusion_getlintmessages_Method 7 4 extends ConduitAPI_diffusion_Method { 8 5 ··· 28 25 } 29 26 30 27 public function defineErrorTypes() { 31 - return array( 32 - ); 28 + return array(); 33 29 } 34 30 35 31 protected function execute(ConduitAPIRequest $request) {
+1 -3
src/applications/diffusion/conduit/ConduitAPI_diffusion_getrecentcommitsbypath_Method.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group conduit 5 - */ 6 3 final class ConduitAPI_diffusion_getrecentcommitsbypath_Method 7 4 extends ConduitAPI_diffusion_Method { 8 5 ··· 64 61 } 65 62 return $result; 66 63 } 64 + 67 65 }
+3 -5
src/applications/diffusion/conduit/ConduitAPI_diffusion_historyquery_Method.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group conduit 5 - */ 6 3 final class ConduitAPI_diffusion_historyquery_Method 7 - extends ConduitAPI_diffusion_abstractquery_Method { 4 + extends ConduitAPI_diffusion_abstractquery_Method { 8 5 9 6 private $parents = array(); 10 7 ··· 33 30 34 31 return array( 35 32 'pathChanges' => mpull($path_changes, 'toDictionary'), 36 - 'parents' => $this->parents); 33 + 'parents' => $this->parents, 34 + ); 37 35 } 38 36 39 37 protected function getGitResult(ConduitAPIRequest $request) {
+1 -4
src/applications/diffusion/conduit/ConduitAPI_diffusion_mergedcommitsquery_Method.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group conduit 5 - */ 6 3 final class ConduitAPI_diffusion_mergedcommitsquery_Method 7 - extends ConduitAPI_diffusion_abstractquery_Method { 4 + extends ConduitAPI_diffusion_abstractquery_Method { 8 5 9 6 public function getMethodDescription() { 10 7 return
-3
src/applications/diffusion/conduit/ConduitAPI_diffusion_rawdiffquery_Method.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group conduit 5 - */ 6 3 final class ConduitAPI_diffusion_rawdiffquery_Method 7 4 extends ConduitAPI_diffusion_abstractquery_Method { 8 5
-3
src/applications/diffusion/conduit/ConduitAPI_diffusion_refsquery_Method.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group conduit 5 - */ 6 3 final class ConduitAPI_diffusion_refsquery_Method 7 4 extends ConduitAPI_diffusion_abstractquery_Method { 8 5
+1 -3
src/applications/diffusion/conduit/ConduitAPI_diffusion_searchquery_Method.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group conduit 5 - */ 6 3 final class ConduitAPI_diffusion_searchquery_Method 7 4 extends ConduitAPI_diffusion_abstractquery_Method { 8 5 ··· 112 109 113 110 return $results; 114 111 } 112 + 115 113 }
-3
src/applications/diffusion/query/DiffusionSymbolQuery.php
··· 8 8 * @task config Configuring the Query 9 9 * @task exec Executing the Query 10 10 * @task internal Internals 11 - * 12 - * @group diffusion 13 11 */ 14 12 final class DiffusionSymbolQuery extends PhabricatorOffsetPagedQuery { 15 13 ··· 282 280 } 283 281 } 284 282 } 285 - 286 283 287 284 }
+2 -2
src/applications/drydock/blueprint/DrydockPreallocatedHostBlueprintImplementation.php
··· 79 79 if ($v_platform !== 'windows') { 80 80 $cmd->execx('mkdir %s', $full_path); 81 81 } else { 82 - // Windows is terrible. The mkdir command doesn't even support putting 83 - // the path in quotes. IN QUOTES. ARGUHRGHUGHHGG!! Do some terribly 82 + // Windows is terrible. The mkdir command doesn't even support putting 83 + // the path in quotes. IN QUOTES. ARGUHRGHUGHHGG!! Do some terribly 84 84 // inaccurate sanity checking since we can't safely escape the path. 85 85 if (preg_match('/^[A-Z]\\:\\\\[a-zA-Z0-9\\\\\\ ]/', $full_path) === 0) { 86 86 throw new Exception(
-3
src/applications/feed/conduit/ConduitAPI_feed_Method.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group conduit 5 - */ 6 3 abstract class ConduitAPI_feed_Method extends ConduitAPIMethod { 7 4 8 5 public function getApplication() {
+1 -5
src/applications/feed/conduit/ConduitAPI_feed_publish_Method.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group conduit 5 - */ 6 - final class ConduitAPI_feed_publish_Method 7 - extends ConduitAPI_feed_Method { 3 + final class ConduitAPI_feed_publish_Method extends ConduitAPI_feed_Method { 8 4 9 5 public function getMethodStatus() { 10 6 return self::METHOD_STATUS_UNSTABLE;
+2 -7
src/applications/feed/conduit/ConduitAPI_feed_query_Method.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group conduit 5 - */ 6 - final class ConduitAPI_feed_query_Method 7 - extends ConduitAPI_feed_Method { 3 + final class ConduitAPI_feed_query_Method extends ConduitAPI_feed_Method { 8 4 9 5 public function getMethodStatus() { 10 6 return self::METHOD_STATUS_UNSTABLE; ··· 44 40 45 41 return array( 46 42 'ERR-UNKNOWN-TYPE' => 47 - 'Unsupported view type, possibles are: '.$view_types 43 + 'Unsupported view type, possibles are: '.$view_types, 48 44 ); 49 45 } 50 46 ··· 53 49 } 54 50 55 51 protected function execute(ConduitAPIRequest $request) { 56 - 57 52 $results = array(); 58 53 $user = $request->getUser(); 59 54
-3
src/applications/files/conduit/ConduitAPI_file_Method.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group conduit 5 - */ 6 3 abstract class ConduitAPI_file_Method extends ConduitAPIMethod { 7 4 8 5 public function getApplication() {
+1 -5
src/applications/files/conduit/ConduitAPI_file_download_Method.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group conduit 5 - */ 6 - final class ConduitAPI_file_download_Method 7 - extends ConduitAPI_file_Method { 3 + final class ConduitAPI_file_download_Method extends ConduitAPI_file_Method { 8 4 9 5 public function getMethodDescription() { 10 6 return 'Download a file from the server.';
-3
src/applications/files/conduit/ConduitAPI_file_info_Method.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group conduit 5 - */ 6 3 final class ConduitAPI_file_info_Method extends ConduitAPI_file_Method { 7 4 8 5 public function getMethodDescription() {
-3
src/applications/files/conduit/ConduitAPI_file_upload_Method.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group conduit 5 - */ 6 3 final class ConduitAPI_file_upload_Method extends ConduitAPI_file_Method { 7 4 8 5 public function getMethodDescription() {
+1 -3
src/applications/files/conduit/ConduitAPI_file_uploadhash_Method.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group conduit 5 - */ 6 3 final class ConduitAPI_file_uploadhash_Method extends ConduitAPI_file_Method { 7 4 8 5 public function getMethodDescription() { ··· 42 39 } 43 40 return $file; 44 41 } 42 + 45 43 }
-4
src/applications/files/config/PhabricatorFilesConfigOptions.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group file 5 - */ 6 3 final class PhabricatorFilesConfigOptions 7 4 extends PhabricatorApplicationConfigOptions { 8 5 ··· 15 12 } 16 13 17 14 public function getOptions() { 18 - 19 15 $viewable_default = array( 20 16 'image/jpeg' => 'image/jpeg', 21 17 'image/jpg' => 'image/jpg',
+1 -5
src/applications/files/controller/PhabricatorFileCommentController.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group file 5 - */ 6 - final class PhabricatorFileCommentController 7 - extends PhabricatorFileController { 3 + final class PhabricatorFileCommentController extends PhabricatorFileController { 8 4 9 5 private $id; 10 6
-3
src/applications/files/editor/PhabricatorFileEditor.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group file 5 - */ 6 3 final class PhabricatorFileEditor 7 4 extends PhabricatorApplicationTransactionEditor { 8 5
-1
src/applications/files/engine/PhabricatorFileStorageEngine.php
··· 12 12 * @task construct Constructing an Engine 13 13 * @task meta Engine Metadata 14 14 * @task file Managing File Data 15 - * @group filestorage 16 15 */ 17 16 abstract class PhabricatorFileStorageEngine { 18 17
-2
src/applications/files/engine/PhabricatorLocalDiskFileStorageEngine.php
··· 6 6 * 7 7 * @task impl Implementation 8 8 * @task internal Internals 9 - * @group filestorage 10 9 */ 11 10 final class PhabricatorLocalDiskFileStorageEngine 12 11 extends PhabricatorFileStorageEngine { ··· 30 29 * @task impl 31 30 */ 32 31 public function writeFile($data, array $params) { 33 - 34 32 $root = $this->getLocalDiskFileStorageRoot(); 35 33 36 34 // Generate a random, unique file path like "ab/29/1f918a9ac39201ff". We
-1
src/applications/files/engine/PhabricatorMySQLFileStorageEngine.php
··· 9 9 * 10 10 * @task impl Implementation 11 11 * @task internal Internals 12 - * @group filestorage 13 12 */ 14 13 final class PhabricatorMySQLFileStorageEngine 15 14 extends PhabricatorFileStorageEngine {
-2
src/applications/files/engine/PhabricatorTestStorageEngine.php
··· 2 2 3 3 /** 4 4 * Test storage engine. Does not actually store files. Used for unit tests. 5 - * 6 - * @group filestorage 7 5 */ 8 6 final class PhabricatorTestStorageEngine 9 7 extends PhabricatorFileStorageEngine {
-2
src/applications/files/engineselector/PhabricatorDefaultFileStorageEngineSelector.php
··· 4 4 * Default storage engine selector. See 5 5 * @{class:PhabricatorFileStorageEngineSelector} and @{article:File Storage 6 6 * Technical Documentation} for more information. 7 - * 8 - * @group filestorage 9 7 */ 10 8 final class PhabricatorDefaultFileStorageEngineSelector 11 9 extends PhabricatorFileStorageEngineSelector {
-1
src/applications/files/engineselector/PhabricatorFileStorageEngineSelector.php
··· 6 6 * of suitable @{class:PhabricatorFileStorageEngine}s. For more information, 7 7 * see @{article:File Storage Technical Documentation}. 8 8 * 9 - * @group filestorage 10 9 * @task select Selecting Storage Engines 11 10 */ 12 11 abstract class PhabricatorFileStorageEngineSelector {
+1 -5
src/applications/files/exception/PhabricatorFileStorageConfigurationException.php
··· 4 4 * Thrown by storage engines to indicate an configuration error which should 5 5 * abort the storage attempt, as opposed to a transient storage error which 6 6 * should be retried on other engines. 7 - * 8 - * @group files 9 7 */ 10 - final class PhabricatorFileStorageConfigurationException extends Exception { 11 - 12 - } 8 + final class PhabricatorFileStorageConfigurationException extends Exception {}
+1 -5
src/applications/files/mail/FileCreateMailReceiver.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group files 5 - */ 6 - final class FileCreateMailReceiver 7 - extends PhabricatorMailReceiver { 3 + final class FileCreateMailReceiver extends PhabricatorMailReceiver { 8 4 9 5 public function isEnabled() { 10 6 $app_class = 'PhabricatorApplicationFiles';
-3
src/applications/files/mail/FileMailReceiver.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group file 5 - */ 6 3 final class FileMailReceiver extends PhabricatorObjectMailReceiver { 7 4 8 5 public function isEnabled() {
-4
src/applications/files/mail/FileReplyHandler.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group file 5 - */ 6 3 final class FileReplyHandler extends PhabricatorMailReplyHandler { 7 4 8 5 public function validateMailReceiver($mail_receiver) { ··· 75 72 76 73 $head_xaction = head($xactions); 77 74 return $head_xaction->getID(); 78 - 79 75 } 80 76 81 77 }
-3
src/applications/files/query/PhabricatorFileQuery.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group file 5 - */ 6 3 final class PhabricatorFileQuery 7 4 extends PhabricatorCursorPagedPolicyAwareQuery { 8 5
-3
src/applications/files/query/PhabricatorFileTransactionQuery.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group file 5 - */ 6 3 final class PhabricatorFileTransactionQuery 7 4 extends PhabricatorApplicationTransactionQuery { 8 5
-6
src/applications/files/storage/PhabricatorFile.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group file 5 - */ 6 3 final class PhabricatorFile extends PhabricatorFileDAO 7 4 implements 8 5 PhabricatorTokenReceiverInterface, ··· 157 154 } 158 155 159 156 public static function newFileFromContentHash($hash, $params) { 160 - 161 157 // Check to see if a file with same contentHash exist 162 158 $file = id(new PhabricatorFile())->loadOneWhere( 163 159 'contentHash = %s LIMIT 1', $hash); ··· 413 409 } 414 410 415 411 public function delete() { 416 - 417 412 // We want to delete all the rows which mark this file as the transformation 418 413 // of some other file (since we're getting rid of it). We also delete all 419 414 // the transformations of this file, so that a user who deletes an image ··· 587 582 } 588 583 589 584 public function isTransformableImage() { 590 - 591 585 // NOTE: The way the 'gd' extension works in PHP is that you can install it 592 586 // with support for only some file types, so it might be able to handle 593 587 // PNG but not JPEG. Try to generate thumbnails for whatever we can. Setup
-3
src/applications/files/storage/PhabricatorFileDAO.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group file 5 - */ 6 3 abstract class PhabricatorFileDAO extends PhabricatorLiskDAO { 7 4 8 5 public function getApplicationName() {
-3
src/applications/files/storage/PhabricatorFileTransaction.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group file 5 - */ 6 3 final class PhabricatorFileTransaction 7 4 extends PhabricatorApplicationTransaction { 8 5
+1 -3
src/applications/files/storage/PhabricatorFileTransactionComment.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group file 5 - */ 6 3 final class PhabricatorFileTransactionComment 7 4 extends PhabricatorApplicationTransactionComment { 8 5 ··· 14 11 // Only cache submitted comments. 15 12 return ($this->getTransactionPHID() != null); 16 13 } 14 + 17 15 }
-3
src/applications/files/storage/PhabricatorTransformedFile.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group file 5 - */ 6 3 final class PhabricatorTransformedFile extends PhabricatorFileDAO { 7 4 8 5 protected $originalPHID;
-4
src/applications/files/storage/__tests__/PhabricatorFileTestCase.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group file 5 - */ 6 3 final class PhabricatorFileTestCase extends PhabricatorTestCase { 7 4 8 5 public function getPhabricatorTestCaseConfiguration() { ··· 58 55 59 56 $this->assertTrue($first_handle != $second_handle); 60 57 } 61 - 62 58 63 59 public function testFileStorageUploadSameFile() { 64 60 $engine = new PhabricatorTestStorageEngine();
-3
src/applications/flag/conduit/ConduitAPI_flag_Method.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group conduit 5 - */ 6 3 abstract class ConduitAPI_flag_Method extends ConduitAPIMethod { 7 4 8 5 public function getApplication() {
-3
src/applications/flag/conduit/ConduitAPI_flag_delete_Method.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group conduit 5 - */ 6 3 final class ConduitAPI_flag_delete_Method extends ConduitAPI_flag_Method { 7 4 8 5 public function getMethodDescription() {
-3
src/applications/flag/conduit/ConduitAPI_flag_edit_Method.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group conduit 5 - */ 6 3 final class ConduitAPI_flag_edit_Method extends ConduitAPI_flag_Method { 7 4 8 5 public function getMethodDescription() {
-4
src/applications/flag/conduit/ConduitAPI_flag_query_Method.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group conduit 5 - */ 6 3 final class ConduitAPI_flag_query_Method extends ConduitAPI_flag_Method { 7 4 8 5 public function getMethodDescription() { ··· 30 27 } 31 28 32 29 protected function execute(ConduitAPIRequest $request) { 33 - 34 30 $query = new PhabricatorFlagQuery(); 35 31 $query->setViewer($request->getUser()); 36 32
+1 -1
src/applications/harbormaster/controller/HarbormasterPlanViewController.php
··· 106 106 try { 107 107 $implementation = $step->getStepImplementation(); 108 108 } catch (Exception $ex) { 109 - // We can't initialize the implementation. This might be because 109 + // We can't initialize the implementation. This might be because 110 110 // it's been renamed or no longer exists. 111 111 $item = id(new PHUIObjectItemView()) 112 112 ->setObjectName(pht('Step %d', $i++))
-3
src/applications/harbormaster/query/HarbormasterBuildTransactionQuery.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group harbormaster 5 - */ 6 3 final class HarbormasterBuildTransactionQuery 7 4 extends PhabricatorApplicationTransactionQuery { 8 5
-3
src/applications/harbormaster/query/HarbormasterBuildableTransactionQuery.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group harbormaster 5 - */ 6 3 final class HarbormasterBuildableTransactionQuery 7 4 extends PhabricatorApplicationTransactionQuery { 8 5
+3 -3
src/applications/harbormaster/storage/build/HarbormasterBuildLog.php
··· 71 71 } 72 72 73 73 // If the length of the content is greater than the chunk size limit, 74 - // then we can never fit the content in a single record. We need to 74 + // then we can never fit the content in a single record. We need to 75 75 // split our content out and call append on it for as many parts as there 76 76 // are to the content. 77 77 if (strlen($content) > self::CHUNK_BYTE_LIMIT) { ··· 85 85 return; 86 86 } 87 87 88 - // Retrieve the size of last chunk from the DB for this log. If the 88 + // Retrieve the size of last chunk from the DB for this log. If the 89 89 // chunk is over 500K, then we need to create a new log entry. 90 90 $conn = $this->establishConnection('w'); 91 91 $result = queryfx_all( ··· 142 142 143 143 public function getLogText() { 144 144 // TODO: This won't cope very well if we're pulling like a 700MB 145 - // log file out of the DB. We should probably implement some sort 145 + // log file out of the DB. We should probably implement some sort 146 146 // of optional limit parameter so that when we're rendering out only 147 147 // 25 lines in the UI, we don't wastefully read in the whole log. 148 148
+1 -3
src/applications/herald/adapter/HeraldCommitAdapter.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group herald 5 - */ 6 3 final class HeraldCommitAdapter extends HeraldAdapter { 7 4 8 5 const FIELD_NEED_AUDIT_FOR_PACKAGE = 'need-audit-for-package'; ··· 559 556 } 560 557 return $result; 561 558 } 559 + 562 560 }
-3
src/applications/legalpad/config/PhabricatorLegalpadConfigOptions.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group legalpad 5 - */ 6 3 final class PhabricatorLegalpadConfigOptions 7 4 extends PhabricatorApplicationConfigOptions { 8 5
+1 -6
src/applications/legalpad/constants/LegalpadConstants.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group legalpad 5 - */ 6 - abstract class LegalpadConstants { 7 - 8 - } 3 + abstract class LegalpadConstants {}
-3
src/applications/legalpad/controller/LegalpadController.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group legalpad 5 - */ 6 3 abstract class LegalpadController extends PhabricatorController { 7 4 8 5 public function buildSideNav($for_app = false) {
-3
src/applications/legalpad/controller/LegalpadDocumentCommentController.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group legalpad 5 - */ 6 3 final class LegalpadDocumentCommentController extends LegalpadController { 7 4 8 5 private $id;
-3
src/applications/legalpad/editor/LegalpadDocumentEditor.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group legalpad 5 - */ 6 3 final class LegalpadDocumentEditor 7 4 extends PhabricatorApplicationTransactionEditor { 8 5
-3
src/applications/legalpad/mail/LegalpadReplyHandler.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group legalpad 5 - */ 6 3 final class LegalpadReplyHandler extends PhabricatorMailReplyHandler { 7 4 8 5 public function validateMailReceiver($mail_receiver) {
-3
src/applications/legalpad/phid/PhabricatorLegalpadPHIDTypeDocument.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group legalpad 5 - */ 6 3 final class PhabricatorLegalpadPHIDTypeDocument extends PhabricatorPHIDType { 7 4 8 5 const TYPECONST = 'LEGD';
-3
src/applications/legalpad/query/LegalpadTransactionQuery.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group legalpad 5 - */ 6 3 final class LegalpadTransactionQuery 7 4 extends PhabricatorApplicationTransactionQuery { 8 5
-3
src/applications/legalpad/storage/LegalpadDAO.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group legalpad 5 - */ 6 3 abstract class LegalpadDAO extends PhabricatorLiskDAO { 7 4 8 5 public function getApplicationName() {
-4
src/applications/legalpad/storage/LegalpadDocumentBody.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group legalpad 5 - */ 6 3 final class LegalpadDocumentBody extends LegalpadDAO 7 4 implements 8 5 PhabricatorMarkupInterface { ··· 68 65 public function shouldUseMarkupCache($field) { 69 66 return (bool)$this->getID(); 70 67 } 71 - 72 68 73 69 }
-3
src/applications/legalpad/storage/LegalpadTransaction.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group legalpad 5 - */ 6 3 final class LegalpadTransaction extends PhabricatorApplicationTransaction { 7 4 8 5 public function getApplicationName() {
+1 -3
src/applications/legalpad/storage/LegalpadTransactionComment.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group legalpad 5 - */ 6 3 final class LegalpadTransactionComment 7 4 extends PhabricatorApplicationTransactionComment { 8 5 ··· 21 18 // Only cache submitted comments. 22 19 return ($this->getTransactionPHID() != null); 23 20 } 21 + 24 22 }
+1 -6
src/applications/legalpad/view/LegalpadTransactionView.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group legalpad 5 - */ 6 3 final class LegalpadTransactionView 7 - extends PhabricatorApplicationTransactionView { 8 - 9 - } 4 + extends PhabricatorApplicationTransactionView {}
-4
src/applications/macro/conduit/ConduitAPI_macro_Method.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group conduit 5 - */ 6 3 abstract class ConduitAPI_macro_Method extends ConduitAPIMethod { 7 4 8 5 public function getApplication() { 9 6 return PhabricatorApplication::getByClass( 10 7 'PhabricatorApplicationMacro'); 11 8 } 12 - 13 9 14 10 }
+1 -5
src/applications/macro/conduit/ConduitAPI_macro_creatememe_Method.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group conduit 5 - */ 6 - final class ConduitAPI_macro_creatememe_Method 7 - extends ConduitAPI_macro_Method { 3 + final class ConduitAPI_macro_creatememe_Method extends ConduitAPI_macro_Method { 8 4 9 5 public function getMethodStatus() { 10 6 return self::METHOD_STATUS_UNSTABLE;
-3
src/applications/macro/conduit/ConduitAPI_macro_query_Method.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group conduit 5 - */ 6 3 final class ConduitAPI_macro_query_Method extends ConduitAPI_macro_Method { 7 4 8 5 public function getMethodDescription() {
-4
src/applications/macro/query/PhabricatorMacroQuery.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group phriction 5 - */ 6 3 final class PhabricatorMacroQuery 7 4 extends PhabricatorCursorPagedPolicyAwareQuery { 8 5 ··· 29 26 } 30 27 31 28 public static function getFlagColorsOptions() { 32 - 33 29 $options = array( 34 30 '-1' => pht('(No Filtering)'), 35 31 '-2' => pht('(Marked With Any Flag)'),
+1 -5
src/applications/macro/remarkup/PhabricatorRemarkupRuleImageMacro.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group markup 5 - */ 6 - final class PhabricatorRemarkupRuleImageMacro 7 - extends PhutilRemarkupRule { 3 + final class PhabricatorRemarkupRuleImageMacro extends PhutilRemarkupRule { 8 4 9 5 private $macros; 10 6
+1 -5
src/applications/macro/remarkup/PhabricatorRemarkupRuleMeme.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group markup 5 - */ 6 - final class PhabricatorRemarkupRuleMeme 7 - extends PhutilRemarkupRule { 3 + final class PhabricatorRemarkupRuleMeme extends PhutilRemarkupRule { 8 4 9 5 private $images; 10 6
+12 -13
src/applications/maniphest/conduit/ConduitAPI_maniphest_Method.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group conduit 5 - */ 6 3 abstract class ConduitAPI_maniphest_Method extends ConduitAPIMethod { 7 4 8 5 public function getApplication() { ··· 103 100 104 101 $owner_phid = $request->getValue('ownerPHID'); 105 102 if ($owner_phid !== null) { 106 - $this->validatePHIDList(array($owner_phid), 107 - PhabricatorPeoplePHIDTypeUser::TYPECONST, 108 - 'ownerPHID'); 103 + $this->validatePHIDList( 104 + array($owner_phid), 105 + PhabricatorPeoplePHIDTypeUser::TYPECONST, 106 + 'ownerPHID'); 109 107 $changes[ManiphestTransaction::TYPE_OWNER] = $owner_phid; 110 108 } 111 109 112 110 $ccs = $request->getValue('ccPHIDs'); 113 111 if ($ccs !== null) { 114 - $this->validatePHIDList($ccs, 115 - PhabricatorPeoplePHIDTypeUser::TYPECONST, 116 - 'ccPHIDS'); 112 + $this->validatePHIDList( 113 + $ccs, 114 + PhabricatorPeoplePHIDTypeUser::TYPECONST, 115 + 'ccPHIDS'); 117 116 $changes[ManiphestTransaction::TYPE_CCS] = $ccs; 118 117 } 119 118 120 119 $project_phids = $request->getValue('projectPHIDs'); 121 120 if ($project_phids !== null) { 122 - $this->validatePHIDList($project_phids, 123 - PhabricatorProjectPHIDTypeProject::TYPECONST, 124 - 'projectPHIDS'); 121 + $this->validatePHIDList( 122 + $project_phids, 123 + PhabricatorProjectPHIDTypeProject::TYPECONST, 124 + 'projectPHIDS'); 125 125 $changes[ManiphestTransaction::TYPE_PROJECTS] = $project_phids; 126 126 } 127 127 ··· 207 207 $event->setUser($request->getUser()); 208 208 $event->setConduitRequest($request); 209 209 PhutilEventEngine::dispatchEvent($event); 210 - 211 210 } 212 211 213 212 protected function buildTaskInfoDictionaries(array $tasks) {
-3
src/applications/maniphest/conduit/ConduitAPI_maniphest_createtask_Method.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group conduit 5 - */ 6 3 final class ConduitAPI_maniphest_createtask_Method 7 4 extends ConduitAPI_maniphest_Method { 8 5
-2
src/applications/maniphest/conduit/ConduitAPI_maniphest_find_Method.php
··· 1 1 <?php 2 2 3 3 /** 4 - * @group conduit 5 - * 6 4 * @concrete-extensible 7 5 */ 8 6 final class ConduitAPI_maniphest_find_Method
+1 -3
src/applications/maniphest/conduit/ConduitAPI_maniphest_gettasktransactions_Method.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group maniphest 5 - */ 6 3 final class ConduitAPI_maniphest_gettasktransactions_Method 7 4 extends ConduitAPI_maniphest_Method { 8 5 ··· 74 71 75 72 return $results; 76 73 } 74 + 77 75 }
-4
src/applications/maniphest/conduit/ConduitAPI_maniphest_info_Method.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group conduit 5 - */ 6 3 final class ConduitAPI_maniphest_info_Method 7 4 extends ConduitAPI_maniphest_Method { 8 - 9 5 10 6 public function getMethodDescription() { 11 7 return 'Retrieve information about a Maniphest task, given its id.';
+2 -8
src/applications/maniphest/conduit/ConduitAPI_maniphest_query_Method.php
··· 1 1 <?php 2 2 3 3 /** 4 - * @group conduit 5 - * 6 4 * TODO: Remove maniphest.find, then make this final. 7 5 * 8 6 * @concrete-extensible 9 7 */ 10 - class ConduitAPI_maniphest_query_Method 11 - extends ConduitAPI_maniphest_Method { 12 - 8 + class ConduitAPI_maniphest_query_Method extends ConduitAPI_maniphest_Method { 13 9 14 10 public function getMethodDescription() { 15 11 return 'Execute complex searches for Maniphest tasks.'; 16 12 } 17 13 18 14 public function defineParamTypes() { 19 - 20 15 $statuses = array( 21 16 ManiphestTaskQuery::STATUS_ANY, 22 17 ManiphestTaskQuery::STATUS_OPEN, ··· 58 53 } 59 54 60 55 public function defineErrorTypes() { 61 - return array( 62 - ); 56 + return array(); 63 57 } 64 58 65 59 protected function execute(ConduitAPIRequest $request) {
-3
src/applications/maniphest/conduit/ConduitAPI_maniphest_update_Method.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group conduit 5 - */ 6 3 final class ConduitAPI_maniphest_update_Method 7 4 extends ConduitAPI_maniphest_Method { 8 5
+1 -6
src/applications/maniphest/constants/ManiphestConstants.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group maniphest 5 - */ 6 - abstract class ManiphestConstants { 7 - 8 - } 3 + abstract class ManiphestConstants {}
-3
src/applications/maniphest/constants/ManiphestTaskOwner.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group maniphest 5 - */ 6 3 final class ManiphestTaskOwner extends ManiphestConstants { 7 4 8 5 const OWNER_UP_FOR_GRABS = 'PHID-!!!!-UP-FOR-GRABS';
-4
src/applications/maniphest/controller/ManiphestBatchEditController.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group maniphest 5 - */ 6 3 final class ManiphestBatchEditController extends ManiphestController { 7 4 8 5 public function processRequest() { 9 - 10 6 $this->requireApplicationCapability( 11 7 ManiphestCapabilityBulkEdit::CAPABILITY); 12 8
-3
src/applications/maniphest/controller/ManiphestExportController.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group maniphest 5 - */ 6 3 final class ManiphestExportController extends ManiphestController { 7 4 8 5 private $key;
-3
src/applications/maniphest/controller/ManiphestSubpriorityController.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group maniphest 5 - */ 6 3 final class ManiphestSubpriorityController extends ManiphestController { 7 4 8 5 public function processRequest() {
+1 -3
src/applications/maniphest/controller/ManiphestTaskDescriptionPreviewController.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group maniphest 5 - */ 6 3 final class ManiphestTaskDescriptionPreviewController 7 4 extends ManiphestController { 8 5 ··· 23 20 return id(new AphrontAjaxResponse()) 24 21 ->setContent($content); 25 22 } 23 + 26 24 }
-3
src/applications/maniphest/controller/ManiphestTransactionPreviewController.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group maniphest 5 - */ 6 3 final class ManiphestTransactionPreviewController extends ManiphestController { 7 4 8 5 private $id;
+1 -3
src/applications/maniphest/event/ManiphestEdgeEventListener.php
··· 3 3 /** 4 4 * Listener for Maniphest Task edge events. When some workflow causes task 5 5 * edges to be added or removed, we consider the edge edit authoritative but 6 - * duplicate the information into a ManiphestTansaction for display. 7 - * 8 - * @group maniphest 6 + * duplicate the information into a @{class:ManiphestTansaction} for display. 9 7 */ 10 8 final class ManiphestEdgeEventListener extends PhabricatorEventListener { 11 9
-4
src/applications/maniphest/export/ManiphestExcelDefaultFormat.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group maniphest 5 - */ 6 3 final class ManiphestExcelDefaultFormat extends ManiphestExcelFormat { 7 4 8 5 public function getName() { ··· 133 130 } 134 131 } 135 132 } 136 - 137 133 138 134 private function col($n) { 139 135 return chr(ord('A') + $n);
-3
src/applications/maniphest/export/ManiphestExcelFormat.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group maniphest 5 - */ 6 3 abstract class ManiphestExcelFormat { 7 4 8 5 final public static function loadAllFormats() {
-6
src/applications/maniphest/mail/ManiphestReplyHandler.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group maniphest 5 - */ 6 3 final class ManiphestReplyHandler extends PhabricatorMailReplyHandler { 7 4 8 5 public function validateMailReceiver($mail_receiver) { ··· 36 33 } 37 34 38 35 protected function receiveEmail(PhabricatorMetaMTAReceivedMail $mail) { 39 - 40 36 // NOTE: We'll drop in here on both the "reply to a task" and "create a 41 37 // new task" workflows! Make sure you test both if you make changes! 42 38 ··· 134 130 ->setContent($body)); 135 131 $xactions[] = $xaction; 136 132 } 137 - 138 133 } 139 134 140 135 $ccs = $mail->loadCCPHIDs(); ··· 184 179 )); 185 180 $event->setUser($user); 186 181 PhutilEventEngine::dispatchEvent($event); 187 - 188 182 } 189 183 190 184 }
+1 -8
src/applications/maniphest/query/ManiphestTaskQuery.php
··· 3 3 /** 4 4 * Query tasks by specific criteria. This class uses the higher-performance 5 5 * but less-general Maniphest indexes to satisfy queries. 6 - * 7 - * @group maniphest 8 6 */ 9 - final class ManiphestTaskQuery 10 - extends PhabricatorCursorPagedPolicyAwareQuery { 7 + final class ManiphestTaskQuery extends PhabricatorCursorPagedPolicyAwareQuery { 11 8 12 9 private $taskIDs = array(); 13 10 private $taskPHIDs = array(); ··· 182 179 } 183 180 184 181 public function loadPage() { 185 - 186 182 // TODO: (T603) It is possible for a user to find the PHID of a project 187 183 // they can't see, then query for tasks in that project and deduce the 188 184 // identity of unknown/invisible projects. Before we allow the user to ··· 358 354 } 359 355 360 356 private function buildStatusWhereClause(AphrontDatabaseConnection $conn) { 361 - 362 357 static $map = array( 363 358 self::STATUS_RESOLVED => ManiphestTaskStatus::STATUS_CLOSED_RESOLVED, 364 359 self::STATUS_WONTFIX => ManiphestTaskStatus::STATUS_CLOSED_WONTFIX, ··· 412 407 413 408 return null; 414 409 } 415 - 416 410 417 411 private function buildAuthorWhereClause(AphrontDatabaseConnection $conn) { 418 412 if (!$this->authorPHIDs) { ··· 940 934 protected function getApplicationSearchObjectPHIDColumn() { 941 935 return 'task.phid'; 942 936 } 943 - 944 937 945 938 public function getQueryApplicationClass() { 946 939 return 'PhabricatorApplicationManiphest';
+1 -5
src/applications/maniphest/remarkup/ManiphestRemarkupRule.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group maniphest 5 - */ 6 - final class ManiphestRemarkupRule 7 - extends PhabricatorRemarkupRuleObject { 3 + final class ManiphestRemarkupRule extends PhabricatorRemarkupRuleObject { 8 4 9 5 protected function getObjectNamePrefix() { 10 6 return 'T';
+2 -5
src/applications/maniphest/search/ManiphestSearchIndexer.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group maniphest 5 - */ 6 - final class ManiphestSearchIndexer 7 - extends PhabricatorSearchDocumentIndexer { 3 + final class ManiphestSearchIndexer extends PhabricatorSearchDocumentIndexer { 8 4 9 5 public function getIndexableObject() { 10 6 return new ManiphestTask(); ··· 83 79 84 80 return $doc; 85 81 } 82 + 86 83 }
-3
src/applications/maniphest/storage/ManiphestDAO.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group maniphest 5 - */ 6 3 abstract class ManiphestDAO extends PhabricatorLiskDAO { 7 4 8 5 public function getApplicationName() {
-2
src/applications/maniphest/storage/ManiphestTaskProject.php
··· 6 6 * efficiently queried. This table is not authoritative; the projectPHIDs field 7 7 * of ManiphestTask is. The rows in this table are regenerated when transactions 8 8 * are applied to tasks which affected their associated projects. 9 - * 10 - * @group maniphest 11 9 */ 12 10 final class ManiphestTaskProject extends ManiphestDAO { 13 11
-3
src/applications/maniphest/storage/ManiphestTaskSubscriber.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group maniphest 5 - */ 6 3 final class ManiphestTaskSubscriber extends ManiphestDAO { 7 4 8 5 protected $taskPHID;
-3
src/applications/maniphest/view/ManiphestTaskListView.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group maniphest 5 - */ 6 3 final class ManiphestTaskListView extends ManiphestView { 7 4 8 5 private $tasks;
-1
src/applications/metamta/view/PhabricatorMetaMTAMailBody.php
··· 5 5 * 6 6 * @task compose Composition 7 7 * @task render Rendering 8 - * @group metamta 9 8 */ 10 9 final class PhabricatorMetaMTAMailBody { 11 10
-6
src/applications/metamta/view/__tests__/PhabricatorMetaMTAMailBodyTestCase.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group metamta 5 - */ 6 3 final class PhabricatorMetaMTAMailBodyTestCase extends PhabricatorTestCase { 7 - 8 4 9 5 public function testBodyRender() { 10 6 $expect = <<<EOTEXT ··· 24 20 25 21 $this->assertEmail($expect, true, true); 26 22 } 27 - 28 23 29 24 public function testBodyRenderNoHerald() { 30 25 $expect = <<<EOTEXT ··· 73 68 74 69 $this->assertEqual($expect, $body->render()); 75 70 } 76 - 77 71 78 72 }
-3
src/applications/nuance/conduit/ConduitAPI_nuance_Method.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group conduit 5 - */ 6 3 abstract class ConduitAPI_nuance_Method extends ConduitAPIMethod { 7 4 8 5 public function getApplication() {
-3
src/applications/nuance/conduit/ConduitAPI_nuance_createitem_Method.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group conduit 5 - */ 6 3 final class ConduitAPI_nuance_createitem_Method 7 4 extends ConduitAPI_nuance_Method { 8 5
+3 -3
src/applications/oauthserver/PhabricatorOAuthResponse.php
··· 1 1 <?php 2 2 3 - /* 4 - * @group oauthserver 5 - */ 6 3 final class PhabricatorOAuthResponse extends AphrontResponse { 7 4 8 5 private $state; ··· 47 44 private function getError() { 48 45 return $this->error; 49 46 } 47 + 50 48 public function setError($error) { 51 49 // errors sometimes redirect to the client (302) but otherwise 52 50 // the spec says all code 400 ··· 60 58 private function getErrorDescription() { 61 59 return $this->errorDescription; 62 60 } 61 + 63 62 public function setErrorDescription($error_description) { 64 63 $this->errorDescription = $error_description; 65 64 return $this; ··· 104 103 public function buildResponseString() { 105 104 return $this->encodeJSONForHTTPResponse($this->buildResponseDict()); 106 105 } 106 + 107 107 }
+2 -10
src/applications/oauthserver/PhabricatorOAuthServer.php
··· 12 12 * For an OAuth 2.0 server, there are two main steps: 13 13 * 14 14 * 1) Authorization - the user authorizes a given client to access the data 15 - * the OAuth 2.0 server protects. Once this is achieved / if it has 15 + * the OAuth 2.0 server protects. Once this is achieved / if it has 16 16 * been achived already, the OAuth server sends the client an authorization 17 17 * code. 18 18 * 2) Access Token - the client should send the authorization code received in 19 19 * step 1 along with its id and secret to the OAuth server to receive an 20 - * access token. This access token can later be used to access Phabricator 20 + * access token. This access token can later be used to access Phabricator 21 21 * data on behalf of the user. 22 22 * 23 23 * @task auth Authorizing @{class:PhabricatorOAuthServerClient}s and ··· 25 25 * @task token Validating @{class:PhabricatorOAuthServerAuthorizationCode}s 26 26 * and generating @{class:PhabricatorOAuthServerAccessToken}s 27 27 * @task internal Internals 28 - * 29 - * @group oauthserver 30 28 */ 31 29 final class PhabricatorOAuthServer { 32 30 ··· 36 34 private $user; 37 35 private $client; 38 36 39 - /** 40 - * @group internal 41 - */ 42 37 private function getUser() { 43 38 if (!$this->user) { 44 39 throw new Exception('You must setUser before you can getUser!'); ··· 51 46 return $this; 52 47 } 53 48 54 - /** 55 - * @group internal 56 - */ 57 49 private function getClient() { 58 50 if (!$this->client) { 59 51 throw new Exception('You must setClient before you can getClient!');
+1 -1
src/applications/oauthserver/PhabricatorOAuthServerScope.php
··· 63 63 64 64 /** 65 65 * A scopes list is considered valid if each scope is a known scope 66 - * and each scope is seen only once. Otherwise, the list is invalid. 66 + * and each scope is seen only once. Otherwise, the list is invalid. 67 67 */ 68 68 static public function validateScopesList($scope_list) { 69 69 $scopes = explode(' ', $scope_list);
+1 -4
src/applications/oauthserver/controller/PhabricatorOAuthServerAuthController.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group oauthserver 5 - */ 6 3 final class PhabricatorOAuthServerAuthController 7 - extends PhabricatorAuthController { 4 + extends PhabricatorAuthController { 8 5 9 6 public function shouldRequireLogin() { 10 7 return true;
+2 -4
src/applications/oauthserver/controller/PhabricatorOAuthServerTokenController.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group oauthserver 5 - */ 6 3 final class PhabricatorOAuthServerTokenController 7 - extends PhabricatorAuthController { 4 + extends PhabricatorAuthController { 8 5 9 6 public function shouldRequireLogin() { 10 7 return false; ··· 137 134 return $response; 138 135 } 139 136 } 137 + 140 138 }
+2 -4
src/applications/oauthserver/storage/PhabricatorOAuthServerAccessToken.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group oauthserver 5 - */ 6 3 final class PhabricatorOAuthServerAccessToken 7 - extends PhabricatorOAuthServerDAO { 4 + extends PhabricatorOAuthServerDAO { 5 + 8 6 protected $id; 9 7 protected $token; 10 8 protected $userPHID;
+1 -4
src/applications/oauthserver/storage/PhabricatorOAuthServerAuthorizationCode.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group oauthserver 5 - */ 6 3 final class PhabricatorOAuthServerAuthorizationCode 7 - extends PhabricatorOAuthServerDAO { 4 + extends PhabricatorOAuthServerDAO { 8 5 9 6 protected $id; 10 7 protected $code;
+2 -3
src/applications/oauthserver/storage/PhabricatorOAuthServerDAO.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group oauthserver 5 - */ 6 3 abstract class PhabricatorOAuthServerDAO extends PhabricatorLiskDAO { 4 + 7 5 public function getApplicationName() { 8 6 return 'oauth_server'; 9 7 } 8 + 10 9 }
+3 -8
src/applications/owners/conduit/ConduitAPI_owners_query_Method.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group conduit 5 - */ 6 - final class ConduitAPI_owners_query_Method 7 - extends ConduitAPI_owners_Method { 3 + final class ConduitAPI_owners_query_Method extends ConduitAPI_owners_Method { 8 4 9 5 public function getMethodDescription() { 10 6 return 'Query for packages by one of the following: repository/path, '. ··· 21 17 'repositoryCallsign' => 'optional string', 22 18 'path' => 'optional string', 23 19 ); 24 - 25 20 } 26 21 27 22 public function defineReturnType() { ··· 120 115 $request->getValue('projectOwner')) ? 121 116 1 : 0; 122 117 123 - $is_affiliated_query = $request->getValue('userAffiliated') ? 124 - 1 : 0; 118 + $is_affiliated_query = $request->getValue('userAffiliated') ? 1 : 0; 125 119 126 120 $repo = $request->getValue('repositoryCallsign'); 127 121 $path = $request->getValue('path'); ··· 155 149 156 150 return self::buildPackageInformationDictionaries($packages); 157 151 } 152 + 158 153 }
-3
src/applications/paste/conduit/ConduitAPI_paste_Method.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group conduit 5 - */ 6 3 abstract class ConduitAPI_paste_Method extends ConduitAPIMethod { 7 4 8 5 public function getApplication() {
-3
src/applications/paste/conduit/ConduitAPI_paste_create_Method.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group conduit 5 - */ 6 3 final class ConduitAPI_paste_create_Method extends ConduitAPI_paste_Method { 7 4 8 5 public function getMethodDescription() {
-3
src/applications/paste/conduit/ConduitAPI_paste_info_Method.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group conduit 5 - */ 6 3 final class ConduitAPI_paste_info_Method extends ConduitAPI_paste_Method { 7 4 8 5 public function getMethodStatus() {
-3
src/applications/paste/conduit/ConduitAPI_paste_query_Method.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group conduit 5 - */ 6 3 final class ConduitAPI_paste_query_Method extends ConduitAPI_paste_Method { 7 4 8 5 public function getMethodDescription() {
-3
src/applications/paste/config/PhabricatorPasteConfigOptions.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group paste 5 - */ 6 3 final class PhabricatorPasteConfigOptions 7 4 extends PhabricatorApplicationConfigOptions { 8 5
-3
src/applications/paste/controller/PhabricatorPasteCommentController.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group paste 5 - */ 6 3 final class PhabricatorPasteCommentController 7 4 extends PhabricatorPasteController { 8 5
-3
src/applications/paste/controller/PhabricatorPasteController.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group paste 5 - */ 6 3 abstract class PhabricatorPasteController extends PhabricatorController { 7 4 8 5 public function buildSideNavView($for_app = false) {
-4
src/applications/paste/controller/PhabricatorPasteEditController.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group paste 5 - */ 6 3 final class PhabricatorPasteEditController extends PhabricatorPasteController { 7 4 8 5 private $id; ··· 10 7 public function willProcessRequest(array $data) { 11 8 $this->id = idx($data, 'id'); 12 9 } 13 - 14 10 15 11 public function processRequest() { 16 12 $request = $this->getRequest();
+1 -6
src/applications/paste/mail/PasteCreateMailReceiver.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group paste 5 - */ 6 - final class PasteCreateMailReceiver 7 - extends PhabricatorMailReceiver { 3 + final class PasteCreateMailReceiver extends PhabricatorMailReceiver { 8 4 9 5 public function isEnabled() { 10 6 $app_class = 'PhabricatorApplicationPaste'; ··· 87 83 ->setRelatedPHID($paste->getPHID()) 88 84 ->setBody($body->render()) 89 85 ->saveAndSend(); 90 - 91 86 } 92 87 93 88 }
-3
src/applications/paste/mail/PasteMockMailReceiver.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group paste 5 - */ 6 3 final class PasteMockMailReceiver extends PhabricatorObjectMailReceiver { 7 4 8 5 public function isEnabled() {
-4
src/applications/paste/mail/PasteReplyHandler.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group paste 5 - */ 6 3 final class PasteReplyHandler extends PhabricatorMailReplyHandler { 7 4 8 5 public function validateMailReceiver($mail_receiver) { ··· 78 75 79 76 $head_xaction = head($xactions); 80 77 return $head_xaction->getID(); 81 - 82 78 } 83 79 84 80 }
-5
src/applications/paste/query/PhabricatorPasteQuery.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group paste 5 - */ 6 3 final class PhabricatorPasteQuery 7 4 extends PhabricatorCursorPagedPolicyAwareQuery { 8 5 ··· 239 236 return $results; 240 237 } 241 238 242 - 243 239 private function buildContent(PhabricatorPaste $paste) { 244 240 $language = $paste->getLanguage(); 245 241 $source = $paste->getRawContent(); ··· 254 250 $source); 255 251 } 256 252 } 257 - 258 253 259 254 public function getQueryApplicationClass() { 260 255 return 'PhabricatorApplicationPaste';
-3
src/applications/paste/query/PhabricatorPasteTransactionQuery.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group paste 5 - */ 6 3 final class PhabricatorPasteTransactionQuery 7 4 extends PhabricatorApplicationTransactionQuery { 8 5
+2 -5
src/applications/paste/remarkup/PhabricatorPasteRemarkupRule.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group markup 5 - */ 6 - final class PhabricatorPasteRemarkupRule 7 - extends PhabricatorRemarkupRuleObject { 3 + final class PhabricatorPasteRemarkupRule extends PhabricatorRemarkupRuleObject { 8 4 9 5 protected function getObjectNamePrefix() { 10 6 return 'P'; ··· 56 52 57 53 return $embed_paste; 58 54 } 55 + 59 56 }
+1 -3
src/applications/paste/storage/PhabricatorPasteTransactionComment.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group paste 5 - */ 6 3 final class PhabricatorPasteTransactionComment 7 4 extends PhabricatorApplicationTransactionComment { 8 5 ··· 17 14 // Only cache submitted comments. 18 15 return ($this->getTransactionPHID() != null); 19 16 } 17 + 20 18 }
+1 -5
src/applications/people/conduit/ConduitAPI_user_disable_Method.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group conduit 5 - */ 6 - final class ConduitAPI_user_disable_Method 7 - extends ConduitAPI_user_Method { 3 + final class ConduitAPI_user_disable_Method extends ConduitAPI_user_Method { 8 4 9 5 public function getMethodDescription() { 10 6 return 'Permanently disable specified users (admin only).';
+1 -5
src/applications/people/conduit/ConduitAPI_user_enable_Method.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group conduit 5 - */ 6 - final class ConduitAPI_user_enable_Method 7 - extends ConduitAPI_user_Method { 3 + final class ConduitAPI_user_enable_Method extends ConduitAPI_user_Method { 8 4 9 5 public function getMethodDescription() { 10 6 return 'Re-enable specified users (admin only).';
+1 -6
src/applications/people/conduit/ConduitAPI_user_info_Method.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group conduit 5 - */ 6 - final class ConduitAPI_user_info_Method 7 - extends ConduitAPI_user_Method { 3 + final class ConduitAPI_user_info_Method extends ConduitAPI_user_Method { 8 4 9 5 public function getMethodStatus() { 10 6 return self::METHOD_STATUS_DEPRECATED; ··· 35 31 } 36 32 37 33 protected function execute(ConduitAPIRequest $request) { 38 - 39 34 $user = id(new PhabricatorUser())->loadOneWhere( 40 35 'phid = %s', 41 36 $request->getValue('phid'));
+2 -6
src/applications/people/conduit/ConduitAPI_user_query_Method.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group conduit 5 - */ 6 - final class ConduitAPI_user_query_Method 7 - extends ConduitAPI_user_Method { 3 + final class ConduitAPI_user_query_Method extends ConduitAPI_user_Method { 8 4 9 5 public function getMethodDescription() { 10 6 return 'Query users.'; 11 7 } 12 8 13 9 public function defineParamTypes() { 14 - 15 10 return array( 16 11 'usernames' => 'optional list<string>', 17 12 'emails' => 'optional list<string>', ··· 80 75 } 81 76 return $results; 82 77 } 78 + 83 79 }
+3 -9
src/applications/people/conduit/ConduitAPI_user_whoami_Method.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group conduit 5 - */ 6 - final class ConduitAPI_user_whoami_Method 7 - extends ConduitAPI_user_Method { 3 + final class ConduitAPI_user_whoami_Method extends ConduitAPI_user_Method { 8 4 9 5 public function getMethodDescription() { 10 6 return 'Retrieve information about the logged-in user.'; 11 7 } 12 8 13 9 public function defineParamTypes() { 14 - return array( 15 - ); 10 + return array(); 16 11 } 17 12 18 13 public function defineReturnType() { ··· 20 15 } 21 16 22 17 public function defineErrorTypes() { 23 - return array( 24 - ); 18 + return array(); 25 19 } 26 20 27 21 public function getRequiredScope() {
+1 -5
src/applications/people/remarkup/PhabricatorRemarkupRuleMention.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group markup 5 - */ 6 - final class PhabricatorRemarkupRuleMention 7 - extends PhutilRemarkupRule { 3 + final class PhabricatorRemarkupRuleMention extends PhutilRemarkupRule { 8 4 9 5 const KEY_RULE_MENTION = 'rule.mention'; 10 6 const KEY_RULE_MENTION_ORIGINAL = 'rule.mention.original';
-3
src/applications/phame/conduit/ConduitAPI_phame_Method.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group conduit 5 - */ 6 3 abstract class ConduitAPI_phame_Method extends ConduitAPIMethod { 7 4 8 5 public function getApplication() {
+1 -7
src/applications/phame/conduit/ConduitAPI_phame_query_Method.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group conduit 5 - */ 6 3 final class ConduitAPI_phame_query_Method extends ConduitAPI_phame_Method { 7 4 8 5 public function getMethodDescription() { ··· 28 25 } 29 26 30 27 public function defineErrorTypes() { 31 - return array( 32 - ); 28 + return array(); 33 29 } 34 30 35 31 protected function execute(ConduitAPIRequest $request) { 36 - 37 32 $query = new PhameBlogQuery(); 38 33 39 34 $query->setViewer($request->getUser()); ··· 79 74 80 75 return $results; 81 76 } 82 - 83 77 84 78 }
-5
src/applications/phame/conduit/ConduitAPI_phame_queryposts_Method.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group conduit 5 - */ 6 3 final class ConduitAPI_phame_queryposts_Method extends ConduitAPI_phame_Method { 7 4 8 5 public function getMethodDescription() { ··· 38 35 } 39 36 40 37 protected function execute(ConduitAPIRequest $request) { 41 - 42 38 $query = new PhamePostQuery(); 43 39 44 40 $query->setViewer($request->getUser()); ··· 104 100 105 101 return $results; 106 102 } 107 - 108 103 109 104 }
-3
src/applications/phame/controller/PhameResourceController.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group phame 5 - */ 6 3 final class PhameResourceController extends CelerityResourceController { 7 4 8 5 private $id;
+1 -3
src/applications/phame/controller/blog/PhameBlogDeleteController.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group phame 5 - */ 6 3 final class PhameBlogDeleteController extends PhameController { 7 4 8 5 private $id; ··· 47 44 48 45 return id(new AphrontDialogResponse())->setDialog($dialog); 49 46 } 47 + 50 48 }
-3
src/applications/phame/controller/blog/PhameBlogFeedController.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group phame 5 - */ 6 3 final class PhameBlogFeedController extends PhameController { 7 4 8 5 private $id;
-3
src/applications/phame/controller/blog/PhameBlogListController.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group phame 5 - */ 6 3 final class PhameBlogListController extends PhameController { 7 4 8 5 private $filter;
-3
src/applications/phame/controller/blog/PhameBlogLiveController.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group phame 5 - */ 6 3 final class PhameBlogLiveController extends PhameController { 7 4 8 5 private $id;
-4
src/applications/phame/controller/blog/PhameBlogViewController.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group phame 5 - */ 6 3 final class PhameBlogViewController extends PhameController { 7 4 8 5 private $id; ··· 141 138 } 142 139 143 140 private function renderActions(PhameBlog $blog, PhabricatorUser $user) { 144 - 145 141 $actions = id(new PhabricatorActionListView()) 146 142 ->setObject($blog) 147 143 ->setObjectURI($this->getRequest()->getRequestURI())
+1 -3
src/applications/phame/controller/post/PhamePostDeleteController.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group phame 5 - */ 6 3 final class PhamePostDeleteController extends PhameController { 7 4 8 5 private $id; ··· 47 44 48 45 return id(new AphrontDialogResponse())->setDialog($dialog); 49 46 } 47 + 50 48 }
+1 -5
src/applications/phame/controller/post/PhamePostEditController.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group phame 5 - */ 6 - final class PhamePostEditController 7 - extends PhameController { 3 + final class PhamePostEditController extends PhameController { 8 4 9 5 private $id; 10 6
+1 -3
src/applications/phame/controller/post/PhamePostFramedController.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group phame 5 - */ 6 3 final class PhamePostFramedController extends PhameController { 7 4 8 5 private $id; ··· 44 41 $response->setFrameable(true); 45 42 return $response; 46 43 } 44 + 47 45 }
-4
src/applications/phame/controller/post/PhamePostListController.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group phame 5 - */ 6 3 final class PhamePostListController extends PhameController { 7 4 8 5 private $bloggername; ··· 92 89 'title' => $title, 93 90 )); 94 91 } 95 - 96 92 97 93 }
+1 -3
src/applications/phame/controller/post/PhamePostNewController.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group phame 5 - */ 6 3 final class PhamePostNewController extends PhameController { 7 4 8 5 private $id; ··· 127 124 'title' => $title, 128 125 )); 129 126 } 127 + 130 128 }
+1 -3
src/applications/phame/controller/post/PhamePostNotLiveController.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group phame 5 - */ 6 3 final class PhamePostNotLiveController extends PhameController { 7 4 8 5 private $id; ··· 57 54 $live_uri = $post->getViewURI(); 58 55 return id(new AphrontRedirectResponse())->setURI($live_uri); 59 56 } 57 + 60 58 }
+2 -5
src/applications/phame/controller/post/PhamePostPreviewController.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group phame 5 - */ 6 - final class PhamePostPreviewController 7 - extends PhameController { 3 + final class PhamePostPreviewController extends PhameController { 8 4 9 5 protected function getSideNavFilter() { 10 6 return null; ··· 27 23 28 24 return id(new AphrontAjaxResponse())->setContent($content); 29 25 } 26 + 30 27 }
+1 -3
src/applications/phame/controller/post/PhamePostPublishController.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group phame 5 - */ 6 3 final class PhamePostPublishController extends PhameController { 7 4 8 5 private $id; ··· 86 83 ), 87 84 '')); 88 85 } 86 + 89 87 }
+1 -3
src/applications/phame/controller/post/PhamePostUnpublishController.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group phame 5 - */ 6 3 final class PhamePostUnpublishController extends PhameController { 7 4 8 5 private $id; ··· 51 48 52 49 return id(new AphrontDialogResponse())->setDialog($dialog); 53 50 } 51 + 54 52 }
+1 -3
src/applications/phame/controller/post/PhamePostViewController.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group phame 5 - */ 6 3 final class PhamePostViewController extends PhameController { 7 4 8 5 private $id; ··· 203 200 204 201 return $properties; 205 202 } 203 + 206 204 }
-3
src/applications/phame/phid/PhabricatorPhamePHIDTypeBlog.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group phame 5 - */ 6 3 final class PhabricatorPhamePHIDTypeBlog extends PhabricatorPHIDType { 7 4 8 5 const TYPECONST = 'BLOG';
-3
src/applications/phame/phid/PhabricatorPhamePHIDTypePost.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group phame 5 - */ 6 3 final class PhabricatorPhamePHIDTypePost extends PhabricatorPHIDType { 7 4 8 5 const TYPECONST = 'POST';
-3
src/applications/phame/query/PhameBlogQuery.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group phame 5 - */ 6 3 final class PhameBlogQuery extends PhabricatorCursorPagedPolicyAwareQuery { 7 4 8 5 private $ids;
-3
src/applications/phame/query/PhamePostQuery.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group phame 5 - */ 6 3 final class PhamePostQuery extends PhabricatorCursorPagedPolicyAwareQuery { 7 4 8 5 private $ids;
-1
src/applications/phame/skins/PhameBasicBlogSkin.php
··· 3 3 /** 4 4 * @task paging Paging 5 5 * @task internal Internals 6 - * @group phame 7 6 */ 8 7 abstract class PhameBasicBlogSkin extends PhameBlogSkin { 9 8
-3
src/applications/phame/skins/PhameBasicTemplateBlogSkin.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group phame 5 - */ 6 3 final class PhameBasicTemplateBlogSkin extends PhameBasicBlogSkin { 7 4 8 5 private $cssResources;
-3
src/applications/phame/skins/PhameBlogSkin.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group phame 5 - */ 6 3 abstract class PhameBlogSkin extends PhabricatorController { 7 4 8 5 private $blog;
-4
src/applications/phame/skins/PhameSkinSpecification.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group phame 5 - */ 6 3 final class PhameSkinSpecification { 7 4 8 5 const TYPE_ADVANCED = 'advanced'; ··· 16 13 private $config; 17 14 18 15 public static function loadAllSkinSpecifications() { 19 - 20 16 static $specs; 21 17 22 18 if ($specs === null) {
-3
src/applications/phame/storage/PhameDAO.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group phame 5 - */ 6 3 abstract class PhameDAO extends PhabricatorLiskDAO { 7 4 8 5 public function getApplicationName() {
-3
src/applications/phame/view/PhamePostView.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group phame 5 - */ 6 3 final class PhamePostView extends AphrontView { 7 4 8 5 private $post;
-3
src/applications/phid/conduit/ConduitAPI_phid_Method.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group conduit 5 - */ 6 3 abstract class ConduitAPI_phid_Method extends ConduitAPIMethod { 7 4 8 5 protected function buildHandleInformationDictionary(
+1 -6
src/applications/phid/conduit/ConduitAPI_phid_info_Method.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group conduit 5 - */ 6 - final class ConduitAPI_phid_info_Method 7 - extends ConduitAPI_phid_Method { 3 + final class ConduitAPI_phid_info_Method extends ConduitAPI_phid_Method { 8 4 9 5 public function getMethodStatus() { 10 6 return self::METHOD_STATUS_DEPRECATED; ··· 35 31 } 36 32 37 33 protected function execute(ConduitAPIRequest $request) { 38 - 39 34 $phid = $request->getValue('phid'); 40 35 41 36 $handle = id(new PhabricatorHandleQuery())
+1 -5
src/applications/phid/conduit/ConduitAPI_phid_lookup_Method.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group conduit 5 - */ 6 - final class ConduitAPI_phid_lookup_Method 7 - extends ConduitAPI_phid_Method { 3 + final class ConduitAPI_phid_lookup_Method extends ConduitAPI_phid_Method { 8 4 9 5 public function getMethodDescription() { 10 6 return 'Look up objects by name.';
+1 -6
src/applications/phid/conduit/ConduitAPI_phid_query_Method.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group conduit 5 - */ 6 - final class ConduitAPI_phid_query_Method 7 - extends ConduitAPI_phid_Method { 3 + final class ConduitAPI_phid_query_Method extends ConduitAPI_phid_Method { 8 4 9 5 public function getMethodDescription() { 10 6 return 'Retrieve information about arbitrary PHIDs.'; ··· 25 21 } 26 22 27 23 protected function execute(ConduitAPIRequest $request) { 28 - 29 24 $phids = $request->getValue('phids'); 30 25 31 26 $handles = id(new PhabricatorHandleQuery())
-1
src/applications/phid/handle/view/render.php
··· 4 4 * Implodes selected handles from a pool of handles. Useful if you load handles 5 5 * for various phids, but only render a few of them at a time. 6 6 * 7 - * @group handle 8 7 * @return PhutilSafeHTML 9 8 */ 10 9 function implode_selected_handle_links($glue, array $handles, array $phids) {
-3
src/applications/pholio/config/PhabricatorPholioConfigOptions.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group pholio 5 - */ 6 3 final class PhabricatorPholioConfigOptions 7 4 extends PhabricatorApplicationConfigOptions { 8 5
+1 -6
src/applications/pholio/constants/PholioConstants.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group pholio 5 - */ 6 - abstract class PholioConstants { 7 - 8 - } 3 + abstract class PholioConstants {}
+1 -3
src/applications/pholio/constants/PholioTransactionType.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group pholio 5 - */ 6 3 final class PholioTransactionType extends PholioConstants { 7 4 8 5 /* edits to the high level mock */ ··· 19 16 20 17 /* your witty commentary at the mock : image : x,y level */ 21 18 const TYPE_INLINE = 'inline'; 19 + 22 20 }
-5
src/applications/pholio/controller/PholioController.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group pholio 5 - */ 6 3 abstract class PholioController extends PhabricatorController { 7 4 8 5 public function buildSideNavView($for_app = false) { ··· 39 36 public function buildApplicationMenu() { 40 37 return $this->buildSideNavView(true)->getMenu(); 41 38 } 42 - 43 - 44 39 45 40 }
-3
src/applications/pholio/controller/PholioImageUploadController.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group pholio 5 - */ 6 3 final class PholioImageUploadController extends PholioController { 7 4 8 5 public function processRequest() {
-3
src/applications/pholio/controller/PholioInlineThumbController.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group pholio 5 - */ 6 3 final class PholioInlineThumbController extends PholioController { 7 4 8 5 private $imageid;
-3
src/applications/pholio/controller/PholioMockCommentController.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group pholio 5 - */ 6 3 final class PholioMockCommentController extends PholioController { 7 4 8 5 private $id;
-3
src/applications/pholio/controller/PholioMockEditController.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group pholio 5 - */ 6 3 final class PholioMockEditController extends PholioController { 7 4 8 5 private $id;
-3
src/applications/pholio/editor/PholioMockEditor.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group pholio 5 - */ 6 3 final class PholioMockEditor extends PhabricatorApplicationTransactionEditor { 7 4 8 5 private $newImages = array();
-4
src/applications/pholio/lipsum/PhabricatorPholioMockTestDataGenerator.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group pholio 5 - */ 6 3 final class PhabricatorPholioMockTestDataGenerator 7 4 extends PhabricatorTestDataGenerator { 8 5 ··· 106 103 } 107 104 return $rand_images; 108 105 } 109 - 110 106 111 107 }
-5
src/applications/pholio/mail/PholioMockMailReceiver.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group pholio 5 - */ 6 3 final class PholioMockMailReceiver extends PhabricatorObjectMailReceiver { 7 4 8 5 public function isEnabled() { ··· 29 26 PhabricatorUser $sender) { 30 27 31 28 // TODO: For now, we just drop this mail on the floor. 32 - 33 29 } 34 - 35 30 36 31 }
-3
src/applications/pholio/mail/PholioReplyHandler.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group pholio 5 - */ 6 3 final class PholioReplyHandler extends PhabricatorMailReplyHandler { 7 4 8 5 public function validateMailReceiver($mail_receiver) {
-3
src/applications/pholio/query/PholioMockQuery.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group pholio 5 - */ 6 3 final class PholioMockQuery 7 4 extends PhabricatorCursorPagedPolicyAwareQuery { 8 5
-3
src/applications/pholio/query/PholioTransactionQuery.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group pholio 5 - */ 6 3 final class PholioTransactionQuery 7 4 extends PhabricatorApplicationTransactionQuery { 8 5
+1 -3
src/applications/pholio/search/PholioSearchIndexer.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group pholio 5 - */ 6 3 final class PholioSearchIndexer extends PhabricatorSearchDocumentIndexer { 7 4 8 5 public function getIndexableObject() { ··· 34 31 35 32 return $doc; 36 33 } 34 + 37 35 }
-3
src/applications/pholio/storage/PholioDAO.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group pholio 5 - */ 6 3 abstract class PholioDAO extends PhabricatorLiskDAO { 7 4 8 5 public function getApplicationName() {
-3
src/applications/pholio/storage/PholioImage.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group pholio 5 - */ 6 3 final class PholioImage extends PholioDAO 7 4 implements 8 5 PhabricatorMarkupInterface,
+1 -3
src/applications/pholio/storage/PholioTransactionComment.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group pholio 5 - */ 6 3 final class PholioTransactionComment 7 4 extends PhabricatorApplicationTransactionComment { 8 5 ··· 33 30 // Only cache submitted comments. 34 31 return ($this->getTransactionPHID() != null); 35 32 } 33 + 36 34 }
+1 -3
src/applications/pholio/view/PholioMockEmbedView.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group pholio 5 - */ 6 3 final class PholioMockEmbedView extends AphrontView { 7 4 8 5 private $mock; ··· 53 50 54 51 return $item; 55 52 } 53 + 56 54 }
-3
src/applications/pholio/view/PholioMockImagesView.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group pholio 5 - */ 6 3 final class PholioMockImagesView extends AphrontView { 7 4 8 5 private $mock;
-3
src/applications/pholio/view/PholioTransactionView.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group pholio 5 - */ 6 3 final class PholioTransactionView 7 4 extends PhabricatorApplicationTransactionView { 8 5
-3
src/applications/pholio/view/PholioUploadedImageView.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group pholio 5 - */ 6 3 final class PholioUploadedImageView extends AphrontView { 7 4 8 5 private $image;
-3
src/applications/phragment/conduit/ConduitAPI_phragment_Method.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group conduit 5 - */ 6 3 abstract class ConduitAPI_phragment_Method extends ConduitAPIMethod { 7 4 8 5 public function getApplication() {
+2 -5
src/applications/phragment/conduit/ConduitAPI_phragment_getpatch_Method.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group conduit 5 - */ 6 3 final class ConduitAPI_phragment_getpatch_Method 7 4 extends ConduitAPI_phragment_Method { 8 5 ··· 99 96 } else { 100 97 // If $mappings[$path] does not exist, then the user has a file, 101 98 // and we have absolutely no record of it what-so-ever (we haven't 102 - // even recorded a deletion). Assuming most applications will store 99 + // even recorded a deletion). Assuming most applications will store 103 100 // some form of data near their own files, this is probably a data 104 101 // file relevant for the application that is not versioned, so we 105 102 // don't tell the client to do anything with it. ··· 115 112 $file_phid = $mappings[$path]->getLatestVersion()->getFilePHID(); 116 113 if ($file_phid !== null) { 117 114 // If the file PHID is present, then this is a new file that 118 - // we know about, but the caller does not. We need to tell 115 + // we know about, but the caller does not. We need to tell 119 116 // the caller to create the file. 120 117 $hash_current = $files[$file_phid]->getContentHash(); 121 118 $patches[] = array(
-3
src/applications/phragment/conduit/ConduitAPI_phragment_queryfragments_Method.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group conduit 5 - */ 6 3 final class ConduitAPI_phragment_queryfragments_Method 7 4 extends ConduitAPI_phragment_Method { 8 5
+2 -2
src/applications/phragment/controller/PhragmentController.php
··· 210 210 ->appendChild(phutil_tag('p', array(), pht( 211 211 'Because Phragment generates files (such as ZIP archives and '. 212 212 'patches) as they are requested, it requires that you configure '. 213 - 'the `security.alterate-file-domain` option. This option on it\'s '. 213 + 'the `security.alterate-file-domain` option. This option on it\'s '. 214 214 'own will also provide additional security when serving files '. 215 215 'across Phabricator.'))); 216 216 } ··· 219 219 220 220 /** 221 221 * We use this to disable the download links if the alternate domain is 222 - * not configured correctly. Although the download links will mostly work 222 + * not configured correctly. Although the download links will mostly work 223 223 * for logged in users without an alternate domain, the behaviour is 224 224 * reasonably non-consistent and will deny public users, even if policies 225 225 * are configured otherwise (because the Files app does not support showing
+1 -1
src/applications/phragment/controller/PhragmentRevertController.php
··· 78 78 ->addCancelButton(pht('Cancel')) 79 79 ->appendParagraph(pht( 80 80 'Reverting this fragment to version %d will create a new version of '. 81 - 'the fragment. It will not delete any version history.', 81 + 'the fragment. It will not delete any version history.', 82 82 $version->getSequence(), 83 83 $version->getSequence())); 84 84 return id(new AphrontDialogResponse())->setDialog($dialog);
+1 -1
src/applications/phragment/controller/PhragmentSnapshotDeleteController.php
··· 45 45 ->addSubmitButton(pht('Delete')) 46 46 ->addCancelButton(pht('Cancel')) 47 47 ->appendParagraph(pht( 48 - 'Deleting this snapshot is a permanent operation. You can not '. 48 + 'Deleting this snapshot is a permanent operation. You can not '. 49 49 'recover the state of the snapshot.')); 50 50 return id(new AphrontDialogResponse())->setDialog($dialog); 51 51 }
+1 -1
src/applications/phragment/controller/PhragmentSnapshotPromoteController.php
··· 130 130 ->save(); 131 131 } 132 132 } else { 133 - // The user is promoting the snapshot to another snapshot. We just 133 + // The user is promoting the snapshot to another snapshot. We just 134 134 // copy the other snapshot's child entries and change the snapshot 135 135 // PHID to make it identical. 136 136 $children = id(new PhragmentSnapshotChildQuery())
+4 -4
src/applications/phragment/storage/PhragmentFragment.php
··· 158 158 $path = trim($zip->getNameIndex($i), '/'); 159 159 $stream = $zip->getStream($path); 160 160 $data = null; 161 - // If the stream is false, then it is a directory entry. We leave 161 + // If the stream is false, then it is a directory entry. We leave 162 162 // $data set to null for directories so we know not to create a 163 163 // version entry for them. 164 164 if ($stream !== false) { ··· 169 169 } 170 170 171 171 // We need to detect any directories that are in the ZIP folder that 172 - // aren't explicitly noted in the ZIP. This can happen if the file 172 + // aren't explicitly noted in the ZIP. This can happen if the file 173 173 // entries in the ZIP look like: 174 174 // 175 175 // * something/blah.png ··· 204 204 } 205 205 206 206 // FIXME: What happens when a child exists, but the current user 207 - // can't see it. We're going to create a new child with the exact 207 + // can't see it. We're going to create a new child with the exact 208 208 // same path and then bad things will happen. 209 209 $children = id(new PhragmentFragmentQuery()) 210 210 ->setViewer($viewer) ··· 237 237 // Iterate over the mappings to find new files. 238 238 foreach ($mappings as $path => $data) { 239 239 if (!array_key_exists($base_path.'/'.$path, $children)) { 240 - // The file is being created. If the data is null, 240 + // The file is being created. If the data is null, 241 241 // then this is explicitly a directory being created. 242 242 $file = null; 243 243 if ($mappings[$path] !== null) {
-3
src/applications/phrequent/storage/PhrequentDAO.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group phrequent 5 - */ 6 3 abstract class PhrequentDAO extends PhabricatorLiskDAO { 7 4 8 5 public function getApplicationName() {
-3
src/applications/phriction/conduit/ConduitAPI_phriction_Method.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group conduit 5 - */ 6 3 abstract class ConduitAPI_phriction_Method extends ConduitAPIMethod { 7 4 8 5 public function getApplication() {
-3
src/applications/phriction/constants/PhrictionActionConstants.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group phriction 5 - */ 6 3 final class PhrictionActionConstants extends PhrictionConstants { 7 4 8 5 const ACTION_CREATE = 'create';
-3
src/applications/phriction/constants/PhrictionChangeType.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group phriction 5 - */ 6 3 final class PhrictionChangeType extends PhrictionConstants { 7 4 8 5 const CHANGE_EDIT = 0;
+1 -6
src/applications/phriction/constants/PhrictionConstants.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group phriction 5 - */ 6 - abstract class PhrictionConstants { 7 - 8 - } 3 + abstract class PhrictionConstants {}
-3
src/applications/phriction/constants/PhrictionDocumentStatus.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group phriction 5 - */ 6 3 final class PhrictionDocumentStatus extends PhrictionConstants { 7 4 8 5 const STATUS_EXISTS = 0;
-3
src/applications/phriction/controller/PhrictionController.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group phriction 5 - */ 6 3 abstract class PhrictionController extends PhabricatorController { 7 4 8 5 public function buildSideNavView($for_app = false) {
+1 -5
src/applications/phriction/controller/PhrictionDiffController.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group phriction 5 - */ 6 - final class PhrictionDiffController 7 - extends PhrictionController { 3 + final class PhrictionDiffController extends PhrictionController { 8 4 9 5 private $id; 10 6
+1 -4
src/applications/phriction/controller/PhrictionDocumentPreviewController.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group phriction 5 - */ 6 3 final class PhrictionDocumentPreviewController 7 4 extends PhrictionController { 8 5 9 6 public function processRequest() { 10 - 11 7 $request = $this->getRequest(); 12 8 $document = $request->getStr('document'); 13 9 ··· 26 22 27 23 return id(new AphrontAjaxResponse())->setContent($content); 28 24 } 25 + 29 26 }
+2 -5
src/applications/phriction/controller/PhrictionMoveController.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group phriction 5 - */ 6 - final class PhrictionMoveController 7 - extends PhrictionController { 3 + final class PhrictionMoveController extends PhrictionController { 8 4 9 5 private $id; 10 6 ··· 161 157 162 158 return id(new AphrontDialogResponse())->setDialog($dialog); 163 159 } 160 + 164 161 }
-2
src/applications/phriction/editor/PhrictionDocumentEditor.php
··· 2 2 3 3 /** 4 4 * Create or update Phriction documents. 5 - * 6 - * @group phriction 7 5 */ 8 6 final class PhrictionDocumentEditor extends PhabricatorEditor { 9 7
+1 -5
src/applications/phriction/remarkup/PhrictionRemarkupRule.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group markup 5 - */ 6 - final class PhrictionRemarkupRule 7 - extends PhutilRemarkupRule { 3 + final class PhrictionRemarkupRule extends PhutilRemarkupRule { 8 4 9 5 public function getPriority() { 10 6 return 350.0;
-2
src/applications/phriction/storage/PhrictionContent.php
··· 2 2 3 3 /** 4 4 * @task markup Markup Interface 5 - * 6 - * @group phriction 7 5 */ 8 6 final class PhrictionContent extends PhrictionDAO 9 7 implements PhabricatorMarkupInterface {
-3
src/applications/phriction/storage/PhrictionDAO.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group phriction 5 - */ 6 3 abstract class PhrictionDAO extends PhabricatorLiskDAO { 7 4 8 5 public function getApplicationName() {
-3
src/applications/phriction/storage/__tests__/PhrictionDocumentTestCase.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group phriction 5 - */ 6 3 final class PhrictionDocumentTestCase extends PhabricatorTestCase { 7 4 8 5 public function testProjectSlugs() {
-3
src/applications/ponder/constants/PonderQuestionStatus.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group ponder 5 - */ 6 3 final class PonderQuestionStatus extends PonderConstants { 7 4 8 5 const STATUS_OPEN = 0;
+1 -3
src/applications/ponder/constants/PonderVote.php
··· 1 1 <?php 2 - /** 3 - * @group ponder 4 - */ 2 + 5 3 final class PonderVote extends PonderConstants { 6 4 7 5 const VOTE_UP = 1;
-3
src/applications/project/conduit/ConduitAPI_project_Method.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group conduit 5 - */ 6 3 abstract class ConduitAPI_project_Method extends ConduitAPIMethod { 7 4 8 5 public function getApplication() {
-3
src/applications/project/conduit/ConduitAPI_project_query_Method.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group conduit 5 - */ 6 3 final class ConduitAPI_project_query_Method extends ConduitAPI_project_Method { 7 4 8 5 public function getMethodDescription() {
+1 -1
src/applications/releeph/conduit/work/ConduitAPI_releephwork_getbranchcommitmessage_Method.php
··· 53 53 $h_branch = $handles[$branch->getPHID()]; 54 54 $h_project = $handles[$project->getPHID()]; 55 55 56 - // Not as customizable as a ReleephRequest's commit message. It doesn't 56 + // Not as customizable as a ReleephRequest's commit message. It doesn't 57 57 // really need to be. 58 58 // TODO: Yes it does, see FB-specific stuff below. 59 59 $commit_message = array();
+1 -1
src/applications/releeph/conduit/work/ConduitAPI_releephwork_nextrequest_Method.php
··· 75 75 * discovered by Phabricator (using the `id` column to perform that 76 76 * ordering). 77 77 * 78 - * This is easy for $needs_pick as the ordinal is stored. It is hard for 78 + * This is easy for $needs_pick as the ordinal is stored. It is hard for 79 79 * reverts, as we have to look that information up. 80 80 */ 81 81 $needs_pick = $this->sortPicks($needs_pick);
+1 -1
src/applications/releeph/conduit/work/ConduitAPI_releephwork_record_Method.php
··· 16 16 * 17 17 * When the daemons discover this commit in the repository with 18 18 * DifferentialReleephRequestFieldSpecification, we'll be able to record the 19 - * commit's PHID as well. That process is slow though, and we don't want to 19 + * commit's PHID as well. That process is slow though, and we don't want to 20 20 * wait a whole minute before marking something as cleanly picked or 21 21 * reverted. 22 22 */
+1 -1
src/applications/releeph/config/PhabricatorApplicationReleephConfigOptions.php
··· 65 65 ->setDescription( 66 66 pht( 67 67 'The default branch template for new branches in unconfigured '. 68 - 'Releeph projects. This is also configurable on a per-project '. 68 + 'Releeph projects. This is also configurable on a per-project '. 69 69 'basis.')), 70 70 ); 71 71 }
+1 -1
src/applications/releeph/controller/request/ReleephRequestDifferentialCreateController.php
··· 70 70 71 71 $dialog->appendChild( 72 72 pht('This differential revision changes code that is associated '. 73 - 'with multiple Releeph branches. '. 73 + 'with multiple Releeph branches. '. 74 74 'Please select the branch where you would like this code to be picked.')); 75 75 76 76 foreach ($branch_groups as $project_id => $branches) {
+2 -2
src/applications/releeph/differential/DifferentialReleephRequestFieldSpecification.php
··· 141 141 * Reviewers: user1 142 142 * 143 143 * Some of these fields are recognized by Differential (e.g. "Requested 144 - * By"). They are folded up into the "Releeph" field, parsed by this 145 - * class. As such $value includes more than just the first-line: 144 + * By"). They are folded up into the "Releeph" field, parsed by this 145 + * class. As such $value includes more than just the first-line: 146 146 * 147 147 * "picks RQ1\n\nRequested By: edward\n\nApproved By: edward (requestor)" 148 148 *
+4 -4
src/applications/releeph/field/specification/ReleephFieldSpecification.php
··· 210 210 private $engine; 211 211 212 212 /** 213 - * ReleephFieldSpecification implements much of PhabricatorMarkupInterface 214 - * for you. If you return true from `shouldMarkup()`, and implement 215 - * `getMarkupText()` then your text will be rendered through the Phabricator 216 - * markup pipeline. 213 + * @{class:ReleephFieldSpecification} implements much of 214 + * @{interface:PhabricatorMarkupInterface} for you. If you return true from 215 + * `shouldMarkup()`, and implement `getMarkupText()` then your text will be 216 + * rendered through the Phabricator markup pipeline. 217 217 * 218 218 * Output is retrievable with `getMarkupEngineOutput()`. 219 219 */
+1 -1
src/applications/releeph/storage/ReleephBranch.php
··· 49 49 // If symbolicName is omitted, set it to the basename. 50 50 // 51 51 // This means that we can enforce symbolicName as a UNIQUE column in the 52 - // DB. We'll interpret symbolicName === basename as meaning "no symbolic 52 + // DB. We'll interpret symbolicName === basename as meaning "no symbolic 53 53 // name". 54 54 // 55 55 // SYMBOLIC_NAME_NOTE
+1 -1
src/applications/releeph/storage/ReleephProject.php
··· 9 9 protected $name; 10 10 11 11 // Specifying the place to pick from is a requirement for svn, though not 12 - // for git. It's always useful though for reasoning about what revs have 12 + // for git. It's always useful though for reasoning about what revs have 13 13 // been picked and which haven't. 14 14 protected $trunkBranch; 15 15
+1 -1
src/applications/releeph/storage/ReleephRequest.php
··· 50 50 $this->getPusherIntent() == self::INTENT_WANT && 51 51 /** 52 52 * We use "!= pass" instead of "== want" in case the requestor intent is 53 - * not present. In other words, only revert if the requestor explicitly 53 + * not present. In other words, only revert if the requestor explicitly 54 54 * passed. 55 55 */ 56 56 $this->getRequestorIntent() != self::INTENT_PASS;
+1 -1
src/applications/releeph/storage/ReleephRequestTransaction.php
··· 254 254 } 255 255 256 256 // ReleephSummaryFieldSpecification is usually blank when an RQ is created, 257 - // creating a transaction change from null to "". Hide these! 257 + // creating a transaction change from null to "". Hide these! 258 258 if ($type === ReleephRequestTransaction::TYPE_EDIT_FIELD) { 259 259 if ($this->getOldValue() === null && $this->getNewValue() === '') { 260 260 return true;
-3
src/applications/repository/PhabricatorRepositoryConfigOptions.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group repository 5 - */ 6 3 final class PhabricatorRepositoryConfigOptions 7 4 extends PhabricatorApplicationConfigOptions { 8 5
-3
src/applications/repository/application/PhabricatorApplicationRepositories.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group repository 5 - */ 6 3 final class PhabricatorApplicationRepositories extends PhabricatorApplication { 7 4 8 5 public function getBaseURI() {
-3
src/applications/repository/conduit/ConduitAPI_repository_Method.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group conduit 5 - */ 6 3 abstract class ConduitAPI_repository_Method extends ConduitAPIMethod { 7 4 8 5 public function getApplication() {
-4
src/applications/repository/conduit/ConduitAPI_repository_create_Method.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group conduit 5 - */ 6 3 final class ConduitAPI_repository_create_Method 7 4 extends ConduitAPI_repository_Method { 8 5 ··· 132 129 133 130 return $repository->toDictionary(); 134 131 } 135 - 136 132 137 133 }
-3
src/applications/repository/phid/PhabricatorRepositoryPHIDTypeArcanistProject.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group repository 5 - */ 6 3 final class PhabricatorRepositoryPHIDTypeArcanistProject 7 4 extends PhabricatorPHIDType { 8 5
-3
src/applications/repository/query/PhabricatorRepositoryArcanistProjectQuery.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group repository 5 - */ 6 3 final class PhabricatorRepositoryArcanistProjectQuery 7 4 extends PhabricatorCursorPagedPolicyAwareQuery { 8 5
-3
src/applications/repository/storage/PhabricatorRepositoryArcanistProject.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group repository 5 - */ 6 3 final class PhabricatorRepositoryArcanistProject 7 4 extends PhabricatorRepositoryDAO 8 5 implements PhabricatorPolicyInterface,
-2
src/applications/repository/storage/PhabricatorRepositorySymbol.php
··· 5 5 * and functions are defined. 6 6 * 7 7 * Query symbols with @{class:DiffusionSymbolQuery}. 8 - * 9 - * @group diffusion 10 8 */ 11 9 final class PhabricatorRepositorySymbol extends PhabricatorRepositoryDAO { 12 10
-3
src/applications/search/constants/PhabricatorSearchField.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group search 5 - */ 6 3 final class PhabricatorSearchField { 7 4 8 5 const FIELD_TITLE = 'titl';
-3
src/applications/search/constants/PhabricatorSearchRelationship.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group search 5 - */ 6 3 final class PhabricatorSearchRelationship { 7 4 8 5 const RELATIONSHIP_AUTHOR = 'auth';
-3
src/applications/search/controller/PhabricatorSearchAttachController.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group search 5 - */ 6 3 final class PhabricatorSearchAttachController 7 4 extends PhabricatorSearchBaseController { 8 5
-3
src/applications/search/controller/PhabricatorSearchBaseController.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group search 5 - */ 6 3 abstract class PhabricatorSearchBaseController extends PhabricatorController { 7 4 8 5 public function buildStandardPageResponse($view, array $data) {
-3
src/applications/search/controller/PhabricatorSearchDeleteController.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group search 5 - */ 6 3 final class PhabricatorSearchDeleteController 7 4 extends PhabricatorSearchBaseController { 8 5
-4
src/applications/search/controller/PhabricatorSearchEditController.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group search 5 - */ 6 3 final class PhabricatorSearchEditController 7 4 extends PhabricatorSearchBaseController { 8 5 ··· 104 101 'title' => $title, 105 102 )); 106 103 } 107 - 108 104 109 105 }
-3
src/applications/search/controller/PhabricatorSearchHovercardController.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group search 5 - */ 6 3 final class PhabricatorSearchHovercardController 7 4 extends PhabricatorSearchBaseController { 8 5
-3
src/applications/search/controller/PhabricatorSearchOrderController.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group search 5 - */ 6 3 final class PhabricatorSearchOrderController 7 4 extends PhabricatorSearchBaseController { 8 5
-3
src/applications/search/controller/PhabricatorSearchSelectController.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group search 5 - */ 6 3 final class PhabricatorSearchSelectController 7 4 extends PhabricatorSearchBaseController { 8 5
-2
src/applications/search/engine/PhabricatorApplicationSearchEngine.php
··· 12 12 * @task read Reading Utilities 13 13 * @task exec Paging and Executing Queries 14 14 * @task render Rendering Results 15 - * 16 - * @group search 17 15 */ 18 16 abstract class PhabricatorApplicationSearchEngine { 19 17
-5
src/applications/search/engine/PhabricatorSearchEngineMySQL.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group search 5 - */ 6 3 final class PhabricatorSearchEngineMySQL extends PhabricatorSearchEngine { 7 4 8 5 public function reindexAbstractDocument( ··· 143 140 } 144 141 145 142 public function executeSearch(PhabricatorSavedQuery $query) { 146 - 147 143 $where = array(); 148 144 $join = array(); 149 145 $order = 'ORDER BY documentCreated DESC'; ··· 334 330 335 331 return $sql; 336 332 } 337 - 338 333 339 334 }
-3
src/applications/search/index/PhabricatorSearchDocumentIndexer.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group search 5 - */ 6 3 abstract class PhabricatorSearchDocumentIndexer { 7 4 8 5 abstract public function getIndexableObject();
-3
src/applications/search/management/PhabricatorSearchManagementIndexWorkflow.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group search 5 - */ 6 3 final class PhabricatorSearchManagementIndexWorkflow 7 4 extends PhabricatorSearchManagementWorkflow { 8 5
-3
src/applications/search/query/PhabricatorNamedQueryQuery.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group search 5 - */ 6 3 final class PhabricatorNamedQueryQuery 7 4 extends PhabricatorCursorPagedPolicyAwareQuery { 8 5
-3
src/applications/search/selector/PhabricatorDefaultSearchEngineSelector.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group search 5 - */ 6 3 final class PhabricatorDefaultSearchEngineSelector 7 4 extends PhabricatorSearchEngineSelector { 8 5
-3
src/applications/search/selector/PhabricatorSearchEngineSelector.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group search 5 - */ 6 3 abstract class PhabricatorSearchEngineSelector { 7 4 8 5 final public function __construct() {
-4
src/applications/search/storage/PhabricatorNamedQuery.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group search 5 - */ 6 3 final class PhabricatorNamedQuery extends PhabricatorSearchDAO 7 4 implements PhabricatorPolicyInterface { 8 5 ··· 44 41 'The queries you have saved are private. Only you can view or edit '. 45 42 'them.'); 46 43 } 47 - 48 44 49 45 }
-3
src/applications/search/storage/PhabricatorSavedQuery.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group search 5 - */ 6 3 final class PhabricatorSavedQuery extends PhabricatorSearchDAO 7 4 implements PhabricatorPolicyInterface { 8 5
-3
src/applications/search/storage/PhabricatorSearchDAO.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group search 5 - */ 6 3 abstract class PhabricatorSearchDAO extends PhabricatorLiskDAO { 7 4 8 5 public function getApplicationName() {
-3
src/applications/search/storage/document/PhabricatorSearchDocument.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group search 5 - */ 6 3 final class PhabricatorSearchDocument extends PhabricatorSearchDAO { 7 4 8 5 protected $phid;
-3
src/applications/search/storage/document/PhabricatorSearchDocumentField.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group search 5 - */ 6 3 final class PhabricatorSearchDocumentField extends PhabricatorSearchDAO { 7 4 8 5 protected $phid;
-3
src/applications/search/storage/document/PhabricatorSearchDocumentRelationship.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group search 5 - */ 6 3 final class PhabricatorSearchDocumentRelationship extends PhabricatorSearchDAO { 7 4 8 5 protected $phid;
-3
src/applications/slowvote/conduit/ConduitAPI_slowvote_Method.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group conduit 5 - */ 6 3 abstract class ConduitAPI_slowvote_Method extends ConduitAPIMethod { 7 4 8 5 public function getApplication() {
-3
src/applications/slowvote/conduit/ConduitAPI_slowvote_info_Method.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group conduit 5 - */ 6 3 final class ConduitAPI_slowvote_info_Method 7 4 extends ConduitAPI_slowvote_Method { 8 5
-3
src/applications/slowvote/controller/PhabricatorSlowvoteController.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group slowvote 5 - */ 6 3 abstract class PhabricatorSlowvoteController extends PhabricatorController { 7 4 8 5 public function buildSideNavView($for_app = false) {
-3
src/applications/slowvote/controller/PhabricatorSlowvoteEditController.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group slowvote 5 - */ 6 3 final class PhabricatorSlowvoteEditController 7 4 extends PhabricatorSlowvoteController { 8 5
-4
src/applications/slowvote/controller/PhabricatorSlowvotePollController.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group slowvote 5 - */ 6 3 final class PhabricatorSlowvotePollController 7 4 extends PhabricatorSlowvoteController { 8 5 ··· 189 186 ->setHeaderText($add_comment_header) 190 187 ->setAction($this->getApplicationURI('/comment/'.$poll->getID().'/')) 191 188 ->setSubmitButtonName(pht('Add Comment')); 192 - 193 189 } 194 190 195 191 }
-7
src/applications/slowvote/controller/PhabricatorSlowvoteVoteController.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group slowvote 5 - */ 6 3 final class PhabricatorSlowvoteVoteController 7 4 extends PhabricatorSlowvoteController { 8 5 ··· 81 78 $this->updateVotes($user, $poll, $old_votes, $votes); 82 79 83 80 return id(new AphrontRedirectResponse())->setURI('/V'.$poll->getID()); 84 - 85 81 } 86 82 87 83 private function updateVotes($user, $poll, $old_votes, $votes) { 88 - 89 84 if (!empty($votes) && count($votes) > 1 && 90 85 $poll->getMethod() == PhabricatorSlowvotePoll::METHOD_PLURALITY) { 91 86 return id(new Aphront400Response()); ··· 108 103 ->setOptionID($vote) 109 104 ->save(); 110 105 } 111 - 112 106 } 113 - 114 107 115 108 }
-3
src/applications/slowvote/query/PhabricatorSlowvoteQuery.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group slowvote 5 - */ 6 3 final class PhabricatorSlowvoteQuery 7 4 extends PhabricatorCursorPagedPolicyAwareQuery { 8 5
+1 -5
src/applications/slowvote/remarkup/SlowvoteRemarkupRule.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group slowvote 5 - */ 6 - final class SlowvoteRemarkupRule 7 - extends PhabricatorRemarkupRuleObject { 3 + final class SlowvoteRemarkupRule extends PhabricatorRemarkupRuleObject { 8 4 9 5 protected function getObjectNamePrefix() { 10 6 return 'V';
-3
src/applications/slowvote/storage/PhabricatorSlowvoteChoice.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group slowvote 5 - */ 6 3 final class PhabricatorSlowvoteChoice extends PhabricatorSlowvoteDAO { 7 4 8 5 protected $pollID;
-3
src/applications/slowvote/storage/PhabricatorSlowvoteComment.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group slowvote 5 - */ 6 3 final class PhabricatorSlowvoteComment extends PhabricatorSlowvoteDAO { 7 4 8 5 protected $pollID;
-3
src/applications/slowvote/storage/PhabricatorSlowvoteDAO.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group slowvote 5 - */ 6 3 abstract class PhabricatorSlowvoteDAO extends PhabricatorLiskDAO { 7 4 8 5 public function getApplicationName() {
-4
src/applications/slowvote/storage/PhabricatorSlowvoteOption.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group slowvote 5 - */ 6 3 final class PhabricatorSlowvoteOption extends PhabricatorSlowvoteDAO { 7 4 8 5 protected $pollID; 9 6 protected $name; 10 - 11 7 12 8 }
-3
src/applications/slowvote/storage/PhabricatorSlowvotePoll.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group slowvote 5 - */ 6 3 final class PhabricatorSlowvotePoll extends PhabricatorSlowvoteDAO 7 4 implements 8 5 PhabricatorPolicyInterface,
-3
src/applications/slowvote/view/SlowvoteEmbedView.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group slowvote 5 - */ 6 3 final class SlowvoteEmbedView extends AphrontView { 7 4 8 5 private $poll;
+4 -4
src/docs/contributor/css_coding_standards.diviner
··· 53 53 } 54 54 } 55 55 56 - The former will activate when users look at the printable versions of pages, 57 - by adding `__print__` to the URI. The latter will be activated in print contexts 56 + The former will activate when users look at the printable versions of pages, by 57 + adding `__print__` to the URI. The latter will be activated in print contexts 58 58 by the media query. 59 59 60 60 = Device Rules = 61 61 62 - Phabricator's environment defines several device classes which can be used 63 - to adjust behavior responsively. In particular: 62 + Phabricator's environment defines several device classes which can be used to 63 + adjust behavior responsively. In particular: 64 64 65 65 lang=css 66 66 .device-phone {
+5 -5
src/docs/contributor/darkconsole.diviner
··· 10 10 understand and resolve bugs and performance problems in Phabricator 11 11 applications. 12 12 13 - DarkConsole was originally implemented as part of the Facebook Lite site; 14 - its name is a bit of play on that (and a reference to the dark color palette 15 - its design uses). 13 + DarkConsole was originally implemented as part of the Facebook Lite site; its 14 + name is a bit of play on that (and a reference to the dark color palette its 15 + design uses). 16 16 17 17 = Warning = 18 18 ··· 24 24 = Enabling DarkConsole = 25 25 26 26 You enable DarkConsole in your configuration, by setting `darkconsole.enabled` 27 - to `true`, and then turning it on in `Settings` -> `Display Preferences`. 28 - Once DarkConsole is enabled, you can show or hide it by pressing ##`## on your 27 + to `true`, and then turning it on in `Settings` -> `Display Preferences`. Once 28 + DarkConsole is enabled, you can show or hide it by pressing ##`## on your 29 29 keyboard. 30 30 31 31 Since the setting is not available to logged-out users, you can also set
+9 -9
src/docs/contributor/database.diviner
··· 118 118 a homogenous way. 119 119 120 120 For example, the concept of "subscribers" is more powerfully done with PHIDs 121 - because we could theoretically have users, projects, teams, and more all 122 - as "subscribers" of other objects. Using an ID column we would need to add a 121 + because we could theoretically have users, projects, teams, and more all as 122 + "subscribers" of other objects. Using an ID column we would need to add a 123 123 "type" column to avoid ID collision; using PHIDs does not require this 124 124 additional column. 125 125 ··· 148 148 There are three simple steps to update the schema: 149 149 150 150 # Create a `.sql` file in `resources/sql/patches/`. This file should: 151 - - Contain the approprate MySQL commands to update the schema. 152 - - Be named as `YYYYMMDD.patchname.ext`. For example, `20130217.example.sql`. 153 - - Use `${NAMESPACE}` rather than `phabricator` for database names. 154 - - Use `COLLATE utf8_bin` for any columns that are to be used as identifiers, 155 - such as PHID columns. Otherwise, use `COLLATE utf8_general_ci`. 156 - - Name all indexes so it is possible to delete them later. 151 + - Contain the approprate MySQL commands to update the schema. 152 + - Be named as `YYYYMMDD.patchname.ext`. For example, `20130217.example.sql`. 153 + - Use `${NAMESPACE}` rather than `phabricator` for database names. 154 + - Use `COLLATE utf8_bin` for any columns that are to be used as identifiers, 155 + such as PHID columns. Otherwise, use `COLLATE utf8_general_ci`. 156 + - Name all indexes so it is possible to delete them later. 157 157 # Edit `src/infrastructure/storage/patch/PhabricatorBuiltinPatchList.php` and 158 - add your patch to @{method@phabricator:PhabricatorBuiltinPatchList::getPatches}. 158 + add your patch to @{method@phabricator:PhabricatorBuiltinPatchList::getPatches}. 159 159 # Run `bin/storage upgrade`. 160 160 161 161 It is also possible to create more complex patches in PHP for data migration
+1 -1
src/docs/contributor/phabricator_code_layout.diviner
··· 71 71 complicated edits and should be used pragmatically versus Storage objects. 72 72 - **DerpException**: exceptions used in the ##Derp## application. 73 73 - **DerpQuery**: query one or more storage objects for pertinent ##Derp## 74 - application data. @{class:PhabricatorOffsetPagedQuery} is particularly 74 + application data. @{class:PhabricatorOffsetPagedQuery} is particularly 75 75 handy for pagination and works well with @{class:AphrontPagerView}. 76 76 - **DerpReplyHandler**: business logic from any configured email interactions 77 77 users can have with the ##Derp## application.
+3 -3
src/docs/contributor/using_edges.diviner
··· 5 5 6 6 = Overview = 7 7 8 - Edges are a generic way of storing a relationship between two objects (like 9 - a Task and its attached files). If you are familiar with the Facebook 10 - associations framework, Phabricator Edges are substantially similar. 8 + Edges are a generic way of storing a relationship between two objects (like a 9 + Task and its attached files). If you are familiar with the Facebook associations 10 + framework, Phabricator Edges are substantially similar. 11 11 12 12 An edge is defined by a source PHID (the edge origin), a destination PHID 13 13 (the edge destination) and an edge type (which describes the relationship,
+2 -2
src/docs/flavor/things_you_should_do_soon.diviner
··· 1 1 @title Things You Should Do Soon 2 2 @group sundry 3 3 4 - Describes things you should start thinking about soon, because scaling will 5 - be easier if you put a plan in place. 4 + Describes things you should start thinking about soon, because scaling will be 5 + easier if you put a plan in place. 6 6 7 7 = Overview = 8 8
+2 -3
src/docs/tech/celerity.diviner
··· 54 54 neessary preprocessing. It uses @{class:CelerityResourceMap} to locate resources 55 55 and read packaging rules. 56 56 57 - The dependency and packaging maps are generated by 58 - ##bin/celerity map##, which updates 59 - ##resources/celerity/map.php##.. 57 + The dependency and packaging maps are generated by ##bin/celerity map##, 58 + which updates ##resources/celerity/map.php##. 60 59 61 60 @{class:CelerityStaticResourceResponse} also manages some Javelin information, 62 61 and @{function:celerity_generate_unique_node_id} uses this metadata to provide
+1 -1
src/docs/user/userguide/events.diviner
··· 188 188 `PhabricatorEventType::TYPE_DIFFERENTIAL_WILLMARKGENERATED`. 189 189 190 190 This event is dispatched before Differential decides if a file is generated (and 191 - doesn't need to be reviewed) or not. Data available on this event: 191 + doesn't need to be reviewed) or not. Data available on this event: 192 192 193 193 - ##corpus## Body of the file. 194 194 - ##is_generated## Boolean indicating if this file should be treated as
+1 -2
src/docs/user/userguide/jump.diviner
··· 24 24 - **p** - Jump to Project 25 25 - **p Some Project** - Jump to Project: Some Project 26 26 - **s SymbolName** - Jump to Symbol SymbolName 27 - - **task: (new title)** - Jumps to Task Creation Page with pre-filled 28 - title. 27 + - **task: (new title)** - Jumps to Task Creation Page with pre-filled title. 29 28 - **(default)** - Search for input.
+1 -1
src/docs/user/userguide/owners.diviner
··· 24 24 - no revision found for the commit, 25 25 - the commit author is not recognized, or 26 26 - the author or the reviewer specified in the commits don't match the ones in 27 - the Differential revision 27 + the Differential revision 28 28 29 29 The owners of the package can accept or specify concern for such commits by 30 30 clicking the "Audit Status" link.
+1 -1
src/docs/user/userguide/remarkup.diviner
··· 556 556 557 557 = Fullscreen Mode = 558 558 559 - Remarkup editors provide a fullscreen composition mode. This can make it easier 559 + Remarkup editors provide a fullscreen composition mode. This can make it easier 560 560 to edit large blocks of text, or improve focus by removing distractions. You can 561 561 exit **Fullscreen** mode by clicking the button again or by pressing escape.
-2
src/infrastructure/celerity/CelerityAPI.php
··· 3 3 /** 4 4 * Indirection layer which provisions for a terrifying future where we need to 5 5 * build multiple resource responses per page. 6 - * 7 - * @group celerity 8 6 */ 9 7 final class CelerityAPI { 10 8
+1 -3
src/infrastructure/celerity/CelerityPhabricatorResourceController.php
··· 2 2 3 3 /** 4 4 * Delivers CSS and JS resources to the browser. This controller handles all 5 - * ##/res/## requests, and manages caching, package construction, and resource 5 + * `/res/` requests, and manages caching, package construction, and resource 6 6 * preprocessing. 7 - * 8 - * @group celerity 9 7 */ 10 8 final class CelerityPhabricatorResourceController 11 9 extends CelerityResourceController {
-5
src/infrastructure/celerity/CelerityResourceTransformer.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group celerity 5 - */ 6 3 final class CelerityResourceTransformer { 7 4 8 5 private $minify; ··· 346 343 * @return string|null Data URI, or null if we declined to generate one. 347 344 */ 348 345 private function generateDataURI($resource_name) { 349 - 350 346 $ext = last(explode('.', $resource_name)); 351 347 switch ($ext) { 352 348 case 'png': ··· 379 375 380 376 return $uri; 381 377 } 382 - 383 378 384 379 }
-2
src/infrastructure/celerity/CelerityStaticResourceResponse.php
··· 4 4 * Tracks and resolves dependencies the page declares with 5 5 * @{function:require_celerity_resource}, and then builds appropriate HTML or 6 6 * Ajax responses. 7 - * 8 - * @group celerity 9 7 */ 10 8 final class CelerityStaticResourceResponse { 11 9
-3
src/infrastructure/celerity/__tests__/CelerityResourceTransformerTestCase.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group celerity 5 - */ 6 3 final class CelerityResourceTransformerTestCase extends PhabricatorTestCase { 7 4 8 5 public function testTransformation() {
-6
src/infrastructure/celerity/api.php
··· 12 12 * @param string Name of the celerity module to include. This is whatever you 13 13 * annotated as "@provides" in the file. 14 14 * @return void 15 - * 16 - * @group celerity 17 15 */ 18 16 function require_celerity_resource($symbol, $source_name = 'phabricator') { 19 17 $response = CelerityAPI::getStaticResourceResponse(); ··· 29 27 * @return string A string appropriate for use as an 'id' attribute on a DOM 30 28 * node. It is guaranteed to be unique for the current page, even 31 29 * if the current request is a subsequent Ajax request. 32 - * 33 - * @group celerity 34 30 */ 35 31 function celerity_generate_unique_node_id() { 36 32 static $uniq = 0; ··· 46 42 * 47 43 * @param string Path to the raw image. 48 44 * @return string Versioned path to the image, if one is available. 49 - * 50 - * @group celerity 51 45 */ 52 46 function celerity_get_resource_uri($resource, $source = 'phabricator') { 53 47 $resource = ltrim($resource, '/');
-2
src/infrastructure/daemon/bot/PhabricatorBot.php
··· 7 7 * script system interactions and integrate with other systems. 8 8 * 9 9 * NOTE: This is super janky and experimental right now. 10 - * 11 - * @group irc 12 10 */ 13 11 final class PhabricatorBot extends PhabricatorDaemon { 14 12
+35 -38
src/infrastructure/daemon/bot/handler/PhabricatorBotFeedNotificationHandler.php
··· 1 1 <?php 2 2 3 3 /** 4 - * Watches the feed and puts notifications into channel(s) of choice 5 - * 6 - * @group irc 4 + * Watches the feed and puts notifications into channel(s) of choice. 7 5 */ 8 6 final class PhabricatorBotFeedNotificationHandler 9 7 extends PhabricatorBotHandler { ··· 33 31 switch ($verbosity) { 34 32 case 2: 35 33 $verbs[] = array( 36 - 'commented', 37 - 'added', 38 - 'changed', 39 - 'resigned', 40 - 'explained', 41 - 'modified', 42 - 'attached', 43 - 'edited', 44 - 'joined', 45 - 'left', 46 - 'removed' 47 - ); 34 + 'commented', 35 + 'added', 36 + 'changed', 37 + 'resigned', 38 + 'explained', 39 + 'modified', 40 + 'attached', 41 + 'edited', 42 + 'joined', 43 + 'left', 44 + 'removed', 45 + ); 48 46 // fallthrough 49 47 case 1: 50 48 $verbs[] = array( 51 - 'updated', 52 - 'accepted', 53 - 'requested', 54 - 'planned', 55 - 'claimed', 56 - 'summarized', 57 - 'commandeered', 58 - 'assigned' 59 - ); 49 + 'updated', 50 + 'accepted', 51 + 'requested', 52 + 'planned', 53 + 'claimed', 54 + 'summarized', 55 + 'commandeered', 56 + 'assigned', 57 + ); 60 58 // fallthrough 61 59 case 0: 62 60 $verbs[] = array( 63 - 'created', 64 - 'closed', 65 - 'raised', 66 - 'committed', 67 - 'abandoned', 68 - 'reclaimed', 69 - 'reopened', 70 - 'deleted' 71 - ); 72 - break; 61 + 'created', 62 + 'closed', 63 + 'raised', 64 + 'committed', 65 + 'abandoned', 66 + 'reclaimed', 67 + 'reopened', 68 + 'deleted', 69 + ); 70 + break; 73 71 74 72 case 3: 75 73 default: 76 74 return true; 77 - break; 78 75 } 79 76 80 77 $verbs = '/('.implode('|', array_mergev($verbs)).')/'; ··· 92 89 93 90 public function runBackgroundTasks() { 94 91 if ($this->startupDelay > 0) { 95 - // the event loop runs every 1s so delay enough to fully conenct 96 - $this->startupDelay--; 92 + // the event loop runs every 1s so delay enough to fully conenct 93 + $this->startupDelay--; 97 94 98 - return; 95 + return; 99 96 } 100 97 if ($this->lastSeenChronoKey == 0) { 101 98 // Since we only want to post notifications about new stories, skip
+1 -2
src/infrastructure/daemon/bot/handler/PhabricatorBotHandler.php
··· 3 3 /** 4 4 * Responds to IRC messages. You plug a bunch of these into a 5 5 * @{class:PhabricatorBot} to give it special behavior. 6 - * 7 - * @group irc 8 6 */ 9 7 abstract class PhabricatorBotHandler { 10 8 ··· 70 68 71 69 return $this->writeMessage($reply); 72 70 } 71 + 73 72 }
-3
src/infrastructure/daemon/bot/handler/PhabricatorBotLogHandler.php
··· 2 2 3 3 /** 4 4 * Logs chatter. 5 - * 6 - * @group irc 7 5 */ 8 6 final class PhabricatorBotLogHandler extends PhabricatorBotHandler { 9 7 10 8 private $futures = array(); 11 9 12 10 public function receiveMessage(PhabricatorBotMessage $message) { 13 - 14 11 switch ($message->getCommand()) { 15 12 case 'MESSAGE': 16 13 $target = $message->getTarget();
-3
src/infrastructure/daemon/bot/handler/PhabricatorBotMacroHandler.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group irc 5 - */ 6 3 final class PhabricatorBotMacroHandler extends PhabricatorBotHandler { 7 4 8 5 private $macros;
+144 -147
src/infrastructure/daemon/bot/handler/PhabricatorBotObjectNameHandler.php
··· 2 2 3 3 /** 4 4 * Looks for Dxxxx, Txxxx and links to them. 5 - * 6 - * @group irc 7 5 */ 8 6 final class PhabricatorBotObjectNameHandler extends PhabricatorBotHandler { 9 7 ··· 14 12 private $recentlyMentioned = array(); 15 13 16 14 public function receiveMessage(PhabricatorBotMessage $original_message) { 17 - 18 15 switch ($original_message->getCommand()) { 19 - case 'MESSAGE': 20 - $message = $original_message->getBody(); 21 - $matches = null; 16 + case 'MESSAGE': 17 + $message = $original_message->getBody(); 18 + $matches = null; 22 19 23 - $paste_ids = array(); 24 - $commit_names = array(); 25 - $vote_ids = array(); 26 - $file_ids = array(); 27 - $object_names = array(); 28 - $output = array(); 20 + $paste_ids = array(); 21 + $commit_names = array(); 22 + $vote_ids = array(); 23 + $file_ids = array(); 24 + $object_names = array(); 25 + $output = array(); 29 26 30 - $pattern = 31 - '@'. 32 - '(?<!/)(?:^|\b)'. 33 - '(R2D2)'. 34 - '(?:\b|$)'. 35 - '@'; 27 + $pattern = 28 + '@'. 29 + '(?<!/)(?:^|\b)'. 30 + '(R2D2)'. 31 + '(?:\b|$)'. 32 + '@'; 36 33 37 - if (preg_match_all($pattern, $message, $matches, PREG_SET_ORDER)) { 38 - foreach ($matches as $match) { 39 - switch ($match[1]) { 40 - case 'R2D2': 41 - $output[$match[1]] = pht('beep hoop bop'); 42 - break; 34 + if (preg_match_all($pattern, $message, $matches, PREG_SET_ORDER)) { 35 + foreach ($matches as $match) { 36 + switch ($match[1]) { 37 + case 'R2D2': 38 + $output[$match[1]] = pht('beep hoop bop'); 39 + break; 40 + } 43 41 } 44 42 } 45 - } 46 43 47 - $pattern = 48 - '@'. 49 - '(?<!/)(?:^|\b)'. // Negative lookbehind prevent matching "/D123". 50 - '([A-Z])(\d+)'. 51 - '(?:\b|$)'. 52 - '@'; 44 + $pattern = 45 + '@'. 46 + '(?<!/)(?:^|\b)'. // Negative lookbehind prevent matching "/D123". 47 + '([A-Z])(\d+)'. 48 + '(?:\b|$)'. 49 + '@'; 53 50 54 - if (preg_match_all($pattern, $message, $matches, PREG_SET_ORDER)) { 55 - foreach ($matches as $match) { 56 - switch ($match[1]) { 57 - case 'P': 58 - $paste_ids[] = $match[2]; 59 - break; 60 - case 'V': 61 - $vote_ids[] = $match[2]; 62 - break; 63 - case 'F': 64 - $file_ids[] = $match[2]; 65 - break; 66 - default: 67 - $name = $match[1].$match[2]; 68 - switch ($name) { 69 - case 'T1000': 70 - $output[$name] = pht( 71 - 'T1000: A mimetic poly-alloy assassin controlled by '. 72 - 'Skynet'); 73 - break; 74 - default: 75 - $object_names[] = $name; 76 - break; 77 - } 78 - break; 51 + if (preg_match_all($pattern, $message, $matches, PREG_SET_ORDER)) { 52 + foreach ($matches as $match) { 53 + switch ($match[1]) { 54 + case 'P': 55 + $paste_ids[] = $match[2]; 56 + break; 57 + case 'V': 58 + $vote_ids[] = $match[2]; 59 + break; 60 + case 'F': 61 + $file_ids[] = $match[2]; 62 + break; 63 + default: 64 + $name = $match[1].$match[2]; 65 + switch ($name) { 66 + case 'T1000': 67 + $output[$name] = pht( 68 + 'T1000: A mimetic poly-alloy assassin controlled by '. 69 + 'Skynet'); 70 + break; 71 + default: 72 + $object_names[] = $name; 73 + break; 74 + } 75 + break; 76 + } 79 77 } 80 78 } 81 - } 82 79 83 - $pattern = 84 - '@'. 85 - '(?<!/)(?:^|\b)'. 86 - '(r[A-Z]+)([0-9a-z]{0,40})'. 87 - '(?:\b|$)'. 88 - '@'; 89 - if (preg_match_all($pattern, $message, $matches, PREG_SET_ORDER)) { 90 - foreach ($matches as $match) { 91 - if ($match[2]) { 92 - $commit_names[] = $match[1].$match[2]; 93 - } else { 94 - $object_names[] = $match[1]; 80 + $pattern = 81 + '@'. 82 + '(?<!/)(?:^|\b)'. 83 + '(r[A-Z]+)([0-9a-z]{0,40})'. 84 + '(?:\b|$)'. 85 + '@'; 86 + if (preg_match_all($pattern, $message, $matches, PREG_SET_ORDER)) { 87 + foreach ($matches as $match) { 88 + if ($match[2]) { 89 + $commit_names[] = $match[1].$match[2]; 90 + } else { 91 + $object_names[] = $match[1]; 92 + } 95 93 } 96 94 } 97 - } 98 95 99 - if ($object_names) { 100 - $objects = $this->getConduit()->callMethodSynchronous( 101 - 'phid.lookup', 102 - array( 103 - 'names' => $object_names, 104 - )); 105 - foreach ($objects as $object) { 106 - $output[$object['phid']] = $object['fullName'].' - '.$object['uri']; 96 + if ($object_names) { 97 + $objects = $this->getConduit()->callMethodSynchronous( 98 + 'phid.lookup', 99 + array( 100 + 'names' => $object_names, 101 + )); 102 + foreach ($objects as $object) { 103 + $output[$object['phid']] = $object['fullName'].' - '.$object['uri']; 104 + } 107 105 } 108 - } 109 106 110 - if ($vote_ids) { 111 - foreach ($vote_ids as $vote_id) { 112 - $vote = $this->getConduit()->callMethodSynchronous( 113 - 'slowvote.info', 114 - array( 115 - 'poll_id' => $vote_id, 116 - )); 117 - $output[$vote['phid']] = 'V'.$vote['id'].': '.$vote['question']. 118 - ' Come Vote '.$vote['uri']; 107 + if ($vote_ids) { 108 + foreach ($vote_ids as $vote_id) { 109 + $vote = $this->getConduit()->callMethodSynchronous( 110 + 'slowvote.info', 111 + array( 112 + 'poll_id' => $vote_id, 113 + )); 114 + $output[$vote['phid']] = 'V'.$vote['id'].': '.$vote['question']. 115 + ' Come Vote '.$vote['uri']; 116 + } 119 117 } 120 - } 121 118 122 - if ($file_ids) { 123 - foreach ($file_ids as $file_id) { 124 - $file = $this->getConduit()->callMethodSynchronous( 125 - 'file.info', 126 - array( 127 - 'id' => $file_id, 128 - )); 129 - $output[$file['phid']] = $file['objectName'].': '.$file['uri'].' - '. 130 - $file['name']; 119 + if ($file_ids) { 120 + foreach ($file_ids as $file_id) { 121 + $file = $this->getConduit()->callMethodSynchronous( 122 + 'file.info', 123 + array( 124 + 'id' => $file_id, 125 + )); 126 + $output[$file['phid']] = $file['objectName'].': '.$file['uri'].' - '. 127 + $file['name']; 128 + } 131 129 } 132 - } 133 130 134 - if ($paste_ids) { 135 - foreach ($paste_ids as $paste_id) { 136 - $paste = $this->getConduit()->callMethodSynchronous( 137 - 'paste.info', 138 - array( 139 - 'paste_id' => $paste_id, 140 - )); 141 - // Eventually I'd like to show the username of the paster as well, 142 - // however that will need something like a user.username_from_phid 143 - // since we (ideally) want to keep the bot to Conduit calls...and 144 - // not call to Phabricator-specific stuff (like actually loading 145 - // the User object and fetching his/her username.) 146 - $output[$paste['phid']] = 'P'.$paste['id'].': '.$paste['uri'].' - '. 147 - $paste['title']; 131 + if ($paste_ids) { 132 + foreach ($paste_ids as $paste_id) { 133 + $paste = $this->getConduit()->callMethodSynchronous( 134 + 'paste.info', 135 + array( 136 + 'paste_id' => $paste_id, 137 + )); 138 + // Eventually I'd like to show the username of the paster as well, 139 + // however that will need something like a user.username_from_phid 140 + // since we (ideally) want to keep the bot to Conduit calls...and 141 + // not call to Phabricator-specific stuff (like actually loading 142 + // the User object and fetching his/her username.) 143 + $output[$paste['phid']] = 'P'.$paste['id'].': '.$paste['uri'].' - '. 144 + $paste['title']; 148 145 149 - if ($paste['language']) { 150 - $output[$paste['phid']] .= ' ('.$paste['language'].')'; 146 + if ($paste['language']) { 147 + $output[$paste['phid']] .= ' ('.$paste['language'].')'; 148 + } 151 149 } 152 150 } 153 - } 154 151 155 - if ($commit_names) { 156 - $commits = $this->getConduit()->callMethodSynchronous( 157 - 'diffusion.getcommits', 158 - array( 159 - 'commits' => $commit_names, 160 - )); 161 - foreach ($commits as $commit) { 162 - if (isset($commit['error'])) { 163 - continue; 152 + if ($commit_names) { 153 + $commits = $this->getConduit()->callMethodSynchronous( 154 + 'diffusion.getcommits', 155 + array( 156 + 'commits' => $commit_names, 157 + )); 158 + foreach ($commits as $commit) { 159 + if (isset($commit['error'])) { 160 + continue; 161 + } 162 + $output[$commit['commitPHID']] = $commit['uri']; 164 163 } 165 - $output[$commit['commitPHID']] = $commit['uri']; 166 164 } 167 - } 168 165 169 - foreach ($output as $phid => $description) { 166 + foreach ($output as $phid => $description) { 170 167 171 - // Don't mention the same object more than once every 10 minutes 172 - // in public channels, so we avoid spamming the chat over and over 173 - // again for discsussions of a specific revision, for example. 168 + // Don't mention the same object more than once every 10 minutes 169 + // in public channels, so we avoid spamming the chat over and over 170 + // again for discsussions of a specific revision, for example. 174 171 175 - $target_name = $original_message->getTarget()->getName(); 176 - if (empty($this->recentlyMentioned[$target_name])) { 177 - $this->recentlyMentioned[$target_name] = array(); 178 - } 172 + $target_name = $original_message->getTarget()->getName(); 173 + if (empty($this->recentlyMentioned[$target_name])) { 174 + $this->recentlyMentioned[$target_name] = array(); 175 + } 179 176 180 - $quiet_until = idx( 181 - $this->recentlyMentioned[$target_name], 182 - $phid, 183 - 0) + (60 * 10); 177 + $quiet_until = idx( 178 + $this->recentlyMentioned[$target_name], 179 + $phid, 180 + 0) + (60 * 10); 184 181 185 - if (time() < $quiet_until) { 186 - // Remain quiet on this channel. 187 - continue; 188 - } 182 + if (time() < $quiet_until) { 183 + // Remain quiet on this channel. 184 + continue; 185 + } 189 186 190 - $this->recentlyMentioned[$target_name][$phid] = time(); 191 - $this->replyTo($original_message, $description); 192 - } 193 - break; 187 + $this->recentlyMentioned[$target_name][$phid] = time(); 188 + $this->replyTo($original_message, $description); 189 + } 190 + break; 194 191 } 195 192 } 196 193
+28 -31
src/infrastructure/daemon/bot/handler/PhabricatorBotSymbolHandler.php
··· 2 2 3 3 /** 4 4 * Watches for "where is <symbol>?" 5 - * 6 - * @group irc 7 5 */ 8 6 final class PhabricatorBotSymbolHandler extends PhabricatorBotHandler { 9 7 10 8 public function receiveMessage(PhabricatorBotMessage $message) { 11 - 12 9 switch ($message->getCommand()) { 13 - case 'MESSAGE': 14 - $text = $message->getBody(); 10 + case 'MESSAGE': 11 + $text = $message->getBody(); 15 12 16 - $matches = null; 17 - if (!preg_match('/where(?: in the world)? is (\S+?)\?/i', 18 - $text, $matches)) { 19 - break; 20 - } 13 + $matches = null; 14 + if (!preg_match('/where(?: in the world)? is (\S+?)\?/i', 15 + $text, $matches)) { 16 + break; 17 + } 21 18 22 - $symbol = $matches[1]; 23 - $results = $this->getConduit()->callMethodSynchronous( 24 - 'diffusion.findsymbols', 25 - array( 26 - 'name' => $symbol, 27 - )); 19 + $symbol = $matches[1]; 20 + $results = $this->getConduit()->callMethodSynchronous( 21 + 'diffusion.findsymbols', 22 + array( 23 + 'name' => $symbol, 24 + )); 28 25 29 - $default_uri = $this->getURI('/diffusion/symbol/'.$symbol.'/'); 26 + $default_uri = $this->getURI('/diffusion/symbol/'.$symbol.'/'); 30 27 31 - if (count($results) > 1) { 32 - $response = "Multiple symbols named '{$symbol}': {$default_uri}"; 33 - } else if (count($results) == 1) { 34 - $result = head($results); 35 - $response = 36 - $result['type'].' '. 37 - $result['name'].' '. 38 - '('.$result['language'].'): '. 39 - nonempty($result['uri'], $default_uri); 40 - } else { 41 - $response = "No symbol '{$symbol}' found anywhere."; 42 - } 28 + if (count($results) > 1) { 29 + $response = "Multiple symbols named '{$symbol}': {$default_uri}"; 30 + } else if (count($results) == 1) { 31 + $result = head($results); 32 + $response = 33 + $result['type'].' '. 34 + $result['name'].' '. 35 + '('.$result['language'].'): '. 36 + nonempty($result['uri'], $default_uri); 37 + } else { 38 + $response = "No symbol '{$symbol}' found anywhere."; 39 + } 43 40 44 - $this->replyTo($message, $response); 41 + $this->replyTo($message, $response); 45 42 46 - break; 43 + break; 47 44 } 48 45 } 49 46
-2
src/infrastructure/daemon/bot/handler/PhabricatorBotWhatsNewHandler.php
··· 2 2 3 3 /** 4 4 * Responds to "Whats new?" with some recent feed content 5 - * 6 - * @group irc 7 5 */ 8 6 final class PhabricatorBotWhatsNewHandler extends PhabricatorBotHandler { 9 7
+1 -3
src/infrastructure/daemon/workers/PhabricatorWorker.php
··· 2 2 3 3 /** 4 4 * @task config Configuring Retries and Failures 5 - * 6 - * @group worker 7 5 */ 8 6 abstract class PhabricatorWorker { 9 7 ··· 215 213 216 214 217 215 /** 218 - * Queue a task to be executed after this one suceeds. 216 + * Queue a task to be executed after this one succeeds. 219 217 * 220 218 * The followup task will be queued only if this task completes cleanly. 221 219 *
-2
src/infrastructure/daemon/workers/query/PhabricatorWorkerLeaseQuery.php
··· 2 2 3 3 /** 4 4 * Select and lease tasks from the worker task queue. 5 - * 6 - * @group worker 7 5 */ 8 6 final class PhabricatorWorkerLeaseQuery extends PhabricatorQuery { 9 7
-4
src/infrastructure/events/PhabricatorEvent.php
··· 1 1 <?php 2 2 3 - 4 - /** 5 - * @group events 6 - */ 7 3 final class PhabricatorEvent extends PhutilEvent { 8 4 9 5 private $user;
-3
src/infrastructure/events/PhabricatorExampleEventListener.php
··· 3 3 /** 4 4 * Example event listener. For details about installing Phabricator event hooks, 5 5 * refer to @{article:Events User Guide: Installing Event Listeners}. 6 - * 7 - * @group events 8 6 */ 9 7 final class PhabricatorExampleEventListener extends PhabricatorEventListener { 10 8 11 9 public function register() { 12 10 // When your listener is installed, its register() method will be called. 13 11 // You should listen() to any events you are interested in here. 14 - 15 12 $this->listen(PhabricatorEventType::TYPE_TEST_DIDRUNTEST); 16 13 } 17 14
-2
src/infrastructure/events/constant/PhabricatorEventType.php
··· 3 3 /** 4 4 * For detailed explanations of these events, see 5 5 * @{article:Events User Guide: Installing Event Listeners}. 6 - * 7 - * @group events 8 6 */ 9 7 final class PhabricatorEventType extends PhutilEventType { 10 8
+1 -3
src/infrastructure/markup/PhabricatorMarkupInterface.php
··· 14 14 * these cases, the implementation can largely ignore the `$field` parameter. 15 15 * 16 16 * @task markup Markup Interface 17 - * 18 - * @group markup 19 17 */ 20 18 interface PhabricatorMarkupInterface { 21 19 ··· 26 24 /** 27 25 * Get a key to identify this field. This should uniquely identify the block 28 26 * of text to be rendered and be usable as a cache key. If the object has a 29 - * PHID, using the PHID and the field name is likley reasonable: 27 + * PHID, using the PHID and the field name is likely reasonable: 30 28 * 31 29 * "{$phid}:{$field}" 32 30 *
-4
src/infrastructure/markup/PhabricatorSyntaxHighlighter.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group markup 5 - */ 6 3 final class PhabricatorSyntaxHighlighter { 7 4 8 5 public static function newEngine() { ··· 30 27 $engine = self::newEngine(); 31 28 return $engine->highlightSource($language, $source); 32 29 } 33 - 34 30 35 31 }
+1 -5
src/infrastructure/markup/rule/PhabricatorRemarkupRuleYoutube.php
··· 1 1 <?php 2 2 3 - /** 4 - * @group markup 5 - */ 6 - final class PhabricatorRemarkupRuleYoutube 7 - extends PhutilRemarkupRule { 3 + final class PhabricatorRemarkupRuleYoutube extends PhutilRemarkupRule { 8 4 9 5 public function getPriority() { 10 6 return 350.0;
+19 -22
src/infrastructure/storage/lisk/LiskDAO.php
··· 93 93 * 94 94 * $dog = id(new Dog())->load($id); 95 95 * 96 - * This will load the Dog record with ID $id into $dog, or ##null## if no such 96 + * This will load the Dog record with ID $id into $dog, or `null` if no such 97 97 * record exists (@{method:load} is an instance method rather than a static 98 98 * method because PHP does not support late static binding, at least until PHP 99 99 * 5.3). ··· 161 161 * @task util Utilities 162 162 * @task xaction Managing Transactions 163 163 * @task isolate Isolation for Unit Testing 164 - * 165 - * @group storage 166 164 */ 167 165 abstract class LiskDAO { 168 166 ··· 464 462 * 465 463 * @task load 466 464 */ 467 - public function loadAllWhere($pattern/* , $arg, $arg, $arg ... */) { 465 + public function loadAllWhere($pattern /* , $arg, $arg, $arg ... */) { 468 466 $args = func_get_args(); 469 467 array_unshift($args, null); 470 468 $data = call_user_func_array( ··· 484 482 * 485 483 * @task load 486 484 */ 487 - public function loadColumnsWhere(array $columns, $pattern/* , $args... */) { 485 + public function loadColumnsWhere(array $columns, $pattern /* , $args... */) { 488 486 if (!$this->getConfigOption(self::CONFIG_PARTIAL_OBJECTS)) { 489 487 throw new BadMethodCallException( 490 488 'This class does not support partial objects.'); ··· 499 497 500 498 /** 501 499 * Load a single object identified by a 'WHERE' clause. You provide 502 - * everything after the 'WHERE', and Lisk builds the first half of the 500 + * everything after the 'WHERE', and Lisk builds the first half of the 503 501 * query. See loadAllWhere(). This method is similar, but returns a single 504 502 * result instead of a list. 505 503 * ··· 509 507 * 510 508 * @task load 511 509 */ 512 - public function loadOneWhere($pattern/* , $arg, $arg, $arg ... */) { 510 + public function loadOneWhere($pattern /* , $arg, $arg, $arg ... */) { 513 511 $args = func_get_args(); 514 512 array_unshift($args, null); 515 513 $data = call_user_func_array( ··· 530 528 } 531 529 532 530 533 - protected function loadRawDataWhere($columns, $pattern/* , $args... */) { 531 + protected function loadRawDataWhere($columns, $pattern /* , $args... */) { 534 532 $connection = $this->establishConnection('r'); 535 533 536 534 $lock_clause = ''; ··· 579 577 * @task load 580 578 */ 581 579 public function reload() { 582 - 583 580 if (!$this->getID()) { 584 581 throw new Exception("Unable to reload object that hasn't been loaded!"); 585 582 } ··· 601 598 * Initialize this object's properties from a dictionary. Generally, you 602 599 * load single objects with loadOneWhere(), but sometimes it may be more 603 600 * convenient to pull data from elsewhere directly (e.g., a complicated 604 - * join via queryData()) and then load from an array representation. 601 + * join via @{method:queryData}) and then load from an array representation. 605 602 * 606 603 * @param dict Dictionary of properties, which should be equivalent to 607 - * selecting a row from the table or calling getProperties(). 604 + * selecting a row from the table or calling 605 + * @{method:getProperties}. 608 606 * @return this 609 607 * 610 608 * @task load ··· 654 652 655 653 /** 656 654 * Initialize a list of objects from a list of dictionaries. Usually you 657 - * load lists of objects with loadAllWhere(), but sometimes that isn't 658 - * flexible enough. One case is if you need to do joins to select the right 659 - * objects: 655 + * load lists of objects with @{method:loadAllWhere}, but sometimes that 656 + * isn't flexible enough. One case is if you need to do joins to select the 657 + * right objects: 660 658 * 661 659 * function loadAllWithOwner($owner) { 662 660 * $data = $this->queryData( ··· 669 667 * return $this->loadAllFromArray($data); 670 668 * } 671 669 * 672 - * This is a lot messier than loadAllWhere(), but more flexible. 670 + * This is a lot messier than @{method:loadAllWhere}, but more flexible. 673 671 * 674 672 * @param list List of property dictionaries. 675 673 * @return dict List of constructed objects, keyed on ID. ··· 1044 1042 1045 1043 /** 1046 1044 * Convert this object into a property dictionary. This dictionary can be 1047 - * restored into an object by using loadFromArray() (unless you're using 1048 - * legacy features with CONFIG_CONVERT_CAMELCASE, but in that case you should 1049 - * just go ahead and die in a fire). 1045 + * restored into an object by using @{method:loadFromArray} (unless you're 1046 + * using legacy features with CONFIG_CONVERT_CAMELCASE, but in that case you 1047 + * should just go ahead and die in a fire). 1050 1048 * 1051 1049 * @return dict Dictionary of object properties. 1052 1050 * ··· 1370 1368 1371 1369 /** 1372 1370 * Hook to apply serialization or validation to data before it is written to 1373 - * the database. See also willReadData(). 1371 + * the database. See also @{method:willReadData}. 1374 1372 * 1375 1373 * @task hook 1376 1374 */ ··· 1411 1409 1412 1410 /** 1413 1411 * Hook to apply serialization or validation to data as it is read from the 1414 - * database. See also willWriteData(). 1412 + * database. See also @{method:willWriteData}. 1415 1413 * 1416 1414 * @task hook 1417 1415 */ ··· 1442 1440 1443 1441 /** 1444 1442 * Reads the value from a field. Override this method for custom behavior 1445 - * of getField() instead of overriding getField directly. 1443 + * of @{method:getField} instead of overriding getField directly. 1446 1444 * 1447 1445 * @param string Canonical field name 1448 1446 * @return mixed Value of the field ··· 1706 1704 * @task util 1707 1705 */ 1708 1706 public function __call($method, $args) { 1709 - 1710 1707 // NOTE: PHP has a bug that static variables defined in __call() are shared 1711 1708 // across all children classes. Call a different method to work around this 1712 1709 // bug.
+1 -2
webroot/rsrc/externals/javelin/core/Event.js
··· 21 21 * 22 22 * @task stop Stopping Event Behaviors 23 23 * @task info Getting Event Information 24 - * @group event 25 24 */ 26 25 JX.install('Event', { 27 26 members : { ··· 211 210 212 211 /** 213 212 * Get the metadata associated with the node that corresponds to the key 214 - * in this event's node map. This is a simple helper method that makes 213 + * in this event's node map. This is a simple helper method that makes 215 214 * the API for accessing metadata associated with specific nodes less ugly. 216 215 * 217 216 * JX.Stratcom.listen('click', 'tag:a', function(event) {
-1
webroot/rsrc/externals/javelin/core/Stratcom.js
··· 31 31 * @task sigil Managing Sigils 32 32 * @task meta Managing Metadata 33 33 * @task internal Internals 34 - * @group event 35 34 */ 36 35 JX.install('Stratcom', { 37 36 statics : {
-4
webroot/rsrc/externals/javelin/core/install.js
··· 77 77 * "namespace" (e.g., JX.Pancake). 78 78 * @param map Map of properties, see method documentation. 79 79 * @return void 80 - * 81 - * @group install 82 80 */ 83 81 JX.install = function(new_name, new_junk) { 84 82 ··· 157 155 * 158 156 * @param junk Map of properties, see method documentation. 159 157 * @return function Constructor of a class created 160 - * 161 - * @group install 162 158 */ 163 159 JX.createClass = function(junk) { 164 160 var name = junk.name || '';
-20
webroot/rsrc/externals/javelin/core/util.js
··· 22 22 * Throw an exception and attach the caller data in the exception. 23 23 * 24 24 * @param string Exception message. 25 - * 26 - * @group util 27 25 */ 28 26 JX.$E = function(message) { 29 27 var e = new Error(message); ··· 45 43 * 46 44 * @param obj Array, or array-like object. 47 45 * @return Array Actual array. 48 - * 49 - * @group util 50 46 */ 51 47 JX.$A = function(object) { 52 48 // IE8 throws "JScript object expected" when trying to call ··· 77 73 * @param wild Scalar or Array. 78 74 * @return Array If the argument was a scalar, an Array with the argument as 79 75 * its only element. Otherwise, the original Array. 80 - * 81 - * @group util 82 76 */ 83 77 JX.$AX = function(maybe_scalar) { 84 78 return JX.isArray(maybe_scalar) ? maybe_scalar : [maybe_scalar]; ··· 93 87 * 94 88 * @param wild Any value. 95 89 * @return bool true if the argument is an array, false otherwise. 96 - * 97 - * @group util 98 90 */ 99 91 JX.isArray = Array.isArray || function(maybe_array) { 100 92 return Object.prototype.toString.call(maybe_array) == '[object Array]'; ··· 132 124 * @param obj Destination object, which properties should be copied to. 133 125 * @param obj Source object, which properties should be copied from. 134 126 * @return obj Modified destination object. 135 - * 136 - * @group util 137 127 */ 138 128 JX.copy = function(copy_dst, copy_src) { 139 129 for (var k in copy_src) { ··· 227 217 * @param ... Zero or more arguments to bind. 228 218 * @return function New function which invokes the original function with 229 219 * bound context and arguments when called. 230 - * 231 - * @group util 232 220 */ 233 221 JX.bind = function(context, func, more) { 234 222 if (__DEV__) { ··· 256 244 * actually have an effect. 257 245 * 258 246 * @return void 259 - * 260 - * @group util 261 247 */ 262 248 JX.bag = function() { 263 249 // \o\ \o/ /o/ woo dance party ··· 271 257 * 272 258 * @param obj Object to retrieve keys from. 273 259 * @return list List of keys. 274 - * 275 - * @group util 276 260 */ 277 261 JX.keys = Object.keys || function(obj) { 278 262 var r = []; ··· 289 273 * 290 274 * @param wild Any value. 291 275 * @return wild The passed argument. 292 - * 293 - * @group util 294 276 */ 295 277 JX.id = function(any) { 296 278 return any; ··· 314 296 * 315 297 * @param string Message to print to the browser debugging console. 316 298 * @return void 317 - * 318 - * @group util 319 299 */ 320 300 JX.log = function(message) { 321 301 window.console.log(message);
-1
webroot/rsrc/externals/javelin/docs/Base.js
··· 8 8 * which exist on all Javelin classes. This class documents those methods. 9 9 * 10 10 * @task events Builtin Events 11 - * @group install 12 11 */ 13 12 JX.install('Base', { 14 13 members : {
-1
webroot/rsrc/externals/javelin/docs/onload.js
··· 13 13 * 14 14 * @param function Callback function to invoke after DOMContentReady. 15 15 * @return void 16 - * @group util 17 16 */ 18 17 JX.onload = function(callback) { 19 18 // This isn't the real function definition, it's only defined here to let the
-10
webroot/rsrc/externals/javelin/lib/DOM.js
··· 32 32 * 33 33 * @param string "id" attribute to select from the document. 34 34 * @return Node Node with the specified "id" attribute. 35 - * 36 - * @group dom 37 35 */ 38 36 JX.$ = function(id) { 39 37 ··· 81 79 * 82 80 * @task build String into HTML 83 81 * @task nodes HTML into Nodes 84 - * 85 - * @group dom 86 82 */ 87 83 JX.install('HTML', { 88 84 ··· 193 189 * know it is from a trusted source and any data in it has been 194 190 * properly escaped. 195 191 * @return JX.HTML HTML object, suitable for use with @{JX.$N}. 196 - * 197 - * @group dom 198 192 */ 199 193 JX.$H = function(str) { 200 194 return new JX.HTML(str); ··· 274 268 * which may be dangerous). 275 269 * @return Node New node with whatever attributes and 276 270 * content were specified. 277 - * 278 - * @group dom 279 271 */ 280 272 JX.$N = function(tag, attr, content) { 281 273 if (typeof content == 'undefined' && ··· 338 330 * @task convenience Convenience Methods 339 331 * @task query Finding Nodes in the DOM 340 332 * @task view Changing View State 341 - * 342 - * @group dom 343 333 */ 344 334 JX.install('DOM', { 345 335 statics : {
-1
webroot/rsrc/externals/javelin/lib/JSON.js
··· 21 21 * 22 22 * @task json JSON Manipulation 23 23 * @task internal Internal 24 - * @group util 25 24 */ 26 25 JX.install('JSON', { 27 26 statics : {
-2
webroot/rsrc/externals/javelin/lib/Mask.js
··· 45 45 * 46 46 * The mask has sigil `jx-mask`, which can be used to intercept events 47 47 * targeting it, like clicks on the mask. 48 - * 49 - * @group control 50 48 */ 51 49 JX.install('Mask', { 52 50 statics : {
-2
webroot/rsrc/externals/javelin/lib/Request.js
··· 13 13 14 14 /** 15 15 * Make basic AJAX XMLHTTPRequests. 16 - * 17 - * @group workflow 18 16 */ 19 17 JX.install('Request', { 20 18 construct : function(uri, handler) {
-4
webroot/rsrc/externals/javelin/lib/URI.js
··· 17 17 * 18 18 * @param string Unparsed URI. 19 19 * @return @{class:JX.URI} JX.URI instance. 20 - * 21 - * @group uri 22 20 */ 23 21 JX.$U = function(uri) { 24 22 return new JX.URI(uri); ··· 38 36 * 39 37 * uri.setFragment('clowntown'); 40 38 * uri.toString() // http://www.example.com/asdf.php?a=b&c=d#clowntown 41 - * 42 - * @group uri 43 39 */ 44 40 JX.install('URI', { 45 41 statics : {
-4
webroot/rsrc/externals/javelin/lib/Vector.js
··· 20 20 * If numeric, the x-coordinate for the new vector. 21 21 * @param number? The y-coordinate for the new vector. 22 22 * @return @{class:JX.Vector} New vector. 23 - * 24 - * @group dom 25 23 */ 26 24 JX.$V = function(x, y) { 27 25 return new JX.Vector(x, y); ··· 75 73 * @task query Querying Positions and Dimensions 76 74 * @task update Changing Positions and Dimensions 77 75 * @task manip Manipulating Vectors 78 - * 79 - * @group dom 80 76 */ 81 77 JX.install('Vector', { 82 78
-3
webroot/rsrc/externals/javelin/lib/Workflow.js
··· 12 12 * @javelin 13 13 */ 14 14 15 - /** 16 - * @group workflow 17 - */ 18 15 JX.install('Workflow', { 19 16 construct : function(uri, data) { 20 17 if (__DEV__) {
-2
webroot/rsrc/externals/javelin/lib/behavior.js
··· 23 23 * @param string Behavior name. 24 24 * @param function Behavior callback/definition. 25 25 * @return void 26 - * @group behavior 27 26 */ 28 27 JX.behavior = function(name, control_function) { 29 28 if (__DEV__) { ··· 76 75 * are lists of configuration dictionaries. The behavior will be 77 76 * invoked once for each configuration dictionary. 78 77 * @return void 79 - * @group behavior 80 78 */ 81 79 JX.initBehaviors = function(map) { 82 80 var missing_behaviors = [];
-2
webroot/rsrc/externals/javelin/lib/control/tokenizer/Tokenizer.js
··· 30 30 * 31 31 * When the tokenizer is focused, the CSS class `jx-tokenizer-container-focused` 32 32 * is added to the container node. 33 - * 34 - * @group control 35 33 */ 36 34 JX.install('Tokenizer', { 37 35 construct : function(containerNode) {
-1
webroot/rsrc/externals/javelin/lib/control/typeahead/Typeahead.js
··· 32 32 * @task start Activating a Typeahead 33 33 * @task control Controlling Typeaheads from Javascript 34 34 * @task internal Internal Methods 35 - * @group control 36 35 */ 37 36 JX.install('Typeahead', { 38 37 /**
-3
webroot/rsrc/externals/javelin/lib/control/typeahead/normalizer/TypeaheadNormalizer.js
··· 4 4 * @javelin 5 5 */ 6 6 7 - /** 8 - * @group control 9 - */ 10 7 JX.install('TypeaheadNormalizer', { 11 8 statics : { 12 9 /**
-3
webroot/rsrc/externals/javelin/lib/control/typeahead/source/TypeaheadCompositeSource.js
··· 6 6 * @javelin 7 7 */ 8 8 9 - /** 10 - * @group control 11 - */ 12 9 JX.install('TypeaheadCompositeSource', { 13 10 14 11 extend : 'TypeaheadSource',
-3
webroot/rsrc/externals/javelin/lib/control/typeahead/source/TypeaheadOnDemandSource.js
··· 7 7 * @javelin 8 8 */ 9 9 10 - /** 11 - * @group control 12 - */ 13 10 JX.install('TypeaheadOnDemandSource', { 14 11 15 12 extend : 'TypeaheadSource',
-2
webroot/rsrc/externals/javelin/lib/control/typeahead/source/TypeaheadPreloadedSource.js
··· 12 12 * URI. This is appropriate if the total data size is small (up to perhaps a 13 13 * few thousand items). If you have more items so you can't ship them down to 14 14 * the client in one repsonse, use @{JX.TypeaheadOnDemandSource}. 15 - * 16 - * @group control 17 15 */ 18 16 JX.install('TypeaheadPreloadedSource', { 19 17
+1 -4
webroot/rsrc/externals/javelin/lib/control/typeahead/source/TypeaheadSource.js
··· 7 7 * @javelin 8 8 */ 9 9 10 - /** 11 - * @group control 12 - */ 13 10 JX.install('TypeaheadSource', { 14 11 construct : function() { 15 12 this._raw = {}; ··· 60 57 * - **display**: the text or nodes to show in the DOM. Usually just the 61 58 * same as ##name##. 62 59 * - **tokenizable**: if you want to tokenize something other than the 63 - * ##name##, for the typeahead to complete on, specify it here. A 60 + * ##name##, for the typeahead to complete on, specify it here. A 64 61 * selected entry from the typeahead will still insert the ##name## 65 62 * into the input, but the ##tokenizable## field lets you complete on 66 63 * non-name things.
-2
webroot/rsrc/externals/javelin/lib/control/typeahead/source/TypeaheadStaticSource.js
··· 9 9 * Typeahead source that uses static data passed to the constructor. For larger 10 10 * datasets, use @{class:JX.TypeaheadPreloadedSource} or 11 11 * @{class:JX.TypeaheadOnDemandSource} to improve performance. 12 - * 13 - * @group control 14 12 */ 15 13 JX.install('TypeaheadStaticSource', { 16 14
+1 -1
webroot/rsrc/js/application/releeph/releeph-request-typeahead.js
··· 58 58 59 59 /** 60 60 * The default normalizer removes useful control characters that would help 61 - * out search. For example, I was just trying to search for a commit with 61 + * out search. For example, I was just trying to search for a commit with 62 62 * the string "a_file" in the message, which was normalized to "afile". 63 63 */ 64 64 datasource.setNormalizer(function(query) {
-2
webroot/rsrc/js/core/behavior-toggle-class.js
··· 13 13 * 14 14 * Optionally, you may provide a `state` key to set the default state of the 15 15 * element. 16 - * 17 - * @group ui 18 16 */ 19 17 JX.behavior('toggle-class', function() { 20 18 JX.Stratcom.listen(