@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator

Diffusion commits: add some edge phrases about Revisions

Summary:
This change implements some messages that were only present
from this class:

DifferentialRevisionHasCommitEdgeType.php

But not in its inverse class:

DiffusionCommitHasRevisionEdgeType.php

In short:

| Before | After |
|-----------|-----------|
| {F313282} | {F313281} |

Closes T15314

Test Plan:
Visit a Diffusion commit and use the sidebar menu "Edit Related Objects" to:

- add 1 revision
- add 2 revisions
- remove 1 revision
- remove 2 revisions
- add 1 revision, remove 1 revision
- add 2 revisions, remove 2 revisions

Check that you don't see phrases like "added an edge" anymore.

Reviewers: O1 Blessed Committers, avivey

Reviewed By: O1 Blessed Committers, avivey

Subscribers: speck, tobiaswiese, Matthew, Cigaryno

Maniphest Tasks: T15314

Differential Revision: https://we.phorge.it/D25306

+41
+41
src/applications/diffusion/edge/DiffusionCommitHasRevisionEdgeType.php
··· 25 25 'The source commit is associated with the destination revision.'); 26 26 } 27 27 28 + public function getTransactionAddString( 29 + $actor, 30 + $add_count, 31 + $add_edges) { 32 + 33 + return pht( 34 + '%s added %s revision(s): %s.', 35 + $actor, 36 + $add_count, 37 + $add_edges); 38 + } 39 + 40 + public function getTransactionRemoveString( 41 + $actor, 42 + $rem_count, 43 + $rem_edges) { 44 + 45 + return pht( 46 + '%s removed %s revision(s): %s.', 47 + $actor, 48 + $rem_count, 49 + $rem_edges); 50 + } 51 + 52 + public function getTransactionEditString( 53 + $actor, 54 + $total_count, 55 + $add_count, 56 + $add_edges, 57 + $rem_count, 58 + $rem_edges) { 59 + 60 + return pht( 61 + '%s edited revision(s), added %s: %s; removed %s: %s.', 62 + $actor, 63 + $add_count, 64 + $add_edges, 65 + $rem_count, 66 + $rem_edges); 67 + } 68 + 28 69 }