@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator

Fix PHP 8.1 "strlen(null)" exceptions searching in Conpherence

Summary:
`strlen()` was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts `phutil_nonempty_string()` as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

```
ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/applications/conpherence/query/ConpherenceFulltextQuery.php:58]
```

```
ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/applications/conpherence/query/ConpherenceFulltextQuery.php:73]
```

Closes T16062

Test Plan: Go to a Conpherence room and search for an existing string.

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T16062

Differential Revision: https://we.phorge.it/D25994

+2 -2
+2 -2
src/applications/conpherence/query/ConpherenceFulltextQuery.php
··· 55 55 $this->previousTransactionPHIDs); 56 56 } 57 57 58 - if (strlen($this->fulltext)) { 58 + if (phutil_nonempty_string($this->fulltext)) { 59 59 $compiler = PhabricatorSearchDocument::newQueryCompiler(); 60 60 $tokens = $compiler->newTokens($this->fulltext); 61 61 $compiled_query = $compiler->compileQuery($tokens); ··· 70 70 } 71 71 72 72 private function buildOrderByClause(AphrontDatabaseConnection $conn_r) { 73 - if (strlen($this->fulltext)) { 73 + if (phutil_nonempty_string($this->fulltext)) { 74 74 return qsprintf( 75 75 $conn_r, 76 76 'ORDER BY MATCH(i.corpus) AGAINST (%s IN BOOLEAN MODE) DESC',