Reduce really unnecessary calls to the id() function

Summary:
Premising that the function id() is occasionally useful;

There is no need to wrap every single object creation with id(),
even where there is just one statement.

There is also a parallel patch for Arcanist: D26611.

Ref T15976

Test Plan:
Look with my little eyes that I've not introduced mistakes.

Run the linter. No syntax errors.

Run this grep, to find such simple calls:

grep -ER '= id\(new [a-zA-Z0-9]+\([^(]*?\)\);' src/

Before the change, 67 results.

After the change, 0 results.

Reviewers: O1 Blessed Committers, aklapper

Reviewed By: O1 Blessed Committers, aklapper

Subscribers: aklapper, tobiaswiese, Matthew, Cigaryno

Maniphest Tasks: T15976

Differential Revision: https://we.phorge.it/D26610

src/applications/audit/management/PhabricatorAuditManagementDeleteWorkflow.php

···
       $query->withPHIDs(mpull($commits, 'getPHID'));
     }
 
-    $commit_iterator = id(new PhabricatorQueryIterator($query));
+    $commit_iterator = new PhabricatorQueryIterator($query);
 
     // See T13457. We may be examining many commits; each commit is small so
     // we can safely increase the page size to improve performance a bit.

src/applications/auth/conduit/PhabricatorAuthLogoutConduitAPIMethod.php

···
     $viewer = $request->getUser();
 
     // Destroy all web sessions.
-    $engine = id(new PhabricatorAuthSessionEngine());
+    $engine = new PhabricatorAuthSessionEngine();
     $engine->terminateLoginSessions($viewer);
 
     // If we were called via OAuth, destroy the OAuth token.

src/applications/auth/controller/PhabricatorAuthRegisterController.php

···
           ->setError($e_captcha));
     }
 
-    $submit = id(new AphrontFormSubmitControl());
+    $submit = new AphrontFormSubmitControl();
 
     if ($is_setup) {
       $submit

src/applications/auth/query/PhabricatorAuthInviteSearchEngine.php

···
   }
 
   public function buildQueryFromSavedQuery(PhabricatorSavedQuery $saved) {
-    $query = id(new PhabricatorAuthInviteQuery());
+    $query = new PhabricatorAuthInviteQuery();
 
     return $query;
   }

src/applications/auth/revoker/PhabricatorAuthConduitTokenRevoker.php

···
   }
 
   public function revokeAllCredentials() {
-    $table = id(new PhabricatorConduitToken());
+    $table = new PhabricatorConduitToken();
     $conn = $table->establishConnection('w');
 
     queryfx(
···
   }
 
   public function revokeCredentialsFrom($object) {
-    $table = id(new PhabricatorConduitToken());
+    $table = new PhabricatorConduitToken();
     $conn = $table->establishConnection('w');
 
     queryfx(

src/applications/badges/query/PhabricatorBadgesSearchEngine.php

···
 
     $viewer = $this->requireViewer();
 
-    $list = id(new PHUIObjectItemListView());
+    $list = new PHUIObjectItemListView();
     foreach ($badges as $badge) {
       $quality_name = PhabricatorBadgesQuality::getQualityName(
         $badge->getQuality());

src/applications/calendar/parser/data/__tests__/PhutilCalendarRecurrenceTestCase.php

···
 final class PhutilCalendarRecurrenceTestCase extends PhutilTestCase {
 
   public function testCalendarRecurrenceLists() {
-    $set = id(new PhutilCalendarRecurrenceSet());
+    $set = new PhutilCalendarRecurrenceSet();
     $result = $set->getEventsBetween(null, null, 0xFFFF);
     $this->assertEqual(
       array(),

src/applications/conduit/controller/PhabricatorConduitConsoleController.php

···
 
     $viewer = $this->getViewer();
 
-    $description_properties = id(new PHUIPropertyListView());
+    $description_properties = new PHUIPropertyListView();
 
     $description_properties->addTextContent(
       new PHUIRemarkupView($viewer, $method->getMethodDescription()));
···
   private function buildMethodProperties(ConduitAPIMethod $method) {
     $viewer = $this->getViewer();
 
-    $view = id(new PHUIPropertyListView());
+    $view = new PHUIPropertyListView();
 
     $status = $method->getMethodStatus();
     $reason = $method->getMethodStatusDescription();

src/applications/conduit/query/PhabricatorConduitSearchEngine.php

···
   }
 
   public function buildQueryFromSavedQuery(PhabricatorSavedQuery $saved) {
-    $query = id(new PhabricatorConduitMethodQuery());
+    $query = new PhabricatorConduitMethodQuery();
 
     $query->withIsStable($saved->getParameter('isStable'));
     $query->withIsUnstable($saved->getParameter('isUnstable'));
···
         if ($list) {
           $out[] = $list;
         }
-        $list = id(new PHUIObjectItemListView());
+        $list = new PHUIObjectItemListView();
         $list->setHeader($app);
 
         $app_object = $method->getApplication();

src/applications/config/controller/services/PhabricatorConfigCacheController.php

···
 
   private function renderCodeBox() {
     $cache = PhabricatorOpcodeCacheSpec::getActiveCacheSpec();
-    $properties = id(new PHUIPropertyListView());
+    $properties = new PHUIPropertyListView();
     $this->renderCommonProperties($properties, $cache);
     return $this->buildConfigBoxView(pht('Opcode Cache'), $properties);
   }
···
   private function renderDataBox() {
     $cache = PhabricatorDataCacheSpec::getActiveCacheSpec();
 
-    $properties = id(new PHUIPropertyListView());
+    $properties = new PHUIPropertyListView();
 
     $this->renderCommonProperties($properties, $cache);
 

src/applications/config/controller/services/PhabricatorConfigClusterSearchController.php

···
   }
 
   private function renderIndexStats($stats) {
-    $view = id(new PHUIPropertyListView());
+    $view = new PHUIPropertyListView();
     if ($stats !== false) {
       foreach ($stats as $label => $val) {
         $view->addProperty($label, $val);

src/applications/daemon/management/PhabricatorDaemonManagementWorkflow.php

···
   }
 
   private function freeActiveLeases() {
-    $task_table = id(new PhabricatorWorkerActiveTask());
+    $task_table = new PhabricatorWorkerActiveTask();
     $conn_w = $task_table->establishConnection('w');
     queryfx(
       $conn_w,

src/applications/dashboard/typeahead/PhabricatorDashboardDatasource.php

···
   }
 
   public function loadResults() {
-    $query = id(new PhabricatorDashboardQuery());
+    $query = new PhabricatorDashboardQuery();
 
     $this->applyFerretConstraints(
       $query,

src/applications/differential/engine/DifferentialFileTreeEngine.php

···
           ->setHref('#'));
     $flank_view->setHead($head_view);
 
-    $tail_view = id(new PHUIListView());
+    $tail_view = new PHUIListView();
 
     if ($viewer->isLoggedIn()) {
       $tail_view->addMenuItem(

src/applications/differential/query/DifferentialChangesetSearchEngine.php

···
   }
 
   public function newQuery() {
-    $query = id(new DifferentialChangesetQuery());
+    $query = new DifferentialChangesetQuery();
 
     if ($this->diff) {
       $query->withDiffs(array($this->diff));

src/applications/differential/view/DifferentialRevisionUpdateHistoryView.php

···
         'radios' => $radios,
       ));
 
-    $table = id(new AphrontTableView($rows));
+    $table = new AphrontTableView($rows);
     $table->setHeaders(
       array(
         pht('Diff'),

src/applications/diffusion/view/DiffusionCommitGraphView.php

···
   }
 
   public function newObjectItemListView() {
-    $list_view = id(new PHUIObjectItemListView());
+    $list_view = new PHUIObjectItemListView();
 
     $item_views = $this->newObjectItemViews();
     foreach ($item_views as $item_view) {

src/applications/diviner/query/DivinerAtomSearchEngine.php

···
   }
 
   public function buildQueryFromSavedQuery(PhabricatorSavedQuery $saved) {
-    $query = id(new DivinerAtomQuery());
+    $query = new DivinerAtomQuery();
 
     $books = $saved->getParameter('bookPHIDs');
     if ($books) {

src/applications/files/controller/PhabricatorFileViewController.php

···
     $request = $this->getRequest();
     $viewer = $request->getUser();
 
-    $tab_group = id(new PHUITabGroupView());
+    $tab_group = new PHUITabGroupView();
     $box->addTabGroup($tab_group);
 
     $finfo = new PHUIPropertyListView();

src/applications/fund/query/FundBackerSearchEngine.php

···
   }
 
   public function buildQueryFromSavedQuery(PhabricatorSavedQuery $saved) {
-    $query = id(new FundBackerQuery());
+    $query = new FundBackerQuery();
 
     $query->withStatuses(array(FundBacker::STATUS_PURCHASED));
 

src/applications/harbormaster/controller/HarbormasterBuildViewController.php

···
       ),
     );
 
-    $base_uri = id(new PhutilURI($build->getURI().$generation.'/'));
+    $base_uri = new PhutilURI($build->getURI().$generation.'/');
 
     $links = array();
     foreach ($options as $option) {

src/applications/harbormaster/controller/HarbormasterBuildableViewController.php

···
       $targets = $build->getBuildTargets();
 
       if ($targets) {
-        $target_list = id(new PHUIStatusListView());
+        $target_list = new PHUIStatusListView();
         foreach ($targets as $target) {
           $status = $target->getTargetStatus();
           $icon = HarbormasterBuildTarget::getBuildTargetStatusIcon($status);

src/applications/herald/controller/HeraldTranscriptController.php

···
 
       $cond_xscripts = $xscript->getConditionTranscriptsForRule($rule_id);
 
-      $cond_list = id(new PHUIStatusListView());
+      $cond_list = new PHUIStatusListView();
       $cond_list->addItem(
         id(new PHUIStatusItemView())
           ->setTarget(phutil_tag('strong', array(), pht('Conditions'))));
···
 
         $name = pht('Action: %s', $name);
 
-        $action_list = id(new PHUIStatusListView());
+        $action_list = new PHUIStatusListView();
         $action_list->addItem(
           id(new PHUIStatusItemView())
             ->setTarget(phutil_tag('strong', array(), $name)));

src/applications/herald/query/HeraldTranscriptSearchEngine.php

···
   }
 
   public function buildQueryFromSavedQuery(PhabricatorSavedQuery $saved) {
-    $query = id(new HeraldTranscriptQuery());
+    $query = new HeraldTranscriptQuery();
 
     $object_monograms = $saved->getParameter('objectMonograms');
     if ($object_monograms) {

src/applications/legalpad/controller/LegalpadDocumentSignatureListController.php

···
       $this->document = $document;
     }
 
-    $engine = id(new LegalpadDocumentSignatureSearchEngine());
+    $engine = new LegalpadDocumentSignatureSearchEngine();
 
     if ($this->document) {
       $engine->setDocument($this->document);

src/applications/legalpad/query/LegalpadDocumentSignatureSearchEngine.php

···
   }
 
   public function buildQueryFromSavedQuery(PhabricatorSavedQuery $saved) {
-    $query = id(new LegalpadDocumentSignatureQuery());
+    $query = new LegalpadDocumentSignatureQuery();
 
     $signer_phids = $saved->getParameter('signerPHIDs', array());
     if ($signer_phids) {

src/applications/meta/controller/PhabricatorApplicationDetailViewController.php

···
     PhabricatorApplication $application) {
 
     $viewer = $this->getViewer();
-    $properties = id(new PHUIPropertyListView());
+    $properties = new PHUIPropertyListView();
 
     $properties->addProperty(
       pht('Description'),
···
     PhabricatorApplication $application) {
 
     $viewer = $this->getViewer();
-    $properties = id(new PHUIPropertyListView());
+    $properties = new PHUIPropertyListView();
 
     $header = id(new PHUIHeaderView())
       ->setHeader(pht('Policies'));

src/applications/metamta/controller/PhabricatorMetaMTAMailViewController.php

···
           $delivery = pht('Voided');
         }
 
-        $reasons = id(new PHUIStatusListView());
+        $reasons = new PHUIStatusListView();
 
         $reason_codes = $actor['reasons'];
         if (!$reason_codes) {
···
         }
         $rules = isort($rules, 'strength');
 
-        $routing_detail = id(new PHUIStatusListView());
+        $routing_detail = new PHUIStatusListView();
         foreach ($rules as $rule) {
           $const = $rule['routingRule'];
           $phids = $rule['phids'];

src/applications/notification/controller/PhabricatorNotificationPanelController.php

···
     $stories = $query->execute();
 
     $clear_ui_class = 'phabricator-notification-clear-all';
-    $clear_uri = id(new PhutilURI('/notification/clear/'));
+    $clear_uri = new PhutilURI('/notification/clear/');
     if ($stories) {
       $builder = id(new PhabricatorNotificationBuilder($stories))
         ->setUser($viewer);

src/applications/notification/query/PhabricatorNotificationSearchEngine.php

···
         break;
     }
 
-    $clear_uri = id(new PhutilURI('/notification/clear/'));
+    $clear_uri = new PhutilURI('/notification/clear/');
     if ($notifications) {
       $builder = id(new PhabricatorNotificationBuilder($notifications))
         ->setUser($viewer);

src/applications/packages/typeahead/PhabricatorPackagesPackageDatasource.php

···
     $viewer = $this->getViewer();
     $raw_query = $this->getRawQuery();
 
-    $package_query = id(new PhabricatorPackagesPackageQuery());
+    $package_query = new PhabricatorPackagesPackageQuery();
     $packages = $this->executeQuery($package_query);
 
     $results = array();

src/applications/packages/typeahead/PhabricatorPackagesPublisherDatasource.php

···
     $viewer = $this->getViewer();
     $raw_query = $this->getRawQuery();
 
-    $publisher_query = id(new PhabricatorPackagesPublisherQuery());
+    $publisher_query = new PhabricatorPackagesPublisherQuery();
     $publishers = $this->executeQuery($publisher_query);
 
     $results = array();

src/applications/phortune/query/PhortuneChargeSearchEngine.php

···
   }
 
   public function buildQueryFromSavedQuery(PhabricatorSavedQuery $saved) {
-    $query = id(new PhortuneChargeQuery());
+    $query = new PhortuneChargeQuery();
 
     $viewer = $this->requireViewer();
 

src/applications/phortune/query/PhortuneSubscriptionSearchEngine.php

···
   }
 
   public function buildQueryFromSavedQuery(PhabricatorSavedQuery $saved) {
-    $query = id(new PhortuneSubscriptionQuery());
+    $query = new PhortuneSubscriptionQuery();
 
     $viewer = $this->requireViewer();
 

src/applications/phriction/controller/PhrictionEditController.php

···
           ->addCancelButton($cancel_uri)
           ->setValue(pht('Save Draft')));
     } else {
-      $submit = id(new AphrontFormSubmitControl());
+      $submit = new AphrontFormSubmitControl();
 
       if (!$is_new) {
         $draft_button = id(new PHUIButtonView())

src/applications/phurl/typeahead/PhabricatorPhurlURLDatasource.php

···
   }
 
   public function loadResults() {
-    $query = id(new PhabricatorPhurlURLQuery());
+    $query = new PhabricatorPhurlURLQuery();
     $urls = $this->executeQuery($query);
     $results = array();
     foreach ($urls as $url) {

src/applications/ponder/controller/PonderAnswerSaveController.php

···
 
     // Answer Editor
 
-    $template = id(new PonderAnswerTransaction());
+    $template = new PonderAnswerTransaction();
     $xactions = array();
 
     $xactions[] = id(clone $template)

src/applications/project/editor/PhabricatorProjectTransactionEditor.php

···
           $member_type);
 
         if ($project_members) {
-          $editor = id(new PhabricatorEdgeEditor());
+          $editor = new PhabricatorEdgeEditor();
           foreach ($project_members as $phid) {
             $editor->addEdge($object->getPHID(), $member_type, $phid);
           }

src/applications/project/order/PhabricatorProjectColumnAuthorOrder.php

···
       $author_icon = 'fa-user';
       $author_color = 'bluegrey';
 
-      $icon_view = id(new PHUIIconView());
+      $icon_view = new PHUIIconView();
 
       if ($author_image) {
         $icon_view->setImage($author_image);

src/applications/project/order/PhabricatorProjectColumnOwnerOrder.php

···
       $owner_icon = 'fa-user';
       $owner_color = 'bluegrey';
 
-      $icon_view = id(new PHUIIconView());
+      $icon_view = new PHUIIconView();
 
       if ($owner_image) {
         $icon_view->setImage($owner_image);

src/applications/project/view/PhabricatorProjectCardView.php

···
       $description = $description_field->getFieldValue();
       if (phutil_nonempty_string($description)) {
         $description = PhabricatorMarkupEngine::summarizeSentence($description);
-        $description = id(new PHUIRemarkupView($viewer, $description));
+        $description = new PHUIRemarkupView($viewer, $description);
 
         $description = phutil_tag(
           'div',

src/applications/repository/engine/PhabricatorRepositoryRefEngine.php

···
     }
 
     if ($updates) {
-      $position_table = id(new PhabricatorRepositoryRefPosition());
+      $position_table = new PhabricatorRepositoryRefPosition();
       $conn = $position_table->establishConnection('w');
 
       $position_table->openTransaction();

src/applications/repository/management/PhabricatorRepositoryManagementParentsWorkflow.php

···
         'Found %s total commit(s); updating...',
         phutil_count($graph)));
 
-    $commit_table = id(new PhabricatorRepositoryCommit());
+    $commit_table = new PhabricatorRepositoryCommit();
     $commit_table_name = $commit_table->getTableName();
     $conn_w = $commit_table->establishConnection('w');
 

src/applications/repository/storage/PhabricatorRepository.php

···
 
     $window_start = (PhabricatorTime::getNow() + $minimum);
 
-    $table = id(new PhabricatorRepositoryCommit());
+    $table = new PhabricatorRepositoryCommit();
     $last_commit = queryfx_one(
       $table->establishConnection('r'),
       'SELECT epoch FROM %T

src/applications/search/engine/PhabricatorProfileMenuEngine.php

···
         $item,
         PhabricatorPolicyCapability::CAN_EDIT);
 
-      $view = id(new PHUIObjectItemView());
+      $view = new PHUIObjectItemView();
 
       $name = $item->getDisplayName();
       $type = $item->getMenuItemTypeName();

src/applications/settings/panel/PhabricatorPasswordSettingsPanel.php

···
         id(new AphrontFormSubmitControl())
           ->setValue(pht('Change Password')));
 
-    $properties = id(new PHUIPropertyListView());
+    $properties = new PHUIPropertyListView();
 
     $properties->addProperty(
       pht('Current Algorithm'),

src/applications/slowvote/controller/PhabricatorSlowvoteEditController.php

···
         }
       }
 
-      $template = id(new PhabricatorSlowvoteTransaction());
+      $template = new PhabricatorSlowvoteTransaction();
       $xactions = array();
 
       if ($is_new) {

src/applications/spaces/typeahead/PhabricatorSpacesNamespaceDatasource.php

···
   }
 
   public function loadResults() {
-    $query = id(new PhabricatorSpacesNamespaceQuery());
+    $query = new PhabricatorSpacesNamespaceQuery();
 
     $spaces = $this->executeQuery($query);
     $results = array();

src/applications/tokens/controller/PhabricatorTokenLeaderController.php

···
     $pager->setURI($request->getRequestURI(), 'page');
     $pager->setOffset($request->getInt('page'));
 
-    $query = id(new PhabricatorTokenReceiverQuery());
+    $query = new PhabricatorTokenReceiverQuery();
     $objects = $query->setViewer($viewer)->executeWithOffsetPager($pager);
     $counts = $query->getTokenCounts();
 
···
     $list = new PHUIObjectItemListView();
     foreach ($phids as $object) {
       $count = idx($counts, $object, 0);
-      $item = id(new PHUIObjectItemView());
+      $item = new PHUIObjectItemView();
       $handle = $handles[$object];
 
       $item->setHeader($handle->getFullName());

src/applications/tokens/query/PhabricatorTokenGivenSearchEngine.php

···
       $handle = $handles[$token_given->getObjectPHID()];
       $token = idx($tokens, $token_given->getTokenPHID());
 
-      $item = id(new PHUIObjectItemView());
+      $item = new PHUIObjectItemView();
       $item->setHeader($handle->getFullName());
       $item->setHref($handle->getURI());
 

src/applications/transactions/draft/PhabricatorDraftEngine.php

···
     $has_draft = $this->hasAnyDraftContent();
 
     $draft_type = PhabricatorObjectHasDraftEdgeType::EDGECONST;
-    $editor = id(new PhabricatorEdgeEditor());
+    $editor = new PhabricatorEdgeEditor();
 
     if ($has_draft) {
       $editor->addEdge($object_phid, $draft_type, $viewer_phid);

src/applications/transactions/editfield/PhabricatorColumnsEditField.php

···
   }
 
   protected function newControl() {
-    $control = id(new AphrontFormHandlesControl());
+    $control = new AphrontFormHandlesControl();
     $control->setIsInvisible(true);
 
     return $control;

src/applications/transactions/editfield/PhabricatorHandlesEditField.php

···
   }
 
   protected function newControl() {
-    $control = id(new AphrontFormHandlesControl());
+    $control = new AphrontFormHandlesControl();
 
     if ($this->getIsInvisible()) {
       $control->setIsInvisible(true);

src/applications/transactions/typeahead/PhabricatorEditEngineDatasource.php

···
   }
 
   private function buildResults() {
-    $query = id(new PhabricatorEditEngineConfigurationQuery());
+    $query = new PhabricatorEditEngineConfigurationQuery();
 
     $forms = $this->executeQuery($query);
     $results = array();

src/applications/uiexample/examples/PHUITimelineExample.php

···
       }
     }
 
-    $timeline = id(new PHUITimelineView());
+    $timeline = new PHUITimelineView();
     $timeline->setViewer($user);
     foreach ($events as $event) {
       $timeline->addEvent($event);

src/infrastructure/graph/PhabricatorObjectGraph.php

···
 
     $ancestry = array_select_keys($ancestry, $order);
 
-    $graph_view = id(new PHUIDiffGraphView());
+    $graph_view = new PHUIDiffGraphView();
 
     $height = $this->getHeight();
     if ($height !== null) {

src/infrastructure/storage/management/workflow/PhabricatorStorageManagementWorkflow.php

···
   public function didExecute(PhutilArgumentParser $args) {}
 
   private function loadSchemata(PhabricatorStorageManagementAPI $api) {
-    $query = id(new PhabricatorConfigSchemaQuery());
+    $query = new PhabricatorConfigSchemaQuery();
 
     $ref = $api->getRef();
     $ref_key = $ref->getRefKey();

src/view/form/control/AphrontFormDateControlValue.php

···
     $time) {
 
     $zone = $this->getTimezone();
-    $date_time = id(new DateTime("{$year}-{$month}-{$day} {$time}", $zone));
+    $date_time = new DateTime("{$year}-{$month}-{$day} {$time}", $zone);
 
     return array(
       $date_time->format($this->getDateFormat()),

src/view/phui/PHUIObjectBoxView.php

···
     $showhide = null;
     if ($this->showAction !== null) {
       if (!$header) {
-        $header = id(new PHUIHeaderView());
+        $header = new PHUIHeaderView();
       }
 
       Javelin::initBehavior('phabricator-reveal-content');

src/view/phui/calendar/PHUICalendarMonthView.php

···
 
     }
 
-    $header = id(new PHUIHeaderView());
+    $header = new PHUIHeaderView();
 
     if ($button_bar) {
       $header->setButtonBar($button_bar);