Correctly implementing mailkey for Phurl

Summary: Re T6049, Correctly implementing mailkey for Phurl

Test Plan: Edit Phurl URL, receive email.

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: Korvin

Differential Revision: https://secure.phabricator.com/D14605

resources/sql/autopatches/20151130.phurl.mailkey.1.sql

···
+ALTER TABLE {$NAMESPACE}_phurl.phurl_url
+  ADD mailKey binary(20) NOT NULL;

resources/sql/autopatches/20151130.phurl.mailkey.2.php

···
+<?php
+
+$table = new PhabricatorPhurlURL();
+$conn_w = $table->establishConnection('w');
+$iterator = new LiskMigrationIterator($table);
+foreach ($iterator as $url) {
+  $id = $url->getID();
+
+  echo pht('Adding mail key for Phurl %d...', $id);
+  echo "\n";
+
+  queryfx(
+    $conn_w,
+    'UPDATE %T SET mailKey = %s WHERE id = %d',
+    $table->getTableName(),
+    Filesystem::readRandomCharacters(20),
+    $id);
+}

src/applications/phurl/editor/PhabricatorPhurlURLEditor.php

···
 
   public function getMailTagsMap() {
     return array(
-      PhabricatorPhurlURLTransaction::MAILTAG_CONTENT =>
+      PhabricatorPhurlURLTransaction::MAILTAG_DETAILS =>
         pht(
-          "A URL's name or path changes."),
-      PhabricatorPhurlURLTransaction::MAILTAG_OTHER =>
-        pht('Other event activity not listed above occurs.'),
+          "A URL's details change."),
     );
   }
 

src/applications/phurl/storage/PhabricatorPhurlURL.php

···
   protected $authorPHID;
   protected $spacePHID;
 
+  protected $mailKey;
+
   const DEFAULT_ICON = 'fa-compress';
 
   public static function initializeNewPhurlURL(PhabricatorUser $actor) {
···
         'alias' => 'sort64?',
         'longURL' => 'text',
         'description' => 'text',
+        'mailKey' => 'bytes20',
       ),
       self::CONFIG_KEY_SCHEMA => array(
         'key_instance' => array(
···
         ),
       ),
     ) + parent::getConfiguration();
+  }
+
+  public function save() {
+    if (!$this->getMailKey()) {
+      $this->setMailKey(Filesystem::readRandomCharacters(20));
+    }
+    return parent::save();
   }
 
   public function generatePHID() {

src/applications/phurl/storage/PhabricatorPhurlURLTransaction.php

···
   const TYPE_ALIAS = 'phurl.alias';
   const TYPE_DESCRIPTION = 'phurl.description';
 
-  const MAILTAG_CONTENT = 'phurl:content';
-  const MAILTAG_OTHER = 'phurl:other';
+  const MAILTAG_DETAILS = 'phurl-details';
 
   public function getApplicationName() {
     return 'phurl';
···
       case self::TYPE_DESCRIPTION:
       case self::TYPE_URL:
       case self::TYPE_ALIAS:
-        $tags[] = self::MAILTAG_CONTENT;
+        $tags[] = self::MAILTAG_DETAILS;
         break;
     }
     return $tags;