Remove redundant assignment statements

Summary: Both sides are equal, so such assignments have no effect.

Test Plan: Read code; run static code analysis.

Reviewers: O1 Blessed Committers, mainframe98

Reviewed By: O1 Blessed Committers, mainframe98

Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Differential Revision: https://we.phorge.it/D26482

src/applications/calendar/xaction/PhabricatorCalendarEventFrequencyTransaction.php

···
 
     if (is_array($value)) {
       $value = idx($value, 'rule');
-    } else {
-      $value = $value;
     }
 
     return phutil_utf8_strtoupper($value);

src/applications/console/plugin/DarkConsoleRequestPlugin.php

···
           $value = phutil_tag('em', array(), pht('(Masked)'));
         } else if (is_array($value)) {
           $value = @json_encode($value);
-        } else {
-          $value = $value;
         }
 
         $rows[] = array(

src/applications/differential/storage/DifferentialHunk.php

···
       switch ($type) {
         case self::DATATYPE_TEXT:
           // In this storage type, the changes are stored on the object.
-          $data = $data;
           break;
         case self::DATATYPE_FILE:
           $data = $this->loadFileData();
···
       switch ($format) {
         case self::DATAFORMAT_RAW:
           // In this format, the changes are stored as-is.
-          $data = $data;
           break;
         case self::DATAFORMAT_DEFLATED:
           $data = PhabricatorCaches::inflateData($data);

src/applications/files/document/PhabricatorJupyterDocumentEngine.php

···
   private function readStringList(array $src, $key) {
     $list = idx($src, $key);
 
-    if (is_array($list)) {
-      $list = $list;
-    } else if (is_string($list)) {
+    if (is_string($list)) {
       $list = array($list);
-    } else {
+    } else if (!is_array($list)) {
       $list = array();
     }
 

src/applications/meta/query/PhabricatorApplicationQuery.php

···
         $apps = msort($apps, 'getName');
         break;
       case self::ORDER_APPLICATION:
-        $apps = $apps;
         break;
       default:
         throw new Exception(