@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator

Rename Differenital "EditPro" controller back to "Edit"

Summary: Ref T11114. We seem to be in reasonable shape here and I don't think anything needs to revert, so rename this back to boring old "edit".

Test Plan: Created, updated, edited a revision via web UI.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T11114

Differential Revision: https://secure.phabricator.com/D17091

+7 -7
+2 -2
src/__phutil_library_map__.php
··· 518 518 'DifferentialRevisionDependedOnByRevisionEdgeType' => 'applications/differential/edge/DifferentialRevisionDependedOnByRevisionEdgeType.php', 519 519 'DifferentialRevisionDependsOnRevisionEdgeType' => 'applications/differential/edge/DifferentialRevisionDependsOnRevisionEdgeType.php', 520 520 'DifferentialRevisionEditConduitAPIMethod' => 'applications/differential/conduit/DifferentialRevisionEditConduitAPIMethod.php', 521 + 'DifferentialRevisionEditController' => 'applications/differential/controller/DifferentialRevisionEditController.php', 521 522 'DifferentialRevisionEditEngine' => 'applications/differential/editor/DifferentialRevisionEditEngine.php', 522 - 'DifferentialRevisionEditProController' => 'applications/differential/controller/DifferentialRevisionEditProController.php', 523 523 'DifferentialRevisionFulltextEngine' => 'applications/differential/search/DifferentialRevisionFulltextEngine.php', 524 524 'DifferentialRevisionGraph' => 'infrastructure/graph/DifferentialRevisionGraph.php', 525 525 'DifferentialRevisionHasChildRelationship' => 'applications/differential/relationships/DifferentialRevisionHasChildRelationship.php', ··· 5183 5183 'DifferentialRevisionDependedOnByRevisionEdgeType' => 'PhabricatorEdgeType', 5184 5184 'DifferentialRevisionDependsOnRevisionEdgeType' => 'PhabricatorEdgeType', 5185 5185 'DifferentialRevisionEditConduitAPIMethod' => 'PhabricatorEditEngineAPIMethod', 5186 + 'DifferentialRevisionEditController' => 'DifferentialController', 5186 5187 'DifferentialRevisionEditEngine' => 'PhabricatorEditEngine', 5187 - 'DifferentialRevisionEditProController' => 'DifferentialController', 5188 5188 'DifferentialRevisionFulltextEngine' => 'PhabricatorFulltextEngine', 5189 5189 'DifferentialRevisionGraph' => 'PhabricatorObjectGraph', 5190 5190 'DifferentialRevisionHasChildRelationship' => 'DifferentialRevisionRelationship',
+3 -3
src/applications/differential/application/PhabricatorDifferentialApplication.php
··· 65 65 ), 66 66 'changeset/' => 'DifferentialChangesetViewController', 67 67 'revision/' => array( 68 - $this->getEditRoutePattern('editpro/') 69 - => 'DifferentialRevisionEditProController', 68 + $this->getEditRoutePattern('edit/') 69 + => 'DifferentialRevisionEditController', 70 70 $this->getEditRoutePattern('attach/(?P<diffID>[^/]+)/to/') 71 - => 'DifferentialRevisionEditProController', 71 + => 'DifferentialRevisionEditController', 72 72 'land/(?:(?P<id>[1-9]\d*))/(?P<strategy>[^/]+)/' 73 73 => 'DifferentialRevisionLandController', 74 74 'closedetails/(?P<phid>[^/]+)/'
+1 -1
src/applications/differential/controller/DifferentialRevisionEditProController.php src/applications/differential/controller/DifferentialRevisionEditController.php
··· 1 1 <?php 2 2 3 - final class DifferentialRevisionEditProController 3 + final class DifferentialRevisionEditController 4 4 extends DifferentialController { 5 5 6 6 public function handleRequest(AphrontRequest $request) {
+1 -1
src/applications/differential/controller/DifferentialRevisionViewController.php
··· 570 570 $curtain->addAction( 571 571 id(new PhabricatorActionView()) 572 572 ->setIcon('fa-pencil') 573 - ->setHref("/differential/revision/editpro/{$revision_id}/") 573 + ->setHref("/differential/revision/edit/{$revision_id}/") 574 574 ->setName(pht('Edit Revision')) 575 575 ->setDisabled(!$can_edit) 576 576 ->setWorkflow(!$can_edit));