@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator

PHP 8.5: Fix null array key in ConpherenceThread::hasAutomaticCapability()

Summary:
Setting null as an array key is deprecated since PHP 8.5 per https://www.php.net/releases/8.5/en.php: "Using null as an array offset or when calling array_key_exists() is now deprecated. Use an empty string instead."
```
ERROR 8192: Using null as an array offset is deprecated, use an empty string instead at [/var/www/html/phorge/phorge/src/applications/conpherence/storage/ConpherenceThread.php:276]
```

Closes T16510

Test Plan: A bit unclear. For me: PHP 8.5, have Conpherence application enabled, go to Feed Transactions at http://phorge.localhost/feed/transactions/

Reviewers: O1 Blessed Committers, mainframe98

Reviewed By: O1 Blessed Committers, mainframe98

Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T16510

Differential Revision: https://we.phorge.it/D26775

+4
+4
src/applications/conpherence/storage/ConpherenceThread.php
··· 272 272 return false; 273 273 } 274 274 275 + if (!$user->getPHID()) { 276 + return false; 277 + } 278 + 275 279 $participants = $this->getParticipants(); 276 280 return isset($participants[$user->getPHID()]); 277 281 }