Group and order Herald fields

Summary:
Ref T8726. Some adapters now have a large number of fields, and we lost the sort-of-human-readable implicit ordering when fields were modularized.

Instead, group and sort fields.

Test Plan: {F603066}

Reviewers: btrahan, chad

Reviewed By: chad

Subscribers: epriestley

Maniphest Tasks: T8726

Differential Revision: https://secure.phabricator.com/D13619

resources/celerity/map.php

···
     'rsrc/js/application/doorkeeper/behavior-doorkeeper-tag.js' => 'e5822781',
     'rsrc/js/application/files/behavior-icon-composer.js' => '8ef9ab58',
     'rsrc/js/application/files/behavior-launch-icon-composer.js' => '48086888',
-    'rsrc/js/application/herald/HeraldRuleEditor.js' => '6c2dffcc',
+    'rsrc/js/application/herald/HeraldRuleEditor.js' => '52684226',
     'rsrc/js/application/herald/PathTypeahead.js' => 'f7fc67ec',
     'rsrc/js/application/herald/herald-rule-editor.js' => '7ebaeed3',
     'rsrc/js/application/maniphest/behavior-batch-editor.js' => '782ab6e7',
···
     'global-drag-and-drop-css' => '697324ad',
     'harbormaster-css' => '49d64eb4',
     'herald-css' => '826075fa',
-    'herald-rule-editor' => '6c2dffcc',
+    'herald-rule-editor' => '52684226',
     'herald-test-css' => '778b008e',
     'inline-comment-summary-css' => '51efda3a',
     'javelin-aphlict' => '5359e785',
···
       'javelin-dom',
       'javelin-reactor-dom',
     ),
+    52684226 => array(
+      'multirow-row-manager',
+      'javelin-install',
+      'javelin-util',
+      'javelin-dom',
+      'javelin-stratcom',
+      'javelin-json',
+      'phabricator-prefab',
+    ),
     '5359e785' => array(
       'javelin-install',
       'javelin-util',
···
     '6c2b09a2' => array(
       'javelin-install',
       'javelin-util',
-    ),
-    '6c2dffcc' => array(
-      'multirow-row-manager',
-      'javelin-install',
-      'javelin-util',
-      'javelin-dom',
-      'javelin-stratcom',
-      'javelin-json',
-      'phabricator-prefab',
     ),
     '6c53634d' => array(
       'javelin-install',

src/__phutil_library_map__.php

···
     'DifferentialAuthorField' => 'applications/differential/customfield/DifferentialAuthorField.php',
     'DifferentialBlameRevisionField' => 'applications/differential/customfield/DifferentialBlameRevisionField.php',
     'DifferentialBranchField' => 'applications/differential/customfield/DifferentialBranchField.php',
+    'DifferentialChangeHeraldFieldGroup' => 'applications/differential/herald/DifferentialChangeHeraldFieldGroup.php',
     'DifferentialChangeType' => 'applications/differential/constants/DifferentialChangeType.php',
     'DifferentialChangesSinceLastUpdateField' => 'applications/differential/customfield/DifferentialChangesSinceLastUpdateField.php',
     'DifferentialChangeset' => 'applications/differential/storage/DifferentialChangeset.php',
···
     'DifferentialDiffCreateController' => 'applications/differential/controller/DifferentialDiffCreateController.php',
     'DifferentialDiffEditor' => 'applications/differential/editor/DifferentialDiffEditor.php',
     'DifferentialDiffHeraldField' => 'applications/differential/herald/DifferentialDiffHeraldField.php',
+    'DifferentialDiffHeraldFieldGroup' => 'applications/differential/herald/DifferentialDiffHeraldFieldGroup.php',
     'DifferentialDiffInlineCommentQuery' => 'applications/differential/query/DifferentialDiffInlineCommentQuery.php',
     'DifferentialDiffPHIDType' => 'applications/differential/phid/DifferentialDiffPHIDType.php',
     'DifferentialDiffProperty' => 'applications/differential/storage/DifferentialDiffProperty.php',
···
     'DifferentialRevisionHasReviewerEdgeType' => 'applications/differential/edge/DifferentialRevisionHasReviewerEdgeType.php',
     'DifferentialRevisionHasTaskEdgeType' => 'applications/differential/edge/DifferentialRevisionHasTaskEdgeType.php',
     'DifferentialRevisionHeraldField' => 'applications/differential/herald/DifferentialRevisionHeraldField.php',
+    'DifferentialRevisionHeraldFieldGroup' => 'applications/differential/herald/DifferentialRevisionHeraldFieldGroup.php',
     'DifferentialRevisionIDField' => 'applications/differential/customfield/DifferentialRevisionIDField.php',
     'DifferentialRevisionLandController' => 'applications/differential/controller/DifferentialRevisionLandController.php',
     'DifferentialRevisionListController' => 'applications/differential/controller/DifferentialRevisionListController.php',
···
     'DiffusionBrowseTableView' => 'applications/diffusion/view/DiffusionBrowseTableView.php',
     'DiffusionCachedResolveRefsQuery' => 'applications/diffusion/query/DiffusionCachedResolveRefsQuery.php',
     'DiffusionChangeController' => 'applications/diffusion/controller/DiffusionChangeController.php',
+    'DiffusionChangeHeraldFieldGroup' => 'applications/diffusion/herald/DiffusionChangeHeraldFieldGroup.php',
     'DiffusionCommitAffectedFilesHeraldField' => 'applications/diffusion/herald/DiffusionCommitAffectedFilesHeraldField.php',
     'DiffusionCommitAuthorHeraldField' => 'applications/diffusion/herald/DiffusionCommitAuthorHeraldField.php',
     'DiffusionCommitAutocloseHeraldField' => 'applications/diffusion/herald/DiffusionCommitAutocloseHeraldField.php',
···
     'DiffusionCommitHasTaskEdgeType' => 'applications/diffusion/edge/DiffusionCommitHasTaskEdgeType.php',
     'DiffusionCommitHash' => 'applications/diffusion/data/DiffusionCommitHash.php',
     'DiffusionCommitHeraldField' => 'applications/diffusion/herald/DiffusionCommitHeraldField.php',
+    'DiffusionCommitHeraldFieldGroup' => 'applications/diffusion/herald/DiffusionCommitHeraldFieldGroup.php',
     'DiffusionCommitHookEngine' => 'applications/diffusion/engine/DiffusionCommitHookEngine.php',
     'DiffusionCommitHookRejectException' => 'applications/diffusion/exception/DiffusionCommitHookRejectException.php',
     'DiffusionCommitMessageHeraldField' => 'applications/diffusion/herald/DiffusionCommitMessageHeraldField.php',
···
     'DiffusionPreCommitContentRevisionSubscribersHeraldField' => 'applications/diffusion/herald/DiffusionPreCommitContentRevisionSubscribersHeraldField.php',
     'DiffusionPreCommitRefChangeHeraldField' => 'applications/diffusion/herald/DiffusionPreCommitRefChangeHeraldField.php',
     'DiffusionPreCommitRefHeraldField' => 'applications/diffusion/herald/DiffusionPreCommitRefHeraldField.php',
+    'DiffusionPreCommitRefHeraldFieldGroup' => 'applications/diffusion/herald/DiffusionPreCommitRefHeraldFieldGroup.php',
     'DiffusionPreCommitRefNameHeraldField' => 'applications/diffusion/herald/DiffusionPreCommitRefNameHeraldField.php',
     'DiffusionPreCommitRefPusherHeraldField' => 'applications/diffusion/herald/DiffusionPreCommitRefPusherHeraldField.php',
     'DiffusionPreCommitRefPusherProjectsHeraldField' => 'applications/diffusion/herald/DiffusionPreCommitRefPusherProjectsHeraldField.php',
···
     'HeraldAlwaysField' => 'applications/herald/field/HeraldAlwaysField.php',
     'HeraldAnotherRuleField' => 'applications/herald/field/HeraldAnotherRuleField.php',
     'HeraldApplyTranscript' => 'applications/herald/storage/transcript/HeraldApplyTranscript.php',
+    'HeraldBasicFieldGroup' => 'applications/herald/field/HeraldBasicFieldGroup.php',
     'HeraldCommitAdapter' => 'applications/diffusion/herald/HeraldCommitAdapter.php',
     'HeraldCondition' => 'applications/herald/storage/HeraldCondition.php',
     'HeraldConditionTranscript' => 'applications/herald/storage/transcript/HeraldConditionTranscript.php',
···
     'HeraldDifferentialDiffAdapter' => 'applications/differential/herald/HeraldDifferentialDiffAdapter.php',
     'HeraldDifferentialRevisionAdapter' => 'applications/differential/herald/HeraldDifferentialRevisionAdapter.php',
     'HeraldDisableController' => 'applications/herald/controller/HeraldDisableController.php',
+    'HeraldEditFieldGroup' => 'applications/herald/field/HeraldEditFieldGroup.php',
     'HeraldEffect' => 'applications/herald/engine/HeraldEffect.php',
     'HeraldEmptyFieldValue' => 'applications/herald/value/HeraldEmptyFieldValue.php',
     'HeraldEngine' => 'applications/herald/engine/HeraldEngine.php',
     'HeraldField' => 'applications/herald/field/HeraldField.php',
+    'HeraldFieldGroup' => 'applications/herald/field/HeraldFieldGroup.php',
     'HeraldFieldTestCase' => 'applications/herald/field/__tests__/HeraldFieldTestCase.php',
     'HeraldFieldValue' => 'applications/herald/value/HeraldFieldValue.php',
     'HeraldInvalidActionException' => 'applications/herald/engine/exception/HeraldInvalidActionException.php',
···
     'HeraldPreCommitRefAdapter' => 'applications/diffusion/herald/HeraldPreCommitRefAdapter.php',
     'HeraldProjectsField' => 'applications/project/herald/HeraldProjectsField.php',
     'HeraldRecursiveConditionsException' => 'applications/herald/engine/exception/HeraldRecursiveConditionsException.php',
+    'HeraldRelatedFieldGroup' => 'applications/herald/field/HeraldRelatedFieldGroup.php',
     'HeraldRemarkupRule' => 'applications/herald/remarkup/HeraldRemarkupRule.php',
     'HeraldRepetitionPolicyConfig' => 'applications/herald/config/HeraldRepetitionPolicyConfig.php',
     'HeraldRule' => 'applications/herald/storage/HeraldRule.php',
···
     'HeraldSelectFieldValue' => 'applications/herald/value/HeraldSelectFieldValue.php',
     'HeraldSpaceField' => 'applications/spaces/herald/HeraldSpaceField.php',
     'HeraldSubscribersField' => 'applications/subscriptions/herald/HeraldSubscribersField.php',
+    'HeraldSupportFieldGroup' => 'applications/herald/field/HeraldSupportFieldGroup.php',
     'HeraldTestConsoleController' => 'applications/herald/controller/HeraldTestConsoleController.php',
     'HeraldTextFieldValue' => 'applications/herald/value/HeraldTextFieldValue.php',
     'HeraldTokenizerFieldValue' => 'applications/herald/value/HeraldTokenizerFieldValue.php',
···
     'ManiphestTaskHasMockEdgeType' => 'applications/maniphest/edge/ManiphestTaskHasMockEdgeType.php',
     'ManiphestTaskHasRevisionEdgeType' => 'applications/maniphest/edge/ManiphestTaskHasRevisionEdgeType.php',
     'ManiphestTaskHeraldField' => 'applications/maniphest/herald/ManiphestTaskHeraldField.php',
+    'ManiphestTaskHeraldFieldGroup' => 'applications/maniphest/herald/ManiphestTaskHeraldFieldGroup.php',
     'ManiphestTaskListController' => 'applications/maniphest/controller/ManiphestTaskListController.php',
     'ManiphestTaskListView' => 'applications/maniphest/view/ManiphestTaskListView.php',
     'ManiphestTaskMailReceiver' => 'applications/maniphest/mail/ManiphestTaskMailReceiver.php',
···
     'PhabricatorCustomFieldConfigOptionType' => 'infrastructure/customfield/config/PhabricatorCustomFieldConfigOptionType.php',
     'PhabricatorCustomFieldDataNotAvailableException' => 'infrastructure/customfield/exception/PhabricatorCustomFieldDataNotAvailableException.php',
     'PhabricatorCustomFieldHeraldField' => 'infrastructure/customfield/herald/PhabricatorCustomFieldHeraldField.php',
+    'PhabricatorCustomFieldHeraldFieldGroup' => 'infrastructure/customfield/herald/PhabricatorCustomFieldHeraldFieldGroup.php',
     'PhabricatorCustomFieldImplementationIncompleteException' => 'infrastructure/customfield/exception/PhabricatorCustomFieldImplementationIncompleteException.php',
     'PhabricatorCustomFieldIndexStorage' => 'infrastructure/customfield/storage/PhabricatorCustomFieldIndexStorage.php',
     'PhabricatorCustomFieldInterface' => 'infrastructure/customfield/interface/PhabricatorCustomFieldInterface.php',
···
     'PholioMockEmbedView' => 'applications/pholio/view/PholioMockEmbedView.php',
     'PholioMockHasTaskEdgeType' => 'applications/pholio/edge/PholioMockHasTaskEdgeType.php',
     'PholioMockHeraldField' => 'applications/pholio/herald/PholioMockHeraldField.php',
+    'PholioMockHeraldFieldGroup' => 'applications/pholio/herald/PholioMockHeraldFieldGroup.php',
     'PholioMockImagesView' => 'applications/pholio/view/PholioMockImagesView.php',
     'PholioMockListController' => 'applications/pholio/controller/PholioMockListController.php',
     'PholioMockMailReceiver' => 'applications/pholio/mail/PholioMockMailReceiver.php',
···
     'PhrictionDocumentController' => 'applications/phriction/controller/PhrictionDocumentController.php',
     'PhrictionDocumentHeraldAdapter' => 'applications/phriction/herald/PhrictionDocumentHeraldAdapter.php',
     'PhrictionDocumentHeraldField' => 'applications/phriction/herald/PhrictionDocumentHeraldField.php',
+    'PhrictionDocumentHeraldFieldGroup' => 'applications/phriction/herald/PhrictionDocumentHeraldFieldGroup.php',
     'PhrictionDocumentPHIDType' => 'applications/phriction/phid/PhrictionDocumentPHIDType.php',
     'PhrictionDocumentPathHeraldField' => 'applications/phriction/herald/PhrictionDocumentPathHeraldField.php',
     'PhrictionDocumentQuery' => 'applications/phriction/query/PhrictionDocumentQuery.php',
···
     'DifferentialAuthorField' => 'DifferentialCustomField',
     'DifferentialBlameRevisionField' => 'DifferentialStoredCustomField',
     'DifferentialBranchField' => 'DifferentialCustomField',
+    'DifferentialChangeHeraldFieldGroup' => 'HeraldFieldGroup',
     'DifferentialChangeType' => 'Phobject',
     'DifferentialChangesSinceLastUpdateField' => 'DifferentialCustomField',
     'DifferentialChangeset' => array(
···
     'DifferentialDiffCreateController' => 'DifferentialController',
     'DifferentialDiffEditor' => 'PhabricatorApplicationTransactionEditor',
     'DifferentialDiffHeraldField' => 'HeraldField',
+    'DifferentialDiffHeraldFieldGroup' => 'HeraldFieldGroup',
     'DifferentialDiffInlineCommentQuery' => 'PhabricatorDiffInlineCommentQuery',
     'DifferentialDiffPHIDType' => 'PhabricatorPHIDType',
     'DifferentialDiffProperty' => 'DifferentialDAO',
···
     'DifferentialRevisionHasReviewerEdgeType' => 'PhabricatorEdgeType',
     'DifferentialRevisionHasTaskEdgeType' => 'PhabricatorEdgeType',
     'DifferentialRevisionHeraldField' => 'HeraldField',
+    'DifferentialRevisionHeraldFieldGroup' => 'HeraldFieldGroup',
     'DifferentialRevisionIDField' => 'DifferentialCustomField',
     'DifferentialRevisionLandController' => 'DifferentialController',
     'DifferentialRevisionListController' => 'DifferentialController',
···
     'DiffusionBrowseTableView' => 'DiffusionView',
     'DiffusionCachedResolveRefsQuery' => 'DiffusionLowLevelQuery',
     'DiffusionChangeController' => 'DiffusionController',
+    'DiffusionChangeHeraldFieldGroup' => 'HeraldFieldGroup',
     'DiffusionCommitAffectedFilesHeraldField' => 'DiffusionCommitHeraldField',
     'DiffusionCommitAuthorHeraldField' => 'DiffusionCommitHeraldField',
     'DiffusionCommitAutocloseHeraldField' => 'DiffusionCommitHeraldField',
···
     'DiffusionCommitHasTaskEdgeType' => 'PhabricatorEdgeType',
     'DiffusionCommitHash' => 'Phobject',
     'DiffusionCommitHeraldField' => 'HeraldField',
+    'DiffusionCommitHeraldFieldGroup' => 'HeraldFieldGroup',
     'DiffusionCommitHookEngine' => 'Phobject',
     'DiffusionCommitHookRejectException' => 'Exception',
     'DiffusionCommitMessageHeraldField' => 'DiffusionCommitHeraldField',
···
     'DiffusionPreCommitContentRevisionSubscribersHeraldField' => 'DiffusionPreCommitContentHeraldField',
     'DiffusionPreCommitRefChangeHeraldField' => 'DiffusionPreCommitRefHeraldField',
     'DiffusionPreCommitRefHeraldField' => 'HeraldField',
+    'DiffusionPreCommitRefHeraldFieldGroup' => 'HeraldFieldGroup',
     'DiffusionPreCommitRefNameHeraldField' => 'DiffusionPreCommitRefHeraldField',
     'DiffusionPreCommitRefPusherHeraldField' => 'DiffusionPreCommitRefHeraldField',
     'DiffusionPreCommitRefPusherProjectsHeraldField' => 'DiffusionPreCommitRefHeraldField',
···
     'HeraldAlwaysField' => 'HeraldField',
     'HeraldAnotherRuleField' => 'HeraldField',
     'HeraldApplyTranscript' => 'Phobject',
+    'HeraldBasicFieldGroup' => 'HeraldFieldGroup',
     'HeraldCommitAdapter' => 'HeraldAdapter',
     'HeraldCondition' => 'HeraldDAO',
     'HeraldConditionTranscript' => 'Phobject',
···
     'HeraldDifferentialDiffAdapter' => 'HeraldDifferentialAdapter',
     'HeraldDifferentialRevisionAdapter' => 'HeraldDifferentialAdapter',
     'HeraldDisableController' => 'HeraldController',
+    'HeraldEditFieldGroup' => 'HeraldFieldGroup',
     'HeraldEffect' => 'Phobject',
     'HeraldEmptyFieldValue' => 'HeraldFieldValue',
     'HeraldEngine' => 'Phobject',
     'HeraldField' => 'Phobject',
+    'HeraldFieldGroup' => 'Phobject',
     'HeraldFieldTestCase' => 'PhutilTestCase',
     'HeraldFieldValue' => 'Phobject',
     'HeraldInvalidActionException' => 'Exception',
···
     'HeraldPreCommitRefAdapter' => 'HeraldPreCommitAdapter',
     'HeraldProjectsField' => 'HeraldField',
     'HeraldRecursiveConditionsException' => 'Exception',
+    'HeraldRelatedFieldGroup' => 'HeraldFieldGroup',
     'HeraldRemarkupRule' => 'PhabricatorObjectRemarkupRule',
     'HeraldRepetitionPolicyConfig' => 'Phobject',
     'HeraldRule' => array(
···
     'HeraldSelectFieldValue' => 'HeraldFieldValue',
     'HeraldSpaceField' => 'HeraldField',
     'HeraldSubscribersField' => 'HeraldField',
+    'HeraldSupportFieldGroup' => 'HeraldFieldGroup',
     'HeraldTestConsoleController' => 'HeraldController',
     'HeraldTextFieldValue' => 'HeraldFieldValue',
     'HeraldTokenizerFieldValue' => 'HeraldFieldValue',
···
     'ManiphestTaskHasMockEdgeType' => 'PhabricatorEdgeType',
     'ManiphestTaskHasRevisionEdgeType' => 'PhabricatorEdgeType',
     'ManiphestTaskHeraldField' => 'HeraldField',
+    'ManiphestTaskHeraldFieldGroup' => 'HeraldFieldGroup',
     'ManiphestTaskListController' => 'ManiphestController',
     'ManiphestTaskListView' => 'ManiphestView',
     'ManiphestTaskMailReceiver' => 'PhabricatorObjectMailReceiver',
···
     'PhabricatorCustomFieldConfigOptionType' => 'PhabricatorConfigOptionType',
     'PhabricatorCustomFieldDataNotAvailableException' => 'Exception',
     'PhabricatorCustomFieldHeraldField' => 'HeraldField',
+    'PhabricatorCustomFieldHeraldFieldGroup' => 'HeraldFieldGroup',
     'PhabricatorCustomFieldImplementationIncompleteException' => 'Exception',
     'PhabricatorCustomFieldIndexStorage' => 'PhabricatorLiskDAO',
     'PhabricatorCustomFieldList' => 'Phobject',
···
     'PholioMockEmbedView' => 'AphrontView',
     'PholioMockHasTaskEdgeType' => 'PhabricatorEdgeType',
     'PholioMockHeraldField' => 'HeraldField',
+    'PholioMockHeraldFieldGroup' => 'HeraldFieldGroup',
     'PholioMockImagesView' => 'AphrontView',
     'PholioMockListController' => 'PholioController',
     'PholioMockMailReceiver' => 'PhabricatorObjectMailReceiver',
···
     'PhrictionDocumentController' => 'PhrictionController',
     'PhrictionDocumentHeraldAdapter' => 'HeraldAdapter',
     'PhrictionDocumentHeraldField' => 'HeraldField',
+    'PhrictionDocumentHeraldFieldGroup' => 'HeraldFieldGroup',
     'PhrictionDocumentPHIDType' => 'PhabricatorPHIDType',
     'PhrictionDocumentPathHeraldField' => 'PhrictionDocumentHeraldField',
     'PhrictionDocumentQuery' => 'PhabricatorCursorPagedPolicyAwareQuery',

src/applications/differential/herald/DifferentialChangeHeraldFieldGroup.php

···
+<?php
+
+final class DifferentialChangeHeraldFieldGroup extends HeraldFieldGroup {
+
+  const FIELDGROUPKEY = 'differential.change';
+
+  public function getGroupLabel() {
+    return pht('Change Details');
+  }
+
+  protected function getGroupOrder() {
+    return 1500;
+  }
+
+}

src/applications/differential/herald/DifferentialDiffAffectedFilesHeraldField.php

···
     return pht('Affected files');
   }
 
+  public function getFieldGroupKey() {
+    return DifferentialChangeHeraldFieldGroup::FIELDGROUPKEY;
+  }
+
   public function getHeraldFieldValue($object) {
     return $this->getAdapter()->loadAffectedPaths();
   }

src/applications/differential/herald/DifferentialDiffContentAddedHeraldField.php

···
     return pht('Added file content');
   }
 
+  public function getFieldGroupKey() {
+    return DifferentialChangeHeraldFieldGroup::FIELDGROUPKEY;
+  }
+
   public function getHeraldFieldValue($object) {
     return $this->getAdapter()->loadAddedContentDictionary();
   }

src/applications/differential/herald/DifferentialDiffContentHeraldField.php

···
     return pht('Changed file content');
   }
 
+  public function getFieldGroupKey() {
+    return DifferentialChangeHeraldFieldGroup::FIELDGROUPKEY;
+  }
+
   public function getHeraldFieldValue($object) {
     return $this->getAdapter()->loadContentDictionary();
   }

src/applications/differential/herald/DifferentialDiffContentRemovedHeraldField.php

···
     return pht('Removed file content');
   }
 
+  public function getFieldGroupKey() {
+    return DifferentialChangeHeraldFieldGroup::FIELDGROUPKEY;
+  }
+
   public function getHeraldFieldValue($object) {
     return $this->getAdapter()->loadRemovedContentDictionary();
   }

src/applications/differential/herald/DifferentialDiffHeraldField.php

···
     return ($object instanceof DifferentialDiff);
   }
 
+  public function getFieldGroupKey() {
+    return DifferentialDiffHeraldFieldGroup::FIELDGROUPKEY;
+  }
+
 }

src/applications/differential/herald/DifferentialDiffHeraldFieldGroup.php

···
+<?php
+
+final class DifferentialDiffHeraldFieldGroup extends HeraldFieldGroup {
+
+  const FIELDGROUPKEY = 'differential.diff';
+
+  public function getGroupLabel() {
+    return pht('Diff Fields');
+  }
+
+  protected function getGroupOrder() {
+    return 1000;
+  }
+
+}

src/applications/differential/herald/DifferentialRevisionAffectedFilesHeraldField.php

···
     return pht('Affected files');
   }
 
+  public function getFieldGroupKey() {
+    return DifferentialChangeHeraldFieldGroup::FIELDGROUPKEY;
+  }
+
   public function getHeraldFieldValue($object) {
     return $this->getAdapter()->loadAffectedPaths();
   }

src/applications/differential/herald/DifferentialRevisionContentAddedHeraldField.php

···
     return pht('Added file content');
   }
 
+  public function getFieldGroupKey() {
+    return DifferentialChangeHeraldFieldGroup::FIELDGROUPKEY;
+  }
+
   public function getHeraldFieldValue($object) {
     return $this->getAdapter()->loadAddedContentDictionary();
   }

src/applications/differential/herald/DifferentialRevisionContentHeraldField.php

···
     return pht('Changed file content');
   }
 
+  public function getFieldGroupKey() {
+    return DifferentialChangeHeraldFieldGroup::FIELDGROUPKEY;
+  }
+
   public function getHeraldFieldValue($object) {
     return $this->getAdapter()->loadContentDictionary();
   }

src/applications/differential/herald/DifferentialRevisionContentRemovedHeraldField.php

···
     return pht('Removed file content');
   }
 
+  public function getFieldGroupKey() {
+    return DifferentialChangeHeraldFieldGroup::FIELDGROUPKEY;
+  }
+
   public function getHeraldFieldValue($object) {
     return $this->getAdapter()->loadRemovedContentDictionary();
   }

src/applications/differential/herald/DifferentialRevisionHeraldField.php

···
     return ($object instanceof DifferentialRevision);
   }
 
+  public function getFieldGroupKey() {
+    return DifferentialRevisionHeraldFieldGroup::FIELDGROUPKEY;
+  }
+
 }

src/applications/differential/herald/DifferentialRevisionHeraldFieldGroup.php

···
+<?php
+
+final class DifferentialRevisionHeraldFieldGroup extends HeraldFieldGroup {
+
+  const FIELDGROUPKEY = 'differential.revision';
+
+  public function getGroupLabel() {
+    return pht('Revision Fields');
+  }
+
+  protected function getGroupOrder() {
+    return 1000;
+  }
+
+}

src/applications/differential/herald/DifferentialRevisionPackageHeraldField.php

···
     return pht('Affected packages');
   }
 
+  public function getFieldGroupKey() {
+    return HeraldRelatedFieldGroup::FIELDGROUPKEY;
+  }
+
   public function getHeraldFieldValue($object) {
     $packages = $this->getAdapter()->loadAffectedPackages();
     return mpull($packages, 'getPHID');

src/applications/differential/herald/DifferentialRevisionPackageOwnerHeraldField.php

···
     return pht('Affected package owners');
   }
 
+  public function getFieldGroupKey() {
+    return HeraldRelatedFieldGroup::FIELDGROUPKEY;
+  }
+
   public function getHeraldFieldValue($object) {
     $packages = $this->getAdapter()->loadAffectedPackages();
     if (!$packages) {

src/applications/diffusion/herald/DiffusionChangeHeraldFieldGroup.php

···
+<?php
+
+final class DiffusionChangeHeraldFieldGroup extends HeraldFieldGroup {
+
+  const FIELDGROUPKEY = 'diffusion.change';
+
+  public function getGroupLabel() {
+    return pht('Change Details');
+  }
+
+  protected function getGroupOrder() {
+    return 1500;
+  }
+
+}

src/applications/diffusion/herald/DiffusionCommitAffectedFilesHeraldField.php

···
     return pht('Affected files');
   }
 
+  public function getFieldGroupKey() {
+    return DiffusionChangeHeraldFieldGroup::FIELDGROUPKEY;
+  }
+
   public function getHeraldFieldValue($object) {
     return $this->getAdapter()->loadAffectedPaths();
   }

src/applications/diffusion/herald/DiffusionCommitDiffContentAddedHeraldField.php

···
     return pht('Diff content added');
   }
 
+  public function getFieldGroupKey() {
+    return DiffusionChangeHeraldFieldGroup::FIELDGROUPKEY;
+  }
+
   public function getHeraldFieldValue($object) {
     return $this->getAdapter()->loadDiffContent('+');
   }

src/applications/diffusion/herald/DiffusionCommitDiffContentHeraldField.php

···
     return pht('Diff content');
   }
 
+  public function getFieldGroupKey() {
+    return DiffusionChangeHeraldFieldGroup::FIELDGROUPKEY;
+  }
+
   public function getHeraldFieldValue($object) {
     return $this->getAdapter()->loadDiffContent('*');
   }

src/applications/diffusion/herald/DiffusionCommitDiffContentRemovedHeraldField.php

···
     return pht('Diff content removed');
   }
 
+  public function getFieldGroupKey() {
+    return DiffusionChangeHeraldFieldGroup::FIELDGROUPKEY;
+  }
+
   public function getHeraldFieldValue($object) {
     return $this->getAdapter()->loadDiffContent('-');
   }

src/applications/diffusion/herald/DiffusionCommitDiffEnormousHeraldField.php

···
     return pht('Change is enormous');
   }
 
+  public function getFieldGroupKey() {
+    return DiffusionChangeHeraldFieldGroup::FIELDGROUPKEY;
+  }
+
   public function getHeraldFieldValue($object) {
     return $this->getAdapter()->isDiffEnormous();
   }

src/applications/diffusion/herald/DiffusionCommitHeraldField.php

···
     return ($object instanceof PhabricatorRepositoryCommit);
   }
 
+  public function getFieldGroupKey() {
+    return DiffusionCommitHeraldFieldGroup::FIELDGROUPKEY;
+  }
+
 }

src/applications/diffusion/herald/DiffusionCommitHeraldFieldGroup.php

···
+<?php
+
+final class DiffusionCommitHeraldFieldGroup extends HeraldFieldGroup {
+
+  const FIELDGROUPKEY = 'diffusion.commit';
+
+  public function getGroupLabel() {
+    return pht('Commit Fields');
+  }
+
+  protected function getGroupOrder() {
+    return 1000;
+  }
+
+}

src/applications/diffusion/herald/DiffusionCommitPackageAuditHeraldField.php

···
     return pht('Affected packages that need audit');
   }
 
+  public function getFieldGroupKey() {
+    return HeraldRelatedFieldGroup::FIELDGROUPKEY;
+  }
+
   public function getHeraldFieldValue($object) {
     $packages = $this->getAdapter()->loadAuditNeededPackages();
     if (!$packages) {

src/applications/diffusion/herald/DiffusionCommitPackageHeraldField.php

···
     return pht('Affected packages');
   }
 
+  public function getFieldGroupKey() {
+    return HeraldRelatedFieldGroup::FIELDGROUPKEY;
+  }
+
   public function getHeraldFieldValue($object) {
     $packages = $this->getAdapter()->loadAffectedPackages();
     return mpull($packages, 'getPHID');

src/applications/diffusion/herald/DiffusionCommitPackageOwnerHeraldField.php

···
     return pht('Affected package owners');
   }
 
+  public function getFieldGroupKey() {
+    return HeraldRelatedFieldGroup::FIELDGROUPKEY;
+  }
+
   public function getHeraldFieldValue($object) {
     $packages = $this->getAdapter()->loadAffectedPackages();
     if (!$packages) {

src/applications/diffusion/herald/DiffusionCommitRevisionAcceptedHeraldField.php

···
     return pht('Accepted Differential revision');
   }
 
+  public function getFieldGroupKey() {
+    return HeraldRelatedFieldGroup::FIELDGROUPKEY;
+  }
+
   public function getHeraldFieldValue($object) {
     $revision = $this->getAdapter()->loadDifferentialRevision();
     if (!$revision) {

src/applications/diffusion/herald/DiffusionCommitRevisionHeraldField.php

···
     return pht('Differential revision');
   }
 
+  public function getFieldGroupKey() {
+    return HeraldRelatedFieldGroup::FIELDGROUPKEY;
+  }
+
   public function getHeraldFieldValue($object) {
     $revision = $this->getAdapter()->loadDifferentialRevision();
 

src/applications/diffusion/herald/DiffusionCommitRevisionReviewersHeraldField.php

···
     return pht('Differential reviewers');
   }
 
+  public function getFieldGroupKey() {
+    return HeraldRelatedFieldGroup::FIELDGROUPKEY;
+  }
+
   public function getHeraldFieldValue($object) {
     $revision = $this->getAdapter()->loadDifferentialRevision();
 

src/applications/diffusion/herald/DiffusionCommitRevisionSubscribersHeraldField.php

···
     return pht('Differential subscribers');
   }
 
+  public function getFieldGroupKey() {
+    return HeraldRelatedFieldGroup::FIELDGROUPKEY;
+  }
+
   public function getHeraldFieldValue($object) {
     $revision = $this->getAdapter()->loadDifferentialRevision();
 

src/applications/diffusion/herald/DiffusionPreCommitContentAffectedFilesHeraldField.php

···
     return pht('Affected files');
   }
 
+  public function getFieldGroupKey() {
+    return DiffusionChangeHeraldFieldGroup::FIELDGROUPKEY;
+  }
+
   public function getHeraldFieldValue($object) {
     return $this->getAdapter()->getDiffContent('name');
   }

src/applications/diffusion/herald/DiffusionPreCommitContentDiffContentAddedHeraldField.php

···
     return pht('Added diff content');
   }
 
+  public function getFieldGroupKey() {
+    return DiffusionChangeHeraldFieldGroup::FIELDGROUPKEY;
+  }
+
   public function getHeraldFieldValue($object) {
     return $this->getAdapter()->getDiffContent('+');
   }

src/applications/diffusion/herald/DiffusionPreCommitContentDiffContentHeraldField.php

···
     return pht('Diff content');
   }
 
+  public function getFieldGroupKey() {
+    return DiffusionChangeHeraldFieldGroup::FIELDGROUPKEY;
+  }
+
   public function getHeraldFieldValue($object) {
     return $this->getAdapter()->getDiffContent('*');
   }

src/applications/diffusion/herald/DiffusionPreCommitContentDiffContentRemovedHeraldField.php

···
     return pht('Removed diff content');
   }
 
+  public function getFieldGroupKey() {
+    return DiffusionChangeHeraldFieldGroup::FIELDGROUPKEY;
+  }
+
   public function getHeraldFieldValue($object) {
     return $this->getAdapter()->getDiffContent('-');
   }

src/applications/diffusion/herald/DiffusionPreCommitContentDiffEnormousHeraldField.php

···
     return pht('Diff is enormous');
   }
 
+  public function getFieldGroupKey() {
+    return DiffusionChangeHeraldFieldGroup::FIELDGROUPKEY;
+  }
+
   public function getHeraldFieldValue($object) {
     return $this->getAdapter()->isDiffEnormous();
   }

src/applications/diffusion/herald/DiffusionPreCommitContentHeraldField.php

···
     return true;
   }
 
+  public function getFieldGroupKey() {
+    return DiffusionCommitHeraldFieldGroup::FIELDGROUPKEY;
+  }
+
 }

src/applications/diffusion/herald/DiffusionPreCommitContentRevisionAcceptedHeraldField.php

···
     return pht('Accepted Differential revision');
   }
 
+  public function getFieldGroupKey() {
+    return HeraldRelatedFieldGroup::FIELDGROUPKEY;
+  }
+
   public function getHeraldFieldValue($object) {
     $revision = $this->getAdapter()->getRevision();
 

src/applications/diffusion/herald/DiffusionPreCommitContentRevisionHeraldField.php

···
     return pht('Differential revision');
   }
 
+  public function getFieldGroupKey() {
+    return HeraldRelatedFieldGroup::FIELDGROUPKEY;
+  }
+
   public function getHeraldFieldValue($object) {
     $revision = $this->getAdapter()->getRevision();
 

src/applications/diffusion/herald/DiffusionPreCommitContentRevisionReviewersHeraldField.php

···
     return pht('Differential reviewers');
   }
 
+  public function getFieldGroupKey() {
+    return HeraldRelatedFieldGroup::FIELDGROUPKEY;
+  }
+
   public function getHeraldFieldValue($object) {
     $revision = $this->getAdapter()->getRevision();
 

src/applications/diffusion/herald/DiffusionPreCommitContentRevisionSubscribersHeraldField.php

···
     return pht('Differential subscribers');
   }
 
+  public function getFieldGroupKey() {
+    return HeraldRelatedFieldGroup::FIELDGROUPKEY;
+  }
+
   public function getHeraldFieldValue($object) {
     $revision = $this->getAdapter()->getRevision();
 

src/applications/diffusion/herald/DiffusionPreCommitRefHeraldField.php

···
     return true;
   }
 
+  public function getFieldGroupKey() {
+    return DiffusionPreCommitRefHeraldFieldGroup::FIELDGROUPKEY;
+  }
+
 }

src/applications/diffusion/herald/DiffusionPreCommitRefHeraldFieldGroup.php

···
+<?php
+
+final class DiffusionPreCommitRefHeraldFieldGroup extends HeraldFieldGroup {
+
+  const FIELDGROUPKEY = 'diffusion.ref';
+
+  public function getGroupLabel() {
+    return pht('Ref Fields');
+  }
+
+  protected function getGroupOrder() {
+    return 1000;
+  }
+
+}

src/applications/herald/adapter/HeraldAdapter.php

···
     return mpull($this->getFieldImplementationMap(), 'getHeraldFieldName');
   }
 
+  public function getFieldGroupKey($field_key) {
+    $field = $this->getFieldImplementation($field_key);
+
+    if (!$field) {
+      return null;
+    }
+
+    return $field->getFieldGroupKey();
+  }
+
 
 /* -(  Conditions  )--------------------------------------------------------- */
 

src/applications/herald/controller/HeraldRuleController.php

···
       }
     }
 
+    $group_map = array();
+    foreach ($field_map as $field_key => $field_name) {
+      $group_key = $adapter->getFieldGroupKey($field_key);
+      $group_map[$group_key][$field_key] = $field_name;
+    }
+
+    $field_groups = HeraldFieldGroup::getAllFieldGroups();
+
+    $groups = array();
+    foreach ($group_map as $group_key => $options) {
+      asort($options);
+
+      $field_group = idx($field_groups, $group_key);
+      if ($field_group) {
+        $group_label = $field_group->getGroupLabel();
+        $group_order = $field_group->getSortKey();
+      } else {
+        $group_label = nonempty($group_key, pht('Other'));
+        $group_order = 'Z';
+      }
+
+      $groups[] = array(
+        'label' => $group_label,
+        'options' => $options,
+        'order' => $group_order,
+      );
+    }
+
+    $groups = array_values(isort($groups, 'order'));
 
     $config_info = array();
-    $config_info['fields'] = $field_map;
+    $config_info['fields'] = $groups;
     $config_info['conditions'] = $all_conditions;
     $config_info['actions'] = $action_map;
     $config_info['valueMap'] = array();
 
-    foreach ($config_info['fields'] as $field => $name) {
+    foreach ($field_map as $field => $name) {
       try {
         $field_conditions = $adapter->getConditionsForField($field);
       } catch (Exception $ex) {
···
       $config_info['conditionMap'][$field] = $field_conditions;
     }
 
-    foreach ($config_info['fields'] as $field => $fname) {
+    foreach ($field_map as $field => $fname) {
       foreach ($config_info['conditionMap'][$field] as $condition) {
         $value_key = $adapter->getValueTypeForFieldAndCondition(
           $field,

src/applications/herald/field/HeraldAlwaysField.php

···
     return pht('Always');
   }
 
+  public function getFieldGroupKey() {
+    return HeraldBasicFieldGroup::FIELDGROUPKEY;
+  }
+
   public function getHeraldFieldValue($object) {
     return true;
   }

src/applications/herald/field/HeraldAnotherRuleField.php

···
     return pht('Another Herald rule');
   }
 
+  public function getFieldGroupKey() {
+    return HeraldBasicFieldGroup::FIELDGROUPKEY;
+  }
+
   public function supportsObject($object) {
     return true;
   }

src/applications/herald/field/HeraldBasicFieldGroup.php

···
+<?php
+
+final class HeraldBasicFieldGroup extends HeraldFieldGroup {
+
+  const FIELDGROUPKEY = 'herald';
+
+  public function getGroupLabel() {
+    return pht('Herald');
+  }
+
+  protected function getGroupOrder() {
+    return 10000;
+  }
+
+}

src/applications/herald/field/HeraldContentSourceField.php

···
     return pht('Content source');
   }
 
+  public function getFieldGroupKey() {
+    return HeraldEditFieldGroup::FIELDGROUPKEY;
+  }
+
   public function getHeraldFieldValue($object) {
     return $this->getAdapter()->getContentSource()->getSource();
   }

src/applications/herald/field/HeraldEditFieldGroup.php

···
+<?php
+
+final class HeraldEditFieldGroup extends HeraldFieldGroup {
+
+  const FIELDGROUPKEY = 'edit';
+
+  public function getGroupLabel() {
+    return pht('Edit Attributes');
+  }
+
+  protected function getGroupOrder() {
+    return 4000;
+  }
+
+}

src/applications/herald/field/HeraldField.php

···
   abstract public function getHeraldFieldName();
   abstract public function getHeraldFieldValue($object);
 
+  public function getFieldGroupKey() {
+    return null;
+  }
+
   protected function getHeraldFieldStandardType() {
     throw new PhutilMethodNotImplementedException();
   }

src/applications/herald/field/HeraldFieldGroup.php

···
+<?php
+
+abstract class HeraldFieldGroup extends Phobject {
+
+  abstract public function getGroupLabel();
+
+  protected function getGroupOrder() {
+    return 1000;
+  }
+
+  final public function getGroupKey() {
+    $class = new ReflectionClass($this);
+
+    $const = $class->getConstant('FIELDGROUPKEY');
+    if ($const === false) {
+      throw new Exception(
+        pht(
+          '"%s" class "%s" must define a "%s" property.',
+          __CLASS__,
+          get_class($this),
+          'FIELDCONST'));
+    }
+
+    return $const;
+  }
+
+  public function getSortKey() {
+    return sprintf('A%08d%s', $this->getGroupOrder(), $this->getGroupLabel());
+  }
+
+  final public static function getAllFieldGroups() {
+    return id(new PhutilClassMapQuery())
+      ->setAncestorClass(__CLASS__)
+      ->setUniqueMethod('getGroupKey')
+      ->setSortMethod('getSortKey')
+      ->execute();
+  }
+}

src/applications/herald/field/HeraldNewObjectField.php

···
     return pht('Is newly created');
   }
 
+  public function getFieldGroupKey() {
+    return HeraldEditFieldGroup::FIELDGROUPKEY;
+  }
+
   public function supportsObject($object) {
     return !$this->getAdapter()->isSingleEventAdapter();
   }

src/applications/herald/field/HeraldRelatedFieldGroup.php

···
+<?php
+
+final class HeraldRelatedFieldGroup extends HeraldFieldGroup {
+
+  const FIELDGROUPKEY = 'related';
+
+  public function getGroupLabel() {
+    return pht('Related Fields');
+  }
+
+  protected function getGroupOrder() {
+    return 2000;
+  }
+
+}

src/applications/herald/field/HeraldSupportFieldGroup.php

···
+<?php
+
+final class HeraldSupportFieldGroup extends HeraldFieldGroup {
+
+  const FIELDGROUPKEY = 'support';
+
+  public function getGroupLabel() {
+    return pht('Supporting Applications');
+  }
+
+  protected function getGroupOrder() {
+    return 3000;
+  }
+
+}

src/applications/maniphest/herald/ManiphestTaskHeraldField.php

···
 
 abstract class ManiphestTaskHeraldField extends HeraldField {
 
+  public function getFieldGroupKey() {
+    return ManiphestTaskHeraldFieldGroup::FIELDGROUPKEY;
+  }
+
   public function supportsObject($object) {
     return ($object instanceof ManiphestTask);
   }

src/applications/maniphest/herald/ManiphestTaskHeraldFieldGroup.php

···
+<?php
+
+final class ManiphestTaskHeraldFieldGroup extends HeraldFieldGroup {
+
+  const FIELDGROUPKEY = 'maniphest.task';
+
+  public function getGroupLabel() {
+    return pht('Task Fields');
+  }
+
+  protected function getGroupOrder() {
+    return 500;
+  }
+
+}

src/applications/metamta/herald/PhabricatorMetaMTAApplicationEmailHeraldField.php

···
   const FIELDCONST = 'application-email';
 
   public function getHeraldFieldName() {
-    return pht('Receiving email address');
+    return pht('Receiving email addresses');
+  }
+
+  public function getFieldGroupKey() {
+    return HeraldEditFieldGroup::FIELDGROUPKEY;
   }
 
   public function supportsObject($object) {

src/applications/pholio/herald/PholioMockHeraldField.php

···
     return ($object instanceof PholioMock);
   }
 
+  public function getFieldGroupKey() {
+    return PholioMockHeraldFieldGroup::FIELDGROUPKEY;
+  }
+
 }

src/applications/pholio/herald/PholioMockHeraldFieldGroup.php

···
+<?php
+
+final class PholioMockHeraldFieldGroup extends HeraldFieldGroup {
+
+  const FIELDGROUPKEY = 'pholio.mock';
+
+  public function getGroupLabel() {
+    return pht('Mock Fields');
+  }
+
+  protected function getGroupOrder() {
+    return 1000;
+  }
+
+}

src/applications/phriction/herald/PhrictionDocumentHeraldField.php

···
     return ($object instanceof PhrictionDocument);
   }
 
+  public function getFieldGroupKey() {
+    return PhrictionDocumentHeraldFieldGroup::FIELDGROUPKEY;
+  }
 }

src/applications/phriction/herald/PhrictionDocumentHeraldFieldGroup.php

···
+<?php
+
+final class PhrictionDocumentHeraldFieldGroup extends HeraldFieldGroup {
+
+  const FIELDGROUPKEY = 'phriction.document';
+
+  public function getGroupLabel() {
+    return pht('Document Fields');
+  }
+
+  protected function getGroupOrder() {
+    return 1000;
+  }
+
+}

src/applications/project/herald/HeraldProjectsField.php

···
     return pht('Projects');
   }
 
+  public function getFieldGroupKey() {
+    return HeraldSupportFieldGroup::FIELDGROUPKEY;
+  }
+
   public function supportsObject($object) {
     return ($object instanceof PhabricatorProjectInterface);
   }

src/applications/spaces/herald/HeraldSpaceField.php

···
     return pht('Space');
   }
 
+  public function getFieldGroupKey() {
+    return HeraldSupportFieldGroup::FIELDGROUPKEY;
+  }
+
   public function supportsObject($object) {
     return ($object instanceof PhabricatorSpacesInterface);
   }

src/applications/subscriptions/herald/HeraldSubscribersField.php

···
     return pht('Subscribers');
   }
 
+  public function getFieldGroupKey() {
+    return HeraldSupportFieldGroup::FIELDGROUPKEY;
+  }
+
   public function supportsObject($object) {
     return ($object instanceof PhabricatorSubscribableInterface);
   }

src/infrastructure/customfield/herald/PhabricatorCustomFieldHeraldField.php

···
     return $this->customField;
   }
 
+  public function getFieldGroupKey() {
+    return PhabricatorCustomFieldHeraldFieldGroup::FIELDGROUPKEY;
+  }
+
   public function supportsObject($object) {
     return ($object instanceof PhabricatorCustomFieldInterface);
   }

src/infrastructure/customfield/herald/PhabricatorCustomFieldHeraldFieldGroup.php

···
+<?php
+
+final class PhabricatorCustomFieldHeraldFieldGroup extends HeraldFieldGroup {
+
+  const FIELDGROUPKEY = 'customfield';
+
+  public function getGroupLabel() {
+    return pht('Custom Fields');
+  }
+
+  protected function getGroupOrder() {
+    return 2000;
+  }
+
+}

webroot/rsrc/js/application/herald/HeraldRuleEditor.js

···
       this._onfieldchange(r);
     },
     _renderCondition : function(row_id) {
-      var field_select = this._renderSelect(
-        this._config.info.fields,
-        this._config.conditions[row_id][0],
-        'field-select');
+      var groups = this._config.info.fields;
+
+      var optgroups = [];
+      for (var ii = 0; ii < groups.length; ii++) {
+        var group = groups[ii];
+        var options = [];
+        for (var k in group.options) {
+          options.push(JX.$N('option', {value: k}, group.options[k]));
+        }
+        optgroups.push(JX.$N('optgroup', {label: group.label}, options));
+      }
+
+      var attrs = {
+        sigil: 'field-select'
+      };
+
+      var field_select = JX.$N('select', attrs, optgroups);
+      field_select.value = this._config.conditions[row_id][0];
+
       var field_cell = JX.$N('td', {sigil: 'field-cell'}, field_select);
 
       var condition_cell = JX.$N('td', {sigil: 'condition-cell'});