lol

openjfx11, openjfx15: add -fcommon workaround

Workaround build failure on -fno-common toolchains like upstream
gcc-10. Otherwise build fails as:

ld: gsttypefindelement.o:(.bss._gst_disable_registry_cache+0x0): multiple definition of
`_gst_disable_registry_cache'; gst.o:(.bss._gst_disable_registry_cache+0x0): first defined here

openjfx17 is not affected.

+17 -4
+4 -1
pkgs/development/compilers/openjdk/openjfx/11.nix
··· 92 92 ''; 93 93 94 94 # glib-2.62 deprecations 95 - NIX_CFLAGS_COMPILE = "-DGLIB_DISABLE_DEPRECATION_WARNINGS"; 95 + # -fcommon: gstreamer workaround for -fno-common toolchains: 96 + # ld: gsttypefindelement.o:(.bss._gst_disable_registry_cache+0x0): multiple definition of 97 + # `_gst_disable_registry_cache'; gst.o:(.bss._gst_disable_registry_cache+0x0): first defined here 98 + NIX_CFLAGS_COMPILE = "-DGLIB_DISABLE_DEPRECATION_WARNINGS -fcommon"; 96 99 97 100 stripDebugList = [ "." ]; 98 101
+13 -3
pkgs/development/compilers/openjdk/openjfx/15.nix
··· 31 31 JDK_HOME = ${openjdk11_headless.home} 32 32 '' + args.gradleProperties or ""); 33 33 34 - #avoids errors about deprecation of GTypeDebugFlags, GTimeVal, etc. 35 - NIX_CFLAGS_COMPILE = [ "-DGLIB_DISABLE_DEPRECATION_WARNINGS" ]; 34 + NIX_CFLAGS_COMPILE = [ 35 + #avoids errors about deprecation of GTypeDebugFlags, GTimeVal, etc. 36 + "-DGLIB_DISABLE_DEPRECATION_WARNINGS" 37 + 38 + # gstreamer workaround for -fno-common toolchains: 39 + # ld: gsttypefindelement.o:(.bss._gst_disable_registry_cache+0x0): multiple definition of 40 + # `_gst_disable_registry_cache'; gst.o:(.bss._gst_disable_registry_cache+0x0): first defined here 41 + "-fcommon" 42 + ]; 36 43 37 44 buildPhase = '' 38 45 runHook preBuild ··· 89 96 ''; 90 97 91 98 # glib-2.62 deprecations 92 - NIX_CFLAGS_COMPILE = "-DGLIB_DISABLE_DEPRECATION_WARNINGS"; 99 + # -fcommon: gstreamer workaround for -fno-common toolchains: 100 + # ld: gsttypefindelement.o:(.bss._gst_disable_registry_cache+0x0): multiple definition of 101 + # `_gst_disable_registry_cache'; gst.o:(.bss._gst_disable_registry_cache+0x0): first defined here 102 + NIX_CFLAGS_COMPILE = "-DGLIB_DISABLE_DEPRECATION_WARNINGS -fcommon"; 93 103 94 104 stripDebugList = [ "." ]; 95 105